Re: Review Request 24704: Patch for KAFKA-1499

2014-12-17 Thread Eric Olander
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review65450 --- core/src/main/scala/kafka/message/BrokerCompression.scala

Re: [DISCUSSION] adding the serializer api back to the new java producer

2014-12-17 Thread Jun Rao
Not yet. It will be when 0.8.2 is release. Thanks, Jun On Wed, Dec 17, 2014 at 5:24 PM, Rajiv Kurian wrote: > > Has the mvn repo been updated too? > > On Wed, Dec 17, 2014 at 4:31 PM, Jun Rao wrote: > > > > Thanks everyone for the feedback and the discussion. The proposed changes > > have been

[jira] [Created] (KAFKA-1823) transient unit test failure in PartitionAssignorTest

2014-12-17 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1823: -- Summary: transient unit test failure in PartitionAssignorTest Key: KAFKA-1823 URL: https://issues.apache.org/jira/browse/KAFKA-1823 Project: Kafka Issue Type: Improvemen

Re: [DISCUSSION] adding the serializer api back to the new java producer

2014-12-17 Thread Rajiv Kurian
Has the mvn repo been updated too? On Wed, Dec 17, 2014 at 4:31 PM, Jun Rao wrote: > > Thanks everyone for the feedback and the discussion. The proposed changes > have been checked into both 0.8.2 and trunk. > > Jun > > On Tue, Dec 16, 2014 at 10:43 PM, Joel Koshy wrote: > > > > Jun, > > > > Tha

Build failed in Jenkins: Kafka-trunk #356

2014-12-17 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1797; add the serializer/deserializer api to the new java client; patched by Jun Rao; reviewed by Neha Narkhede -- [...truncated 979 lines...] kafka.log.CleanerTest > tes

Re: [DISCUSSION] adding the serializer api back to the new java producer

2014-12-17 Thread Jun Rao
Thanks everyone for the feedback and the discussion. The proposed changes have been checked into both 0.8.2 and trunk. Jun On Tue, Dec 16, 2014 at 10:43 PM, Joel Koshy wrote: > > Jun, > > Thanks for summarizing this - it helps confirm for me that I did not > misunderstand anything in this thread

[jira] [Updated] (KAFKA-1797) add the serializer/deserializer api to the new java client

2014-12-17 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1797: --- Resolution: Fixed Fix Version/s: 0.8.2 Status: Resolved (was: Patch Available) Thanks for t

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-17 Thread Jiangjie Qin
> On Dec. 17, 2014, 1:17 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, line > > 338 > > > > > > Can we make this a "reliable" commit - i.e., with retries up to the

Re: Review Request 29072: Patch for kafka-1797

2014-12-17 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29072/#review65383 --- Ship it! Ship It! - Neha Narkhede On Dec. 17, 2014, 5:47 p.m., J

[jira] [Commented] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

2014-12-17 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250480#comment-14250480 ] Jiangjie Qin commented on KAFKA-1650: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

2014-12-17 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1650: Attachment: KAFKA-1650_2014-12-17_12:29:23.patch > Mirror Maker could lose data on unclean shutdown.

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-17 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/ --- (Updated Dec. 17, 2014, 8:29 p.m.) Review request for kafka. Bugs: KAFKA-1650

[jira] [Commented] (KAFKA-1797) add the serializer/deserializer api to the new java client

2014-12-17 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250197#comment-14250197 ] Jun Rao commented on KAFKA-1797: Updated reviewboard https://reviews.apache.org/r/29072/di

[jira] [Updated] (KAFKA-1797) add the serializer/deserializer api to the new java client

2014-12-17 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1797: --- Attachment: kafka-1797_2014-12-17_09:47:45.patch > add the serializer/deserializer api to the new java client

Re: Review Request 29072: Patch for kafka-1797

2014-12-17 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29072/ --- (Updated Dec. 17, 2014, 5:47 p.m.) Review request for kafka. Summary (updated

[jira] [Commented] (KAFKA-1819) Cleaner gets confused about deleted and re-created topics

2014-12-17 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250163#comment-14250163 ] Neha Narkhede commented on KAFKA-1819: -- +1 on [~jjkoshy]'s suggestion. That makes mor

[jira] [Commented] (KAFKA-1753) add --decommission-broker option

2014-12-17 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250158#comment-14250158 ] Neha Narkhede commented on KAFKA-1753: -- [~charmalloc] The only thing we are waiting o

[jira] [Commented] (KAFKA-1822) Add "echo" request

2014-12-17 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249934#comment-14249934 ] Joe Stein commented on KAFKA-1822: -- I like the idea of this. Instead of calling it Echo c

[jira] [Updated] (KAFKA-1822) Add "echo" request

2014-12-17 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1822: - Description: Currently there is no simple way to generate a request and validate we receive a response

[jira] [Commented] (KAFKA-1753) add --decommission-broker option

2014-12-17 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249913#comment-14249913 ] Joe Stein commented on KAFKA-1753: -- [~Dmitry Pekar] patch this feature option on this tic

Re: Review Request 24704: Patch for KAFKA-1499

2014-12-17 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review65316 --- Overall, looks good. I do have a bit of a concern on having to maint

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-17 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/#review65306 --- core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala

Optimistic locking

2014-12-17 Thread Daniel Schierbeck
I'm trying to design a system that uses Kafka as its primary data store by persisting immutable events into a topic and keeping a secondary index in another data store. The secondary index would store the "entities". Each event would pertain to some "entity", e.g. a user, and those entities are sto

[jira] [Commented] (KAFKA-1753) add --decommission-broker option

2014-12-17 Thread Dmitry Pekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249692#comment-14249692 ] Dmitry Pekar commented on KAFKA-1753: - [~charmalloc] So we need a merge of KAFKA-1792