[jira] [Comment Edited] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-07 Thread Vladimir Tretyakov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14267397#comment-14267397 ] Vladimir Tretyakov edited comment on KAFKA-1723 at 1/7/15 8:25 AM:

[jira] [Commented] (KAFKA-1566) Kafka environment configuration (kafka-env.sh)

2015-01-07 Thread Yongkun Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14267394#comment-14267394 ] Yongkun Wang commented on KAFKA-1566: - This is going to be very convenient to remind

[jira] [Commented] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-07 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14267407#comment-14267407 ] Manikumar Reddy commented on KAFKA-1723: Thanks for the suggestion. will remove

[jira] [Commented] (KAFKA-1846) Offset storage topic should not default to replication factor 1

2015-01-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268790#comment-14268790 ] Gwen Shapira commented on KAFKA-1846: - Being able to set the default replication

[jira] [Commented] (KAFKA-1844) Remove max.message.bytes from topic config

2015-01-07 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268774#comment-14268774 ] Sriharsha Chintalapani commented on KAFKA-1844: --- There is already work being

[jira] [Updated] (KAFKA-1844) Remove max.message.bytes from topic config

2015-01-07 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1844: -- Resolution: Duplicate Status: Resolved (was: Patch Available) Remove

[jira] [Commented] (KAFKA-1756) never allow the replica fetch size to be less than the max message size

2015-01-07 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268571#comment-14268571 ] Sriharsha Chintalapani commented on KAFKA-1756: --- [~junrao] [~charmalloc]

[jira] [Commented] (KAFKA-1841) OffsetCommitRequest API - timestamp field is not versioned

2015-01-07 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268583#comment-14268583 ] Parth Brahmbhatt commented on KAFKA-1841: - @junrao If noone plans to take this

[jira] [Assigned] (KAFKA-1722) static analysis code coverage for pci audit needs

2015-01-07 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein reassigned KAFKA-1722: Assignee: Ashish Kumar Singh Absolutely! static analysis code coverage for pci audit needs

[jira] [Commented] (KAFKA-1756) never allow the replica fetch size to be less than the max message size

2015-01-07 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268585#comment-14268585 ] Joe Stein commented on KAFKA-1756: -- HI [~sriharsha] we have a patch for global

[jira] [Updated] (KAFKA-1722) static analysis code coverage for pci audit needs

2015-01-07 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1722: - Reviewer: Joe Stein static analysis code coverage for pci audit needs

[jira] [Commented] (KAFKA-1841) OffsetCommitRequest API - timestamp field is not versioned

2015-01-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268628#comment-14268628 ] Jun Rao commented on KAFKA-1841: Parth, Thanks for offering. I have a patch that's almost

Re: Review Request 28769: Patch for KAFKA-1809

2015-01-07 Thread Gwen Shapira
On Jan. 7, 2015, 5:02 p.m., Jay Kreps wrote: core/src/main/scala/kafka/cluster/Broker.scala, line 36 https://reviews.apache.org/r/28769/diff/1/?file=783935#file783935line36 Hey guys, I have a big concern with adding JSON to the protocol mixed in with the binary format. Can we

[jira] [Commented] (KAFKA-1836) metadata.fetch.timeout.ms set to zero blocks forever

2015-01-07 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268178#comment-14268178 ] Ewen Cheslack-Postava commented on KAFKA-1836: -- A couple of notes on the

[jira] [Commented] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268121#comment-14268121 ] Jun Rao commented on KAFKA-1723: Hi, Manikumar, Thanks for working on this jira. Since we

[jira] [Created] (KAFKA-1845) KafkaConfig should use ConfigDef

2015-01-07 Thread Gwen Shapira (JIRA)
Gwen Shapira created KAFKA-1845: --- Summary: KafkaConfig should use ConfigDef Key: KAFKA-1845 URL: https://issues.apache.org/jira/browse/KAFKA-1845 Project: Kafka Issue Type: Improvement

Review Request 29668: Patch for KAFKA-1844

2015-01-07 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29668/ --- Review request for kafka. Bugs: KAFKA-1844

[jira] [Updated] (KAFKA-1844) Remove max.message.bytes from topic config

2015-01-07 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1844: -- Summary: Remove max.message.bytes from topic config (was: Topic

[jira] [Commented] (KAFKA-1841) OffsetCommitRequest API - timestamp field is not versioned

2015-01-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268154#comment-14268154 ] Jun Rao commented on KAFKA-1841: Thinking about this a bit more. We can revert the wire

[jira] [Commented] (KAFKA-1844) Remove max.message.bytes from topic config

2015-01-07 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268196#comment-14268196 ] Sriharsha Chintalapani commented on KAFKA-1844: --- Created reviewboard

[jira] [Updated] (KAFKA-1844) Remove max.message.bytes from topic config

2015-01-07 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1844: -- Status: Patch Available (was: Open) Remove max.message.bytes from topic

[jira] [Updated] (KAFKA-1844) Remove max.message.bytes from topic config

2015-01-07 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1844: -- Attachment: KAFKA-1844.patch Remove max.message.bytes from topic config

[jira] [Created] (KAFKA-1844) Topic message.max.bytes can be larger than the replica.fetch.max.bytes

2015-01-07 Thread Sriharsha Chintalapani (JIRA)
Sriharsha Chintalapani created KAFKA-1844: - Summary: Topic message.max.bytes can be larger than the replica.fetch.max.bytes Key: KAFKA-1844 URL: https://issues.apache.org/jira/browse/KAFKA-1844

Samza Blog Post Published - Help Share: http://thenewstack.io/apache-samza-linkedins-framework-for-stream-processing/

2015-01-07 Thread Ed Yakabosky
Hi all - I am a Program Manager supporting Apache Kafka and Apache Samza development at LinkedIn. The Samza team just published a blog posthttp://thenewstack.io/apache-samza-linkedins-framework-for-stream-processing/ providing an overview of Samza on TheNewStack.io. Please read it and share

[jira] [Commented] (KAFKA-1845) KafkaConfig should use ConfigDef

2015-01-07 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268363#comment-14268363 ] Jay Kreps commented on KAFKA-1845: -- Amen. This will also allow us to auto-generate the

[jira] [Updated] (KAFKA-1845) KafkaConfig should use ConfigDef

2015-01-07 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1845: - Labels: newbie (was: ) KafkaConfig should use ConfigDef -

[jira] [Commented] (KAFKA-1722) static analysis code coverage for pci audit needs

2015-01-07 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268377#comment-14268377 ] Ashish Kumar Singh commented on KAFKA-1722: --- [~joestein], the growing user and

[jira] [Updated] (KAFKA-1841) OffsetCommitRequest API - timestamp field is not versioned

2015-01-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1841: --- Attachment: kafka-1841.patch OffsetCommitRequest API - timestamp field is not versioned

[jira] [Updated] (KAFKA-1841) OffsetCommitRequest API - timestamp field is not versioned

2015-01-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1841: --- Assignee: Jun Rao Status: Patch Available (was: Open) OffsetCommitRequest API - timestamp field is

[jira] [Commented] (KAFKA-1841) OffsetCommitRequest API - timestamp field is not versioned

2015-01-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268694#comment-14268694 ] Jun Rao commented on KAFKA-1841: Created reviewboard

Review Request 29692: Patch for kafka-1841

2015-01-07 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29692/ --- Review request for kafka. Bugs: kafka-1841

[jira] [Commented] (KAFKA-1841) OffsetCommitRequest API - timestamp field is not versioned

2015-01-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268698#comment-14268698 ] Jun Rao commented on KAFKA-1841: [~dana.powers], could you try this patch on 0.8.2 and see

Re: Review Request 29692: Patch for kafka-1841

2015-01-07 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29692/#review67149 --- Jun, have you had a chance to test the 0.8.1 client against the

[jira] [Commented] (KAFKA-1819) Cleaner gets confused about deleted and re-created topics

2015-01-07 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268715#comment-14268715 ] Neha Narkhede commented on KAFKA-1819: -- [~gwenshap] What I was trying to achieve by

Re: Review Request 27391: Fix KAFKA-1634

2015-01-07 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27391/#review67114 ---

Re: Review Request 25944: Patch for KAFKA-1013

2015-01-07 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Jan. 8, 2015, 2:35 a.m.) Review request for kafka, Guozhang Wang,

[jira] [Created] (KAFKA-1846) Offset storage topic should not default to replication factor 1

2015-01-07 Thread Jay Kreps (JIRA)
Jay Kreps created KAFKA-1846: Summary: Offset storage topic should not default to replication factor 1 Key: KAFKA-1846 URL: https://issues.apache.org/jira/browse/KAFKA-1846 Project: Kafka Issue

Re: Review Request 29692: Patch for kafka-1841

2015-01-07 Thread Jun Rao
On Jan. 8, 2015, 2:15 a.m., Neha Narkhede wrote: Jun, have you had a chance to test the 0.8.1 client against the 0.8.2 server, as we had discussed earlier today? Yes, it works as expected with the following test program built with the 0.8.1 branch. package kafka import

Re: Review Request 28769: Patch for KAFKA-1809

2015-01-07 Thread Gwen Shapira
On Jan. 7, 2015, 3:01 a.m., Jun Rao wrote: core/src/main/scala/kafka/cluster/EndPoint.scala, line 36 https://reviews.apache.org/r/28769/diff/11/?file=807932#file807932line36 Do we need the dot after -? Yes. Because of the brackets its an actual dot (doesn't match any) and its

Re: Review Request 28769: Patch for KAFKA-1809

2015-01-07 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28769/#review67040 --- core/src/main/scala/kafka/cluster/Broker.scala

Re: Review Request 28769: Patch for KAFKA-1809

2015-01-07 Thread Gwen Shapira
On Jan. 7, 2015, 5:02 p.m., Jay Kreps wrote: core/src/main/scala/kafka/cluster/Broker.scala, line 36 https://reviews.apache.org/r/28769/diff/1/?file=783935#file783935line36 Hey guys, I have a big concern with adding JSON to the protocol mixed in with the binary format. Can we

Re: Review Request 29647: Patch for KAFKA-1697

2015-01-07 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29647/#review67044 --- It does look like this is all that needs to be removed. Only

Re: Review Request 28769: Patch for KAFKA-1809

2015-01-07 Thread Jay Kreps
On Jan. 7, 2015, 5:02 p.m., Jay Kreps wrote: core/src/main/scala/kafka/cluster/Broker.scala, line 36 https://reviews.apache.org/r/28769/diff/1/?file=783935#file783935line36 Hey guys, I have a big concern with adding JSON to the protocol mixed in with the binary format. Can we

[jira] [Commented] (KAFKA-1697) remove code related to ack1 on the broker

2015-01-07 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14267940#comment-14267940 ] Ewen Cheslack-Postava commented on KAFKA-1697: -- On a related note (which