[
https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14272165#comment-14272165
]
German Borbolla edited comment on KAFKA-1577 at 1/10/15 12:56 AM:
On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote:
kafka-patch-review.py, line 96
https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96
Did you tested the failure senario? I did not get error message. I
think we will get exception only after invoking
On Jan. 9, 2015, 6:48 p.m., Neha Narkhede wrote:
kafka-patch-review.py, line 20
https://reviews.apache.org/r/29756/diff/4/?file=814310#file814310line20
I got the following error on this patch
nnarkhed-mn1:kafka nnarkhed$ python kafka-patch-review.py -b trunk -j
[
https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14272165#comment-14272165
]
German Borbolla commented on KAFKA-1577:
This is marked as Fix version for 0.8.2
Hey guys,
We had a bit of a compatibility slip-up in 0.8.2 with the offset commit
stuff. We caught this one before the final release so it's not too bad. But
I do think it kind of points to an area we could do better.
One piece of feedback we have gotten from going out and talking to users is
[
https://issues.apache.org/jira/browse/KAFKA-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14272298#comment-14272298
]
jaikiran pai commented on KAFKA-1836:
-
Thanks [~nehanarkhede], I've updated the review
On Jan. 9, 2015, 5:51 p.m., Ewen Cheslack-Postava wrote:
clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java,
line 110
https://reviews.apache.org/r/29752/diff/1/?file=813990#file813990line110
This works since the check farther down ensures
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29752/
---
(Updated Jan. 10, 2015, 2:57 a.m.)
Review request for kafka.
Bugs:
Hi Ted,
https://www.python.org/dev/peps/pep-0257/ works fine for me. Are you
sure you aren't having that closing ')' in the URL that you are accessing?
-Jaikiran
On Saturday 10 January 2015 07:16 AM, Ted Yu wrote:
Jay:
https://www.python.org/dev/peps/pep-0257
Jay:
https://www.python.org/dev/peps/pep-0257
https://www.python.org/dev/peps/pep-0257/) gives me 404.
Can you double check ?
Cheers
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29714/#review67573
---
core/src/main/scala/kafka/network/SocketServer.scala
[
https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14272309#comment-14272309
]
Sriharsha Chintalapani commented on KAFKA-1577:
---
[~german.borbolla] The
[
https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14272313#comment-14272313
]
German Borbolla commented on KAFKA-1577:
[~sriharsha] you're right, this happened
[
https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14272320#comment-14272320
]
Sriharsha Chintalapani commented on KAFKA-1577:
---
[~german.borbolla] can you
[
https://issues.apache.org/jira/browse/KAFKA-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-1731.
Resolution: Fixed
The patch is already committed. Also committed the doc change in KAFKA-1481.
add
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23702/#review67551
---
core/src/main/scala/kafka/server/BrokerMetadataFileHandler.scala
[
https://issues.apache.org/jira/browse/KAFKA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14272082#comment-14272082
]
Neha Narkhede commented on KAFKA-1070:
--
[~sriharsha] There are still questions around
[
https://issues.apache.org/jira/browse/KAFKA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14272095#comment-14272095
]
Sriharsha Chintalapani commented on KAFKA-1070:
---
Thanks [~nehanarkhede] .
On Jan. 7, 2015, 3:01 a.m., Jun Rao wrote:
Thanks for the patch. It's a lot work! A few general comments below, in
addition to the more detailed comments.
1. Formatting: add a space after comma in function signature and function
calls. So instead of
def foo(a: A,b: B)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/#review67446
---
Thanks for the new patch. Looks good. Just a few more minor
[
https://issues.apache.org/jira/browse/KAFKA-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jaikiran pai updated KAFKA-1854:
Status: Patch Available (was: Open)
Patch has been submitted
P.S: It looks like (while auto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/
---
(Updated Jan. 9, 2015, 8:09 a.m.)
Review request for kafka.
Bugs: KAFKA-1854
[
https://issues.apache.org/jira/browse/KAFKA-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jaikiran pai updated KAFKA-1854:
Attachment: KAFKA-1854_2015-01-09_13:39:23.patch
Allow the JIRA username and password to be
[
https://issues.apache.org/jira/browse/KAFKA-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270735#comment-14270735
]
jaikiran pai commented on KAFKA-1854:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270783#comment-14270783
]
Manikumar Reddy commented on KAFKA-1723:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1723:
---
Attachment: KAFKA-1723_2015-01-09_14:24:18.patch
make the metrics name in new producer more
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/
---
(Updated Jan. 9, 2015, 10:13 a.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270839#comment-14270839
]
jaikiran pai commented on KAFKA-1854:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jaikiran pai updated KAFKA-1854:
Attachment: KAFKA-1854_2015-01-09_15:42:28.patch
Allow the JIRA username and password to be
On Jan. 9, 2015, 7:52 a.m., Jaikiran Pai wrote:
This one needs a minor change which I'm going to submit as an update
Patch updated and now ready for review.
- Jaikiran
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/
---
(Updated Jan. 9, 2015, 8:56 a.m.)
Review request for kafka.
Bugs: KAFKA-1723
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67400
---
kafka-patch-review.py
[
https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1852:
-
Reviewer: Joel Koshy
OffsetCommitRequest can commit offset on unknown topic
[
https://issues.apache.org/jira/browse/KAFKA-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1854:
-
Reviewer: Neha Narkhede
Allow the JIRA username and password to be prompted during patch
[
https://issues.apache.org/jira/browse/KAFKA-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271714#comment-14271714
]
Aditya Auradkar commented on KAFKA-1848:
https://reviews.apache.org/r/29728/
[
https://issues.apache.org/jira/browse/KAFKA-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271733#comment-14271733
]
Neha Narkhede commented on KAFKA-1826:
--
[~onurkaraman] The topic tool should have
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271758#comment-14271758
]
Jay Kreps commented on KAFKA-1723:
--
Yeah, I'm not really sure whether to just leave it or
Bhavesh,
1. I would expect the behavior you're suggesting as well. Any fix for the
JIRA should address this, and I raised that point when reviewing the
current version of the patch.
2. It's currently marked for 0.8.3 so it probably won't make it into 0.8.2,
especially if there isn't a patch for
[
https://issues.apache.org/jira/browse/KAFKA-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271595#comment-14271595
]
Neha Narkhede commented on KAFKA-1851:
--
[~junrao] Why is this a blocker?
[
https://issues.apache.org/jira/browse/KAFKA-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271612#comment-14271612
]
Neha Narkhede edited comment on KAFKA-1819 at 1/9/15 6:14 PM:
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29752/#review67466
---
Ship it!
Looks good other than what Ewen pointed out.
- Neha
[
https://issues.apache.org/jira/browse/KAFKA-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1855:
-
Reviewer: Neha Narkhede
Assignee: (was: Neha Narkhede)
Topic unusable after unsuccessful
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29751/#review67476
---
Ship it!
Ship It!
- Neha Narkhede
On Jan. 9, 2015, 2:53 a.m.,
[
https://issues.apache.org/jira/browse/KAFKA-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271670#comment-14271670
]
Jun Rao commented on KAFKA-1851:
Because it doesn't match the spec of the protocol. If you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67477
---
kafka-patch-review.py
[
https://issues.apache.org/jira/browse/KAFKA-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271737#comment-14271737
]
Jay Kreps commented on KAFKA-1853:
--
Hey [~jaikiran] I am not sure about this change. The
[
https://issues.apache.org/jira/browse/KAFKA-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271612#comment-14271612
]
Neha Narkhede edited comment on KAFKA-1819 at 1/9/15 6:06 PM:
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/
---
(Updated Jan. 9, 2015, 6:15 p.m.)
Review request for kafka.
Bugs: KAFKA-1723
On Jan. 8, 2015, 9:21 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/Selector.java, line
419
https://reviews.apache.org/r/29523/diff/20/?file=813232#file813232line419
It's probably better to just reference a ProducerMetrics constant.
Selector is a low
On Jan. 8, 2015, 10:28 p.m., Jay Kreps wrote:
clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java, line 115
https://reviews.apache.org/r/29523/diff/20/?file=813229#file813229line115
This won't be enough to distinguish the metric, right? Absent the
group/tags info...
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271663#comment-14271663
]
Manikumar Reddy commented on KAFKA-1723:
1. Submitted new patch with suggested
On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote:
kafka-patch-review.py, line 96
https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96
Did you tested the failure senario? I did not get error message. I
think we will get exception only after invoking
[
https://issues.apache.org/jira/browse/KAFKA-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1842:
-
Component/s: config
New producer/consumer should support configurable connection timeouts
[
https://issues.apache.org/jira/browse/KAFKA-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1842:
-
Fix Version/s: 0.8.3
New producer/consumer should support configurable connection timeouts
[
https://issues.apache.org/jira/browse/KAFKA-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271749#comment-14271749
]
Jun Rao commented on KAFKA-1797:
Thanks for the reviews. Committed changes suggested by
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29752/#review67457
---
Ship it!
One minor nit, but looks good to me. Non-binding +1.
Henri Pihkala created KAFKA-1855:
Summary: Topic unreadable after unsuccessful UpdateMetadataRequest
Key: KAFKA-1855
URL: https://issues.apache.org/jira/browse/KAFKA-1855
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Pihkala updated KAFKA-1855:
-
Summary: Topic unusable after unsuccessful UpdateMetadataRequest (was:
Topic unreadable after
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29738/#review67458
---
Ship it!
Ship It!
- Neha Narkhede
On Jan. 9, 2015, 1:22 a.m.,
[
https://issues.apache.org/jira/browse/KAFKA-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271612#comment-14271612
]
Neha Narkhede commented on KAFKA-1819:
--
[~gwenshap] Saw the following unit test
[
https://issues.apache.org/jira/browse/KAFKA-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1786:
-
Reviewer: Neha Narkhede
implement a global configuration feature for brokers
[
https://issues.apache.org/jira/browse/KAFKA-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271770#comment-14271770
]
Neha Narkhede commented on KAFKA-1786:
--
[~abiletskyi], [~charmalloc]. For large
[
https://issues.apache.org/jira/browse/KAFKA-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271797#comment-14271797
]
Neha Narkhede commented on KAFKA-1753:
--
[~joestein], KAFKA-1792 is waiting on a
[
https://issues.apache.org/jira/browse/KAFKA-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271919#comment-14271919
]
Gwen Shapira commented on KAFKA-1819:
-
I'm having trouble reproducing the errors:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/
---
(Updated Jan. 9, 2015, 6:12 p.m.)
Review request for kafka.
Bugs: KAFKA-1723
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1723:
---
Attachment: KAFKA-1723_2015-01-09_23:43:22.patch
make the metrics name in new producer more
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271637#comment-14271637
]
Manikumar Reddy commented on KAFKA-1723:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1836:
-
Reviewer: Neha Narkhede
[~jaikiran] Will help you check this in after [~ewencp]'s comment is
[
https://issues.apache.org/jira/browse/KAFKA-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1848:
-
Reviewer: Guozhang Wang
Checking shutdown during each iteration of ZookeeperConsumerConnector
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/#review67479
---
Ship it!
Thanks for the patch. Checked the jmx and looks good to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29647/#review67489
---
This seems like a small change, but it is not since it changes the
[
https://issues.apache.org/jira/browse/KAFKA-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1851:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for the review. Committed to both
[
https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1792:
-
Reviewer: Neha Narkhede
change behavior of --generate to produce assignment config with fair
[
https://issues.apache.org/jira/browse/KAFKA-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1843:
-
Component/s: producer
Metadata fetch/refresh in new producer should handle all node connection
[
https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271791#comment-14271791
]
Neha Narkhede edited comment on KAFKA-1792 at 1/9/15 8:02 PM:
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29751/#review67499
---
core/src/main/scala/kafka/server/KafkaApis.scala
[
https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271791#comment-14271791
]
Neha Narkhede commented on KAFKA-1792:
--
[~Dmitry Pekar] Not sure if you are waiting
[
https://issues.apache.org/jira/browse/KAFKA-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271990#comment-14271990
]
Jun Rao commented on KAFKA-1841:
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29692/
---
(Updated Jan. 9, 2015, 10:36 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14272031#comment-14272031
]
Gwen Shapira commented on KAFKA-1819:
-
Looking more into this, I'm not even sure if it
[
https://issues.apache.org/jira/browse/KAFKA-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1841:
---
Attachment: kafka-1841_2015-01-09_14:36:50.patch
OffsetCommitRequest API - timestamp field is not versioned
[
https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14272039#comment-14272039
]
Neha Narkhede commented on KAFKA-1792:
--
[~joestein] No problem at all. I was catching
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14272057#comment-14272057
]
Jun Rao commented on KAFKA-1481:
Also committed the doc change to 0.8.2 documentation.
[
https://issues.apache.org/jira/browse/KAFKA-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271871#comment-14271871
]
Joe Stein commented on KAFKA-1786:
--
Hey [~nehanarkhede] I had sent this out on the
[
https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271872#comment-14271872
]
Joe Stein commented on KAFKA-1792:
--
[~nehanarkhede] Dmitry has been out on vacation and
On Jan. 9, 2015, 8:01 p.m., Ewen Cheslack-Postava wrote:
core/src/main/scala/kafka/server/KafkaApis.scala, line 512
https://reviews.apache.org/r/29751/diff/1/?file=813957#file813957line512
You could just change getOffsets so it doesn't have this behavior
instead of checking the
[
https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271884#comment-14271884
]
Jun Rao commented on KAFKA-1852:
Another weird thing this causes is that we can commit an
On Jan. 9, 2015, 9:44 a.m., Manikumar Reddy O wrote:
kafka-patch-review.py, line 134
https://reviews.apache.org/r/29756/diff/2/?file=814144#file814144line134
Can we do authentication check at the beginning and fail-fast if the
username/password is wrong. Currently it will update
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/
---
(Updated Jan. 9, 2015, 12:47 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270968#comment-14270968
]
jaikiran pai commented on KAFKA-1854:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jaikiran pai updated KAFKA-1854:
Attachment: KAFKA-1854_2015-01-09_18:16:35.patch
Allow the JIRA username and password to be
On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote:
kafka-patch-review.py, line 96
https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96
Did you tested the failure senario? I did not get error message. I
think we will get exception only after invoking
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29756/#review67414
---
kafka-patch-review.py
On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote:
kafka-patch-review.py, line 96
https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96
Did you tested the failure senario? I did not get error message. I
think we will get exception only after invoking
On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote:
kafka-patch-review.py, line 96
https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96
Did you tested the failure senario? I did not get error message. I
think we will get exception only after invoking
On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote:
kafka-patch-review.py, line 96
https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96
Did you tested the failure senario? I did not get error message. I
think we will get exception only after invoking
On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote:
kafka-patch-review.py, line 96
https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96
Did you tested the failure senario? I did not get error message. I
think we will get exception only after invoking
97 matches
Mail list logo
