It is a bit hacky, with multiple requests in transit on the wire how do
you know which request wasn't supported if the returned correlationId is -1?
Requests are currently responded to in the order they were sent, so the
corrId
is not yet critical, but with will this always be true? One could
QianHu created KAFKA-1869:
-
Summary: Openning some random ports while running kafka service
Key: KAFKA-1869
URL: https://issues.apache.org/jira/browse/KAFKA-1869
Project: Kafka
Issue Type: Bug
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29714/#review68424
---
core/src/main/scala/kafka/network/IPFilter.scala
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Vandevelde updated KAFKA-1870:
-
Summary: Cannot commit with simpleConsumer on Zookeeper only with Java API
(was: Cannot
Thomas Vandevelde created KAFKA-1870:
Summary: Cannot commit on Zookeeper only with Java API
Key: KAFKA-1870
URL: https://issues.apache.org/jira/browse/KAFKA-1870
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Vandevelde updated KAFKA-1870:
-
Attachment: OffsetCommitRequest.diff
Patch attached
Cannot commit with simpleConsumer
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280429#comment-14280429
]
Sriharsha Chintalapani commented on KAFKA-1870:
---
[~tomvdv] can you send the
Magnus,
I think I buy your points, we can return the empty response with just the
response header, in which case the current JVM clients will throw
Serialization Exception, for other clients like kafka-python they will
throw similar exceptions also while trying to construct the response body.
Igor Khomenko created KAFKA-1871:
Summary: Kafka Producer constructor hungs in case of wrong
'serializer.class' property
Key: KAFKA-1871
URL: https://issues.apache.org/jira/browse/KAFKA-1871
Project:
[
https://issues.apache.org/jira/browse/KAFKA-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Khomenko updated KAFKA-1871:
-
Fix Version/s: (was: 0.8.2)
0.8.1.2
Kafka Producer constructor hungs in
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280517#comment-14280517
]
Guozhang Wang commented on KAFKA-1870:
--
Thanks for the findings Thomas.
However
Yeah I second what Magnus is saying, reusing correlation id to mean
something else isn't the right thing. This would actually break the Java
clients as well which are very pedantic about getting the right correlation
in each response.
-Jay
On Fri, Jan 16, 2015 at 2:34 AM, Magnus Edenhill
I'm definitely +1 on the KIP concept. As Joe mentioned, we are already
doing this in one form or the other. However, IMO it is fairly ad hoc
- i.e., a combination of DISCUSS threads, jira comments, RB and code
comments, wikis and html documentation. In the past I have had to dig
into a bunch of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29952/#review68437
---
Ship it!
Ship It!
- Neha Narkhede
On Jan. 16, 2015, 12:52 a.m.,
I think adding a section about deprecation would be helpful. A good
fraction of the time I would expect the goal of a KIP is to fix or replace
older functionality that needs continued support for compatibility, but
should eventually be phased out. This helps Kafka devs understand how long
they'll
Gwen -- KIP write up looks good. Deprecation schedule probably needs to be
more specific, but I think that discussion probably needs to happen after a
solution is agreed upon.
Jay -- I think older clients will get a bad error message instead of a
good one isn't what would be happening with this
[
https://issues.apache.org/jira/browse/KAFKA-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1730:
-
Fix Version/s: 0.8.2
add the doc for the new java producer in 0.8.2
[
https://issues.apache.org/jira/browse/KAFKA-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1864:
-
Fix Version/s: 0.8.2
Revisit defaults for the internal offsets topic
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1870:
-
Assignee: Joel Koshy (was: Neha Narkhede)
Cannot commit with simpleConsumer on Zookeeper only
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1870:
-
Assignee: (was: Joel Koshy)
Cannot commit with simpleConsumer on Zookeeper only with Java
On Jan. 16, 2015, 1:55 p.m., Eric Olander wrote:
core/src/test/scala/unit/kafka/network/IPFilterTest.scala, line 71
https://reviews.apache.org/r/29714/diff/2/?file=823240#file823240line71
This is more an FYI as it may go against established practices for
tests in this project.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29203/#review68441
---
Ship it!
Ship It!
- Guozhang Wang
On Dec. 18, 2014, 11:42 a.m.,
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1870:
-
Reviewer: Joel Koshy
Since this is related to offset commit, thought you'd like to take a look,
Gwen,
KIP write-up looks good. According to the rest of the KIP process proposal,
would you like to start a DISCUSS/VOTE thread for it?
Thanks,
Neha
On Fri, Jan 16, 2015 at 9:37 AM, Ewen Cheslack-Postava e...@confluent.io
wrote:
Gwen -- KIP write up looks good. Deprecation schedule probably
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29203/#review68442
---
Ship it!
Ship It!
- Neha Narkhede
On Dec. 18, 2014, 11:42 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29714/#review68440
---
Looks awesome. Great tests.
Two things:
1. The patch no longer
[
https://issues.apache.org/jira/browse/KAFKA-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy resolved KAFKA-1869.
Resolution: Not a Problem
Fix Version/s: 0.8.2
Assignee: Manikumar Reddy
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280619#comment-14280619
]
Joel Koshy commented on KAFKA-1870:
---
Committing offsets to Kafka is a little more
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280632#comment-14280632
]
Thomas Vandevelde commented on KAFKA-1870:
--
Do you mean we should then have the
+1 to Ewen's suggestions: Deprecation, status and version.
Perhaps add the JIRA where the KIP was implemented to the metadata.
This will help tie things together.
On Fri, Jan 16, 2015 at 9:35 AM, Ewen Cheslack-Postava
e...@confluent.io wrote:
I think adding a section about deprecation would be
[
https://issues.apache.org/jira/browse/KAFKA-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280669#comment-14280669
]
Sriharsha Chintalapani commented on KAFKA-1871:
---
[~igor.quickblox] is the
[
https://issues.apache.org/jira/browse/KAFKA-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280677#comment-14280677
]
Jun Rao commented on KAFKA-1871:
Could you get the stack trace? Thanks,
Kafka Producer
Agree that reusing correlation id won't work well.
I want to point out that the issue is larger than just unsupported
request types.
Any error that happens before we figure out the request leads to
silently closing the connection. Requests larger than
socket.request.max.bytes, or IPs with more
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280715#comment-14280715
]
Joel Koshy commented on KAFKA-1870:
---
Not really - the SimpleConsumer commitOffsets
+1 on the idea, and we could mutually link the KIP wiki page with the the
created JIRA ticket (i.e. include the JIRA number on the page and the KIP
url on the ticket description).
Regarding the KIP process, probably we do not need two phase communication
of a [DISCUSS] followed by [VOTE], as Jay
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280725#comment-14280725
]
Guozhang Wang commented on KAFKA-1870:
--
Joel, I think for v0 now the offsets will be
[
https://issues.apache.org/jira/browse/KAFKA-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280724#comment-14280724
]
Jun Rao commented on KAFKA-1649:
This is discussed in the mailing list. The behavior
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280728#comment-14280728
]
Jun Rao commented on KAFKA-1870:
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1870:
---
Attachment: kafka-1870.patch
Cannot commit with simpleConsumer on Zookeeper only with Java API
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1870:
---
Assignee: Jun Rao
Status: Patch Available (was: Open)
Cannot commit with simpleConsumer on Zookeeper
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29977/
---
Review request for kafka.
Bugs: kafka-1870
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29977/#review68459
---
core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280736#comment-14280736
]
Joel Koshy commented on KAFKA-1870:
---
[~guozhang] yes that is the intended effect. i.e.,
I updated the KIP: Using acks 1 in version 0 will log a WARN message
in the broker about client using deprecated behavior (suggested by Joe
in the JIRA, and I think it makes sense).
Gwen
On Fri, Jan 16, 2015 at 10:40 AM, Gwen Shapira gshap...@cloudera.com wrote:
How about we continue the
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280742#comment-14280742
]
Joel Koshy commented on KAFKA-1870:
---
Actually, sorry - nm. I just misread the API. For
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29977/
---
(Updated Jan. 16, 2015, 8:08 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1870:
---
Attachment: kafka-1870_2015-01-16_12:08:05.patch
Cannot commit with simpleConsumer on Zookeeper only with
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280756#comment-14280756
]
Jun Rao commented on KAFKA-1870:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280768#comment-14280768
]
Jun Rao commented on KAFKA-1870:
I think it makes sense to pin the version of
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280778#comment-14280778
]
Joel Koshy commented on KAFKA-1870:
---
This is a pretty severe limitation of the scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29977/#review68466
---
Ship it!
Ship It!
- Joel Koshy
On Jan. 16, 2015, 8:08 p.m., Jun
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280890#comment-14280890
]
Gwen Shapira commented on KAFKA-1856:
-
[~singhashish], I see many errors in the tests
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Stein updated KAFKA-1856:
-
Reviewer: Gwen Shapira
once this is working let me know and I can create the Jenkins build for
whatever
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280949#comment-14280949
]
Ashish Kumar Singh commented on KAFKA-1856:
---
[~gwenshap] those errors are due to
On Jan. 16, 2015, 7:53 p.m., Sriharsha Chintalapani wrote:
core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala, line 22
https://reviews.apache.org/r/29977/diff/1/?file=823660#file823660line22
Shouldn't this provide another constructor that takes in versionId?
The problem is
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280959#comment-14280959
]
Gwen Shapira commented on KAFKA-1856:
-
Any idea what do other projects do about flaky
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29977/#review68498
---
Ship it!
Ship It!
- Sriharsha Chintalapani
On Jan. 16, 2015,
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280985#comment-14280985
]
Ashish Kumar Singh commented on KAFKA-1856:
---
I can speak of Apache Hive. The
[
https://issues.apache.org/jira/browse/KAFKA-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280988#comment-14280988
]
Ashish Kumar Singh commented on KAFKA-1664:
---
Testing file
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280991#comment-14280991
]
Ashish Kumar Singh commented on KAFKA-1856:
---
So, I re-ran it on KAFKA-1664,
[
https://issues.apache.org/jira/browse/KAFKA-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-1548:
-
Description:
Today in many requests like fetch and offset we have a integer replica_id
field, if
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281102#comment-14281102
]
Gwen Shapira commented on KAFKA-1856:
-
It does!
SQOOP's precommit hook contains a
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281116#comment-14281116
]
Gwen Shapira commented on KAFKA-1856:
-
btw. can you test on a non-trunk version? like
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29893/#review68534
---
Awesome script. Very nicely structured and very readable. I left
[
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1870:
---
Priority: Blocker (was: Minor)
Fix Version/s: 0.8.2
Marking this as an 0.8.2 blocker.
Cannot
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281166#comment-14281166
]
Jun Rao commented on KAFKA-1723:
Actually committed the delta patch to 0.8.2 as well.
[
https://issues.apache.org/jira/browse/KAFKA-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1864:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for the reviews. Committed to 0.8.2
[
https://issues.apache.org/jira/browse/KAFKA-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281175#comment-14281175
]
Jun Rao commented on KAFKA-1867:
When fixing this, we should remove the TODO items in
[
https://issues.apache.org/jira/browse/KAFKA-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281178#comment-14281178
]
Manikumar Reddy commented on KAFKA-1864:
Will this also fixes KAFKA-1846?
[
https://issues.apache.org/jira/browse/KAFKA-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-1846.
Resolution: Duplicate
Fix Version/s: (was: 0.8.3)
Duplicate of KAFKA-1864.
Offset storage
[
https://issues.apache.org/jira/browse/KAFKA-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281182#comment-14281182
]
Jun Rao commented on KAFKA-1864:
Yes, thanks for the reminder.
Revisit defaults for the
71 matches
Mail list logo
