[jira] [Commented] (KAFKA-1408) Kafk broker can not stop itself normaly after problems with connection to ZK

2015-02-09 Thread Dmitry Bugaychenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313765#comment-14313765 ] Dmitry Bugaychenko commented on KAFKA-1408: --- When topic deletion is disabled the

Re: [DISCUSS] KIP-8 Add a flush method to the new Java producer

2015-02-09 Thread Bhavesh Mistry
HI Jay, Imagine, if you have flaky network connection to brokers, and if flush() will be blocked if "one of broker is not available" ( basically How would be address failure mode and io thread not able to drain records or busy due to pending request". Do you flush() method is only to flush to in m

Re: New consumer client

2015-02-09 Thread Bhavesh Mistry
Hi Jay, 1) Sorry to get back to you so late. It is CRC check error on any consumer thread regardless of the server. What happens is I have to catch this exception is skip the message now. There is no option to re-fetch this message. Is there any way to add behavior in Java consumer to re-fet

Re: Kafka New(Java) Producer Connection reset by peer error and LB

2015-02-09 Thread Bhavesh Mistry
HI Kafka Team, Please confirm if you would like to open Jira issue to track this ? Thanks, Bhavesh On Mon, Feb 9, 2015 at 12:39 PM, Bhavesh Mistry wrote: > Hi Kakfa Team, > > We are getting this connection reset by pears after couple of minute aster > start-up of producer due to infrastructur

[jira] [Created] (KAFKA-1939) Add csv reporter in ProducerPerformance for the new producer

2015-02-09 Thread xinyisu (JIRA)
xinyisu created KAFKA-1939: -- Summary: Add csv reporter in ProducerPerformance for the new producer Key: KAFKA-1939 URL: https://issues.apache.org/jira/browse/KAFKA-1939 Project: Kafka Issue Type: N

Build failed in Jenkins: KafkaPreCommit #1

2015-02-09 Thread Apache Jenkins Server
See -- [...truncated 1963 lines...] at scala.collection.mutable.ArrayOps$ofRef.count(ArrayOps.scala:186) at kafka.utils.TestUtils$.verifyNonDaemonThreadsStatus(TestUtils.scala:707) at

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-09 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313546#comment-14313546 ] Ashish Kumar Singh commented on KAFKA-1856: --- Sounds good [~charmalloc]. Thanks!

Re: [DISCUSS] KIPs

2015-02-09 Thread Joe Stein
I did https://cwiki.apache.org/confluence/display/KAFKA/drafts ~ Joestein On Mon, Feb 9, 2015 at 11:01 PM, Jay Kreps wrote: > Yeah no pressure. I think you added a holding area for incomplete KIPs, > right? I think that is a good idea. We definitely need a place to stash > these while they are

Re: [DISCUSS] KIP-8 Add a flush method to the new Java producer

2015-02-09 Thread Jay Kreps
Yeah I second the problem Guozhang flags with giving flush a timeout. In general failover in Kafka is a bounded thing unless you have brought your Kafka cluster down entirely so I think depending on that bound implicitly is okay. It is possible to make flush() be instead boolean tryFlush(long ti

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-09 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313509#comment-14313509 ] Joe Stein commented on KAFKA-1856: -- [~singhashish] I created a new jenkins build https:/

Re: [DISCUSS] KIP-8 Add a flush method to the new Java producer

2015-02-09 Thread Jay Kreps
Hey Joel, The use case would be for something like mirror maker. You want to do something like the following: while(true) { val recs = consumer.poll(time); for(rec <- recs) producer.send(rec); producer.flush(); consumer.commit(); } If you replace flush() with just calling get() on th

Re: [DISCUSS] KIPs

2015-02-09 Thread Jay Kreps
Yeah no pressure. I think you added a holding area for incomplete KIPs, right? I think that is a good idea. We definitely need a place to stash these while they are getting built out... -Jay On Mon, Feb 9, 2015 at 6:10 PM, Joe Stein wrote: > I like the round-up, looks good, thanks Joel. > > I s

Re: Cannot stop Kafka server if zookeeper is shutdown first

2015-02-09 Thread Jaikiran Pai
Hi, I don't have enough context to know if replacing ZkClient is important right now. However, I did take a look at the code to see how extensively ZkClient gets used and I agree with Gwen that replacing it is a bigger task and will need further testing too, to ensure they don't have issues o

Re: [DISCUSS] KIP-8 Add a flush method to the new Java producer

2015-02-09 Thread Joel Koshy
- WRT the motivation: "if you set linger.ms > 0 to encourage batching of messages, which is likely a good idea for this kind of use case, then the second for loop will block for a ms" -> however, in practice this will really only be for the first couple of calls right? Since the subsequent

Re: [DISCUSS] KIPs

2015-02-09 Thread Joe Stein
I like the round-up, looks good, thanks Joel. I should be able to get KIP-5 and KIP-6 to have more detail in the coming days. ~ Joestein On Mon, Feb 9, 2015 at 9:01 PM, Joel Koshy wrote: > I'm looking through a couple of the KIP threads today and had the same > issue; and thought it would be u

Re: [DISCUSS] KIPs

2015-02-09 Thread Joel Koshy
I'm looking through a couple of the KIP threads today and had the same issue; and thought it would be useful to do a status round-up of KIPs. We could incorporate status in the title itself (so we can quickly see it in the child-page list) but I just added a table to the top-level wiki. Hopefully t

Re: [DISCUSSION] KIP-2: Refactor Brokers to Allow Multiple Endpoints

2015-02-09 Thread Joel Koshy
For (1) - +1 especially since the existing clients will keep working. For (2) - I'm less clear on the proposal. Can you incorporate it into the KIP and/or linked wiki? Also, on the KIP itself, can you clarify what the TRACE protocol is? The RB has a brief comment ("plan is to add instrumentation i

Build failed in Jenkins: Kafka-trunk #389

2015-02-09 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-1333; Add the consumer coordinator to server; reviewed by Onur Karaman and Jay Kreps [wangguoz] KAFKA-1333 follow-up; Add missing files for the coordinator folder -- [.

[jira] [Commented] (KAFKA-1546) Automate replica lag tuning

2015-02-09 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313301#comment-14313301 ] Aditya Auradkar commented on KAFKA-1546: [~nmarasoi] are you actively working on t

[jira] [Created] (KAFKA-1938) [doc] Quick start example should reference appropriate Kafka version

2015-02-09 Thread Stevo Slavic (JIRA)
Stevo Slavic created KAFKA-1938: --- Summary: [doc] Quick start example should reference appropriate Kafka version Key: KAFKA-1938 URL: https://issues.apache.org/jira/browse/KAFKA-1938 Project: Kafka

[jira] [Updated] (KAFKA-1937) Mirror maker needs to clear the unacked offset map after rebalance.

2015-02-09 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1937: Attachment: KAFKA-1937.patch > Mirror maker needs to clear the unacked offset map after rebalance. >

[jira] [Commented] (KAFKA-1937) Mirror maker needs to clear the unacked offset map after rebalance.

2015-02-09 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313195#comment-14313195 ] Jiangjie Qin commented on KAFKA-1937: - Created reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1937) Mirror maker needs to clear the unacked offset map after rebalance.

2015-02-09 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1937: Status: Patch Available (was: Open) > Mirror maker needs to clear the unacked offset map after reba

Review Request 30810: Patch for KAFKA-1937

2015-02-09 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30810/ --- Review request for kafka. Bugs: KAFKA-1937 https://issues.apache.org/jira/b

Re: Review Request 30809: Patch for KAFKA-1888

2015-02-09 Thread Abhishek Nigam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/ --- (Updated Feb. 9, 2015, 11:53 p.m.) Review request for kafka. Bugs: KAFKA-1888

[jira] [Created] (KAFKA-1937) Mirror maker needs to clear the unacked offset map after rebalance.

2015-02-09 Thread Jiangjie Qin (JIRA)
Jiangjie Qin created KAFKA-1937: --- Summary: Mirror maker needs to clear the unacked offset map after rebalance. Key: KAFKA-1937 URL: https://issues.apache.org/jira/browse/KAFKA-1937 Project: Kafka

Review Request 30809: Patch for KAFKA-1888

2015-02-09 Thread Abhishek Nigam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/ --- Review request for kafka. Bugs: KAFKA-1888 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1333) Add consumer co-ordinator module to the server

2015-02-09 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313130#comment-14313130 ] Guozhang Wang commented on KAFKA-1333: -- Pushed to trunk and leaving this ticket as op

Re: [DISCUSS] KIP-8 Add a flush method to the new Java producer

2015-02-09 Thread Guozhang Wang
The proposal looks good to me, will need some time to review the implementation RB later. Bhavesh, I am wondering how you will use a flush() with a timeout since such a call does not actually provide any flushing guarantees? As for close(), there is a separate JIRA for this: KAFKA-1660

Re: Review Request 29831: Patch for KAFKA-1476

2015-02-09 Thread Onur Karaman
> On Feb. 7, 2015, 3:33 p.m., Neha Narkhede wrote: > > Thanks for attaching the latest run of the tool. I observed that we should > > get rid of zookeeper error message from > > Could not fetch offset from zookeeper for group g1 partition [t1,0] due to > > org.apache.zookeeper.KeeperException$

[jira] [Updated] (KAFKA-1476) Get a list of consumer groups

2015-02-09 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Onur Karaman updated KAFKA-1476: Attachment: sample-kafka-consumer-groups-sh-output-2-9-2015.txt > Get a list of consumer groups > --

[jira] [Updated] (KAFKA-1476) Get a list of consumer groups

2015-02-09 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Onur Karaman updated KAFKA-1476: Attachment: KAFKA-1476_2015-02-09_14:37:30.patch > Get a list of consumer groups > -

[jira] [Commented] (KAFKA-1476) Get a list of consumer groups

2015-02-09 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313035#comment-14313035 ] Onur Karaman commented on KAFKA-1476: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 29831: Patch for KAFKA-1476

2015-02-09 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29831/ --- (Updated Feb. 9, 2015, 10:37 p.m.) Review request for kafka. Bugs: KAFKA-1476

Re: [DISCUSS] KIP-8 Add a flush method to the new Java producer

2015-02-09 Thread Bhavesh Mistry
Hi Jay, How about adding timeout for each method calls flush(timeout,TimeUnit) and close(timeout,TimeUNIT) ? We had runway io thread issue and caller thread should not blocked for ever for these methods ? Thanks, Bhavesh On Sun, Feb 8, 2015 at 12:18 PM, Jay Kreps wrote: > Well actually in t

[jira] [Commented] (KAFKA-1927) Replace requests in kafka.api with requests in org.apache.kafka.common.requests

2015-02-09 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313017#comment-14313017 ] Tong Li commented on KAFKA-1927: @jay, @Gwen, thanks so much for both of your comments. I

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-02-09 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313014#comment-14313014 ] Tong Li commented on KAFKA-1926: Jay. awesome comment, really appreciated. I will start wi

Re: Review Request 29893: Patch for KAFKA-1856

2015-02-09 Thread Ashish Singh
> On Feb. 8, 2015, 4:07 p.m., Joe Stein wrote: > > dev-utils/test-patch.py, line 147 > > > > > > What is this structure that comes back? When it sorts does it do the > > latest time first and uses that patch? I am run

Re: Review Request 29893: Patch for KAFKA-1856

2015-02-09 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29893/#review71700 --- dev-utils/test-patch.py

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

2015-02-09 Thread Jiangjie Qin
I just updated the KIP page and incorporated Jay and Neha’s suggestion. As a brief summary of where we are: Consensus reached: Have N independent mirror maker threads each has their own consumers but share a producer. The mirror maker threads will be responsible for decompression, compression and

Kafka New(Java) Producer Connection reset by peer error and LB

2015-02-09 Thread Bhavesh Mistry
Hi Kakfa Team, We are getting this connection reset by pears after couple of minute aster start-up of producer due to infrastructure deployment strategies we have adopted from LinkedIn. We have LB hostname and port as seed server, and all producers are getting following exception because of TCP i

[jira] [Commented] (KAFKA-1758) corrupt recovery file prevents startup

2015-02-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312603#comment-14312603 ] Manikumar Reddy commented on KAFKA-1758: Attaching a patch which handles NumberFor

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-02-09 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312598#comment-14312598 ] Jay Kreps commented on KAFKA-1926: -- Hey [~tongli] this is a great bug to start with. Basi

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-09 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312596#comment-14312596 ] Ashish Kumar Singh commented on KAFKA-1856: --- [~gwenshap] and [~charmalloc] thank

[jira] [Commented] (KAFKA-1758) corrupt recovery file prevents startup

2015-02-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312592#comment-14312592 ] Manikumar Reddy commented on KAFKA-1758: Created reviewboard https://reviews.apach

[jira] [Updated] (KAFKA-1758) corrupt recovery file prevents startup

2015-02-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1758: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) > corrupt recovery file p

[jira] [Updated] (KAFKA-1758) corrupt recovery file prevents startup

2015-02-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1758: --- Attachment: KAFKA-1758.patch > corrupt recovery file prevents startup > --

[jira] [Created] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-02-09 Thread Aditya Auradkar (JIRA)
Aditya Auradkar created KAFKA-1936: -- Summary: Track offset commit requests separately from produce requests Key: KAFKA-1936 URL: https://issues.apache.org/jira/browse/KAFKA-1936 Project: Kafka

Review Request 30801: Patch for KAFKA-1758

2015-02-09 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30801/ --- Review request for kafka. Bugs: KAFKA-1758 https://issues.apache.org/jira/b

Re: Review Request 30570: Patch for KAFKA-1914

2015-02-09 Thread Aditya Auradkar
> On Feb. 9, 2015, 6:29 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, lines 296-303 > > > > > > I agree with Guozhang that the offset commits need to be disambiguated. > > > >

[jira] [Resolved] (KAFKA-1661) Move MockConsumer and MockProducer from src/main to src/test

2015-02-09 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-1661. -- Resolution: Fixed Hey guys, I'd like to close this. The mock is in the public part of the main jar inte

[jira] [Commented] (KAFKA-1927) Replace requests in kafka.api with requests in org.apache.kafka.common.requests

2015-02-09 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312581#comment-14312581 ] Jay Kreps commented on KAFKA-1927: -- Hey [~tongli] Gwen is right that this will be a prett

[jira] [Commented] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerOffsetChecker

2015-02-09 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312578#comment-14312578 ] Ashish Kumar Singh commented on KAFKA-313: -- Sounds good to me. > Add JSON/CSV out

Re: Review Request 30570: Patch for KAFKA-1914

2015-02-09 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30570/#review71660 --- core/src/main/scala/kafka/server/ReplicaManager.scala

Re: org.apache.common migration

2015-02-09 Thread Jay Kreps
Hey Jun, I think the existing scala clients should just remain as they are. There is no point updating them, and as you say it would be quite fragile. The conversion to the new requests would just be for the server usage. -Jay On Mon, Feb 9, 2015 at 9:48 AM, Jun Rao wrote: > We need to be a bi

Re: Review Request 30570: Patch for KAFKA-1914

2015-02-09 Thread Aditya Auradkar
> On Feb. 9, 2015, 5:47 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, lines 296-303 > > > > > > appendToLocalLog can be called for both produce and commit-offset > > requests. A

Re: Review Request 30570: Patch for KAFKA-1914

2015-02-09 Thread Aditya Auradkar
> On Feb. 9, 2015, 5:47 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, lines 296-303 > > > > > > appendToLocalLog can be called for both produce and commit-offset > > requests. A

[jira] [Commented] (KAFKA-1925) Coordinator Node Id set to INT_MAX breaks coordinator metadata updates

2015-02-09 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312538#comment-14312538 ] Guozhang Wang commented on KAFKA-1925: -- Pushed to trunk. > Coordinator Node Id set t

[jira] [Updated] (KAFKA-1925) Coordinator Node Id set to INT_MAX breaks coordinator metadata updates

2015-02-09 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1925: - Resolution: Fixed Status: Resolved (was: Patch Available) > Coordinator Node Id set to IN

[jira] [Created] (KAFKA-1935) Consumer should use a separate socket for Coordinator connection

2015-02-09 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1935: Summary: Consumer should use a separate socket for Coordinator connection Key: KAFKA-1935 URL: https://issues.apache.org/jira/browse/KAFKA-1935 Project: Kafka

Re: org.apache.common migration

2015-02-09 Thread Jun Rao
We need to be a bit careful when doing 2b. Currently, our public apis include SimpleConsumer, which unfortunately exposes our RPC requests/responses. Doing 2b would mean api changes to SimpleConsumer. So, if we want to do 2b before 3, we would need to agree on making such api changes. Otherwise, 2b

Re: Review Request 30570: Patch for KAFKA-1914

2015-02-09 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30570/#review71646 --- core/src/main/scala/kafka/server/ReplicaManager.scala

Re: Review Request 30777: Patch for KAFKA-1919

2015-02-09 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30777/#review71643 --- Ship it! Ship It! - Guozhang Wang On Feb. 9, 2015, 1:01 a.m., Ja

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations

2015-02-09 Thread Guozhang Wang
I feel the benefits of lowering the development bar for new clients does not worth the complexity we need to introduce in the server side, as today the clients just need one more request type (metadata request) to send the produce / fetch to the right brokers, whereas re-routing mechanism will resu

[jira] [Commented] (KAFKA-1927) Replace requests in kafka.api with requests in org.apache.kafka.common.requests

2015-02-09 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312466#comment-14312466 ] Gwen Shapira commented on KAFKA-1927: - Hey, didn't mean to make it sound like you are

[jira] [Updated] (KAFKA-1933) Fine-grained locking in log append

2015-02-09 Thread Maxim Ivanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Ivanov updated KAFKA-1933: Description: This patch adds finer locking when appending to log. It breaks global append lock into

[jira] [Commented] (KAFKA-1737) Document required ZkSerializer for ZkClient used with AdminUtils

2015-02-09 Thread Vivek Madani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312350#comment-14312350 ] Vivek Madani commented on KAFKA-1737: - I'll take care of this and submit a new patch -

[jira] [Commented] (KAFKA-1933) Fine-grained locking in log append

2015-02-09 Thread Maxim Ivanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312349#comment-14312349 ] Maxim Ivanov commented on KAFKA-1933: - Got a results on a beefier machine with 16 cor

[jira] [Commented] (KAFKA-1927) Replace requests in kafka.api with requests in org.apache.kafka.common.requests

2015-02-09 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312280#comment-14312280 ] Tong Li commented on KAFKA-1927: Gwen Shapira, indeed. I was doing OpenStack development f

[jira] [Commented] (KAFKA-1927) Replace requests in kafka.api with requests in org.apache.kafka.common.requests

2015-02-09 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312263#comment-14312263 ] Gwen Shapira commented on KAFKA-1927: - I'm not sure I'd take it as my first patch (in

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-02-09 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312229#comment-14312229 ] Tong Li commented on KAFKA-1926: Jay, if you can provide a bit more direction, I would lik

[jira] [Commented] (KAFKA-1927) Replace requests in kafka.api with requests in org.apache.kafka.common.requests

2015-02-09 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312224#comment-14312224 ] Tong Li commented on KAFKA-1927: I wonder if Jay can provide a bit more information so tha

[jira] [Commented] (KAFKA-1933) Fine-grained locking in log append

2015-02-09 Thread Maxim Ivanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312181#comment-14312181 ] Maxim Ivanov commented on KAFKA-1933: - Updated patch, now it correctly calculates offs

[jira] [Updated] (KAFKA-1933) Fine-grained locking in log append

2015-02-09 Thread Maxim Ivanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Ivanov updated KAFKA-1933: Attachment: KAFKA-1933_2015-02-09_12:27:06.patch > Fine-grained locking in log append >

Re: Review Request 30775: Fine-grained locking in log.append

2015-02-09 Thread Maxim Ivanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30775/ --- (Updated Feb. 9, 2015, 12:27 p.m.) Review request for kafka. Bugs: KAFKA-1933

[jira] [Commented] (KAFKA-1933) Fine-grained locking in log append

2015-02-09 Thread Maxim Ivanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312171#comment-14312171 ] Maxim Ivanov commented on KAFKA-1933: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1933) Fine-grained locking in log append

2015-02-09 Thread Maxim Ivanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Ivanov updated KAFKA-1933: Attachment: (was: KAFKA-1933_2015-02-09_12:15:06.patch) > Fine-grained locking in log append > -

[jira] [Updated] (KAFKA-1933) Fine-grained locking in log append

2015-02-09 Thread Maxim Ivanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Ivanov updated KAFKA-1933: Description: This patch adds finer locking when appending to log. It breaks global append lock into

[jira] [Updated] (KAFKA-1933) Fine-grained locking in log append

2015-02-09 Thread Maxim Ivanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Ivanov updated KAFKA-1933: Attachment: KAFKA-1933_2015-02-09_12:15:06.patch > Fine-grained locking in log append >

[jira] [Commented] (KAFKA-1933) Fine-grained locking in log append

2015-02-09 Thread Maxim Ivanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312160#comment-14312160 ] Maxim Ivanov commented on KAFKA-1933: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 30775: Fine-grained locking in log.append

2015-02-09 Thread Maxim Ivanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30775/ --- (Updated Feb. 9, 2015, 12:15 p.m.) Review request for kafka. Bugs: KAFKA-1933

[jira] [Comment Edited] (KAFKA-1933) Fine-grained locking in log append

2015-02-09 Thread Maxim Ivanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14311977#comment-14311977 ] Maxim Ivanov edited comment on KAFKA-1933 at 2/9/15 10:38 AM: --

[jira] [Commented] (KAFKA-1933) Fine-grained locking in log append

2015-02-09 Thread Maxim Ivanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14311977#comment-14311977 ] Maxim Ivanov commented on KAFKA-1933: - Hi, thank for looking into this. Today I real