> On Feb. 9, 2015, 6:29 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, lines 296-303 > > <https://reviews.apache.org/r/30570/diff/1/?file=846132#file846132line296> > > > > I agree with Guozhang that the offset commits need to be disambiguated. > > > > How about we do the following: > > * Aditya, you can go ahead with this change. i.e., record the total > > rate in ReplicaManager > > * File a separate jira to address the discrepancies. E.g., right now > > offset commit failures due to append failures are counted in failed produce > > rate.
Thanks Joel! I've filed this ticket https://issues.apache.org/jira/browse/KAFKA-1936. - Aditya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30570/#review71660 ----------------------------------------------------------- On Feb. 3, 2015, 7:13 p.m., Aditya Auradkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30570/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 7:13 p.m.) > > > Review request for kafka and Joel Koshy. > > > Bugs: KAFKA-1914 > https://issues.apache.org/jira/browse/KAFKA-1914 > > > Repository: kafka > > > Description > ------- > > Fixing KAFKA-1914. Adding metrics to count total number of produce and fetch > metrics > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaRequestHandler.scala > e4053fbe8ef78bf8bc39cb3f8ea4c21032613a16 > core/src/main/scala/kafka/server/ReplicaManager.scala > fb948b9ab28c516e81dab14dcbe211dcd99842b6 > core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala > ccf5e2e36260b2484181b81d1b06e81de972674b > > Diff: https://reviews.apache.org/r/30570/diff/ > > > Testing > ------- > > I've added asserts to the SimpleFetchTest to count the number of fetch > requests. I'm going to file an additional jira to add unit tests for all the > BrokerTopicMetrics updated via ReplicaManager > > > Thanks, > > Aditya Auradkar > >
