[jira] [Created] (KAFKA-1961) Looks like its possible to delete _consumer_offsets topic

2015-02-16 Thread Gwen Shapira (JIRA)
Gwen Shapira created KAFKA-1961: --- Summary: Looks like its possible to delete _consumer_offsets topic Key: KAFKA-1961 URL: https://issues.apache.org/jira/browse/KAFKA-1961 Project: Kafka Issue T

Re: [DISCUSS] KIP-8 Add a flush method to the new Java producer

2015-02-16 Thread Jay Kreps
Yes, I think we all agree it would be good to add a client-side request timeout. That would effectively imply a flush timeout as well since any requests that couldn't complete in that time would be errors and hence completed in the definition we gave. -Jay On Mon, Feb 16, 2015 at 7:57 PM, Bhavesh

Re: [DISCUSS] KIP-8 Add a flush method to the new Java producer

2015-02-16 Thread Bhavesh Mistry
Hi All, Thanks Jay and all address concern. I am fine with just having flush() method as long as it covers failure mode and resiliency. e.g We had situation where entire Kafka cluster brokers were reachable, but upon adding new kafka node and admin migrated "leader to new brokers" that new bro

Re: Review Request 31021: Patch for KAFKA-1951

2015-02-16 Thread Jiangjie Qin
> On Feb. 14, 2015, 9:04 p.m., Gwen Shapira wrote: > > core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala, lines 83-85 > > > > > > Adding comma-separated columns at the end of the row, instead of > > parenthes

[jira] [Commented] (KAFKA-1951) Consumer offset checker should handle corner cases for dual commit or no offsets.

2015-02-16 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323488#comment-14323488 ] Jiangjie Qin commented on KAFKA-1951: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 31021: Patch for KAFKA-1951

2015-02-16 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31021/ --- (Updated Feb. 17, 2015, 12:36 a.m.) Review request for kafka. Bugs: KAFKA-195

[jira] [Updated] (KAFKA-1951) Consumer offset checker should handle corner cases for dual commit or no offsets.

2015-02-16 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1951: Attachment: KAFKA-1951_2015-02-16_16:36:46.patch > Consumer offset checker should handle corner case

[jira] [Commented] (KAFKA-1615) Generating group ID in ZookeeperConsumerConnector shouldn't require local hostname to resolve

2015-02-16 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323353#comment-14323353 ] Gwen Shapira commented on KAFKA-1615: - Hi [~jrafalski], Thanks for jumping in on this

[jira] [Commented] (KAFKA-1960) .gitignore does not exclude test generated files and folders.

2015-02-16 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323347#comment-14323347 ] Tong Li commented on KAFKA-1960: Created reviewboard https://reviews.apache.org/r/31097/di

[jira] [Updated] (KAFKA-1960) .gitignore does not exclude test generated files and folders.

2015-02-16 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1960: --- Attachment: KAFKA-1960.patch > .gitignore does not exclude test generated files and folders. > ---

Review Request 31097: Patch for KAFKA-1960

2015-02-16 Thread Tong Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31097/ --- Review request for kafka. Bugs: KAFKA-1960 https://issues.apache.org/jira/b

Re: Review Request 31088: Patch for KAFKA-1959

2015-02-16 Thread Gwen Shapira
> On Feb. 16, 2015, 6:22 p.m., Gwen Shapira wrote: > > The rename does make things a bit clearer, so I don't object to committing > > it. > > But the test does not override "group" in superclas Thread. Thread.group is > > a private variable, so it cannot be overriden (and the classes that inhe

[jira] [Updated] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic

2015-02-16 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1852: -- Attachment: KAFKA-1852_2015-02-16_13:21:46.patch > OffsetCommitRequest can commi

[jira] [Commented] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic

2015-02-16 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323316#comment-14323316 ] Sriharsha Chintalapani commented on KAFKA-1852: --- Updated reviewboard https:/

Re: Review Request 29912: Patch for KAFKA-1852

2015-02-16 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29912/ --- (Updated Feb. 16, 2015, 9:22 p.m.) Review request for kafka. Bugs: KAFKA-1852

[jira] [Created] (KAFKA-1960) .gitignore does not exclude test generated files and folders.

2015-02-16 Thread Tong Li (JIRA)
Tong Li created KAFKA-1960: -- Summary: .gitignore does not exclude test generated files and folders. Key: KAFKA-1960 URL: https://issues.apache.org/jira/browse/KAFKA-1960 Project: Kafka Issue Type:

Re: Review Request 31088: Patch for KAFKA-1959

2015-02-16 Thread Tong Li
> On Feb. 16, 2015, 6:22 p.m., Gwen Shapira wrote: > > The rename does make things a bit clearer, so I don't object to committing > > it. > > But the test does not override "group" in superclas Thread. Thread.group is > > a private variable, so it cannot be overriden (and the classes that inhe

[jira] [Commented] (KAFKA-1387) Kafka getting stuck creating ephemeral node it has already created when two zookeeper sessions are established in a very short period of time

2015-02-16 Thread Tommy Becker (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323229#comment-14323229 ] Tommy Becker commented on KAFKA-1387: - Can a project member comment on what it is goin

Re: Review Request 31088: Patch for KAFKA-1959

2015-02-16 Thread Tong Li
> On Feb. 16, 2015, 6:22 p.m., Gwen Shapira wrote: > > The rename does make things a bit clearer, so I don't object to committing > > it. > > But the test does not override "group" in superclas Thread. Thread.group is > > a private variable, so it cannot be overriden (and the classes that inhe

[jira] [Commented] (KAFKA-1615) Generating group ID in ZookeeperConsumerConnector shouldn't require local hostname to resolve

2015-02-16 Thread Jonathan Rafalski (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323165#comment-14323165 ] Jonathan Rafalski commented on KAFKA-1615: -- [~gwenshap], I would like to start w

Re: Review Request 31088: Patch for KAFKA-1959

2015-02-16 Thread Gwen Shapira
> On Feb. 16, 2015, 6:22 p.m., Gwen Shapira wrote: > > The rename does make things a bit clearer, so I don't object to committing > > it. > > But the test does not override "group" in superclas Thread. Thread.group is > > a private variable, so it cannot be overriden (and the classes that inhe

Re: Review Request 31088: Patch for KAFKA-1959

2015-02-16 Thread Tong Li
> On Feb. 16, 2015, 6:22 p.m., Gwen Shapira wrote: > > The rename does make things a bit clearer, so I don't object to committing > > it. > > But the test does not override "group" in superclas Thread. Thread.group is > > a private variable, so it cannot be overriden (and the classes that inhe

[jira] [Updated] (KAFKA-1959) Class CommitThread overwrite group of Thread class causing compile errors

2015-02-16 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1959: --- Attachment: compileError.png > Class CommitThread overwrite group of Thread class causing compile errors > ---

Re: Review Request 31088: Patch for KAFKA-1959

2015-02-16 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31088/#review72637 --- The rename does make things a bit clearer, so I don't object to comm

[jira] [Updated] (KAFKA-1956) New consumer client can return early from a poll() call

2015-02-16 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1956: - Summary: New consumer client can return early from a poll() call (was: new consumer client can't fetch re

[jira] [Commented] (KAFKA-1956) new consumer client can't fetch records from kafka server

2015-02-16 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323107#comment-14323107 ] Jay Kreps commented on KAFKA-1956: -- Gotcha. Yes, that is just a mismatch of assumptions I

Re: [DISCUSS] KIP-5 - Broker Configuration Management

2015-02-16 Thread Andrii Biletskyi
Hi all, I've added some details to Proposed Changes paragraph. https://cwiki.apache.org/confluence/display/KAFKA/KIP-5+-+Broker+Configuration+Management Please let me know if something else require description / details. Thanks, Andrii On Sat, Jan 24, 2015 at 1:39 AM, Jay Kreps wrote: > Cool.

[jira] [Commented] (KAFKA-1959) Class CommitThread overwrite group of Thread class causing compile errors

2015-02-16 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322966#comment-14322966 ] Tong Li commented on KAFKA-1959: Created reviewboard https://reviews.apache.org/r/31088/di

[jira] [Updated] (KAFKA-1959) Class CommitThread overwrite group of Thread class causing compile errors

2015-02-16 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1959: --- Attachment: KAFKA-1959.patch > Class CommitThread overwrite group of Thread class causing compile errors > ---

Review Request 31088: Patch for KAFKA-1959

2015-02-16 Thread Tong Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31088/ --- Review request for kafka. Bugs: KAFKA-1959 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1959) Class CommitThread overwrite group of Thread class causing compile errors

2015-02-16 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322933#comment-14322933 ] Tong Li commented on KAFKA-1959: Though I saw the error by using scala 2.10.4, I think i

[jira] [Created] (KAFKA-1959) Class CommitThread overwrite group of Thread class causing compile errors

2015-02-16 Thread Tong Li (JIRA)
Tong Li created KAFKA-1959: -- Summary: Class CommitThread overwrite group of Thread class causing compile errors Key: KAFKA-1959 URL: https://issues.apache.org/jira/browse/KAFKA-1959 Project: Kafka

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations

2015-02-16 Thread Andrii Biletskyi
@Guozhang: Thanks for your comments, I've answered some of those. The main thing is having merged request for create-alter-delete-describe - I have some concerns about this approach. @*Jay*: I see that introduced ClusterMetadaRequest is also one of the concerns. We can solve it if we implement re-

Re: Review Request 29301: Patch for KAFKA-1694

2015-02-16 Thread Andrii Biletskyi
> On Feb. 3, 2015, 7:14 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java, lines > > 39-42 > > > > > > How about merge them into one request? The format could be: > >

[jira] [Commented] (KAFKA-1958) ZookeeperConsumerConnector doesn't remove consumer node on shutdown.

2015-02-16 Thread Beletsky Andrey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322765#comment-14322765 ] Beletsky Andrey commented on KAFKA-1958: +Reason of it:+ {code} ZookeeperConsumerC

[jira] [Updated] (KAFKA-1958) ZookeeperConsumerConnector doesn't remove consumer node on shutdown.

2015-02-16 Thread Beletsky Andrey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Beletsky Andrey updated KAFKA-1958: --- Description: We use kafka with ZooKeeper via high level consumer. There is a scheduled job tha

[jira] [Updated] (KAFKA-1958) ZookeeperConsumerConnector doesn't remove consumer node on shutdown.

2015-02-16 Thread Beletsky Andrey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Beletsky Andrey updated KAFKA-1958: --- Description: We use kafka with ZooKeeper via high level consumer. There is a scheduled job tha

[jira] [Updated] (KAFKA-1958) ZookeeperConsumerConnector doesn't remove consumer node on shutdown.

2015-02-16 Thread Beletsky Andrey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Beletsky Andrey updated KAFKA-1958: --- Description: We use kafka with ZooKeeper via high level consumer. There is a scheduled job tha

[jira] [Updated] (KAFKA-1958) ZookeeperConsumerConnector doesn't remove consumer node on shutdown.

2015-02-16 Thread Beletsky Andrey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Beletsky Andrey updated KAFKA-1958: --- Description: We use kafka with ZooKeeper via high level consumer. There is a scheduled job tha

[jira] [Created] (KAFKA-1958) ZookeeperConsumerConnector doesn't remove consumer node on shutdown.

2015-02-16 Thread Beletsky Andrey (JIRA)
Beletsky Andrey created KAFKA-1958: -- Summary: ZookeeperConsumerConnector doesn't remove consumer node on shutdown. Key: KAFKA-1958 URL: https://issues.apache.org/jira/browse/KAFKA-1958 Project: Kafka

[jira] [Commented] (KAFKA-1956) new consumer client can't fetch records from kafka server

2015-02-16 Thread Hongliang Su (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322592#comment-14322592 ] Hongliang Su commented on KAFKA-1956: - [~jkreps] I understood what you mean. User s

[jira] [Commented] (KAFKA-1811) ensuring registered broker host:port is unique

2015-02-16 Thread Chao Chu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322496#comment-14322496 ] Chao Chu commented on KAFKA-1811: - Is it ok to introduce some other library like [apache c