[jira] [Assigned] (KAFKA-1679) JmxTool outputs nothing if any mbean attributes can't be retrieved

2015-02-23 Thread Jonathan Rafalski (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Rafalski reassigned KAFKA-1679: Assignee: Jonathan Rafalski > JmxTool outputs nothing if any mbean attributes can't

[jira] [Assigned] (KAFKA-1972) JMX Tool output for CSV format does not handle attributes with comma in their value

2015-02-23 Thread Jonathan Rafalski (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Rafalski reassigned KAFKA-1972: Assignee: Jonathan Rafalski > JMX Tool output for CSV format does not handle attrib

[jira] [Commented] (KAFKA-1680) JmxTool exits if no arguments are given

2015-02-23 Thread Jonathan Rafalski (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333188#comment-14333188 ] Jonathan Rafalski commented on KAFKA-1680: -- I understand what you are saying here

Re: How to get a JIRA assigned

2015-02-23 Thread Joe Stein
Jay, I thought it was the same issue like with confluence and comments and why we have to grant rights for that. Bots coming and reassigning everything to them or something in JIRA. We could ask/open a ticket with INFRA, if nothing else maybe help come up with a different way to solve it. ~ Joes

[jira] [Commented] (KAFKA-1379) Partition reassignment resets clock for time-based retention

2015-02-23 Thread Moritz Siuts (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1438#comment-1438 ] Moritz Siuts commented on KAFKA-1379: - This also happens when a broker dies and loses

[jira] [Commented] (KAFKA-1755) Improve error handling in log cleaner

2015-02-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1460#comment-1460 ] Joel Koshy commented on KAFKA-1755: --- Created reviewboard https://reviews.apache.org/r/31

[jira] [Updated] (KAFKA-1755) Improve error handling in log cleaner

2015-02-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1755: -- Status: Patch Available (was: Open) > Improve error handling in log cleaner > -

[jira] [Updated] (KAFKA-1755) Improve error handling in log cleaner

2015-02-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1755: -- Attachment: KAFKA-1755.patch > Improve error handling in log cleaner > -

Review Request 31306: Patch for KAFKA-1755

2015-02-23 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/ --- Review request for kafka. Bugs: KAFKA-1755 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1755) Improve error handling in log cleaner

2015-02-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1487#comment-1487 ] Joel Koshy commented on KAFKA-1755: --- I thought a bit more about this and here is a patch

[jira] [Commented] (KAFKA-1755) Improve error handling in log cleaner

2015-02-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1489#comment-1489 ] Joel Koshy commented on KAFKA-1755: --- Also, I have an incremental patch that prevents the

[jira] [Commented] (KAFKA-1964) testPartitionReassignmentCallback hangs occasionally

2015-02-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333437#comment-14333437 ] Guozhang Wang commented on KAFKA-1964: -- I think this is related to KAFKA-1948, and my

[jira] [Created] (KAFKA-1977) Make logEndOffset available in the Zookeeper consumer

2015-02-23 Thread Will Funnell (JIRA)
Will Funnell created KAFKA-1977: --- Summary: Make logEndOffset available in the Zookeeper consumer Key: KAFKA-1977 URL: https://issues.apache.org/jira/browse/KAFKA-1977 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-1977) Make logEndOffset available in the Zookeeper consumer

2015-02-23 Thread Will Funnell (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Will Funnell updated KAFKA-1977: Attachment: Make_logEndOffset_available_in_the_Zookeeper_consumer.patch > Make logEndOffset availabl

[jira] [Updated] (KAFKA-1977) Make logEndOffset available in the Zookeeper consumer

2015-02-23 Thread Will Funnell (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Will Funnell updated KAFKA-1977: Status: Patch Available (was: Open) > Make logEndOffset available in the Zookeeper consumer > -

[jira] [Updated] (KAFKA-527) Compression support does numerous byte copies

2015-02-23 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-527: Component/s: compression > Compression support does numerous byte copies > --

[jira] [Commented] (KAFKA-1865) Add a flush() call to the new producer API

2015-02-23 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333471#comment-14333471 ] Neha Narkhede commented on KAFKA-1865: -- +1 :-) > Add a flush() call to the new produ

[jira] [Commented] (KAFKA-1907) ZkClient can block controlled shutdown indefinitely

2015-02-23 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333474#comment-14333474 ] Neha Narkhede commented on KAFKA-1907: -- Thanks for the update! No rush. > ZkClient c

[jira] [Commented] (KAFKA-1971) starting a broker with a conflicting id will delete the previous broker registration

2015-02-23 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333482#comment-14333482 ] Neha Narkhede commented on KAFKA-1971: -- Excellent, thanks for looking into this! > s

Re: Review Request 31306: Patch for KAFKA-1755

2015-02-23 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review73584 --- It also makes a lot of sense to disallow setting a compacted topic t

[jira] [Commented] (KAFKA-1964) testPartitionReassignmentCallback hangs occasionally

2015-02-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333520#comment-14333520 ] Guozhang Wang commented on KAFKA-1964: -- Another reason for this issue is that the Ill

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-23 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333528#comment-14333528 ] Ashish Kumar Singh commented on KAFKA-1856: --- [~charmalloc] were you able to get

[jira] [Commented] (KAFKA-1796) Sanity check partition command line tools

2015-02-23 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333536#comment-14333536 ] Mayuresh Gharat commented on KAFKA-1796: [~nehanarkhede] Sure. Actually I went thr

Re: Review Request 30196: Patch for KAFKA-1886

2015-02-23 Thread Aditya Auradkar
> On Feb. 7, 2015, 4:22 p.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala, line 295 > > > > > > Why do you need the sleep here? We try to avoid blindly sleeping in > > Ka

Re: Review Request 31260: Patch for kafka-1971

2015-02-23 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31260/#review73592 --- Ship it! +1 if the comment below is fixed. core/src/test/scala/un

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-23 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333560#comment-14333560 ] Joe Stein commented on KAFKA-1856: -- [~singhashish] I didn't want to make these changes wh

[jira] [Created] (KAFKA-1978) Replication test_0131 system test has been failing.

2015-02-23 Thread Abhishek Nigam (JIRA)
Abhishek Nigam created KAFKA-1978: - Summary: Replication test_0131 system test has been failing. Key: KAFKA-1978 URL: https://issues.apache.org/jira/browse/KAFKA-1978 Project: Kafka Issue Typ

[jira] [Created] (KAFKA-1979) LogCleaner delete file asynchronously and can cause inconsistency between log cleaner checkpoint and first dirty log segment file.

2015-02-23 Thread Jiangjie Qin (JIRA)
Jiangjie Qin created KAFKA-1979: --- Summary: LogCleaner delete file asynchronously and can cause inconsistency between log cleaner checkpoint and first dirty log segment file. Key: KAFKA-1979 URL: https://issues.apach

Apache Samza Meetup Announced (March 4 @6PM hosted at LinkedIn¹s campus in Mountain View CA)

2015-02-23 Thread Ed Yakabosky
Hi all - I would like to announce the first Bay Area Apache Samza Meetup hosted at LinkedIn in Mountain View, CA on March 4, 2015 @6PM. We plan to host the event every 2-months to encourage knowledge sharing & collaboration in Samz

Re: Review Request 31306: Patch for KAFKA-1755

2015-02-23 Thread Joel Koshy
> On Feb. 23, 2015, 5:08 p.m., Neha Narkhede wrote: > > It also makes a lot of sense to disallow setting a compacted topic to > > uncompacted and vice versa without deleting the topic. Was there a reason > > to not include that change here or are you planning on including it in your > > follow

Re: Review Request 31306: Patch for KAFKA-1755

2015-02-23 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review73618 --- core/src/main/scala/kafka/message/ByteBufferMessageSet.scala

[jira] [Created] (KAFKA-1980) Console consumer throws OutOfMemoryError with large max-messages

2015-02-23 Thread JIRA
Håkon Hitland created KAFKA-1980: Summary: Console consumer throws OutOfMemoryError with large max-messages Key: KAFKA-1980 URL: https://issues.apache.org/jira/browse/KAFKA-1980 Project: Kafka

Re: Review Request 31306: Patch for KAFKA-1755

2015-02-23 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review73629 --- core/src/main/scala/kafka/message/ByteBufferMessageSet.scala

Re: Review Request 31306: Patch for KAFKA-1755

2015-02-23 Thread Joel Koshy
> On Feb. 23, 2015, 6:36 p.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala, line 221 > > > > > > We may also need to check this right: > > sourceCodec != NoCompressionCod

[jira] [Commented] (KAFKA-1979) LogCleaner delete file asynchronously and can cause inconsistency between log cleaner checkpoint and first dirty log segment file.

2015-02-23 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333703#comment-14333703 ] Jay Kreps commented on KAFKA-1979: -- Can you expand on this a bit. The delete protocol is

[jira] [Created] (KAFKA-1981) Make log compaction point configurable

2015-02-23 Thread Jay Kreps (JIRA)
Jay Kreps created KAFKA-1981: Summary: Make log compaction point configurable Key: KAFKA-1981 URL: https://issues.apache.org/jira/browse/KAFKA-1981 Project: Kafka Issue Type: Improvement Affe

[jira] [Updated] (KAFKA-1981) Make log compaction point configurable

2015-02-23 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1981: - Labels: newbie++ (was: ) > Make log compaction point configurable > -

[jira] [Commented] (KAFKA-1974) NPE in SelectorTest on trunk

2015-02-23 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333735#comment-14333735 ] Aditya Auradkar commented on KAFKA-1974: [~nehanarkhede] I agree that a null check

[jira] [Updated] (KAFKA-1971) starting a broker with a conflicting id will delete the previous broker registration

2015-02-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1971: --- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the review. Double committed to

Anyone interested in speaking at Bay Area Kafka meetup @ LinkedIn on March 24?

2015-02-23 Thread Ed Yakabosky
Hi Kafka Open Source - LinkedIn will host another Bay Area Kafka meetup in Mountain View on March 24. We are planning to present on Offset Management but are looking for additional speakers. If you’re interested in presenting a use case, operational plan, or your experience with a particular

Re: Review Request 30763: Second attempt at flush()

2015-02-23 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/#review73665 --- Hi Jay, I applied the patch and tried to run it in our test environm

Re: Review Request 30763: Second attempt at flush()

2015-02-23 Thread Jiangjie Qin
> On Feb. 23, 2015, 8:53 p.m., Jiangjie Qin wrote: > > Hi Jay, I applied the patch and tried to run it in our test environment. I > > got this exception: > > > > java.util.ConcurrentModificationException > > at java.util.HashMap$HashIterator.nextNode(HashMap.java:1429) > > at ja

[jira] [Commented] (KAFKA-1979) LogCleaner delete file asynchronously and can cause inconsistency between log cleaner checkpoint and first dirty log segment file.

2015-02-23 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333995#comment-14333995 ] Jiangjie Qin commented on KAFKA-1979: - Hey Jay. I checked it again. You are right, I m

Re: Review Request 31306: Patch for KAFKA-1755

2015-02-23 Thread Joel Koshy
> On Feb. 23, 2015, 7:05 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala, line 209 > > > > > > In doing !compactedTopic here I'm forcing iteration over the messages > > below.

[jira] [Resolved] (KAFKA-1980) Console consumer throws OutOfMemoryError with large max-messages

2015-02-23 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1980. -- Resolution: Won't Fix Best to discuss this on the mailing list first. (http://kafka.apache.org/

Re: Review Request 31306: Patch for KAFKA-1755

2015-02-23 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/ --- (Updated Feb. 23, 2015, 10:29 p.m.) Review request for kafka. Bugs: KAFKA-175

[jira] [Commented] (KAFKA-1755) Improve error handling in log cleaner

2015-02-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334000#comment-14334000 ] Joel Koshy commented on KAFKA-1755: --- Updated reviewboard https://reviews.apache.org/r/31

[jira] [Resolved] (KAFKA-1979) LogCleaner delete file asynchronously and can cause inconsistency between log cleaner checkpoint and first dirty log segment file.

2015-02-23 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin resolved KAFKA-1979. - Resolution: Invalid > LogCleaner delete file asynchronously and can cause inconsistency between lo

[jira] [Updated] (KAFKA-1755) Improve error handling in log cleaner

2015-02-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1755: -- Attachment: KAFKA-1755_2015-02-23_14:29:54.patch > Improve error handling in log cleaner > -

Re: Review Request 31306: Patch for KAFKA-1755

2015-02-23 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review73692 --- core/src/main/scala/kafka/message/ByteBufferMessageSet.scala

Re: Review Request 28027: Patch for KAFKA-1724

2015-02-23 Thread Jun Rao
> On Nov. 14, 2014, 2:39 a.m., Jun Rao wrote: > > Thanks for the patch. I am not sure if that's the right place to fix it > > though. The issue is that when KafkaController.onControllerResignation() is > > called, the controller wasn't actually active. A better fix is probably to > > guard thi

Re: [kafka-clients] Re: [VOTE] 0.8.2.1 Candidate 1

2015-02-23 Thread Jun Rao
Hi, Joe, Left a comment on KAFKA-1724. Not sure if it's a true blocker. However, we can probably include it if it can be fixed in the next couple of days. Thanks, Jun On Sun, Feb 22, 2015 at 2:12 PM, Joe Stein wrote: > Jun, > > Can we also add https://issues.apache.org/jira/browse/KAFKA-1724

Build failed in Jenkins: KafkaPreCommit #17

2015-02-23 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1971; starting a broker with a conflicting id will delete the previous broker registration; patched by Jun Rao; reviewed by Neha Narkhede -- [...truncated 1024 lines...]

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-23 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334046#comment-14334046 ] Ashish Kumar Singh commented on KAFKA-1856: --- Sounds good [~charmalloc]! > Add P

[jira] [Commented] (KAFKA-1460) NoReplicaOnlineException: No replica for partition

2015-02-23 Thread Stevo Slavic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334066#comment-14334066 ] Stevo Slavic commented on KAFKA-1460: - Just encountered this issue in an integration t

[jira] [Created] (KAFKA-1982) change kafka.examples.Producer to use the new java producer

2015-02-23 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1982: -- Summary: change kafka.examples.Producer to use the new java producer Key: KAFKA-1982 URL: https://issues.apache.org/jira/browse/KAFKA-1982 Project: Kafka Issue Type: Im

[jira] [Commented] (KAFKA-1724) Errors after reboot in single node setup

2015-02-23 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334088#comment-14334088 ] Sriharsha Chintalapani commented on KAFKA-1724: --- [~junrao] Thanks for the co

[jira] [Updated] (KAFKA-1978) Replication test_0131 system test has been failing.

2015-02-23 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Nigam updated KAFKA-1978: -- Reviewer: Guozhang Wang Status: Patch Available (was: Open) > Replication test_0131 syste

[jira] [Updated] (KAFKA-1978) Replication test_0131 system test has been failing.

2015-02-23 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Nigam updated KAFKA-1978: -- Status: Open (was: Patch Available) > Replication test_0131 system test has been failing. > ---

[jira] [Created] (KAFKA-1983) TestEndToEndLatency can be unreliable after hard kill

2015-02-23 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1983: -- Summary: TestEndToEndLatency can be unreliable after hard kill Key: KAFKA-1983 URL: https://issues.apache.org/jira/browse/KAFKA-1983 Project: Kafka Issue Type: Improveme

[jira] [Commented] (KAFKA-1983) TestEndToEndLatency can be unreliable after hard kill

2015-02-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334096#comment-14334096 ] Jun Rao commented on KAFKA-1983: An easy solution is probably to avoid committing offset a

[jira] [Commented] (KAFKA-1476) Get a list of consumer groups

2015-02-23 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334110#comment-14334110 ] Ashish Kumar Singh commented on KAFKA-1476: --- [~nehanarkhede] I guess you missed

[jira] [Commented] (KAFKA-1724) Errors after reboot in single node setup

2015-02-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334130#comment-14334130 ] Jun Rao commented on KAFKA-1724: [~sriharsha], so, this is fixed as part of KAFKA-1760? >

Build failed in Jenkins: Kafka-trunk #404

2015-02-23 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1971; starting a broker with a conflicting id will delete the previous broker registration; patched by Jun Rao; reviewed by Neha Narkhede -- [...truncated 273 lines...] ka

[jira] [Commented] (KAFKA-1724) Errors after reboot in single node setup

2015-02-23 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334148#comment-14334148 ] Sriharsha Chintalapani commented on KAFKA-1724: --- [~junrao] Yes. We've isStar

[jira] [Created] (KAFKA-1984) java producer may miss an available partition

2015-02-23 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1984: -- Summary: java producer may miss an available partition Key: KAFKA-1984 URL: https://issues.apache.org/jira/browse/KAFKA-1984 Project: Kafka Issue Type: Bug Affects V

[jira] [Assigned] (KAFKA-1982) change kafka.examples.Producer to use the new java producer

2015-02-23 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Singh reassigned KAFKA-1982: - Assignee: Ashish Kumar Singh > change kafka.examples.Producer to use the new java

[jira] [Commented] (KAFKA-1379) Partition reassignment resets clock for time-based retention

2015-02-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334253#comment-14334253 ] Joel Koshy commented on KAFKA-1379: --- We have been thinking through various alternatives

Re: Review Request 28096: Patch for KAFKA-313

2015-02-23 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28096/ --- (Updated Feb. 24, 2015, 2:11 a.m.) Review request for kafka, Gwen Shapira, Jare

[jira] [Updated] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerOffsetChecker

2015-02-23 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Singh updated KAFKA-313: - Attachment: KAFKA-313_2015-02-23_18:11:32.patch > Add JSON/CSV output and looping options t

[jira] [Commented] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerOffsetChecker

2015-02-23 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334260#comment-14334260 ] Ashish Kumar Singh commented on KAFKA-313: -- Updated reviewboard https://reviews.ap

[jira] [Updated] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-02-23 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Singh updated KAFKA-313: - Summary: Add JSON/CSV output and looping options to ConsumerGroupCommand (was: Add JSON/CS

[jira] [Updated] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-02-23 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Singh updated KAFKA-313: - Description: Adds: * '--loop N' - causes the program to loop forever, sleeping for up to N

[jira] [Commented] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-02-23 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334264#comment-14334264 ] Ashish Kumar Singh commented on KAFKA-313: -- [~gwenshap], [~nehanarkhede] I have up

Re: Review Request 31226: KAFKA-1615 Generating group ID in ZookeeperConsumerConnector shouldn't require local hostname to resolve

2015-02-23 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31226/#review73733 --- Thank you! Give me few days to reproduce the issue and verify that

[jira] [Commented] (KAFKA-1664) Kafka does not properly parse multiple ZK nodes with non-root chroot

2015-02-23 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334266#comment-14334266 ] Ashish Kumar Singh commented on KAFKA-1664: --- [~nehanarkhede] could you review th

Re: Review Request 30763: Second attempt at flush()

2015-02-23 Thread Jay Kreps
> On Feb. 23, 2015, 6:44 a.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 376 > > > > > > Add @throws KafkaException I added the other exceptions I k

Re: Review Request 30763: Second attempt at flush()

2015-02-23 Thread Jay Kreps
> On Feb. 23, 2015, 5 a.m., Jiangjie Qin wrote: > > clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java, > > line 210 > > > > > > It probably does not matter, but here we are only sendin

Re: Review Request 30763: Second attempt at flush()

2015-02-23 Thread Jay Kreps
> On Feb. 23, 2015, 8:53 p.m., Jiangjie Qin wrote: > > Hi Jay, I applied the patch and tried to run it in our test environment. I > > got this exception: > > > > java.util.ConcurrentModificationException > > at java.util.HashMap$HashIterator.nextNode(HashMap.java:1429) > > at ja

Re: Review Request 30763: KAFKA-1865: Producer Flush: if at first your patch doesn't succeed, try, try, try again.

2015-02-23 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/ --- (Updated Feb. 24, 2015, 2:29 a.m.) Review request for kafka. Summary (updated

[jira] [Commented] (KAFKA-1865) Add a flush() call to the new producer API

2015-02-23 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334281#comment-14334281 ] Jay Kreps commented on KAFKA-1865: -- Updated reviewboard https://reviews.apache.org/r/3076

[jira] [Updated] (KAFKA-1865) Add a flush() call to the new producer API

2015-02-23 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1865: - Attachment: KAFKA-1865_2015-02-23_18:29:16.patch > Add a flush() call to the new producer API > --

Re: Review Request 30763: KAFKA-1865: Producer Flush: if at first your patch doesn't succeed, try, try, try again.

2015-02-23 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/ --- (Updated Feb. 24, 2015, 2:31 a.m.) Review request for kafka. Bugs: KAFKA-1865

Re: Review Request 30763: KAFKA-1865: Producer Flush: if at first your patch doesn't succeed, try, try, try again.

2015-02-23 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/#review73749 --- Ship it! LGTM. Thanks, Jay. I actually tried just putting a synchro

Re: Review Request 30763: KAFKA-1865: Producer Flush: if at first your patch doesn't succeed, try, try, try again.

2015-02-23 Thread Jay Kreps
> On Feb. 24, 2015, 4:22 a.m., Jiangjie Qin wrote: > > LGTM. Thanks, Jay. > > I actually tried just putting a synchronized block around the line where we > > copy the imcomplete set and it seems worked. Maybe we can do that if you > > prefer less code. I think that depends on the lock the add/

[jira] [Commented] (KAFKA-1757) Can not delete Topic index on Windows

2015-02-23 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334389#comment-14334389 ] Sriharsha Chintalapani commented on KAFKA-1757: --- patch merged by [~jkreps] c

[jira] [Updated] (KAFKA-1757) Can not delete Topic index on Windows

2015-02-23 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1757: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Can not del

Re: Review Request 30763: KAFKA-1865: Producer Flush: if at first your patch doesn't succeed, try, try, try again.

2015-02-23 Thread Jiangjie Qin
> On Feb. 24, 2015, 4:22 a.m., Jiangjie Qin wrote: > > LGTM. Thanks, Jay. > > I actually tried just putting a synchronized block around the line where we > > copy the imcomplete set and it seems worked. Maybe we can do that if you > > prefer less code. > > Jay Kreps wrote: > I think that d

Re: Review Request 30763: KAFKA-1865: Producer Flush: if at first your patch doesn't succeed, try, try, try again.

2015-02-23 Thread Jay Kreps
I handle this by synchronizing flush()--only one thread can be flushing at a time. This isn't too much of a drawback since the first flush will drain everything anyway the second flush likely won't do too much, so sequencing them shouldn't hurt too much. However your idea of using a counter may ac