[
https://issues.apache.org/jira/browse/KAFKA-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14341226#comment-14341226
]
Neha Narkhede commented on KAFKA-1987:
--
+1
Potential race condition in partition
[
https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14341201#comment-14341201
]
Guozhang Wang commented on KAFKA-1910:
--
Jay,
I found my fix to KAFKA-1948 was not
[
https://issues.apache.org/jira/browse/KAFKA-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14341342#comment-14341342
]
Jiangjie Qin commented on KAFKA-1987:
-
I agree with Joel that we probably can leave it
Hi Jay,
I just modified the KIP. The only concern I have about this change is that
it will break existing deployments. And we need to change the command line
arguments format for other tools as well. It is defiitely better that we
conform to the unix standard. It is just I am not sure if the
[
https://issues.apache.org/jira/browse/KAFKA-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340162#comment-14340162
]
Sriharsha Chintalapani commented on KAFKA-1866:
---
[~nehanarkhede] I updated
[
https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340163#comment-14340163
]
Sriharsha Chintalapani commented on KAFKA-1852:
---
[~jjkoshy] Updated the
[
https://issues.apache.org/jira/browse/KAFKA-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340257#comment-14340257
]
Rick Kellogg commented on KAFKA-1877:
-
Please be aware that exposure of version
[
https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-1982:
--
Attachment: KAFKA-1982_2015-02-27_11:08:34.patch
change kafka.examples.Producer to use the new
[
https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340701#comment-14340701
]
Jun Rao commented on KAFKA-1400:
Yes, that's probably the goal of this test. The checking
[
https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1400:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for the review. Committed to trunk.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31369/
---
(Updated Feb. 27, 2015, 7:08 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29912/#review74569
---
Ship it!
Minor locking issue noted below. I can take care of that.
[
https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340633#comment-14340633
]
Ashish K Singh commented on KAFKA-1982:
---
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340663#comment-14340663
]
Jun Rao commented on KAFKA-1988:
Hi, Tong,
My suggestion is slightly different. My point
Yeah it will break the existing usage but personally I think it is worth it
to be standard across all our tools.
-Jay
On Fri, Feb 27, 2015 at 9:53 AM, Jiangjie Qin j...@linkedin.com.invalid
wrote:
Hi Jay,
I just modified the KIP. The only concern I have about this change is that
it will
[
https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340785#comment-14340785
]
Gwen Shapira commented on KAFKA-1400:
-
Awesome. I'm just happy to see this fixed :)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31369/#review74553
---
Thanks for the patch, Ashish. Its shaping up to be a very useful
On Feb. 26, 2015, 10:27 p.m., Jun Rao wrote:
examples/src/main/java/kafka/examples/Consumer.java, line 62
https://reviews.apache.org/r/31369/diff/4/?file=875219#file875219line62
It would be useful to print out the key as well.
Added
On Feb. 26, 2015, 10:27 p.m., Jun Rao wrote:
[
https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340709#comment-14340709
]
Andrew Pennebaker commented on KAFKA-330:
-
Could the default config please set
[
https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340767#comment-14340767
]
Jay Kreps commented on KAFKA-330:
-
+1 on enabling by default.
Add delete topic support
The biggest gap in tool standardization and MirrorMaker is the fact
that MirrorMaker takes 2 configuration files as inputs with required
parameters that can't be set on command line.
If we are breaking back-compatibility, perhaps we can standardize this part too?
On Fri, Feb 27, 2015 at 12:36
Would anyone object if I commented out the kafka.api.ConsumerTest out until
it is fixed? It hangs and is making accepting patches very time-consuming.
--
Thanks,
Neha
Wow. That was quick :-)
Any committers who would also like to give a +1?
On Fri, Feb 27, 2015 at 1:44 PM, Ashish Singh asi...@cloudera.com wrote:
+1
On Fri, Feb 27, 2015 at 1:42 PM, Gwen Shapira gshap...@cloudera.com
wrote:
Actually, we will greatly appreciate :)
On Fri, Feb 27, 2015
Make sense to me.
On Fri, Feb 27, 2015 at 12:59 PM, Jiangjie Qin
j...@linkedin.com.invalid wrote:
I think it probably needs another KIP to discuss the command line tool
standardization because it is essentially a cross boad user interface
change.
For this specific KIP, I believe the scope is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29647/#review74592
---
Sorry for the late review. Have one comment below.
+1
On 2/27/15, 1:41 PM, Harsha ka...@harsha.io wrote:
+1
On Fri, Feb 27, 2015, at 01:37 PM, Neha Narkhede wrote:
Would anyone object if I commented out the kafka.api.ConsumerTest out
until
it is fixed? It hangs and is making accepting patches very
time-consuming.
--
Thanks,
Neha
+1
On Fri, Feb 27, 2015 at 1:42 PM, Gwen Shapira gshap...@cloudera.com wrote:
Actually, we will greatly appreciate :)
On Fri, Feb 27, 2015 at 1:37 PM, Neha Narkhede n...@confluent.io wrote:
Would anyone object if I commented out the kafka.api.ConsumerTest out
until
it is fixed? It hangs
+1
On Fri, Feb 27, 2015, at 01:37 PM, Neha Narkhede wrote:
Would anyone object if I commented out the kafka.api.ConsumerTest out
until
it is fixed? It hangs and is making accepting patches very
time-consuming.
--
Thanks,
Neha
Actually, we will greatly appreciate :)
On Fri, Feb 27, 2015 at 1:37 PM, Neha Narkhede n...@confluent.io wrote:
Would anyone object if I commented out the kafka.api.ConsumerTest out until
it is fixed? It hangs and is making accepting patches very time-consuming.
--
Thanks,
Neha
On Feb. 27, 2015, 8:47 p.m., Joel Koshy wrote:
Minor locking issue noted below. I can take care of that.
This obviously does not cover the case of committing offsets to a topic
that is currently being deleted. I think that can be done in a separate
jira. Can you file one?
Joel,
[
https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340883#comment-14340883
]
Gwen Shapira commented on KAFKA-1501:
-
Is there anything pending here? Any reason not
+1
On Fri, Feb 27, 2015 at 01:50:07PM -0800, Neha Narkhede wrote:
Wow. That was quick :-)
Any committers who would also like to give a +1?
On Fri, Feb 27, 2015 at 1:44 PM, Ashish Singh asi...@cloudera.com wrote:
+1
On Fri, Feb 27, 2015 at 1:42 PM, Gwen Shapira gshap...@cloudera.com
On Feb. 21, 2015, 7:03 p.m., Neha Narkhede wrote:
core/src/main/scala/kafka/server/KafkaServer.scala, line 317
https://reviews.apache.org/r/31256/diff/2/?file=871520#file871520line317
Overall, this change makes sense to me. However, now the startup and
shutdown sequence is
[
https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sriharsha Chintalapani updated KAFKA-1852:
--
Attachment: KAFKA-1852_2015-02-27_13:50:34.patch
OffsetCommitRequest can
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29912/
---
(Updated Feb. 27, 2015, 9:50 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340874#comment-14340874
]
Sriharsha Chintalapani commented on KAFKA-1852:
---
Updated reviewboard
Thanks for the quick responses. I deleted it for now, since commenting out
code is silly given that you can revive the file from version control
later.
On Fri, Feb 27, 2015 at 2:03 PM, Joel Koshy jjkosh...@gmail.com wrote:
+1
On Fri, Feb 27, 2015 at 01:50:07PM -0800, Neha Narkhede wrote:
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tong Li updated KAFKA-1988:
---
Attachment: KAFKA-1988.patch
org.apache.kafka.common.utils.Utils.abs method returns wrong value for
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339921#comment-14339921
]
Tong Li commented on KAFKA-1988:
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339924#comment-14339924
]
Tong Li commented on KAFKA-1988:
Jun Rao,
Thanks for taking time reviewing the
Jun Rao,
Thanks for taking time reviewing the patch. Would like to confirm
here is what you suggested to do:
1. Utils.abs will be renamed to Utils.toPositive
2. Make changes in these methods of class DefaultPartitioner and
ByteArrayPartitioner so that toPositive gets
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31533/
---
Review request for kafka.
Bugs: KAFKA-1988
[
https://issues.apache.org/jira/browse/KAFKA-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338303#comment-14338303
]
Po Zhou edited comment on KAFKA-1460 at 2/27/15 11:22 AM:
--
I
See https://builds.apache.org/job/KafkaPreCommit/24/changes
Changes:
[neha.narkhede] KAFKA-1664 Kafka does not properly parse multiple ZK nodes with
non-root chroot; reviewed by Neha Narkhede and Jun Rao
--
[...truncated 1357 lines...]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30084/#review74632
---
core/src/test/scala/unit/kafka/metrics/MetricsTest.scala
Yasuhiro Matsuda created KAFKA-1989:
---
Summary: New purgatory design
Key: KAFKA-1989
URL: https://issues.apache.org/jira/browse/KAFKA-1989
Project: Kafka
Issue Type: Improvement
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30084/#review74635
---
Ship it!
I will include those changes during checkin to reduce
[
https://issues.apache.org/jira/browse/KAFKA-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1866:
-
Fix Version/s: 0.8.3
LogStartOffset gauge throws exceptions after log.delete()
[
https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1989:
-
Priority: Critical (was: Major)
New purgatory design
[
https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1989:
-
Assignee: Yasuhiro Matsuda (was: Joel Koshy)
New purgatory design
[
https://issues.apache.org/jira/browse/KAFKA-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1866:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for the patch. Pushed
[
https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1989:
-
Affects Version/s: 0.8.2.0
New purgatory design
Key:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31568/
---
Review request for kafka.
Bugs: KAFKA-1989
[
https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-1989:
Status: Patch Available (was: Open)
New purgatory design
[
https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-1989:
Attachment: KAFKA-1989.patch
New purgatory design
[
https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14341070#comment-14341070
]
Yasuhiro Matsuda commented on KAFKA-1989:
-
Created reviewboard
See https://builds.apache.org/job/Kafka-trunk/411/changes
Changes:
[neha.narkhede] KAFKA-1664 Kafka does not properly parse multiple ZK nodes with
non-root chroot; reviewed by Neha Narkhede and Jun Rao
--
[...truncated 546 lines...]
On Feb. 27, 2015, 10:53 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/message/CompressionCodec.scala, line 46
https://reviews.apache.org/r/24704/diff/14/?file=801514#file801514line46
Not sure what you mean - can you elaborate?
Jun Rao wrote:
Instead of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24704/#review74612
---
Sorry for the late review. Just a minor comment below.
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340959#comment-14340959
]
Tong Li commented on KAFKA-1988:
Run Rao, I got the point now. Thanks so much for your
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29912/#review74614
---
Ship it!
Ship It!
- Joel Koshy
On Feb. 27, 2015, 9:50 p.m.,
[
https://issues.apache.org/jira/browse/KAFKA-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1664:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for the patch. Pushed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31566/
---
Review request for kafka.
Bugs: KAFKA-1988
See https://builds.apache.org/job/Kafka-trunk/410/changes
Changes:
[neha.narkhede] Deleting the ConsumerTest until the issue with the hanging test
is resolved; discussed on the mailing list and got several +1s
--
[...truncated 1299 lines...]
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14341089#comment-14341089
]
Neha Narkhede commented on KAFKA-1824:
--
[~gwenshap] Still doesn't apply. Not sure if
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1824:
Attachment: KAFKA-1824.v1.patch
I'll blame the patch-tool.
I generated new patch with git diff and
See https://builds.apache.org/job/KafkaPreCommit/25/changes
Changes:
[neha.narkhede] KAFKA-1866 LogStartOffset gauge throws exceptions after
log.delete(); reviewed by Neha Narkhede
--
[...truncated 560 lines...]
kafka.admin.DeleteConsumerGroupTest
See https://builds.apache.org/job/Kafka-trunk/412/changes
Changes:
[neha.narkhede] KAFKA-1866 LogStartOffset gauge throws exceptions after
log.delete(); reviewed by Neha Narkhede
--
[...truncated 534 lines...]
kafka.log.LogManagerTest
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24704/#review74615
---
core/src/main/scala/kafka/message/CompressionCodec.scala
Thanks Neha, I will make sure the ConsumerTest gets fixed when I check in
1910.
On Fri, Feb 27, 2015 at 2:12 PM, Neha Narkhede n...@confluent.io wrote:
Thanks for the quick responses. I deleted it for now, since commenting out
code is silly given that you can revive the file from version
See https://builds.apache.org/job/KafkaPreCommit/23/changes
[
https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340998#comment-14340998
]
Guozhang Wang commented on KAFKA-1501:
--
Gwen, the problem is that, we seems still not
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340993#comment-14340993
]
Guozhang Wang commented on KAFKA-1988:
--
+1. Thanks Tong / Jun for fixing this and
Sounds good. Thanks!
On Fri, Feb 27, 2015 at 3:01 PM, Guozhang Wang wangg...@gmail.com wrote:
Thanks Neha, I will make sure the ConsumerTest gets fixed when I check in
1910.
On Fri, Feb 27, 2015 at 2:12 PM, Neha Narkhede n...@confluent.io wrote:
Thanks for the quick responses. I deleted
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29647/#review74623
---
core/src/main/scala/kafka/cluster/Partition.scala
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tong Li updated KAFKA-1988:
---
Attachment: KAFKA-1988.patch
org.apache.kafka.common.utils.Utils.abs method returns wrong value for
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14341004#comment-14341004
]
Tong Li commented on KAFKA-1988:
Created reviewboard
77 matches
Mail list logo
