[
https://issues.apache.org/jira/browse/KAFKA-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492891#comment-14492891
]
Rajini Sivaram commented on KAFKA-2089:
---
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33125/
---
(Updated April 13, 2015, 7:15 p.m.)
Review request for kafka.
Summary
[
https://issues.apache.org/jira/browse/KAFKA-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram updated KAFKA-2089:
--
Attachment: KAFKA-2089_2015-04-13_18:59:33.patch
MetadataTest transient failure
[
https://issues.apache.org/jira/browse/KAFKA-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492713#comment-14492713
]
Jiangjie Qin commented on KAFKA-2089:
-
Hey [~rsivaram], your are right. We don't have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33125/#review79901
---
Ship it!
LGTM. Just a minor comment.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33088/
---
(Updated April 13, 2015, 6:55 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33140/#review79918
---
Ship it!
Ship It!
- Gwen Shapira
On April 13, 2015, 6:58 p.m.,
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492711#comment-14492711
]
Rajini Sivaram commented on KAFKA-1690:
---
[~sriharsha] Yes, of course. Being newbies,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33135/#review79907
---
Ship it!
Ship It!
- Jiangjie Qin
On April 13, 2015, 3:51 p.m.,
Ewen Cheslack-Postava created KAFKA-2119:
Summary: ConsumerRecord key() and value() methods should not have
throws Exception
Key: KAFKA-2119
URL: https://issues.apache.org/jira/browse/KAFKA-2119
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-1334:
Attachment: KAFKA-1334_2015-04-13_11:55:06.patch
Add failure detection capability to the
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492849#comment-14492849
]
Onur Karaman commented on KAFKA-1334:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492856#comment-14492856
]
Onur Karaman commented on KAFKA-1334:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ewen Cheslack-Postava updated KAFKA-2119:
-
Assignee: Ewen Cheslack-Postava (was: Neha Narkhede)
Status: Patch
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-1334:
Attachment: KAFKA-1334_2015-04-13_11:58:53.patch
Add failure detection capability to the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33140/
---
Review request for kafka.
Bugs: KAFKA-2119
Hi Jun,
Michael from Security Infrastructure at LinkedIn‹ I¹d be interested in
joining. Could you send me the invite?
On 4/10/15, 3:01 PM, Jun Rao j...@confluent.io wrote:
We plan to have a KIP discussion on Google hangout on Apr. 15 at 9:30am
PST. This is moved to a different time on Wed due
Hi,
I just created a KIP to add a request timeout to NetworkClient for new Kafka
clients.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-19+-+Add+a+request+timeout+to+NetworkClient
Comments and suggestions are welcome!
Thanks.
Jiangjie (Becket) Qin
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat reassigned KAFKA-2120:
--
Assignee: Mayuresh Gharat
Add a request timeout to NetworkClient
Jiangjie Qin created KAFKA-2120:
---
Summary: Add a request timeout to NetworkClient
Key: KAFKA-2120
URL: https://issues.apache.org/jira/browse/KAFKA-2120
Project: Kafka
Issue Type: New Feature
[
https://issues.apache.org/jira/browse/KAFKA-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493465#comment-14493465
]
Guozhang Wang commented on KAFKA-2055:
--
[~lvfangmin] Do you want to take on this
See https://builds.apache.org/job/KafkaPreCommit/73/changes
I think KAFKA-2063 (bounding fetch response) is still under discussion, and
may not be got it in time with KAFKA-1927.
On Thu, Apr 9, 2015 at 4:49 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
I think it's reasonable to batch the protocol changes together. In
addition to the
Here is the resource leak problem that we have encountered when 0.8.2 java
KafkaProducer failed in constructor. here is the code snippet of
KafkaProducer to illustrate the problem.
---
public KafkaProducer(ProducerConfig config, SerializerK keySerializer,
SerializerV
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33135/#review79978
---
Ship it!
Ship It!
- Ewen Cheslack-Postava
On April 13, 2015,
[
https://issues.apache.org/jira/browse/KAFKA-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493438#comment-14493438
]
Guozhang Wang commented on KAFKA-2117:
--
Committed to trunk.
OffsetManager uses
[
https://issues.apache.org/jira/browse/KAFKA-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-2117:
-
Resolution: Fixed
Fix Version/s: 0.8.3
Status: Resolved (was: Patch Available)
See https://builds.apache.org/job/Kafka-trunk/461/changes
Changes:
[wangguoz] KAFKA-2117; Use the correct metadata field for reading offset
struct; reviewed by Jun Rao and Jiangjie Qin
--
[...truncated 1514 lines...]
kafka.api.ProducerFailureHandlingTest
It is a valid problem and we should correct it as soon as possible, I'm
with Ewen regarding the solution.
On Mon, Apr 13, 2015 at 5:05 PM, Ewen Cheslack-Postava e...@confluent.io
wrote:
Steven,
Looks like there is even more that could potentially be leaked -- since key
and value serializers
Steven,
Looks like there is even more that could potentially be leaked -- since key
and value serializers are created and configured at the end, even the IO
thread allocated by the producer could leak. Given that, I think 1 isn't a
great option since, as you said, it doesn't really address the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33140/#review79980
---
Ship it!
Ship It!
- Guozhang Wang
On April 13, 2015, 6:58 p.m.,
[
https://issues.apache.org/jira/browse/KAFKA-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493471#comment-14493471
]
Guozhang Wang commented on KAFKA-2056:
--
Hey [~lvfangmin], I agree that the problem
[
https://issues.apache.org/jira/browse/KAFKA-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493495#comment-14493495
]
Fangmin Lv commented on KAFKA-2056:
---
Hi [~guozhang], I agree with you, it's more robust
[
https://issues.apache.org/jira/browse/KAFKA-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493497#comment-14493497
]
Fangmin Lv commented on KAFKA-2055:
---
[~guozhang] Sure, I'd like to take it over.
[
https://issues.apache.org/jira/browse/KAFKA-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv reassigned KAFKA-2055:
-
Assignee: Fangmin Lv
ConsumerBounceTest.testSeekAndCommitWithBrokerFailures transient failure
[
https://issues.apache.org/jira/browse/KAFKA-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492855#comment-14492855
]
Ewen Cheslack-Postava commented on KAFKA-2119:
--
Created reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33088/
---
(Updated April 13, 2015, 6:58 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ewen Cheslack-Postava updated KAFKA-2119:
-
Attachment: KAFKA-2119.patch
ConsumerRecord key() and value() methods should not
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33088/
---
(Updated April 13, 2015, 5:11 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33125/
---
Review request for kafka.
Bugs: KAFKA-2089
[
https://issues.apache.org/jira/browse/KAFKA-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492049#comment-14492049
]
Rajini Sivaram commented on KAFKA-2089:
---
Jiangjie Qin,
Thank you for the review. I
[
https://issues.apache.org/jira/browse/KAFKA-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492106#comment-14492106
]
Onur Karaman commented on KAFKA-2115:
-
Trunk's coordinator is pretty much
[
https://issues.apache.org/jira/browse/KAFKA-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492121#comment-14492121
]
Fangmin Lv commented on KAFKA-2056:
---
The last few consumers may not be assigned with
[
https://issues.apache.org/jira/browse/KAFKA-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492014#comment-14492014
]
Rajini Sivaram commented on KAFKA-2089:
---
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram updated KAFKA-2089:
--
Attachment: KAFKA-2089.patch
MetadataTest transient failure
--
[
https://issues.apache.org/jira/browse/KAFKA-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv updated KAFKA-2056:
--
Attachment: KAFKA-2056.patch
PartitionAssignorTest.testRangePartitionAssignor transient failure
Jun,
2. Yes, you are right. The idea is that different exceptions and different
error causes may require different actions. That's why instead of generic
error handling logic it is proposed to implement a separate component -
ExceptionHandler that will encapsulate logic to take the right action
[
https://issues.apache.org/jira/browse/KAFKA-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-2115:
---
Resolution: Fixed
Fix Version/s: 0.8.3
Status: Resolved (was: Patch Available)
Thanks for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33132/
---
Review request for kafka.
Bugs: kafka-2088
[
https://issues.apache.org/jira/browse/KAFKA-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-2056:
---
Assignee: Fangmin Lv
Status: Patch Available (was: Open)
[
https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-2102:
---
Status: In Progress (was: Patch Available)
Remove unnecessary synchronization when managing metadata
[
https://issues.apache.org/jira/browse/KAFKA-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhiqiang He updated KAFKA-2088:
---
Attachment: kafka-2088.1.patch
kafka-console-consumer.sh should not create zookeeper path when no
[
https://issues.apache.org/jira/browse/KAFKA-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhiqiang He updated KAFKA-2088:
---
Status: Patch Available (was: Open)
https://reviews.apache.org/r/33132/diff/
please review it.
See https://builds.apache.org/job/KafkaPreCommit/72/changes
Changes:
[junrao] kafka-2115; Error updating metrics in RequestChannel; patched by Gwen
Shapira; reviewed by Jun Rao
--
[...truncated 1055 lines...]
kafka.log.FileMessageSetTest
Gian Merlino created KAFKA-2118:
---
Summary: Cleaner cannot clean after shutdown during replaceSegments
Key: KAFKA-2118
URL: https://issues.apache.org/jira/browse/KAFKA-2118
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492614#comment-14492614
]
Guozhang Wang commented on KAFKA-2116:
--
Hi Gwen, there is a ticket for adding /
[
https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492628#comment-14492628
]
Guozhang Wang commented on KAFKA-1910:
--
1. Sounds good.
Refactor KafkaConsumer
See https://builds.apache.org/job/Kafka-trunk/460/changes
Changes:
[junrao] kafka-2115; Error updating metrics in RequestChannel; patched by Gwen
Shapira; reviewed by Jun Rao
--
[...truncated 1249 lines...]
kafka.api.ProducerFailureHandlingTest
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33133/
---
Review request for kafka.
Bugs: KAFKA-1690
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram updated KAFKA-1690:
--
Assignee: Rajini Sivaram (was: Sriharsha Chintalapani)
Status: Patch Available (was:
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram updated KAFKA-1690:
--
Attachment: KAFKA-1690.patch
new java producer needs ssl support as a client
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492530#comment-14492530
]
Rajini Sivaram commented on KAFKA-1690:
---
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492569#comment-14492569
]
Guozhang Wang commented on KAFKA-1910:
--
Hey Jay,
1. I agree with you, the function
[
https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492598#comment-14492598
]
Jay Kreps commented on KAFKA-1910:
--
Hey [~guozhang],
1. Cool. Yeah I think create is
My bad on 1), fixing it right now.
On Sun, Apr 12, 2015 at 8:06 PM, Jun Rao j...@confluent.io wrote:
For 1, the issue seems to be that we try to get metadata using the offset
field. Filed KAFKA-2117.
Thanks,
Jun
On Sun, Apr 12, 2015 at 1:12 PM, Jay Kreps jay.kr...@gmail.com wrote:
I
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492538#comment-14492538
]
Rajini Sivaram commented on KAFKA-1690:
---
[~prestona] and I have been looking at TLS
[
https://issues.apache.org/jira/browse/KAFKA-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-2117:
-
Attachment: KAFKA-2117.patch
OffsetManager uses incorrect field for metadata
[
https://issues.apache.org/jira/browse/KAFKA-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492539#comment-14492539
]
Guozhang Wang commented on KAFKA-2117:
--
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-2117:
-
Assignee: Guozhang Wang
Status: Patch Available (was: Open)
OffsetManager uses incorrect
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33135/
---
Review request for kafka.
Bugs: KAFKA-2117
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sriharsha Chintalapani reassigned KAFKA-1690:
-
Assignee: Sriharsha Chintalapani (was: Rajini Sivaram)
new java
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492543#comment-14492543
]
Sriharsha Chintalapani commented on KAFKA-1690:
---
[~rsivaram] There is
Jun,
404. Great, thanks!
500. If I understand correctly KAFKA-1367 says ISR part of TMR may
be inconsistent. If so, then I believe all admin commands but describeTopic
are not affected. Let me emphasize that it's about AdminClient operations,
not about Wire Protocol requests. What I mean:
To
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33135/#review79887
---
Ship it!
Ship It!
- Jun Rao
On April 13, 2015, 3:51 p.m.,
74 matches
Mail list logo