[jira] [Commented] (KAFKA-2089) MetadataTest transient failure

2015-04-13 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492891#comment-14492891 ] Rajini Sivaram commented on KAFKA-2089: --- Updated reviewboard

Re: Review Request 33125: Add comment to timing fix

2015-04-13 Thread Rajini Sivaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33125/ --- (Updated April 13, 2015, 7:15 p.m.) Review request for kafka. Summary

[jira] [Updated] (KAFKA-2089) MetadataTest transient failure

2015-04-13 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram updated KAFKA-2089: -- Attachment: KAFKA-2089_2015-04-13_18:59:33.patch MetadataTest transient failure

[jira] [Commented] (KAFKA-2089) MetadataTest transient failure

2015-04-13 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492713#comment-14492713 ] Jiangjie Qin commented on KAFKA-2089: - Hey [~rsivaram], your are right. We don't have

Re: Review Request 33125: Fix timing issue in MetadataTest

2015-04-13 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33125/#review79901 --- Ship it! LGTM. Just a minor comment.

Re: Review Request 33088: add heartbeat to coordinator

2015-04-13 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33088/ --- (Updated April 13, 2015, 6:55 p.m.) Review request for kafka. Bugs:

Re: Review Request 33140: Patch for KAFKA-2119

2015-04-13 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33140/#review79918 --- Ship it! Ship It! - Gwen Shapira On April 13, 2015, 6:58 p.m.,

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

2015-04-13 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492711#comment-14492711 ] Rajini Sivaram commented on KAFKA-1690: --- [~sriharsha] Yes, of course. Being newbies,

Re: Review Request 33135: Fix KAFKA-2117

2015-04-13 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33135/#review79907 --- Ship it! Ship It! - Jiangjie Qin On April 13, 2015, 3:51 p.m.,

[jira] [Created] (KAFKA-2119) ConsumerRecord key() and value() methods should not have throws Exception

2015-04-13 Thread Ewen Cheslack-Postava (JIRA)
Ewen Cheslack-Postava created KAFKA-2119: Summary: ConsumerRecord key() and value() methods should not have throws Exception Key: KAFKA-2119 URL: https://issues.apache.org/jira/browse/KAFKA-2119

[jira] [Updated] (KAFKA-1334) Add failure detection capability to the coordinator / consumer

2015-04-13 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Onur Karaman updated KAFKA-1334: Attachment: KAFKA-1334_2015-04-13_11:55:06.patch Add failure detection capability to the

[jira] [Commented] (KAFKA-1334) Add failure detection capability to the coordinator / consumer

2015-04-13 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492849#comment-14492849 ] Onur Karaman commented on KAFKA-1334: - Updated reviewboard

[jira] [Commented] (KAFKA-1334) Add failure detection capability to the coordinator / consumer

2015-04-13 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492856#comment-14492856 ] Onur Karaman commented on KAFKA-1334: - Updated reviewboard

[jira] [Updated] (KAFKA-2119) ConsumerRecord key() and value() methods should not have throws Exception

2015-04-13 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2119: - Assignee: Ewen Cheslack-Postava (was: Neha Narkhede) Status: Patch

[jira] [Updated] (KAFKA-1334) Add failure detection capability to the coordinator / consumer

2015-04-13 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Onur Karaman updated KAFKA-1334: Attachment: KAFKA-1334_2015-04-13_11:58:53.patch Add failure detection capability to the

Review Request 33140: Patch for KAFKA-2119

2015-04-13 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33140/ --- Review request for kafka. Bugs: KAFKA-2119

Re: KIP discussion Apr 15 at 9:30 am PST

2015-04-13 Thread Michael Herstine
Hi Jun, Michael from Security Infrastructure at LinkedIn‹ I¹d be interested in joining. Could you send me the invite? On 4/10/15, 3:01 PM, Jun Rao j...@confluent.io wrote: We plan to have a KIP discussion on Google hangout on Apr. 15 at 9:30am PST. This is moved to a different time on Wed due

[DISCUSS] KIP-19 Add a request timeout to NetworkClient

2015-04-13 Thread Jiangjie Qin
Hi, I just created a KIP to add a request timeout to NetworkClient for new Kafka clients. https://cwiki.apache.org/confluence/display/KAFKA/KIP-19+-+Add+a+request+timeout+to+NetworkClient Comments and suggestions are welcome! Thanks. Jiangjie (Becket) Qin

[jira] [Assigned] (KAFKA-2120) Add a request timeout to NetworkClient

2015-04-13 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat reassigned KAFKA-2120: -- Assignee: Mayuresh Gharat Add a request timeout to NetworkClient

[jira] [Created] (KAFKA-2120) Add a request timeout to NetworkClient

2015-04-13 Thread Jiangjie Qin (JIRA)
Jiangjie Qin created KAFKA-2120: --- Summary: Add a request timeout to NetworkClient Key: KAFKA-2120 URL: https://issues.apache.org/jira/browse/KAFKA-2120 Project: Kafka Issue Type: New Feature

[jira] [Commented] (KAFKA-2055) ConsumerBounceTest.testSeekAndCommitWithBrokerFailures transient failure

2015-04-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493465#comment-14493465 ] Guozhang Wang commented on KAFKA-2055: -- [~lvfangmin] Do you want to take on this

Jenkins build is back to normal : KafkaPreCommit #73

2015-04-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/KafkaPreCommit/73/changes

Re: [KIP-DISCUSSION] KIP-13 Quotas

2015-04-13 Thread Guozhang Wang
I think KAFKA-2063 (bounding fetch response) is still under discussion, and may not be got it in time with KAFKA-1927. On Thu, Apr 9, 2015 at 4:49 PM, Aditya Auradkar aaurad...@linkedin.com.invalid wrote: I think it's reasonable to batch the protocol changes together. In addition to the

[DISCUSS] error handling in java KafkaProducer

2015-04-13 Thread Steven Wu
Here is the resource leak problem that we have encountered when 0.8.2 java KafkaProducer failed in constructor. here is the code snippet of KafkaProducer to illustrate the problem. --- public KafkaProducer(ProducerConfig config, SerializerK keySerializer, SerializerV

Re: Review Request 33135: Fix KAFKA-2117

2015-04-13 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33135/#review79978 --- Ship it! Ship It! - Ewen Cheslack-Postava On April 13, 2015,

[jira] [Commented] (KAFKA-2117) OffsetManager uses incorrect field for metadata

2015-04-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493438#comment-14493438 ] Guozhang Wang commented on KAFKA-2117: -- Committed to trunk. OffsetManager uses

[jira] [Updated] (KAFKA-2117) OffsetManager uses incorrect field for metadata

2015-04-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2117: - Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available)

Build failed in Jenkins: Kafka-trunk #461

2015-04-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/461/changes Changes: [wangguoz] KAFKA-2117; Use the correct metadata field for reading offset struct; reviewed by Jun Rao and Jiangjie Qin -- [...truncated 1514 lines...] kafka.api.ProducerFailureHandlingTest

Re: [DISCUSS] error handling in java KafkaProducer

2015-04-13 Thread Guozhang Wang
It is a valid problem and we should correct it as soon as possible, I'm with Ewen regarding the solution. On Mon, Apr 13, 2015 at 5:05 PM, Ewen Cheslack-Postava e...@confluent.io wrote: Steven, Looks like there is even more that could potentially be leaked -- since key and value serializers

Re: [DISCUSS] error handling in java KafkaProducer

2015-04-13 Thread Ewen Cheslack-Postava
Steven, Looks like there is even more that could potentially be leaked -- since key and value serializers are created and configured at the end, even the IO thread allocated by the producer could leak. Given that, I think 1 isn't a great option since, as you said, it doesn't really address the

Re: Review Request 33140: Patch for KAFKA-2119

2015-04-13 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33140/#review79980 --- Ship it! Ship It! - Guozhang Wang On April 13, 2015, 6:58 p.m.,

[jira] [Commented] (KAFKA-2056) PartitionAssignorTest.testRangePartitionAssignor transient failure

2015-04-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493471#comment-14493471 ] Guozhang Wang commented on KAFKA-2056: -- Hey [~lvfangmin], I agree that the problem

[jira] [Commented] (KAFKA-2056) PartitionAssignorTest.testRangePartitionAssignor transient failure

2015-04-13 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493495#comment-14493495 ] Fangmin Lv commented on KAFKA-2056: --- Hi [~guozhang], I agree with you, it's more robust

[jira] [Commented] (KAFKA-2055) ConsumerBounceTest.testSeekAndCommitWithBrokerFailures transient failure

2015-04-13 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493497#comment-14493497 ] Fangmin Lv commented on KAFKA-2055: --- [~guozhang] Sure, I'd like to take it over.

[jira] [Assigned] (KAFKA-2055) ConsumerBounceTest.testSeekAndCommitWithBrokerFailures transient failure

2015-04-13 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv reassigned KAFKA-2055: - Assignee: Fangmin Lv ConsumerBounceTest.testSeekAndCommitWithBrokerFailures transient failure

[jira] [Commented] (KAFKA-2119) ConsumerRecord key() and value() methods should not have throws Exception

2015-04-13 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492855#comment-14492855 ] Ewen Cheslack-Postava commented on KAFKA-2119: -- Created reviewboard

Re: Review Request 33088: add heartbeat to coordinator

2015-04-13 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33088/ --- (Updated April 13, 2015, 6:58 p.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-2119) ConsumerRecord key() and value() methods should not have throws Exception

2015-04-13 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2119: - Attachment: KAFKA-2119.patch ConsumerRecord key() and value() methods should not

Re: Review Request 33088: add heartbeat to coordinator

2015-04-13 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33088/ --- (Updated April 13, 2015, 5:11 p.m.) Review request for kafka. Bugs:

Review Request 33125: Fix timing issue in MetadataTest

2015-04-13 Thread Rajini Sivaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33125/ --- Review request for kafka. Bugs: KAFKA-2089

[jira] [Commented] (KAFKA-2089) MetadataTest transient failure

2015-04-13 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492049#comment-14492049 ] Rajini Sivaram commented on KAFKA-2089: --- Jiangjie Qin, Thank you for the review. I

[jira] [Commented] (KAFKA-2115) Error updating metrics in RequestChannel

2015-04-13 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492106#comment-14492106 ] Onur Karaman commented on KAFKA-2115: - Trunk's coordinator is pretty much

[jira] [Commented] (KAFKA-2056) PartitionAssignorTest.testRangePartitionAssignor transient failure

2015-04-13 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492121#comment-14492121 ] Fangmin Lv commented on KAFKA-2056: --- The last few consumers may not be assigned with

[jira] [Commented] (KAFKA-2089) MetadataTest transient failure

2015-04-13 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492014#comment-14492014 ] Rajini Sivaram commented on KAFKA-2089: --- Created reviewboard

[jira] [Updated] (KAFKA-2089) MetadataTest transient failure

2015-04-13 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram updated KAFKA-2089: -- Attachment: KAFKA-2089.patch MetadataTest transient failure --

[jira] [Updated] (KAFKA-2056) PartitionAssignorTest.testRangePartitionAssignor transient failure

2015-04-13 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv updated KAFKA-2056: -- Attachment: KAFKA-2056.patch PartitionAssignorTest.testRangePartitionAssignor transient failure

Re: [DISCUSS] KIP-18 - JBOD Support

2015-04-13 Thread Andrii Biletskyi
Jun, 2. Yes, you are right. The idea is that different exceptions and different error causes may require different actions. That's why instead of generic error handling logic it is proposed to implement a separate component - ExceptionHandler that will encapsulate logic to take the right action

[jira] [Updated] (KAFKA-2115) Error updating metrics in RequestChannel

2015-04-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2115: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for

Review Request 33132: Patch for kafka-2088

2015-04-13 Thread ransom
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33132/ --- Review request for kafka. Bugs: kafka-2088

[jira] [Updated] (KAFKA-2056) PartitionAssignorTest.testRangePartitionAssignor transient failure

2015-04-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2056: --- Assignee: Fangmin Lv Status: Patch Available (was: Open)

[jira] [Updated] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

2015-04-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2102: --- Status: In Progress (was: Patch Available) Remove unnecessary synchronization when managing metadata

[jira] [Updated] (KAFKA-2088) kafka-console-consumer.sh should not create zookeeper path when no brokers found and chroot was set in zookeeper.connect

2015-04-13 Thread Zhiqiang He (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhiqiang He updated KAFKA-2088: --- Attachment: kafka-2088.1.patch kafka-console-consumer.sh should not create zookeeper path when no

[jira] [Updated] (KAFKA-2088) kafka-console-consumer.sh should not create zookeeper path when no brokers found and chroot was set in zookeeper.connect

2015-04-13 Thread Zhiqiang He (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhiqiang He updated KAFKA-2088: --- Status: Patch Available (was: Open) https://reviews.apache.org/r/33132/diff/ please review it.

Build failed in Jenkins: KafkaPreCommit #72

2015-04-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/KafkaPreCommit/72/changes Changes: [junrao] kafka-2115; Error updating metrics in RequestChannel; patched by Gwen Shapira; reviewed by Jun Rao -- [...truncated 1055 lines...] kafka.log.FileMessageSetTest

[jira] [Created] (KAFKA-2118) Cleaner cannot clean after shutdown during replaceSegments

2015-04-13 Thread Gian Merlino (JIRA)
Gian Merlino created KAFKA-2118: --- Summary: Cleaner cannot clean after shutdown during replaceSegments Key: KAFKA-2118 URL: https://issues.apache.org/jira/browse/KAFKA-2118 Project: Kafka Issue

[jira] [Commented] (KAFKA-2116) Add code that uses new consumer to system_tests

2015-04-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492614#comment-14492614 ] Guozhang Wang commented on KAFKA-2116: -- Hi Gwen, there is a ticket for adding /

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-04-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492628#comment-14492628 ] Guozhang Wang commented on KAFKA-1910: -- 1. Sounds good. Refactor KafkaConsumer

Build failed in Jenkins: Kafka-trunk #460

2015-04-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/460/changes Changes: [junrao] kafka-2115; Error updating metrics in RequestChannel; patched by Gwen Shapira; reviewed by Jun Rao -- [...truncated 1249 lines...] kafka.api.ProducerFailureHandlingTest

Review Request 33133: SSL support for new Java producer client

2015-04-13 Thread Rajini Sivaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33133/ --- Review request for kafka. Bugs: KAFKA-1690

[jira] [Updated] (KAFKA-1690) new java producer needs ssl support as a client

2015-04-13 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram updated KAFKA-1690: -- Assignee: Rajini Sivaram (was: Sriharsha Chintalapani) Status: Patch Available (was:

[jira] [Updated] (KAFKA-1690) new java producer needs ssl support as a client

2015-04-13 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram updated KAFKA-1690: -- Attachment: KAFKA-1690.patch new java producer needs ssl support as a client

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

2015-04-13 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492530#comment-14492530 ] Rajini Sivaram commented on KAFKA-1690: --- Created reviewboard

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-04-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492569#comment-14492569 ] Guozhang Wang commented on KAFKA-1910: -- Hey Jay, 1. I agree with you, the function

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-04-13 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492598#comment-14492598 ] Jay Kreps commented on KAFKA-1910: -- Hey [~guozhang], 1. Cool. Yeah I think create is

Re: Exceptions on trunk

2015-04-13 Thread Guozhang Wang
My bad on 1), fixing it right now. On Sun, Apr 12, 2015 at 8:06 PM, Jun Rao j...@confluent.io wrote: For 1, the issue seems to be that we try to get metadata using the offset field. Filed KAFKA-2117. Thanks, Jun On Sun, Apr 12, 2015 at 1:12 PM, Jay Kreps jay.kr...@gmail.com wrote: I

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

2015-04-13 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492538#comment-14492538 ] Rajini Sivaram commented on KAFKA-1690: --- [~prestona] and I have been looking at TLS

[jira] [Updated] (KAFKA-2117) OffsetManager uses incorrect field for metadata

2015-04-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2117: - Attachment: KAFKA-2117.patch OffsetManager uses incorrect field for metadata

[jira] [Commented] (KAFKA-2117) OffsetManager uses incorrect field for metadata

2015-04-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492539#comment-14492539 ] Guozhang Wang commented on KAFKA-2117: -- Created reviewboard

[jira] [Updated] (KAFKA-2117) OffsetManager uses incorrect field for metadata

2015-04-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2117: - Assignee: Guozhang Wang Status: Patch Available (was: Open) OffsetManager uses incorrect

Review Request 33135: Fix KAFKA-2117

2015-04-13 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33135/ --- Review request for kafka. Bugs: KAFKA-2117

[jira] [Assigned] (KAFKA-1690) new java producer needs ssl support as a client

2015-04-13 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani reassigned KAFKA-1690: - Assignee: Sriharsha Chintalapani (was: Rajini Sivaram) new java

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

2015-04-13 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492543#comment-14492543 ] Sriharsha Chintalapani commented on KAFKA-1690: --- [~rsivaram] There is

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-04-13 Thread Andrii Biletskyi
Jun, 404. Great, thanks! 500. If I understand correctly KAFKA-1367 says ISR part of TMR may be inconsistent. If so, then I believe all admin commands but describeTopic are not affected. Let me emphasize that it's about AdminClient operations, not about Wire Protocol requests. What I mean: To

Re: Review Request 33135: Fix KAFKA-2117

2015-04-13 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33135/#review79887 --- Ship it! Ship It! - Jun Rao On April 13, 2015, 3:51 p.m.,