[
https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492569#comment-14492569
]
Guozhang Wang commented on KAFKA-1910:
--------------------------------------
Hey Jay,
1. I agree with you, the function name is quite misleading. I am thinking about
changing them to "createXYZRequest" (there are two such functions in total,
namely initiateConsumerMetadataRequest and initiateCoordinatorRequest).
2. Right now we have two handlers for async requests, offset commit and
heartbeat (join-group does not use handlers but parse the response directly
since it is a blocking call), and for these two requests the handling logic
seems quite independent to the request setup environment, which is why I
separate them as objects. Do you have specific concerns about what "tied to
what happens during the request setup"?
> Refactor KafkaConsumer
> ----------------------
>
> Key: KAFKA-1910
> URL: https://issues.apache.org/jira/browse/KAFKA-1910
> Project: Kafka
> Issue Type: Sub-task
> Components: consumer
> Reporter: Guozhang Wang
> Assignee: Guozhang Wang
> Fix For: 0.8.3
>
> Attachments: KAFKA-1910.patch, KAFKA-1910.patch, KAFKA-1910.patch,
> KAFKA-1910_2015-03-05_14:55:33.patch
>
>
> KafkaConsumer now contains all the logic on the consumer side, making it a
> very huge class file, better re-factoring it to have multiple layers on top
> of KafkaClient.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
