[jira] [Updated] (KAFKA-2146) adding partition did not find the correct startIndex

2015-04-26 Thread chenshangan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenshangan updated KAFKA-2146: --- Status: Patch Available (was: Open) use partition 0 as head partition; find the index of first replic

[jira] [Comment Edited] (KAFKA-2140) Improve code readability

2015-04-26 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513618#comment-14513618 ] Ismael Juma edited comment on KAFKA-2140 at 4/27/15 6:43 AM: -

[jira] [Commented] (KAFKA-2140) Improve code readability

2015-04-26 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513618#comment-14513618 ] Ismael Juma commented on KAFKA-2140: [~ewencp], the JIRA integration is also already e

[jira] [Commented] (KAFKA-1054) Eliminate Compilation Warnings for 0.8 Final Release

2015-04-26 Thread Ismael Juma (JIRA)
> Issue Type: Improvement >Reporter: Guozhang Wang > Labels: newbie > Fix For: 0.9.0 > > Attachments: KAFKA-1054-20150426-V1.patch, > KAFKA-1054-20150426-V2.patch, KAFKA-1054.patch, KAFKA-1054_Mar_10_2015.patch > > >

[jira] [Commented] (KAFKA-1054) Eliminate Compilation Warnings for 0.8 Final Release

2015-04-26 Thread ASF GitHub Bot (JIRA)
URL: https://issues.apache.org/jira/browse/KAFKA-1054 > Project: Kafka > Issue Type: Improvement >Reporter: Guozhang Wang > Labels: newbie > Fix For: 0.9.0 > > Attachments: KAFKA-1054-20150426-V1.patch, > KAFKA-1054

[GitHub] kafka pull request: KAFKA-1054; Eliminate Scala Compilation Warnin...

2015-04-26 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/57 KAFKA-1054; Eliminate Scala Compilation Warnings Changes: - Suppressed compiler warnings about type erasure in matching via unboxing by Jon Riehl. - Suppressed warning caused by slight differ

[jira] [Commented] (KAFKA-2106) Partition balance tool between borkers

2015-04-26 Thread lizhitao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513587#comment-14513587 ] lizhitao commented on KAFKA-2106: - if I have this tools,wonderful > Partition balance too

[jira] [Commented] (KAFKA-2139) Add a separate controller messge queue with higher priority on broker side

2015-04-26 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513578#comment-14513578 ] Jiangjie Qin commented on KAFKA-2139: - Sorry for the confusion... I'm absolutely with

[jira] [Updated] (KAFKA-2106) Partition balance tool between borkers

2015-04-26 Thread chenshangan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenshangan updated KAFKA-2106: --- Attachment: KAFKA-2106.patch.2 check reassignment status, Thread.sleep according to the status rather

[jira] [Commented] (KAFKA-2140) Improve code readability

2015-04-26 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513571#comment-14513571 ] Ismael Juma commented on KAFKA-2140: Thanks Ewen, useful reference. We already receive

[jira] [Commented] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

2015-04-26 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513564#comment-14513564 ] Ismael Juma commented on KAFKA-1595: Ok, understood about the clients. I guess this wi

[jira] [Commented] (KAFKA-2103) kafka.producer.AsyncProducerTest failure.

2015-04-26 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513558#comment-14513558 ] Dong Lin commented on KAFKA-2103: - Of course. Let me work on this ticket. > kafka.produce

[jira] [Updated] (KAFKA-2103) kafka.producer.AsyncProducerTest failure.

2015-04-26 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar updated KAFKA-2103: --- Assignee: Dong Lin > kafka.producer.AsyncProducerTest failure. > -

[jira] [Commented] (KAFKA-2103) kafka.producer.AsyncProducerTest failure.

2015-04-26 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513555#comment-14513555 ] Aditya Auradkar commented on KAFKA-2103: [~lindong] Can you take a crack at this?

[jira] [Commented] (KAFKA-2139) Add a separate controller messge queue with higher priority on broker side

2015-04-26 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513540#comment-14513540 ] Gwen Shapira commented on KAFKA-2139: - Thanks. Good point about separate port not sol

[jira] [Commented] (KAFKA-2139) Add a separate controller messge queue with higher priority on broker side

2015-04-26 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513534#comment-14513534 ] Jiangjie Qin commented on KAFKA-2139: - Hey Gwen, thanks for this really quick review!

Java One - Call for Papers closes April 29

2015-04-26 Thread Gwen Shapira
Hi Kafka Devs, Call for papers for Java One closes on April 29. Java One is the largest conference for Java developers (duh), taking place for 5 days in September in SF. There are about gazillion attendees every year. If you do something cool with Kafka - either as a user building cool data pipe

Re: Review Request 33557: Patch for KAFKA-1936

2015-04-26 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/#review81657 --- Ship it! Ship It! - Jiangjie Qin On April 27, 2015, 4:26 a.m., D

[jira] [Commented] (KAFKA-2139) Add a separate controller messge queue with higher priority on broker side

2015-04-26 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513511#comment-14513511 ] Gwen Shapira commented on KAFKA-2139: - Thanks for the nice doc. Two questions / commen

[jira] [Updated] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-04-26 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1936: Attachment: KAFKA-1936_2015-04-26_21:26:34.patch > Track offset commit requests separately from produce requ

[jira] [Commented] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-04-26 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513508#comment-14513508 ] Dong Lin commented on KAFKA-1936: - Updated reviewboard https://reviews.apache.org/r/33557/

Re: Review Request 33557: Patch for KAFKA-1936

2015-04-26 Thread Dong Lin
> On April 27, 2015, 4 a.m., Jiangjie Qin wrote: > > core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala, line 107 > > > > > > Typo, larger. Thanks for noticing the bytes-out-rate and the typo. I missed that

Re: Review Request 33557: Patch for KAFKA-1936

2015-04-26 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/ --- (Updated April 27, 2015, 4:26 a.m.) Review request for kafka. Bugs: KAFKA-193

[jira] [Updated] (KAFKA-2103) kafka.producer.AsyncProducerTest failure.

2015-04-26 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2103: Issue Type: Sub-task (was: Bug) Parent: KAFKA-2054 > kafka.producer.AsyncProducerTest failu

[jira] [Updated] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-04-26 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1936: Attachment: KAFKA-1936_2015-04-26_21:20:28.patch > Track offset commit requests separately from produce requ

[jira] [Commented] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-04-26 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513503#comment-14513503 ] Dong Lin commented on KAFKA-1936: - Updated reviewboard https://reviews.apache.org/r/33557/

Re: Review Request 33557: Patch for KAFKA-1936

2015-04-26 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/ --- (Updated April 27, 2015, 4:20 a.m.) Review request for kafka. Bugs: KAFKA-193

[jira] [Commented] (KAFKA-2103) kafka.producer.AsyncProducerTest failure.

2015-04-26 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513499#comment-14513499 ] Jiangjie Qin commented on KAFKA-2103: - [~nehanarkhede] Yes, it is still failing. I'll

[jira] [Commented] (KAFKA-1940) Initial checkout and build failing

2015-04-26 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513494#comment-14513494 ] Jiangjie Qin commented on KAFKA-1940: - The kafka.producer.AsyncProducerTest failures s

Re: Review Request 33557: Patch for KAFKA-1936

2015-04-26 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/#review81654 --- Should we also apply the same rule to bytes out rate? core/src/tes

[jira] [Commented] (KAFKA-2152) Console producer fails to start when server running with broker.id != 0

2015-04-26 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513482#comment-14513482 ] Gwen Shapira commented on KAFKA-2152: - When you created the topic at first, the partit

[jira] [Resolved] (KAFKA-2152) Console producer fails to start when server running with broker.id != 0

2015-04-26 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira resolved KAFKA-2152. - Resolution: Not A Problem > Console producer fails to start when server running with broker.id !=

[jira] [Commented] (KAFKA-2147) Unbalanced replication can cause extreme purgatory growth

2015-04-26 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513475#comment-14513475 ] Jiangjie Qin commented on KAFKA-2147: - Sorry for not responding to you on the mailing

[jira] [Created] (KAFKA-2152) Console producer fails to start when server running with broker.id != 0

2015-04-26 Thread Lior Gonnen (JIRA)
Lior Gonnen created KAFKA-2152: -- Summary: Console producer fails to start when server running with broker.id != 0 Key: KAFKA-2152 URL: https://issues.apache.org/jira/browse/KAFKA-2152 Project: Kafka

RE: [VOTE] KIP-11- Authorization design for kafka security

2015-04-26 Thread Sun, Dapeng
Hi Parth The design looks good, a few minor comments below. Since I just started looking into the discussion and many previous discussions I may missed, I'm sorry if these comments had be discussed. 1. About SimpleAclAuthorizer (SimpleAuthorizer): a. As my understanding, I think there should on

[jira] [Commented] (KAFKA-2139) Add a separate controller messge queue with higher priority on broker side

2015-04-26 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513453#comment-14513453 ] Jiangjie Qin commented on KAFKA-2139: - Hi [~jkreps][~nehanarkhede][~junrao][~jjkoshy][

[jira] [Updated] (KAFKA-2151) make MockMetricsReporter a little more generic

2015-04-26 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated KAFKA-2151: -- Status: Patch Available (was: Open) > make MockMetricsReporter a little more generic >

[jira] [Updated] (KAFKA-2151) make MockMetricsReporter a little more generic

2015-04-26 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated KAFKA-2151: -- Attachment: KAFKA-2151.patch > make MockMetricsReporter a little more generic >

Review Request 33574: Patch for KAFKA-2151

2015-04-26 Thread Steven Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33574/ --- Review request for kafka. Bugs: KAFKA-2151 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-2151) make MockMetricsReporter a little more generic

2015-04-26 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513448#comment-14513448 ] Steven Zhen Wu commented on KAFKA-2151: --- Created reviewboard https://reviews.apache.

[jira] [Created] (KAFKA-2151) make MockMetricsReporter a little more generic

2015-04-26 Thread Steven Zhen Wu (JIRA)
Steven Zhen Wu created KAFKA-2151: - Summary: make MockMetricsReporter a little more generic Key: KAFKA-2151 URL: https://issues.apache.org/jira/browse/KAFKA-2151 Project: Kafka Issue Type: Im

[jira] [Commented] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

2015-04-26 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513441#comment-14513441 ] Gwen Shapira commented on KAFKA-1595: - I'm a bit concerned about choosing a library *b

[jira] [Commented] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

2015-04-26 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513420#comment-14513420 ] Jun Rao commented on KAFKA-1595: [~ijuma], we discussed the json library in the context of

[jira] [Commented] (KAFKA-2128) kafka.Kafka should return non-zero exit code when caught exception.

2015-04-26 Thread Sasaki Toru (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513408#comment-14513408 ] Sasaki Toru commented on KAFKA-2128: Thanks [~gwenshap] and [~aauradkar] for reviews.

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-26 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513387#comment-14513387 ] Ashish K Singh commented on KAFKA-1367: --- [~nehanarkhede] If no one has already start

Build failed in Jenkins: Kafka-trunk #477

2015-04-26 Thread Apache Jenkins Server
See Changes: [junrao] kafka-2118; Cleaner cannot clean after shutdown during replaceSegments; patched by Rajini Sivaram; reviewed by Jun Rao -- [...truncated 667 lines...] kafka.log.LogTest > testOpe

[jira] [Commented] (KAFKA-2140) Improve code readability

2015-04-26 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513374#comment-14513374 ] Ewen Cheslack-Postava commented on KAFKA-2140: -- Not sure if it's changed at a

[jira] [Updated] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

2015-04-26 Thread Tim Brooks (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2102: -- Attachment: KAFKA-2102_2015-04-26_17:25:21.patch > Remove unnecessary synchronization when managing meta

[jira] [Commented] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

2015-04-26 Thread Tim Brooks (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513346#comment-14513346 ] Tim Brooks commented on KAFKA-2102: --- Updated reviewboard https://reviews.apache.org/r/32

Re: Review Request 32937: Patch for KAFKA-2102

2015-04-26 Thread Tim Brooks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32937/ --- (Updated April 27, 2015, 12:26 a.m.) Review request for kafka. Bugs: KAFKA-21

[jira] [Updated] (KAFKA-2118) Cleaner cannot clean after shutdown during replaceSegments

2015-04-26 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2118: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for t

[jira] [Updated] (KAFKA-2003) Add upgrade tests

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2003: - Component/s: system tests > Add upgrade tests > - > > Key: KAFKA-2

[jira] [Updated] (KAFKA-2014) Chaos Monkey / Failure Inducer for Kafka

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2014: - Component/s: system tests > Chaos Monkey / Failure Inducer for Kafka > ---

[jira] [Updated] (KAFKA-1858) Make ServerShutdownTest a bit less flaky

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1858: - Reviewer: Jun Rao Status: Patch Available (was: Open) > Make ServerShutdownTest a bit less

[jira] [Updated] (KAFKA-2041) Add ability to specify a KeyClass for KafkaLog4jAppender

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2041: - Status: Patch Available (was: Open) > Add ability to specify a KeyClass for KafkaLog4jAppender >

[jira] [Updated] (KAFKA-2080) quick cleanup of producer performance scripts

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2080: - Component/s: tools > quick cleanup of producer performance scripts > -

[jira] [Updated] (KAFKA-2080) quick cleanup of producer performance scripts

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2080: - Labels: newbie (was: ) > quick cleanup of producer performance scripts >

[jira] [Updated] (KAFKA-1904) run sanity failed test

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1904: - Component/s: system tests > run sanity failed test > -- > > Ke

[jira] [Commented] (KAFKA-1621) Standardize --messages option in perf scripts

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513324#comment-14513324 ] Neha Narkhede commented on KAFKA-1621: -- [~rekhajoshm] Sorry for the delay, reviewed y

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-04-26 Thread Jun Rao
Andrii, Another thing. We decided not to add the lag info in TMR. To be consistent, we probably also want to remove ISR from TMR since only the leader knows it. We can punt on adding any new request from getting ISR. ISR is mostly useful for monitoring. Currently, one can determine if a replica is

[jira] [Updated] (KAFKA-2100) Client Error doesn't preserve or display original server error code when it is an unknown code

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2100: - Labels: newbie (was: ) > Client Error doesn't preserve or display original server error code when

[jira] [Updated] (KAFKA-2100) Client Error doesn't preserve or display original server error code when it is an unknown code

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2100: - Component/s: clients > Client Error doesn't preserve or display original server error code when it

[jira] [Commented] (KAFKA-2101) Metric metadata-age is reset on a failed update

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513318#comment-14513318 ] Neha Narkhede commented on KAFKA-2101: -- [~timbrooks] To clarify your question - we sh

[jira] [Updated] (KAFKA-1342) Slow controlled shutdowns can result in stale shutdown requests

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1342: - Labels: newbie++ (was: ) > Slow controlled shutdowns can result in stale shutdown requests >

[jira] [Commented] (KAFKA-2103) kafka.producer.AsyncProducerTest failure.

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513316#comment-14513316 ] Neha Narkhede commented on KAFKA-2103: -- [~becket_qin] Is this still an issue? If so,

[jira] [Commented] (KAFKA-1737) Document required ZkSerializer for ZkClient used with AdminUtils

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513312#comment-14513312 ] Neha Narkhede commented on KAFKA-1737: -- [~vivekpm] Makes sense. Would you like to upl

[jira] [Resolved] (KAFKA-2108) Node deleted all data and re-sync from replicas after attempted upgrade from 0.8.1.1 to 0.8.2.0

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-2108. -- Resolution: Incomplete Closing due to inactivity. [~slimunholyone], [~becket_qin] feel free to r

[jira] [Updated] (KAFKA-1054) Eliminate Compilation Warnings for 0.8 Final Release

2015-04-26 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-1054: --- Attachment: KAFKA-1054-20150426-V2.patch This is the same as `KAFKA-1054-20150426-V1.patch`, but

[jira] [Updated] (KAFKA-1054) Eliminate Compilation Warnings for 0.8 Final Release

2015-04-26 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-1054: --- Attachment: KAFKA-1054-20150426-V1.patch This is a rebased patch with an additional commit for fixing

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-04-26 Thread Andrii Biletskyi
Jun, I like your approach to AlterTopicReques semantics! Sounds like we linearize all request fields to ReplicaAssignment - I will definitely try this out to ensure there are no other pitfalls. With regards to multiple instructions in one batch per topic. For me this sounds reasonable too. We dis

Jenkins build is back to normal : Kafka-trunk #476

2015-04-26 Thread Apache Jenkins Server
See

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513265#comment-14513265 ] Neha Narkhede commented on KAFKA-1367: -- [~jkreps] Yup, issue still exists and the sol

Re: [VOTE] KIP-11- Authorization design for kafka security

2015-04-26 Thread Jun Rao
A few more minor comments. 100. To make it clear, perhaps we should rename the resource "group" to consumer-group. We can probably make the same change in CLI as well so that it's not confused with user group. 101. Currently, create is only at the cluster level. Should it also be at topic level?

Build failed in Jenkins: Kafka-trunk #475

2015-04-26 Thread Apache Jenkins Server
See Changes: [nehanarkhede] KAFKA-2140 follow up, checking in newly renamed file ConsumerRebalanceFailedException [nehanarkhede] KAFKA-2128 kafka.Kafka should return non-zero exit code when caught exception; reviewed by Neha

[jira] [Updated] (KAFKA-2114) Unable to change min.insync.replicas default

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2114: - Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to trunk. Thanks Gwen!

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-04-26 Thread Jun Rao
Andrii, Thanks for the update. For your second point, I agree that if a single AlterTopicRequest can make multiple changes, there is no need to support the same topic included more than once in the request. Now about the semantics in your first question. I was thinking that we can do the followi

Re: Review Request 33421: Patch for KAFKA-2114

2015-04-26 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33421/#review81634 --- Ship it! Ship It! - Neha Narkhede On April 22, 2015, 12:10 a.m.,

Jenkins build is back to normal : KafkaPreCommit #87

2015-04-26 Thread Apache Jenkins Server
See

[jira] [Commented] (KAFKA-2140) Improve code readability

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513225#comment-14513225 ] Neha Narkhede commented on KAFKA-2140: -- Nice. My assumption was that (and I could be

[jira] [Updated] (KAFKA-1940) Initial checkout and build failing

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1940: - Status: Patch Available (was: Open) > Initial checkout and build failing > --

[jira] [Updated] (KAFKA-2105) NullPointerException in client on MetadataRequest

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2105: - Status: Patch Available (was: Open) > NullPointerException in client on MetadataRequest > ---

[jira] [Updated] (KAFKA-2150) FetcherThread backoff need to grab lock before wait on condition.

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2150: - Reviewer: Guozhang Wang [~guozhang] This was introduced in KAFKA-1461, so assigning to you for rev

[jira] [Commented] (KAFKA-2140) Improve code readability

2015-04-26 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513203#comment-14513203 ] Ismael Juma commented on KAFKA-2140: Yes, I'd be happy to help with that. It would mak

[jira] [Comment Edited] (KAFKA-2029) Improving controlled shutdown for rolling updates

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513138#comment-14513138 ] Neha Narkhede edited comment on KAFKA-2029 at 4/26/15 7:15 PM: -

[jira] [Comment Edited] (KAFKA-2029) Improving controlled shutdown for rolling updates

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513138#comment-14513138 ] Neha Narkhede edited comment on KAFKA-2029 at 4/26/15 7:15 PM: -

[jira] [Commented] (KAFKA-2140) Improve code readability

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513202#comment-14513202 ] Neha Narkhede commented on KAFKA-2140: -- Fixed and pushed. > Improve code readability

[jira] [Commented] (KAFKA-2140) Improve code readability

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513200#comment-14513200 ] Neha Narkhede commented on KAFKA-2140: -- Forgot to explicitly add this. Will be much b

[jira] [Updated] (KAFKA-2140) Improve code readability

2015-04-26 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2140: --- Attachment: KAFKA-2140-fix.patch [~nehanarkhede], I attached a patch that restores the file that was s

[jira] [Commented] (KAFKA-2140) Improve code readability

2015-04-26 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513187#comment-14513187 ] Ismael Juma commented on KAFKA-2140: It looks like something weird happened in the mer

[jira] [Commented] (KAFKA-1758) corrupt recovery file prevents startup

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513186#comment-14513186 ] Neha Narkhede commented on KAFKA-1758: -- [~omkreddy] I took a quick look and left a fe

[jira] [Updated] (KAFKA-1758) corrupt recovery file prevents startup

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1758: - Reviewer: Neha Narkhede > corrupt recovery file prevents startup > ---

Re: Review Request 30801: Patch for KAFKA-1758

2015-04-26 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30801/#review81622 --- core/src/main/scala/kafka/log/LogManager.scala

[GitHub] kafka pull request: Kafka 1595 remove deprecated json parser

2015-04-26 Thread ijuma
Github user ijuma closed the pull request at: https://github.com/apache/kafka/pull/55 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[jira] [Commented] (KAFKA-1887) controller error message on shutting the last broker

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513159#comment-14513159 ] Neha Narkhede commented on KAFKA-1887: -- [~sriharsha] The patch is waiting for a comme

[jira] [Updated] (KAFKA-1887) controller error message on shutting the last broker

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1887: - Reviewer: Neha Narkhede > controller error message on shutting the last broker > -

[jira] [Updated] (KAFKA-1907) ZkClient can block controlled shutdown indefinitely

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1907: - Labels: zkclient-problems (was: ) > ZkClient can block controlled shutdown indefinitely > ---

[jira] [Commented] (KAFKA-1886) SimpleConsumer swallowing ClosedByInterruptException

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513154#comment-14513154 ] Neha Narkhede commented on KAFKA-1886: -- [~aauradkar] Took a quick look at your patch

Re: Review Request 30196: Patch for KAFKA-1886

2015-04-26 Thread Neha Narkhede
> On Feb. 7, 2015, 4:22 p.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala, line 295 > > > > > > Why do you need the sleep here? We try to avoid blindly sleeping in > > Ka

[jira] [Commented] (KAFKA-2027) kafka never notifies the zookeeper client when a partition moved with due to an auto-rebalance (when auto.leader.rebalance.enable=true)

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513151#comment-14513151 ] Neha Narkhede commented on KAFKA-2027: -- Can you describe the end user behavior that y

[jira] [Updated] (KAFKA-2082) Kafka Replication ends up in a bad state

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2082: - Labels: zkclient-problems (was: ) > Kafka Replication ends up in a bad state > --

  1   2   >