On May 1, 2015, 9:25 p.m., Jay Kreps wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 382
https://reviews.apache.org/r/33065/diff/3/?file=946988#file946988line382
Beautiful! So much deleted code!
Haha :) Yeah, I love how minimal SocketServer became.
- Gwen
[
https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ewen Cheslack-Postava updated KAFKA-2123:
-
Attachment: KAFKA-2123_2015-05-01_19:33:19.patch
Make new consumer offset commit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33196/
---
(Updated May 2, 2015, 2:33 a.m.)
Review request for kafka.
Bugs: KAFKA-2123
[
https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14524185#comment-14524185
]
Steven Zhen Wu commented on KAFKA-2121:
---
Updated reviewboard
On April 18, 2015, 12:49 a.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/ByteBufferSend.java,
line 55
https://reviews.apache.org/r/33065/diff/1/?file=922619#file922619line55
Do you know why the return is changed from int to long?
writeTo() and
[
https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steven Zhen Wu updated KAFKA-2121:
--
Attachment: KAFKA-2121_2015-05-01_15:42:30.patch
prevent potential resource leak in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33760/#review82292
---
Ship it!
Ship It!
- Guozhang Wang
On May 1, 2015, 10:42 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33760/
---
(Updated May 1, 2015, 10:42 p.m.)
Review request for kafka.
Bugs: KAFKA-2121
[
https://issues.apache.org/jira/browse/KAFKA-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1928:
Attachment: KAFKA-1928_2015-05-01_15:45:24.patch
Move kafka.network over to using the network
[
https://issues.apache.org/jira/browse/KAFKA-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14524195#comment-14524195
]
Gwen Shapira commented on KAFKA-1928:
-
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated May 1, 2015, 10:45 p.m.)
Review request for kafka.
Bugs: KAFKA-1928
[
https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14524491#comment-14524491
]
Ewen Cheslack-Postava commented on KAFKA-2123:
--
Updated to add backoff back
GitHub user lvfangmin opened a pull request:
https://github.com/apache/kafka/pull/60
Patch for KAFKA-2055: ConsumerBounceTest.testSeekAndCommitWithBrokerFail...
...ures transient failure
You can merge this pull request into a Git repository by running:
$ git pull
[
https://issues.apache.org/jira/browse/KAFKA-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523248#comment-14523248
]
ASF GitHub Bot commented on KAFKA-2055:
---
GitHub user lvfangmin opened a pull
+1.
Thanks
Parth
On 5/1/15, 12:38 AM, Ewen Cheslack-Postava e...@confluent.io wrote:
Also +1. There are some drawbacks to using Github for reviews, e.g. lots
of
emails for each review because they don't let you publish your entire
review in one go like RB does, but it drastically lowers the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33760/
---
Review request for kafka.
Bugs: KAFKA-2121
Hey Gwen,
Thanks for the feedback. As Joel said, these client configs do not introduce a
producer/consumer zk dependency. It is configuration that is needed by the
broker.
From your comments, I gather that you are more worried about managing broker
internal configs via Zookeeper since we
[
https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steven Zhen Wu updated KAFKA-2121:
--
Attachment: KAFKA-2121.patch
prevent potential resource leak in KafkaProducer and
[
https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523538#comment-14523538
]
Steven Zhen Wu commented on KAFKA-2121:
---
Created reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review82281
---
I did a high level pass. On the whole I think this is awesome! I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33760/#review82280
---
Pointed out two minor issues, but otherwise LGTM.
Hi Aditya, thanks for the write up and focusing on this piece.
Agreed we need something that we can do broker changes dynamically without
rolling restarts.
I think though if every broker is getting changes it with notifications it
is going to limit which configs can be dynamic.
We could never
If you use KafkaProducer as a Closable, you still need to catch the
exception when calling close(), right? So the behavior is different whether
you use it as a Producer or a Closable?
Thanks,
Jun
On Thu, Apr 30, 2015 at 6:26 PM, Jay Kreps j...@confluent.io wrote:
Hey Jun,
I think the
Suresh,
We typically wrap up the voting of a KIP in a few days. However, given that
this KIP is quite critical and there seems to be new questions, perhaps we
can spend a bit more time to have people's concerns addressed and then
resume the voting.
Joe,
Do you still have concerns given the
24 matches
Mail list logo
