Re: Review Request 33620: Patch for KAFKA-1690

2015-05-11 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/ --- (Updated May 11, 2015, 6:31 a.m.) Review request for kafka. Bugs: KAFKA-1690

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

2015-05-11 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537641#comment-14537641 ] Sriharsha Chintalapani commented on KAFKA-1690: --- Updated reviewboard

[jira] [Updated] (KAFKA-1690) new java producer needs ssl support as a client

2015-05-11 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1690: -- Attachment: KAFKA-1690_2015-05-10_23:20:30.patch new java producer needs ssl

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

2015-05-11 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537633#comment-14537633 ] Sriharsha Chintalapani commented on KAFKA-1690: --- Updated reviewboard

Re: Review Request 33620: Patch for KAFKA-1690

2015-05-11 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/ --- (Updated May 11, 2015, 6:20 a.m.) Review request for kafka. Bugs: KAFKA-1690

[jira] [Issue Comment Deleted] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Comment: was deleted (was: Created reviewboard against branch origin/trunk) Improve consumer

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150511_AddTestcases.patch Improve consumer read performance for Windows

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150422.patch) Improve consumer read performance for Windows

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537786#comment-14537786 ] Honghai Chen commented on KAFKA-1646: - Add test cases

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150422.patch) Improve consumer read performance for Windows

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150422.patch Improve consumer read performance for Windows

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150511_AddTestcases.patch Improve consumer read performance for Windows

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537793#comment-14537793 ] Honghai Chen commented on KAFKA-1646: - Created reviewboard against branch

[jira] [Issue Comment Deleted] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Comment: was deleted (was: Created reviewboard against branch origin/trunk) Improve consumer

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150511_AddTestcases.patch) Improve consumer read performance

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150511_AddTestcases.patch Improve consumer read performance for Windows

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537791#comment-14537791 ] Honghai Chen commented on KAFKA-1646: - Created reviewboard against branch

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150511_AddTestcases.patch) Improve consumer read performance

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537796#comment-14537796 ] Honghai Chen commented on KAFKA-1646: - Created reviewboard against branch

[jira] [Issue Comment Deleted] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Comment: was deleted (was: Created reviewboard against branch origin/trunk) Improve consumer

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150414_184503.patch) Improve consumer read performance for

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150414_035415.patch) Improve consumer read performance for

Re: Review Request 33204: Patch for KAFKA-1646 add test cases

2015-05-11 Thread Honghai Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/ --- (Updated May 11, 2015, 10 a.m.) Review request for kafka. Summary (updated)

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150312_200352.patch) Improve consumer read performance for

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646.patch) Improve consumer read performance for Windows

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537787#comment-14537787 ] Honghai Chen commented on KAFKA-1646: - Created reviewboard against branch

[jira] [Issue Comment Deleted] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Comment: was deleted (was: Created reviewboard against branch origin/trunk) Improve consumer

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150511_AddTestcases.patch) Improve consumer read performance

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150511_AddTestcases.patch Improve consumer read performance for Windows

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2015-05-11 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537798#comment-14537798 ] Honghai Chen commented on KAFKA-1646: - Created reviewboard against branch

[jira] [Updated] (KAFKA-1977) Make logEndOffset available in the Zookeeper consumer

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1977: --- Status: In Progress (was: Patch Available) [~willf], thanks for the patch. This is a useful feature to add.

[jira] [Updated] (KAFKA-2184) ConsumerConfig does not honor default java.util.Properties

2015-05-11 Thread Jason Whaley (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Whaley updated KAFKA-2184: Description: When creating a ConsumerConfig from java.util.Properties, an IllegalArgumentException

Re: Review Request 33916: Patch for KAFKA-2163

2015-05-11 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33916/#review83264 --- Ship it! Thanks for the patch. Looks good. Just a couple of minor

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-11 Thread Jay Kreps
I totally agree that ZK is not in-and-of-itself a configuration management solution and it would be better if we could just keep all our config in files. Anyone who has followed the various config discussions over the past few years of discussion knows I'm the biggest proponent of immutable

[jira] [Updated] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-2169: Attachment: KAFKA-2169.patch Upgrade to zkclient-0.5 ---

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538376#comment-14538376 ] Parth Brahmbhatt commented on KAFKA-2169: - Created reviewboard

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538709#comment-14538709 ] Jun Rao commented on KAFKA-2169: Parth, 1. Have you done the api compatibility test? 3.

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538713#comment-14538713 ] Parth Brahmbhatt commented on KAFKA-2169: - [~junrao] 1) Yes I tested with 0.8.2

Re: Review Request 34050: Patch for KAFKA-2169

2015-05-11 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34050/#review83286 ---

Re: Review Request 34050: Patch for KAFKA-2169

2015-05-11 Thread Jun Rao
On May 11, 2015, 8:25 p.m., Jun Rao wrote: core/src/main/scala/kafka/controller/KafkaController.scala, lines 1116-1120 https://reviews.apache.org/r/34050/diff/1/?file=955526#file955526line1116 We register two StateListeners on the same zkclient instance in the broker. If we can't

[jira] [Updated] (KAFKA-2136) Client side protocol changes to return quota delays

2015-05-11 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2136: - Attachment: KAFKA-2136_2015-05-11_14:50:56.patch Client side protocol changes to return

[jira] [Updated] (KAFKA-2185) Update to Gradle 2.4

2015-05-11 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2185: --- Assignee: (was: Ismael Juma) Update to Gradle 2.4 Key:

[jira] [Updated] (KAFKA-2185) Update to Gradle 2.4

2015-05-11 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2185: --- Attachment: KAFKA-2185.patch Update to Gradle 2.4 Key:

[jira] [Commented] (KAFKA-2185) Update to Gradle 2.4

2015-05-11 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538544#comment-14538544 ] Ismael Juma commented on KAFKA-2185: Updated reviewboard

Re: Review Request 34056: Patch for KAFKA-2185

2015-05-11 Thread Ismael Juma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34056/ --- (Updated May 11, 2015, 8:02 p.m.) Review request for kafka. Bugs: KAFKA-2185

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-11 Thread Gwen Shapira
What Todd said :) (I think my ops background is showing...) On Mon, May 11, 2015 at 10:17 PM, Todd Palino tpal...@gmail.com wrote: I understand your point here, Jay, but I disagree that we can't have two configuration systems. We have two different types of configuration information. We have

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-11 Thread Gwen Shapira
Hi Jay, I don't say we can't get rid of configuration file, I believe we can - it is just a lot of work and not a good idea IMO. I think the analogy to normal unix services stands. MySQL and Postgres use configuration files. I think there two topics here: 1. Configuring dynamically created

Re: Review Request 34050: Patch for KAFKA-2169

2015-05-11 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34050/#review83278 --- Thanks for the patch. A couple of comments blow.

Re: Review Request 34050: Patch for KAFKA-2169

2015-05-11 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34050/ --- (Updated May 11, 2015, 8:53 p.m.) Review request for kafka. Bugs: KAFKA-2169

[jira] [Updated] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-2169: Attachment: KAFKA-2169_2015-05-11_13:52:57.patch Upgrade to zkclient-0.5

[jira] [Updated] (KAFKA-2185) Update to Gradle 2.4

2015-05-11 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2185: --- Attachment: KAFKA-2185_2015-05-11_20:55:08.patch Update to Gradle 2.4

Re: Review Request 34056: Patch for KAFKA-2185

2015-05-11 Thread Ismael Juma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34056/ --- (Updated May 11, 2015, 7:55 p.m.) Review request for kafka. Bugs: KAFKA-2185

[jira] [Updated] (KAFKA-2185) Update to Gradle 2.4

2015-05-11 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2185: --- Attachment: (was: KAFKA-2185.patch) Update to Gradle 2.4

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538629#comment-14538629 ] Parth Brahmbhatt commented on KAFKA-2169: - Updated reviewboard

[jira] [Created] (KAFKA-2185) Update to Gradle 2.4

2015-05-11 Thread Ismael Juma (JIRA)
Ismael Juma created KAFKA-2185: -- Summary: Update to Gradle 2.4 Key: KAFKA-2185 URL: https://issues.apache.org/jira/browse/KAFKA-2185 Project: Kafka Issue Type: Improvement Components:

[jira] [Commented] (KAFKA-2185) Update to Gradle 2.4

2015-05-11 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538537#comment-14538537 ] Ismael Juma commented on KAFKA-2185: Created reviewboard

[jira] [Updated] (KAFKA-2185) Update to Gradle 2.4

2015-05-11 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2185: --- Status: Patch Available (was: Open) Update to Gradle 2.4

Review Request 34056: Patch for KAFKA-2185

2015-05-11 Thread Ismael Juma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34056/ --- Review request for kafka. Bugs: KAFKA-2185

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538592#comment-14538592 ] Jun Rao commented on KAFKA-2169: 1) By api compatibility, I meant the following. Let's say

[jira] [Created] (KAFKA-2186) Follow-up patch of KAFKA-1650

2015-05-11 Thread Jiangjie Qin (JIRA)
Jiangjie Qin created KAFKA-2186: --- Summary: Follow-up patch of KAFKA-1650 Key: KAFKA-2186 URL: https://issues.apache.org/jira/browse/KAFKA-2186 Project: Kafka Issue Type: Bug

RE: [DISCUSS] KIP-21 Configuration Management

2015-05-11 Thread Aditya Auradkar
I did initially think having everything in ZK was better than having the dichotomy Joel referred to primarily because all kafka configs can be managed consistently. I guess the biggest disadvantage of driving broker config primarily from ZK is that it requires everyone to manage Kafka

Re: Review Request 33378: Patch for KAFKA-2136

2015-05-11 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/ --- (Updated May 11, 2015, 9:51 p.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Commented] (KAFKA-2136) Client side protocol changes to return quota delays

2015-05-11 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538703#comment-14538703 ] Aditya A Auradkar commented on KAFKA-2136: -- Updated reviewboard

[jira] [Updated] (KAFKA-2186) Follow-up patch of KAFKA-1650

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2186: --- Reviewer: Joel Koshy Follow-up patch of KAFKA-1650 - Key:

[jira] [Updated] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2169: --- Reviewer: Jun Rao Upgrade to zkclient-0.5 --- Key: KAFKA-2169

[jira] [Updated] (KAFKA-2185) Update to Gradle 2.4

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2185: --- Reviewer: Jun Rao Assignee: Ismael Juma Update to Gradle 2.4

[jira] [Updated] (KAFKA-2132) Move Log4J appender to clients module

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2132: --- Reviewer: Jay Kreps (was: Gwen Shapira) Move Log4J appender to clients module

[jira] [Updated] (KAFKA-2163) Offsets manager cache should prevent stale-offset-cleanup while an offset load is in progress; otherwise we can lose consumer offsets

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2163: --- Reviewer: Jun Rao Offsets manager cache should prevent stale-offset-cleanup while an offset load is in

[jira] [Updated] (KAFKA-2176) DefaultPartitioner doesn't perform consistent hashing based on

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2176: --- Reviewer: Guozhang Wang DefaultPartitioner doesn't perform consistent hashing based on

[jira] [Updated] (KAFKA-2178) Loss of highwatermarks on incorrect cluster shutdown/restart

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2178: --- Reviewer: Jun Rao Loss of highwatermarks on incorrect cluster shutdown/restart

Kafka KIP hangout May 12

2015-05-11 Thread Jun Rao
Hi, Everyone, We will have a KIP hangout at 11 PST on May 12. The following is the agenda. If you want to attend and is not on the invite, please let me know. Agenda: KIP-11 (authorization): any remaining issues KIP-12 (sasl/ssl authentication): status check KIP-19 (Add a request timeout to

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538900#comment-14538900 ] Jun Rao commented on KAFKA-1997: The reasoning is that there is no good default value to

Review Request 34047: Patch for KAFKA-2169

2015-05-11 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34047/ --- Review request for kafka. Bugs: KAFKA-2169

[jira] [Updated] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-2169: Attachment: KAFKA-2169.patch Upgrade to zkclient-0.5 ---

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538313#comment-14538313 ] Parth Brahmbhatt commented on KAFKA-2169: - Created reviewboard

[jira] [Updated] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-2169: Status: Patch Available (was: Open) Upgrade to zkclient-0.5 ---

Review Request 34050: Patch for KAFKA-2169

2015-05-11 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34050/ --- Review request for kafka. Bugs: KAFKA-2169

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538409#comment-14538409 ] Parth Brahmbhatt commented on KAFKA-2169: - Posted a review on review board.

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-11 Thread Joel Koshy
So the general concern here is the dichotomy of configs (which we already have - i.e., in the form of broker config files vs topic configs in zookeeper). We (at LinkedIn) had some discussions on this last week and had this very question for the operations team whose opinion is I think to a large

[jira] [Commented] (KAFKA-2150) FetcherThread backoff need to grab lock before wait on condition.

2015-05-11 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538994#comment-14538994 ] Guozhang Wang commented on KAFKA-2150: -- My bad on missing this but while reviewing.

Re: Review Request 33551: Patch for KAFKA-2150

2015-05-11 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33551/#review83332 --- Ship it! Ship It! - Guozhang Wang On April 25, 2015, 8:35 p.m.,

[jira] [Updated] (KAFKA-2150) FetcherThread backoff need to grab lock before wait on condition.

2015-05-11 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2150: - Resolution: Fixed Status: Resolved (was: Patch Available) FetcherThread backoff need to

Re: Review Request 33378: Patch for KAFKA-2136

2015-05-11 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/#review83341 --- core/src/main/scala/kafka/api/FetchResponse.scala

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-05-11 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538801#comment-14538801 ] Jiangjie Qin commented on KAFKA-1997: - Hey [~junrao], good point. I will do that when

Re: Review Request 33049: Patch for KAFKA-2084

2015-05-11 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated May 11, 2015, 11:16 p.m.) Review request for kafka, Joel Koshy and

[jira] [Commented] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

2015-05-11 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538850#comment-14538850 ] Aditya A Auradkar commented on KAFKA-2084: -- Updated reviewboard

[jira] [Updated] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

2015-05-11 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2084: - Attachment: KAFKA-2084_2015-05-11_16:16:01.patch byte rate metrics per client ID

Re: Review Request 33620: Patch for KAFKA-1690

2015-05-11 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/ --- (Updated May 11, 2015, 11:09 p.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

2015-05-11 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538838#comment-14538838 ] Sriharsha Chintalapani commented on KAFKA-1690: --- Updated reviewboard

[jira] [Updated] (KAFKA-1690) new java producer needs ssl support as a client

2015-05-11 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1690: -- Attachment: KAFKA-1690_2015-05-11_16:09:36.patch new java producer needs ssl

Re: Review Request 33049: Patch for KAFKA-2084

2015-05-11 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated May 11, 2015, 11:17 p.m.) Review request for kafka, Joel Koshy and

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538762#comment-14538762 ] Jun Rao commented on KAFKA-1997: A late comment: shouldn't we hardcode the key/value

[jira] [Updated] (KAFKA-2103) kafka.producer.AsyncProducerTest failure.

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2103: --- Reviewer: Jun Rao kafka.producer.AsyncProducerTest failure. -

[jira] [Assigned] (KAFKA-2167) ZkUtils updateEphemeralPath JavaDoc (spelling and correctness)

2015-05-11 Thread Neelesh Srinivas Salian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned KAFKA-2167: -- Assignee: Neelesh Srinivas Salian ZkUtils updateEphemeralPath JavaDoc

[GitHub] kafka pull request: Corrected the Changes in ZkUtils.scala - KAFKA...

2015-05-11 Thread neeleshCloud
GitHub user neeleshCloud opened a pull request: https://github.com/apache/kafka/pull/63 Corrected the Changes in ZkUtils.scala - KAFKA-2167 Corrected Spelling errors. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (KAFKA-2167) ZkUtils updateEphemeralPath JavaDoc (spelling and correctness)

2015-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539267#comment-14539267 ] ASF GitHub Bot commented on KAFKA-2167: --- GitHub user neeleshCloud opened a pull

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-11 Thread Ashish Singh
I agree with the Joel's suggestion on keeping broker's configs in config file and clients/topics config in ZK. Few other projects, Apache Solr for one, also does something similar for its configurations. On Monday, May 11, 2015, Gwen Shapira gshap...@cloudera.com wrote: I like this approach

[jira] [Commented] (KAFKA-2175) Reduce server log verbosity at info level

2015-05-11 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539293#comment-14539293 ] Gwen Shapira commented on KAFKA-2175: - Non-binding +1. Probably the most useful

[jira] [Updated] (KAFKA-2175) Reduce server log verbosity at info level

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2175: --- Reviewer: Joel Koshy Reduce server log verbosity at info level -

[jira] [Updated] (KAFKA-2174) Wrong TopicMetadata deserialization

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2174: --- Reviewer: Jun Rao Wrong TopicMetadata deserialization ---

  1   2   >