Re: [DISCUSS] Add missing API to old high level consumer

I peeked at the Java producer SSL changes, haven't tried it yet though. I can see about getting a Go version to help testing compatibility done in the next few weeks. I still don't understand the Auth pieces, I haven't been able to make the KIP lately I need to try to attend like every other or so

Re: [DISCUSS] Add missing API to old high level consumer

Makes sense, thanks! When we added Authz to Sqoop, we tested with "mock" authorizers that would either allow everything or deny everything and would log every call. Perhaps this will make sense for Kafka too. Parth has the patch up, so we can see how he tested it. Gwen On Fri, May 15, 2015 at 10

Re: Review Request 33065: Patch for KAFKA-1928

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33065/ --- (Updated May 15, 2015, 7:30 a.m.) Review request for kafka. Bugs: 1928 and KA

[jira] [Updated] (KAFKA-1928) Move kafka.network over to using the network classes in org.apache.kafka.common.network

[ https://issues.apache.org/jira/browse/KAFKA-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1928: Attachment: KAFKA-1928_2015-05-15_10:30:31.patch > Move kafka.network over to using the network clas

[jira] [Commented] (KAFKA-1928) Move kafka.network over to using the network classes in org.apache.kafka.common.network

[ https://issues.apache.org/jira/browse/KAFKA-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545084#comment-14545084 ] Gwen Shapira commented on KAFKA-1928: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 33620: Patch for KAFKA-1690

> On May 14, 2015, 10:21 a.m., Rajini Sivaram wrote: > > clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java, > > line 190 > > > > > > I think when delegated tasks are run asynchronously, sele

Re: [Discussion] Using Client Requests and Responses in Server

Gwen, I didn't find this in answers above so apologies if this was discussed. It's about the way we would like to handle request versions. As I understood from Jun's answer we generally should try using the same java object while evolving the request. I believe the only example of evolved request

[jira] [Created] (KAFKA-2194) Produce request failure after Kafka + Zookeeper restart

Ian Morgan created KAFKA-2194: - Summary: Produce request failure after Kafka + Zookeeper restart Key: KAFKA-2194 URL: https://issues.apache.org/jira/browse/KAFKA-2194 Project: Kafka Issue Type: B

[jira] [Updated] (KAFKA-2194) Produce request failure after Kafka + Zookeeper restart

[ https://issues.apache.org/jira/browse/KAFKA-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Morgan updated KAFKA-2194: -- Description: Trying to separate out Kafka-logs and Zookeeper data from the primary kafka folder, so tha

Re: [Discussion] Using Client Requests and Responses in Server

I agree, we currently don't handle versions correctly when de-serializing into java objects. This will be an isssue for every req/resp we move to use the java objects. It looks like this requires: 1. Add versionId parameter to all parse functions in Java req/resp objects 2. Modify getRequest to pa

Re: [Discussion] Using Client Requests and Responses in Server

Correct, I think we are on the same page. This way we can fix RequestChannel part (where it uses AbstractRequest.getRequest) But would it be okay to add versionId to AbstractRequest.getErrorResponse signature too? I'm a bit lost with all those Abstract... objects hierarchy and not sure whether it'

Re: [Discussion] Using Client Requests and Responses in Server

Agree that you need version in getErrorResponse too (so you'll get the correct error), which means you'll need to add versionId to constructors of every response object... You'll want to keep two interfaces, one with version and one with CURR_VERSION as default, so you won't need to modify every s

Re: [Discussion] Using Client Requests and Responses in Server

Okay, I can pick that. I'll create sub-task under KAFKA-2044. Thanks, Andrii Biletskyi On Fri, May 15, 2015 at 4:27 PM, Gwen Shapira wrote: > Agree that you need version in getErrorResponse too (so you'll get the > correct error), which means you'll need to add versionId to constructors of > ev

[jira] [Created] (KAFKA-2195) Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest

Andrii Biletskyi created KAFKA-2195: --- Summary: Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest Key: KAFKA-2195 URL: https://issues.apache.org/jira/browse/KAFKA-2195

Re: Review Request 33620: Patch for KAFKA-1690

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/ --- (Updated May 15, 2015, 2:18 p.m.) Review request for kafka. Bugs: KAFKA-1690

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545554#comment-14545554 ] Sriharsha Chintalapani commented on KAFKA-1690: --- Updated reviewboard https:/

[jira] [Updated] (KAFKA-1690) new java producer needs ssl support as a client

[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1690: -- Attachment: KAFKA-1690_2015-05-15_07:18:21.patch > new java producer needs ssl s

[jira] [Updated] (KAFKA-1690) new java producer needs ssl support as a client

[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1690: -- Status: Patch Available (was: In Progress) > new java producer needs ssl suppor

Re: Review Request 33620: Patch for KAFKA-1690

> On May 13, 2015, 3:40 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/network/Channel.java, lines > > 70-71 > > > > > > This is a general question. For ssl and sasl, does authentication only >

[GitHub] kafka pull request: validate configuration while parsing ConfigDef

GitHub user gprabhat90 opened a pull request: https://github.com/apache/kafka/pull/66 validate configuration while parsing ConfigDef In java client, configDef class's parse() function should return parsed and validated values (if validator is present) but it does not validate the c

[jira] [Created] (KAFKA-2196) remove roundrobin identical topic constraint in consumer coordinator

Onur Karaman created KAFKA-2196: --- Summary: remove roundrobin identical topic constraint in consumer coordinator Key: KAFKA-2196 URL: https://issues.apache.org/jira/browse/KAFKA-2196 Project: Kafka

[jira] [Commented] (KAFKA-2196) remove roundrobin identical topic constraint in consumer coordinator

[ https://issues.apache.org/jira/browse/KAFKA-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545688#comment-14545688 ] Onur Karaman commented on KAFKA-2196: - Created reviewboard https://reviews.apache.org/

Review Request 34273: remove roundrobin identical topic constraint in consumer coordinator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34273/ --- Review request for kafka. Bugs: KAFKA-2196 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2196) remove roundrobin identical topic constraint in consumer coordinator

[ https://issues.apache.org/jira/browse/KAFKA-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Onur Karaman updated KAFKA-2196: Attachment: KAFKA-2196.patch > remove roundrobin identical topic constraint in consumer coordinator

[jira] [Updated] (KAFKA-2196) remove roundrobin identical topic constraint in consumer coordinator

[ https://issues.apache.org/jira/browse/KAFKA-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Onur Karaman updated KAFKA-2196: Status: Patch Available (was: Open) > remove roundrobin identical topic constraint in consumer coor

[jira] [Created] (KAFKA-2197) Controller not able to update state for broker on the same machine

Ben Edwards created KAFKA-2197: -- Summary: Controller not able to update state for broker on the same machine Key: KAFKA-2197 URL: https://issues.apache.org/jira/browse/KAFKA-2197 Project: Kafka

[jira] [Updated] (KAFKA-2197) Controller not able to update state for broker on the same machine

[ https://issues.apache.org/jira/browse/KAFKA-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Edwards updated KAFKA-2197: --- Description: I am using kafka on docker. When I try to create a topic the controller seems to get stu

[jira] [Updated] (KAFKA-2197) Controller not able to update state for broker on the same machine

[ https://issues.apache.org/jira/browse/KAFKA-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Edwards updated KAFKA-2197: --- Attachment: docker-compose.yml > Controller not able to update state for broker on the same machine >

[Vote] KIP-11 Authorization design for kafka security

Hi, Opening the voting thread for KIP-11. Link to the KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-11+-+Authorization+Interface Link to Jira: https://issues.apache.org/jira/browse/KAFKA-1688 Thanks Parth

[jira] [Updated] (KAFKA-2197) Controller not able to update state for broker on the same machine

[ https://issues.apache.org/jira/browse/KAFKA-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Edwards updated KAFKA-2197: --- Attachment: docker-compose-stripped.yml > Controller not able to update state for broker on the same m

[jira] [Updated] (KAFKA-2197) Controller not able to update state for broker on the same machine

[ https://issues.apache.org/jira/browse/KAFKA-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Edwards updated KAFKA-2197: --- Attachment: (was: docker-compose.yml) > Controller not able to update state for broker on the same

[jira] [Updated] (KAFKA-2197) Controller not able to update state for broker on the same machine

[ https://issues.apache.org/jira/browse/KAFKA-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2197: - Assignee: (was: Neha Narkhede) > Controller not able to update state for broker on the same ma

[jira] [Commented] (KAFKA-2197) Controller not able to update state for broker on the same machine

[ https://issues.apache.org/jira/browse/KAFKA-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545751#comment-14545751 ] Neha Narkhede commented on KAFKA-2197: -- [~bedwards] Unassigning myself as I probably

[jira] [Commented] (KAFKA-2197) Controller not able to update state for broker on the same machine

[ https://issues.apache.org/jira/browse/KAFKA-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545753#comment-14545753 ] Ben Edwards commented on KAFKA-2197: I tried the mailing list, but I will try again! D

[jira] [Updated] (KAFKA-2197) Controller not able to update state for broker on the same machine

[ https://issues.apache.org/jira/browse/KAFKA-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Edwards updated KAFKA-2197: --- Description: I am using kafka on docker. When I try to create a topic the controller seems to get stu

[jira] [Resolved] (KAFKA-2197) Controller not able to update state for broker on the same machine

[ https://issues.apache.org/jira/browse/KAFKA-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Edwards resolved KAFKA-2197. Resolution: Not A Problem > Controller not able to update state for broker on the same machine > ---

[jira] [Commented] (KAFKA-2197) Controller not able to update state for broker on the same machine

[ https://issues.apache.org/jira/browse/KAFKA-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545798#comment-14545798 ] Ben Edwards commented on KAFKA-2197: Closing: the issue is that while zookeeper can se

Re: Review Request 34050: Patch for KAFKA-2169

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34050/ --- (Updated May 15, 2015, 5:19 p.m.) Review request for kafka. Bugs: KAFKA-2169

[jira] [Updated] (KAFKA-2169) Upgrade to zkclient-0.5

[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-2169: Attachment: KAFKA-2169_2015-05-15_10:18:41.patch > Upgrade to zkclient-0.5 > ---

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545814#comment-14545814 ] Parth Brahmbhatt commented on KAFKA-2169: - Updated reviewboard https://reviews.apa

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545817#comment-14545817 ] Parth Brahmbhatt commented on KAFKA-2169: - [~junrao] updated the review with chang

[jira] [Commented] (KAFKA-2073) Replace TopicMetadata request/response with o.a.k.requests.metadata

[ https://issues.apache.org/jira/browse/KAFKA-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545841#comment-14545841 ] Andrii Biletskyi commented on KAFKA-2073: - [~sriharsha] is there any update on thi

Re: Review Request 34170: Patch for KAFKA-2191

> On May 13, 2015, 11:50 p.m., Aditya Auradkar wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java, > > line 45 > > > > > > I think this is a good catch. > > > > Just so I u

[jira] [Commented] (KAFKA-2194) Produce request failure after Kafka + Zookeeper restart

[ https://issues.apache.org/jira/browse/KAFKA-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545873#comment-14545873 ] Jiangjie Qin commented on KAFKA-2194: - Any reason to start Kafka before starting ZK?

Review Request 34283: Third Attempt: use a global read-write lock in purgatory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34283/ --- Review request for kafka. Bugs: KAFKA-2160 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2160) DelayedOperationPurgatory should remove the pair in watchersForKey with empty watchers list

[ https://issues.apache.org/jira/browse/KAFKA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2160: - Attachment: KAFKA-2160.patch > DelayedOperationPurgatory should remove the pair in watchersForKey

[jira] [Commented] (KAFKA-2160) DelayedOperationPurgatory should remove the pair in watchersForKey with empty watchers list

[ https://issues.apache.org/jira/browse/KAFKA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545905#comment-14545905 ] Guozhang Wang commented on KAFKA-2160: -- Created reviewboard https://reviews.apache.or

Re: [Vote] KIP-11 Authorization design for kafka security

+1 non-binding On Fri, May 15, 2015 at 9:18 AM -0700, "Parth Brahmbhatt" wrote: Hi, Opening the voting thread for KIP-11. Link to the KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-11+-+Authorization+Interface Link to Jira: https://issues.apache.org/jira/browse/KAFK

[jira] [Commented] (KAFKA-2073) Replace TopicMetadata request/response with o.a.k.requests.metadata

[ https://issues.apache.org/jira/browse/KAFKA-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545943#comment-14545943 ] Sriharsha Chintalapani commented on KAFKA-2073: --- [~abiletskyi] Please take i

Re: [Vote] KIP-11 Authorization design for kafka security

+1 non-binding On Fri, May 15, 2015 at 9:12 PM, Harsha wrote: > +1 non-binding > > > > > > > On Fri, May 15, 2015 at 9:18 AM -0700, "Parth Brahmbhatt" < > pbrahmbh...@hortonworks.com> wrote: > > > > > > > > > > > Hi, > > Opening the voting thread for KIP-11. > > Link to the KIP: > https://cwiki.

Re: [Vote] KIP-11 Authorization design for kafka security

+1 non-binding On 5/15/15, 11:43 AM, "Gwen Shapira" wrote: >+1 non-binding > >On Fri, May 15, 2015 at 9:12 PM, Harsha wrote: > >> +1 non-binding >> >> >> >> >> >> >> On Fri, May 15, 2015 at 9:18 AM -0700, "Parth Brahmbhatt" < >> pbrahmbh...@hortonworks.com> wrote: >> >> >> >> >> >> >> >> >> >>

[jira] [Assigned] (KAFKA-2073) Replace TopicMetadata request/response with o.a.k.requests.metadata

[ https://issues.apache.org/jira/browse/KAFKA-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi reassigned KAFKA-2073: --- Assignee: Andrii Biletskyi (was: Sriharsha Chintalapani) > Replace TopicMetadata req

[jira] [Updated] (KAFKA-2147) Unbalanced replication can cause extreme purgatory growth

[ https://issues.apache.org/jira/browse/KAFKA-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Huus updated KAFKA-2147: - Attachment: purgatory.log Purgatory log from the attached patch. Based on my understanding, the check is

Re: [Vote] KIP-11 Authorization design for kafka security

+1 non-binding. Tom Graves On Friday, May 15, 2015 2:00 PM, Don Bosco Durai wrote: +1 non-binding On 5/15/15, 11:43 AM, "Gwen Shapira" wrote: >+1 non-binding > >On Fri, May 15, 2015 at 9:12 PM, Harsha wrote: > >> +1 non-binding >> >> >> >> >> >> >> On Fri, May 15, 2015 at 9:18 A

RE: [DISCUSS] KIP-21 Configuration Management

Updated the wiki to capture our recent discussions. Please read. https://cwiki.apache.org/confluence/display/KAFKA/KIP-21+-+Dynamic+Configuration Thanks, Aditya From: Joel Koshy [jjkosh...@gmail.com] Sent: Tuesday, May 12, 2015 1:09 PM To: dev@kafka.apache

Re: [DISCUSS] KIP-21 Configuration Management

The wiki says: "There will be 3 paths within config /config/clients/ /config/topics/ /config/brokers/ Didn't we decide that brokers will not be configured dynamically, rather we will keep the config in the file? On Fri, May 15, 2015 at 10:46 PM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wr

RE: [DISCUSS] KIP-21 Configuration Management

Yes we did. I just overlooked that line.. cleaning it up now. Aditya From: Gwen Shapira [gshap...@cloudera.com] Sent: Friday, May 15, 2015 12:55 PM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management The wiki says: "There will

Re: Review Request 33620: Patch for KAFKA-1690

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/#review83807 --- clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.

Re: Review Request 34170: Patch for KAFKA-2191

> On May 13, 2015, 11:50 p.m., Aditya Auradkar wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java, > > line 45 > > > > > > I think this is a good catch. > > > > Just so I u

Re: [Vote] KIP-11 Authorization design for kafka security

+1 -Jay On Fri, May 15, 2015 at 9:18 AM, Parth Brahmbhatt < pbrahmbh...@hortonworks.com> wrote: > Hi, > > Opening the voting thread for KIP-11. > > Link to the KIP: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-11+-+Authorization+Interface > Link to Jira: https://issues.apache.org/jira

Re: Review Request 33620: Patch for KAFKA-1690

> On May 15, 2015, 8:26 p.m., Michael Herstine wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java, > > line 295 > > > > > > Pursuant to my last comment-- what exactly does this conf

Re: Review Request 34170: Patch for KAFKA-2191

> On May 13, 2015, 11:50 p.m., Aditya Auradkar wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java, > > line 45 > > > > > > I think this is a good catch. > > > > Just so I u

Re: [DISCUSS] KIP-19 Add a request timeout to NetworkClient

I modified the WIKI page to incorporate the feedbacks from mailing list and KIP hangout. - Added the deprecation plan for TIMEOUT_CONFIG - Added the actions to take after request timeout I finally chose to create a new connection if requests timeout. The reason is: 1. In most cases, if a broker i

Re: Review Request 33620: Patch for KAFKA-1690

> On May 15, 2015, 8:26 p.m., Michael Herstine wrote: > > clients/src/main/java/org/apache/kafka/common/network/TransportLayer.java, > > line 34 > > > > > > This is probably just my ignorance of the Kafka codebase, but

Re: Review Request 33620: Patch for KAFKA-1690

> On May 15, 2015, 8:26 p.m., Michael Herstine wrote: > > clients/src/main/java/org/apache/kafka/common/security/auth/PrincipalBuilder.java, > > line 29 > > > > > > Will it be "pluggable"; i.e. can individual sites pro

Re: Review Request 33065: Patch for KAFKA-1928

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33065/#review83959 --- Thanks for the patch. There seem to be some compilation errors. Perh

[jira] [Commented] (KAFKA-2160) DelayedOperationPurgatory should remove the pair in watchersForKey with empty watchers list

[ https://issues.apache.org/jira/browse/KAFKA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546287#comment-14546287 ] Guozhang Wang commented on KAFKA-2160: -- Ran kafka.TestPurgatoryPerformance to compare

[jira] [Comment Edited] (KAFKA-2160) DelayedOperationPurgatory should remove the pair in watchersForKey with empty watchers list

[ https://issues.apache.org/jira/browse/KAFKA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546287#comment-14546287 ] Guozhang Wang edited comment on KAFKA-2160 at 5/15/15 10:27 PM:

[jira] [Commented] (KAFKA-2160) DelayedOperationPurgatory should remove the pair in watchersForKey with empty watchers list

[ https://issues.apache.org/jira/browse/KAFKA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546290#comment-14546290 ] Guozhang Wang commented on KAFKA-2160: -- [~junrao][~jjkoshy] Could you take a look at

[jira] [Commented] (KAFKA-2160) DelayedOperationPurgatory should remove the pair in watchersForKey with empty watchers list

[ https://issues.apache.org/jira/browse/KAFKA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546320#comment-14546320 ] Joel Koshy commented on KAFKA-2160: --- I would be surprised if the global RW lock is a pro

Re: [DISCUSS] KIP-19 Add a request timeout to NetworkClient

+1 on creating a new connection. So from what I understand the request timeout should be greater than the replication timeout in any case. If the broker is slow or not responding and the request times out we will treat it as we treat disconnections and update metadata try sending it to new leader

Re: Review Request 33620: Patch for KAFKA-1690

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/#review83993 --- clients/src/main/java/org/apache/kafka/common/network/SSLTransportL

Re: Review Request 34125: Patch for KAFKA-2147

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34125/ --- (Updated May 15, 2015, 11:14 p.m.) Review request for kafka. Bugs: KAFKA-2147

[jira] [Commented] (KAFKA-2147) Unbalanced replication can cause extreme purgatory growth

[ https://issues.apache.org/jira/browse/KAFKA-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546355#comment-14546355 ] Jun Rao commented on KAFKA-2147: Updated reviewboard https://reviews.apache.org/r/34125/di

[jira] [Updated] (KAFKA-2147) Unbalanced replication can cause extreme purgatory growth

[ https://issues.apache.org/jira/browse/KAFKA-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2147: --- Attachment: KAFKA-2147_2015-05-15_16:14:44.patch > Unbalanced replication can cause extreme purgatory growth >

[jira] [Commented] (KAFKA-2147) Unbalanced replication can cause extreme purgatory growth

[ https://issues.apache.org/jira/browse/KAFKA-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546356#comment-14546356 ] Jun Rao commented on KAFKA-2147: Interesting, looking at the code again, it seems that the

Re: [Vote] KIP-11 Authorization design for kafka security

+1 Thanks, Jun On Fri, May 15, 2015 at 9:18 AM, Parth Brahmbhatt < pbrahmbh...@hortonworks.com> wrote: > Hi, > > Opening the voting thread for KIP-11. > > Link to the KIP: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-11+-+Authorization+Interface > Link to Jira: https://issues.apache.

Re: [DISCUSS] KIP-21 Configuration Management

Aditya, In the following, we should encode the config properties as a json map to be consistent with topic config. "Internally, the znodes are comma-separated key-value pairs where key represents the configuration property to change. {"version": x, "config" : {X1=Y1, X2=Y2..}}" Thanks, Jun On

Re: Review Request 33620: Patch for KAFKA-1690

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/#review83998 --- Few more minor comments. General comment on javadocs: although this

Re: [DISCUSS] Add missing API to old high level consumer

Hi, Jiangjie, It seems that api is already in kafka.javaapi.consumer.ZookeeperConsumerConnector. We just need to add it to kafka.javaapi.consumer.ConsumerConnector. This is fine and I don't think we need a KIP. Since this is only added in trunk, it will be part of the 0.8.3 release. I agree with J

Re: Review Request 33620: Patch for KAFKA-1690

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/#review84006 --- clients/src/main/java/org/apache/kafka/common/network/SSLTransportL

Re: Review Request 33620: Patch for KAFKA-1690

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/#review84012 --- clients/src/main/java/org/apache/kafka/common/network/SSLTransportL

Re: Review Request 33620: Patch for KAFKA-1690

> On May 15, 2015, 10:54 p.m., Joel Koshy wrote: > > clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java, > > line 153 > > > > > > I think Michael meant the following which I think is valid ri

Re: Review Request 33620: Patch for KAFKA-1690

> On May 16, 2015, 12:07 a.m., Joel Koshy wrote: > > clients/src/main/java/org/apache/kafka/common/network/SSLChannelBuilder.java, > > line 35 > > > > > > Can we just use a fixed thread pool? > > > > A more ge

Re: [DISCUSS] Add missing API to old high level consumer

Sounds good. Thanks, Jun. Jiangjie (Becket) Qin On 5/15/15, 5:21 PM, "Jun Rao" wrote: >Hi, Jiangjie, > >It seems that api is already in >kafka.javaapi.consumer.ZookeeperConsumerConnector. We just need to add it >to kafka.javaapi.consumer.ConsumerConnector. This is fine and I don't >think >we ne

Re: Review Request 34241: Patch for KAFKA-2190

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34241/ --- (Updated May 16, 2015, 2:50 a.m.) Review request for kafka. Bugs: KAFKA-2190

[jira] [Commented] (KAFKA-2190) Incorporate close(timeout) to Mirror Maker

[ https://issues.apache.org/jira/browse/KAFKA-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546524#comment-14546524 ] Jiangjie Qin commented on KAFKA-2190: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-2190) Incorporate close(timeout) to Mirror Maker

[ https://issues.apache.org/jira/browse/KAFKA-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2190: Attachment: KAFKA-2190_2015-05-15_19:50:42.patch > Incorporate close(timeout) to Mirror Maker >

Re: Review Request 33049: Patch for KAFKA-2084

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/#review84025 --- core/src/main/scala/kafka/server/KafkaApis.scala