[jira] [Resolved] (KAFKA-6162) Stream Store tries to create directory with invalid name on Windows

2017-11-13 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-6162. Resolution: Duplicate > Stream Store tries to create directory with invalid name on Windows

Re: 答复: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-13 Thread Jun Rao
Hi, Hu, Currently, records-lag-max is an attribute for the mbean kafka.consumer:type=consumer-fetch-manager-metrics,client-id="{client-id}". So, it probably makes sense for records-lead-min to be an attribute under the same mbean. The partition level records-lead can probably be an attribute for

[jira] [Created] (KAFKA-6206) Kafka processes ignore read/write performance and reliability

2017-11-13 Thread Macoy Jones (JIRA)
Macoy Jones created KAFKA-6206: -- Summary: Kafka processes ignore read/write performance and reliability Key: KAFKA-6206 URL: https://issues.apache.org/jira/browse/KAFKA-6206 Project: Kafka Issu

答复: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-13 Thread Hu Xi
Jun, Thanks for the feedback. Some things need to make sure. Currently, these new-added metrics follow the exact naming convention with those 'lag' counterparts, as shown below: [cid:fcb78ea1-d9ac-48f4-a4ac-4fca7208af11] Consumer-level metric: records-lag-max ==> records-lead-min Partition-

[jira] [Resolved] (KAFKA-5254) rethink KTable API overloads

2017-11-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-5254. -- Resolution: Duplicate > rethink KTable API overloads > > >

Re: [DISCUSS] KIP-224: Add configuration parameters `retries` and `retry.backoff.ms` to Streams API

2017-11-13 Thread Guozhang Wang
Thanks Matthias. LGTM. On Mon, Nov 13, 2017 at 4:18 PM, Matthias J. Sax wrote: > I had a look into the code and here are my observations: > > 1) We use a hard coded retry of 5 for both (note, MAX is a final static > value in global state store). > > 2) We already have code in the main loop that

Re: [VOTE] KIP-224: Add configuration parameters `retries` to Streams API

2017-11-13 Thread Bill Bejeck
Thanks for the KIP, +1 -Bill On Mon, Nov 13, 2017 at 7:25 PM, Ted Yu wrote: > +1 > > On Mon, Nov 13, 2017 at 4:20 PM, Matthias J. Sax > wrote: > > > Hi @all, > > > > I would like to start the vote for KIP-224: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 224%3A+Add+config

Re: [VOTE] KIP-224: Add configuration parameters `retries` to Streams API

2017-11-13 Thread Ted Yu
+1 On Mon, Nov 13, 2017 at 4:20 PM, Matthias J. Sax wrote: > Hi @all, > > I would like to start the vote for KIP-224: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 224%3A+Add+configuration+parameter+%60retries%60+to+Streams+API > > > Thanks a lot! > > > -Matthias > >

[VOTE] KIP-224: Add configuration parameters `retries` to Streams API

2017-11-13 Thread Matthias J. Sax
Hi @all, I would like to start the vote for KIP-224: https://cwiki.apache.org/confluence/display/KAFKA/KIP-224%3A+Add+configuration+parameter+%60retries%60+to+Streams+API Thanks a lot! -Matthias signature.asc Description: OpenPGP digital signature

Re: [DISCUSS] KIP-224: Add configuration parameters `retries` and `retry.backoff.ms` to Streams API

2017-11-13 Thread Matthias J. Sax
I had a look into the code and here are my observations: 1) We use a hard coded retry of 5 for both (note, MAX is a final static value in global state store). 2) We already have code in the main loop that handles LockExceptions. 3) For a global store there is actually no lock contention as only

Re: [VOTE] KIP-204 : adding records deletion operation to the new Admin Client API

2017-11-13 Thread Ismael Juma
Looks good to me, one minor comment: I thought DeleteRecords should be DeletedRecords. That makes it clearer that it's the result of deleting in my opinion. Ismael On Mon, Nov 13, 2017 at 11:16 PM, Paolo Patierno wrote: > Guozhang thanks :-) > > > It's getting late in my timezone, so maybe it's

Re: [VOTE] KIP-204 : adding records deletion operation to the new Admin Client API

2017-11-13 Thread Paolo Patierno
Guozhang thanks :-) It's getting late in my timezone, so maybe it's better for me don't take a look at email anymore ;) So finally, the KIP-204 was accepted. Waiting for more comments (if needed) on the PR for getting it merged. Thanks, Paolo Patierno Senior Software Engineer (IoT) @ Red

Re: [VOTE] KIP-204 : adding records deletion operation to the new Admin Client API

2017-11-13 Thread Guozhang Wang
Paolo, I have indeed voted +1 on the KIP itself, but I thought you only have two binding +1s (Jason and myself); overlooked the vote from Damian and I was expecting Ismael to vote. So I think you are all good now :) Guozhang On Mon, Nov 13, 2017 at 3:08 PM, Paolo Patierno wrote: > Sorry Guo

Re: [VOTE] KIP-204 : adding records deletion operation to the new Admin Client API

2017-11-13 Thread Paolo Patierno
Sorry Guozhang ... reviewing the emails thread I have misunderstood your +1 which was not a vote but just about the wiki design. So the vote is still opened with 2 binding votes and 5 non binding votes. From: Guozhang Wang Sent: Monday, November 13, 2017 9:21:07

[jira] [Created] (KAFKA-6205) Have State Stores Restore Before Initializing Toplogy

2017-11-13 Thread Bill Bejeck (JIRA)
Bill Bejeck created KAFKA-6205: -- Summary: Have State Stores Restore Before Initializing Toplogy Key: KAFKA-6205 URL: https://issues.apache.org/jira/browse/KAFKA-6205 Project: Kafka Issue Type: I

Re: [VOTE] KIP-204 : adding records deletion operation to the new Admin Client API

2017-11-13 Thread Guozhang Wang
I'm not sure if Ismael's reply on the mailing list is a casted vote for this KIP. @Ismael, could you review the KIP again and cast your vote if possible? Guozhang On Mon, Nov 13, 2017 at 6:10 AM, Paolo Patierno wrote: > Hi all, > > I'm going to close this vote because this KIP was accepted w

Re: [VOTE] 0.11.0.2 RC0

2017-11-13 Thread Ted Yu
Understood. The test passed when run standalone. +1 from me. On Mon, Nov 13, 2017 at 1:19 AM, Rajini Sivaram wrote: > Hi Ted, > > Thank you for running the tests. As you have mentioned in KAFKA-4262, this > has been a known intermittent test failure. It has been difficult to make > integration

[GitHub] kafka pull request #4208: MINOR: Not enough replica exception should never h...

2017-11-13 Thread guozhangwang
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4208 MINOR: Not enough replica exception should never happen for delete records When reviewing https://github.com/apache/kafka/pull/4132, I felt that NOT_ENOUGH_REPLICAS should never happen actually

Re: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-13 Thread Jun Rao
Hi, Hu, Thanks for the KIP. Looks good overall. Could you document the mbean name for the new metrics? We probably want the name to be consistent with records-max-lag as described in http://kafka.apache.org/documentation/#monitoring. Also, it seems that records-lead-avg and records-lead-min don't

Re: [DISCUSS] KIP-209 Connection String Support

2017-11-13 Thread Clebert Suconic
It would work out. it's just a matter to find what's easier for users... a builder would work equally. I listed the rejected alternative in case the constructor wasn't accepted. I don't think it adds complexity. it's the same quite frankly. refactoring a method out to a builder of factory is a si

Re: [DISCUSS] KIP-209 Connection String Support

2017-11-13 Thread charly molter
Hi Clebert, You mention in rejected alternatives "builders" but you don't give a justification. Could you explain why a utility method or class doesn't work out? There's already 5 constructors in KafkaConsumer and I'm afraid this change would just make the API more complex. Thanks, Charly On M

Re: [DISCUSS] KIP-209 Connection String Support

2017-11-13 Thread Clebert Suconic
I was waiting for more input after my last update.. what should be done now? On Sat, Nov 4, 2017 at 2:19 PM, Clebert Suconic wrote: > I have updated KIP-209. > > > Determined the \", \\ and \; meanings > > Also introduced the possibility of using $ to translate as system properties. > > I"m not

Re: [VOTE] KIP-204 : adding records deletion operation to the new Admin Client API

2017-11-13 Thread Paolo Patierno
Hi all, I'm going to close this vote because this KIP was accepted with : 3 binding votes 5 non-binding votes Thanks everyone for comments and for voting. Paolo Patierno Senior Software Engineer (IoT) @ Red Hat Microsoft MVP on Azure & IoT Microsoft Azure Advisor Twitter : @ppatierno

Re: [DISCUSS] KIP-225 - Use tags for consumer “records.lag” metrics

2017-11-13 Thread charly molter
Hi, There doesn't seem to be much opposition to this KIP, I'll leave a couple more days before starting the vote. Thanks! On Thu, Nov 9, 2017 at 1:59 PM, charly molter wrote: > Hi, > > I'd like to start the discussion on KIP-225. > > This KIP tries to correct the way the consumer lag metrics a

[jira] [Resolved] (KAFKA-6202) Classes OffsetsMessageFormatter and GroupMetadataMessageFormatter shall be used by kafka tools, but in the last releases lost visibility

2017-11-13 Thread Seweryn Habdank-Wojewodzki (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seweryn Habdank-Wojewodzki resolved KAFKA-6202. --- Resolution: Invalid > Classes OffsetsMessageFormatter and GroupMetadat

[jira] [Created] (KAFKA-6204) Interceptor and MetricsReporter should implement java.io.Closeable

2017-11-13 Thread Charly Molter (JIRA)
Charly Molter created KAFKA-6204: Summary: Interceptor and MetricsReporter should implement java.io.Closeable Key: KAFKA-6204 URL: https://issues.apache.org/jira/browse/KAFKA-6204 Project: Kafka

Re: [VOTE] 0.11.0.2 RC0

2017-11-13 Thread Rajini Sivaram
Hi Ted, Thank you for running the tests. As you have mentioned in KAFKA-4262, this has been a known intermittent test failure. It has been difficult to make integration tests for quotas reliable since they verify the time taken to complete after running for a short duration. We should make the tes