Re: [DISCUSS] KIP-719: Add Log4J2 Appender

2022-01-19 Thread Dongjin Lee
Hi all, I just filed the issue based on the discussion here: KAFKA-13604: Add pluggable logging framework support ( https://issues.apache.org/jira/browse/KAFKA-13604) Thanks for posing a great issue, Viktor and Haruki! Best, Dongjin On Thu, Jan 20, 2022 at 2:54 AM Viktor Somogyi-Vass wrote:

[jira] [Created] (KAFKA-13604) Add pluggable logging framework support

2022-01-19 Thread Dongjin Lee (Jira)
Dongjin Lee created KAFKA-13604: --- Summary: Add pluggable logging framework support Key: KAFKA-13604 URL: https://issues.apache.org/jira/browse/KAFKA-13604 Project: Kafka Issue Type:

[jira] [Created] (KAFKA-13603) empty active segment can trigger recovery after clean shutdown and restart

2022-01-19 Thread Cong Ding (Jira)
Cong Ding created KAFKA-13603: - Summary: empty active segment can trigger recovery after clean shutdown and restart Key: KAFKA-13603 URL: https://issues.apache.org/jira/browse/KAFKA-13603 Project: Kafka

Re: [DISCUSS] KIP-704: Send a hint to broker if it is an unclean leader

2022-01-19 Thread Raman Verma
Thanks for this KIP, Jose - Could you please explain the following about backward compatibility. If a leader has been elected unclean. And we decide to roll the cluster back when the leader is in the middle of recovery, leader will simply not be able to recover when we roll back because it will

Re: [DISCUSS] KIP-815: Replace KafkaConsumer with AdminClient in GetOffsetShell

2022-01-19 Thread Luke Chen
Hi Ziming, Thanks for the update! It looks good now. Only 1 minor comment: The file name in example can change to `kafka_admin_client.properties`, which should be much clear. Otherwise LGTM! Thanks for the improvement! Thank you. Luke On Thu, Jan 20, 2022 at 10:03 AM deng ziming wrote: >

[DISCUSS] KIP-815: Replace KafkaConsumer with AdminClient in GetOffsetShell

2022-01-19 Thread deng ziming
Hi everyone, I would like to restart a discussion for KIP-815 since the old KIP number conflict with another KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-815%3A+Replace+KafkaConsumer+with+AdminClient+in+GetOffsetShell

Re: [DISCUSS] KIP-813: Replace KafkaConsumer with AdminClient in GetOffsetShell

2022-01-19 Thread deng ziming
Thank you Daan for your reminders, I already changed the KIP number to KIP-815 > On Jan 17, 2022, at 4:39 PM, Daan Gertis wrote: > > Hey Deng, > > Seems like we ran into a bit of a split-brain situation here. I just created > KIP-813 based on the last number in the wiki page and only now see

[VOTE] KIP-591: Add Kafka Streams config to set default state store

2022-01-19 Thread Luke Chen
Hi devs, I'd like to start a vote for the KIP-591: Add Kafka Streams config to set default state store. The goal is to allow users to set a default store in the config, so it can apply to all the streams. Detailed description can be found here:

[jira] [Created] (KAFKA-13602) Allow to broadcast a result record

2022-01-19 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-13602: --- Summary: Allow to broadcast a result record Key: KAFKA-13602 URL: https://issues.apache.org/jira/browse/KAFKA-13602 Project: Kafka Issue Type: New

Re: [DISCUSS] KIP-704: Send a hint to broker if it is an unclean leader

2022-01-19 Thread José Armando García Sancio
Hi all, I made the following changes to the KIP: https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=173082256=12=11 Some of the highlights are: 1. Changed the field from IsUnclean to IsLeaderRecovering 2. Added a few more sentences explaining why this KIP is backward

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #620

2022-01-19 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-808: Add support for unix epoch precision in TimestampConverter SMT

2022-01-19 Thread Julien Chanaud
Hi Tom and thanks for your review, I agree and I have renamed the field name to unix.precision. I've replaced all references to the word "epoch" which I mistakenly used to describe measurements throughout the KIP. I have also modified the KIP name as well. Before : Add support for unix epoch

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #619

2022-01-19 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-813 Shared State Stores

2022-01-19 Thread Matthias J. Sax
Daan, thanks for the KIP. I personally find the motivation section a little bit confusing. If I understand the KIP correctly, you want to read a topic into a state store (ie, materialize it). This is already possible today. Of course, today a "second" changelog topic would be created. It

Re: [VOTE] 3.1.0 RC1

2022-01-19 Thread Bill Bejeck
Hi David, Thanks for running the release! I did the following: 1. Validated all signatures and keys 2. Built from source 3. Ran all the unit tests 4. Spot checked the java docs, and the site docs 5. Ran a portion of the quick start 6. Ran the Kafka Streams demo application I

Re: [DISCUSS] KIP-704: Send a hint to broker if it is an unclean leader

2022-01-19 Thread José Armando García Sancio
Thanks for the feedback Colin and Luke. Colin wrote: > The KIP talks a bit about "recovery," which is a new term (as far as I > know). If I understand correctly, this is a state that the partition enters > into after an unclean leader election. I would suggest using a different > term for this,

Re: Requesting permission to the apache kafka project

2022-01-19 Thread Matthias J. Sax
You are all set. On 1/18/22 11:28 AM, Philip Nee wrote: Hello, Would like to gain permission to the AK for contribution. wikiID: pnee jiraID: pnee Thanks, P

[jira] [Created] (KAFKA-13601) Add option to support sync offset commit in Kafka Connect Sink

2022-01-19 Thread Anil Dasari (Jira)
Anil Dasari created KAFKA-13601: --- Summary: Add option to support sync offset commit in Kafka Connect Sink Key: KAFKA-13601 URL: https://issues.apache.org/jira/browse/KAFKA-13601 Project: Kafka

Re: KIP-769: Connect API to retrieve connector configuration definitions

2022-01-19 Thread Chris Egerton
Hi all, With regards to Tom's question about possible uses of the version string, one of the most useful applications I've found for it so far has been debugging connector issues, especially based on captured logs. Using the version string to identify a git tag containing the exact source code

Re: [DISCUSS] KIP-808: Add support for unix epoch precision in TimestampConverter SMT

2022-01-19 Thread Tom Bentley
Hi Julien, I wonder if the name epoch.precision is a little confusing. An epoch is a point in time chosen as a origin for a particular calendar system. As such it doesn't have a precision. It's only measurements from this point in time which have a precision. In the unix case, precisions of

Re: [DISCUSS] KIP-719: Add Log4J2 Appender

2022-01-19 Thread Viktor Somogyi-Vass
Hi folks, >a) I think this makes sense. But I think this shouldn't block this KIP, it can be done after moving to log4j2. Absolutely. >However, this limitation may change in the future - slf4j will support dynamic logging levels in 2.0: This would be awesome, let's keep an eye on this. >Kafka

[DISCUSS] KIP-814: Static membership protocol should let the leader skip assignment

2022-01-19 Thread David Jacot
Hi folks, I'd like to start a discussion for KIP-814: Static membership protocol should let the leader skip assignment. This is a small extension to the static membership protocol to address KAFKA-13435. The KIP is here: https://cwiki.apache.org/confluence/x/C5-kCw. Please let me know what you

Status of KIP-714: Client Metrics and Observability

2022-01-19 Thread rifer...@riferrei.com
Hi there, I want to get up to speed in what is going on with this KIP and how it works, so I would like to ask where can I get more information on it? I know it still being discussed, but I would appreciate if there are any code branches that I could use to see the design changes and

Re: KIP-769: Connect API to retrieve connector configuration definitions

2022-01-19 Thread Tom Bentley
Hi Mickael, Thanks for the KIP. Overall I think this looks good. I have a small concern about the proliferation of Versioned. Currently this interface has a really weak contract. There's no requirement for versions to be comparable, or documentation about when versions should be changed by

Re: [VOTE] KIP-719: Deprecate Log4J Appender

2022-01-19 Thread Viktor Somogyi-Vass
Hi Dongjin, +1 (non-binding) from me as well. Thanks for picking this up! Viktor On Mon, Jan 17, 2022 at 1:07 PM Mickael Maison wrote: > Hi Dongjin, > > +1 (binding) Thanks for all your efforts on this KIP > > Thanks, > Mickael > > On Tue, Dec 21, 2021 at 10:00 AM Dongjin Lee wrote: > > > >

Re: [VOTE] 3.1.0 RC1

2022-01-19 Thread David Jacot
Thanks for all the votes! We are still missing two binding votes from PMC members. Best, David On Tue, Jan 18, 2022 at 5:00 PM Israel Ekpo wrote: > > Performed the following validations using the tools available here: > > https://github.com/izzyacademy/apache-kafka-release-party > >-

Re: [VOTE] KIP-792: Add "generation" field into consumer protocol

2022-01-19 Thread Luke Chen
Hi all, Bump this thread to see if there are other comments to this KIP. So far, I have one +1 vote (binding), and need more votes. Thank you. Luke On Tue, Dec 21, 2021 at 10:33 AM Luke Chen wrote: > Hi all, > > Bump this thread to see if there are other comments to this KIP. > > Thank you. >

Re: [DISCUSS] KIP-591: Add Kafka Streams config to set default state store

2022-01-19 Thread Luke Chen
Hi all, If there are no other comments, I'll start to vote tomorrow. Thank you. Luke On Sat, Jan 15, 2022 at 10:47 AM Luke Chen wrote: > Hi Matthias, > > Thanks for the comments. > > 1. The config name: `default.dsl.store` looks good to me. Updated! > 2. the KIP still contains a view case of

Re: [DISCUSS] KIP-704: Send a hint to broker if it is an unclean leader

2022-01-19 Thread Luke Chen
Hi José, Thanks for the KIP. It's indeed a problem that we should handle it well! Just a minor comment: In the `PartitionChangeRecord` schema, you set the `isUnclean` field as type boolean, but the value (-1, 0, 1) are all int values. Did you mean int32 type or the value should be updated?

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #618

2022-01-19 Thread Apache Jenkins Server
See