Re: [ANNOUNCE] New committer: Ismael Juma

Congratulations, Ismael! E. Ribeiro Em 26/04/2016 15:33, "Jason Gustafson" escreveu: > Great work, Ismael! > > On Tue, Apr 26, 2016 at 9:00 AM, Grant Henke wrote: > > > Congratulations Ismael! > > On Apr 26, 2016 8:55 AM, "Harsha" wrote: > > > > > Congrats, Ismael > > > > > > -Harsha > > > > >

Re: [ANNOUNCE] New Kafka Committer Ewen Cheslack-Postava

Congratulations, Ewen! :) Cheers, Eddie Em 08/12/2015 17:37, "Neha Narkhede" escreveu: > I am pleased to announce that the Apache Kafka PMC has voted to > invite Ewen Cheslack-Postava as a committer and Ewen has accepted. > > Ewen is an active member of the community and has contributed and revi

Re: Release source doesn't contain .gitignore

Hi Grant, Sorry for my stupid question, but it is usually a best practice to include such file in the src tar balls? I am certainly okay with including it, of course. :) But I didn't see it in ZooKeeper 3.4.7, Hadoop 2.4.6 or Cassandra 3.0 sources, for example. OTOH, I see the .gitattributes file

Re: [VOTE] KIP-38: ZooKeeper authentication

+1 (non-binding) On Thu, Oct 22, 2015 at 3:46 PM, Neha Narkhede wrote: > +1 (binding) > > On Wed, Oct 21, 2015 at 7:24 PM, Todd Palino wrote: > > > +1 (non-binding) > > > > On Wed, Oct 21, 2015 at 6:53 PM, Jiangjie Qin > > > wrote: > > > > > +1 (non-binding) > > > > > > On Wed, Oct 21, 2015 at

[jira] [Assigned] (KAFKA-2685) "alter topic" on non-existent topic exits without error

[ https://issues.apache.org/jira/browse/KAFKA-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro reassigned KAFKA-2685: - Assignee: Edward Ribeiro > "alter topic" on non-existent topic exits

[jira] [Updated] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2338: -- Assignee: Ben Stopford > Warn users if they change max.message.bytes that they also need

[jira] [Commented] (KAFKA-2659) Warn user, if increasing max message bytes, to also increase on consumer

[ https://issues.apache.org/jira/browse/KAFKA-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959455#comment-14959455 ] Edward Ribeiro commented on KAFKA-2659: --- [~gwenshap], Oh, it's KAFKA-23

[jira] [Updated] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2338: -- Assignee: (was: Edward Ribeiro) > Warn users if they change max.message.bytes that t

[jira] [Commented] (KAFKA-2601) ConsoleProducer tool shows stacktrace on invalid command parameters

[ https://issues.apache.org/jira/browse/KAFKA-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940026#comment-14940026 ] Edward Ribeiro commented on KAFKA-2601: --- Hi [~GabrielNicolasAvellaneda],

[jira] [Updated] (KAFKA-2601) ConsoleProducer tool shows stacktrace on invalid command parameters

[ https://issues.apache.org/jira/browse/KAFKA-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2601: -- Reviewer: (was: Edward Ribeiro) > ConsoleProducer tool shows stacktrace on invalid comm

[jira] [Updated] (KAFKA-2601) ConsoleProducer tool shows stacktrace on invalid command parameters

[ https://issues.apache.org/jira/browse/KAFKA-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2601: -- Assignee: (was: Edward Ribeiro) > ConsoleProducer tool shows stacktrace on invalid comm

[jira] [Commented] (KAFKA-2601) ConsoleProducer tool shows stacktrace on invalid command parameters

[ https://issues.apache.org/jira/browse/KAFKA-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939213#comment-14939213 ] Edward Ribeiro commented on KAFKA-2601: --- Excuse me, Gabriel, I jumped too soo

[jira] [Comment Edited] (KAFKA-2601) ConsoleProducer tool shows stacktrace on invalid command parameters

[ https://issues.apache.org/jira/browse/KAFKA-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939213#comment-14939213 ] Edward Ribeiro edited comment on KAFKA-2601 at 10/1/15 3:1

[jira] [Assigned] (KAFKA-2601) ConsoleProducer tool shows stacktrace on invalid command parameters

[ https://issues.apache.org/jira/browse/KAFKA-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro reassigned KAFKA-2601: - Assignee: Edward Ribeiro > ConsoleProducer tool shows stacktrace on invalid comm

[jira] [Updated] (KAFKA-2578) Client Metadata internal state should be synchronized

[ https://issues.apache.org/jira/browse/KAFKA-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2578: -- Status: Patch Available (was: Open) > Client Metadata internal state should be synchroni

[jira] [Updated] (KAFKA-2599) Metadata#getClusterForCurrentTopics can throw NPE even with null checking

[ https://issues.apache.org/jira/browse/KAFKA-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2599: -- Status: Patch Available (was: Open) > Metadata#getClusterForCurrentTopics can throw NPE e

[jira] [Comment Edited] (KAFKA-2578) Client Metadata internal state should be synchronized

[ https://issues.apache.org/jira/browse/KAFKA-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934290#comment-14934290 ] Edward Ribeiro edited comment on KAFKA-2578 at 9/29/15 9:3

[jira] [Comment Edited] (KAFKA-2578) Client Metadata internal state should be synchronized

[ https://issues.apache.org/jira/browse/KAFKA-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934290#comment-14934290 ] Edward Ribeiro edited comment on KAFKA-2578 at 9/29/15 9:3

[jira] [Updated] (KAFKA-2599) Metadata#getClusterForCurrentTopics can throw NPE even with null checking

[ https://issues.apache.org/jira/browse/KAFKA-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2599: -- Description: While working on another issue I have just seen the following: {code} private

[jira] [Created] (KAFKA-2599) Metadata#getClusterForCurrentTopics can throw NPE even with null checking

Edward Ribeiro created KAFKA-2599: - Summary: Metadata#getClusterForCurrentTopics can throw NPE even with null checking Key: KAFKA-2599 URL: https://issues.apache.org/jira/browse/KAFKA-2599 Project

[jira] [Commented] (KAFKA-2578) Client Metadata internal state should be synchronized

[ https://issues.apache.org/jira/browse/KAFKA-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934290#comment-14934290 ] Edward Ribeiro commented on KAFKA-2578: --- Thanks, mate! :) > Client M

[jira] [Assigned] (KAFKA-2578) Client Metadata internal state should be synchronized

[ https://issues.apache.org/jira/browse/KAFKA-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro reassigned KAFKA-2578: - Assignee: Edward Ribeiro (was: Jason Gustafson) > Client Metadata internal state sho

[jira] [Commented] (KAFKA-2578) Client Metadata internal state should be synchronized

[ https://issues.apache.org/jira/browse/KAFKA-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934269#comment-14934269 ] Edward Ribeiro commented on KAFKA-2578: --- Hey, [~hachikuji], this patch i

Re: [VOTE] KIP-28 - Add a processor client for stream data processing

+1 (non-binding) On Tue, Sep 22, 2015 at 3:37 PM, Ashish Singh wrote: > +1 (non-binding) > > On Tue, Sep 22, 2015 at 10:12 AM, Ismael Juma wrote: > > > +1 (non-binding) > > > > On Tue, Sep 22, 2015 at 6:10 PM, Jason Gustafson > > wrote: > > > > > +1 (non-binding) > > > > > > On Mon, Sep 21, 20

Re: [ANNOUNCE] New Committer Sriharsha Chintalapani

Congrats, Harsha! On Tue, Sep 22, 2015 at 12:27 PM, Jay Kreps wrote: > Congrats Sriharsha! > > -Jay > > On Mon, Sep 21, 2015 at 9:10 PM, Jun Rao wrote: > > > I am pleased to announce that the Apache Kafka PMC has voted to > > invite Sriharsha Chintalapani as a committer and Sriharsha has accept

[jira] [Commented] (KAFKA-2563) Version number major.major.minor.fix in kafka-merge-pr.py

[ https://issues.apache.org/jira/browse/KAFKA-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901212#comment-14901212 ] Edward Ribeiro commented on KAFKA-2563: --- This is a duplicate of KAFKA-

Re: 0.9.0.0 remaining jiras

Is KAFKA-1811 worth considering for 0.9.0? Thanks! Eddie On Mon, Sep 14, 2015 at 4:34 PM, Jiangjie Qin wrote: > HI Jun, > > Can we also include KAFKA-2448 in 0.9 as well? We see this issue a few > times before and that cause replica fetcher th

[jira] [Commented] (KAFKA-2515) handle oversized messages properly in new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744252#comment-14744252 ] Edward Ribeiro commented on KAFKA-2515: --- Ewen was able to simulate the bug wi

Re: Review Request 36578: Patch for KAFKA-2338

and modify accordingly. - Edward Ribeiro On Sept. 2, 2015, 10:30 p.m., Edward Ribeiro wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

[jira] [Commented] (KAFKA-2515) handle oversized messages properly in new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744102#comment-14744102 ] Edward Ribeiro commented on KAFKA-2515: --- [~onurkaraman], isn't this issu

Re: 0.9.0.0 remaining jiras

Excuse me, I'd put my issue in this list on the backburner, but resuming work on it this week. Cheers, Eddie Em 12/09/2015 13:40, "Jun Rao" escreveu: > The following is a candidate list of jiras that we want to complete in the > upcoming release (0.9.0.0). Our goal is to finish at least all the

Re: Maybe 0.8.3 should really be 0.9.0?

+1 on 0.9.0 On Tue, Sep 8, 2015 at 4:07 PM, Ashish Singh wrote: > +1 on 0.9.0 > > On Tue, Sep 8, 2015 at 12:00 PM, Gwen Shapira wrote: > > > I propose a simple rename: s/0.8.3/0.9.0/ > > > > No change of scope and not including current 0.9.0 issues. > > > > On Tue, Sep 8, 2015 at 11:36 AM, Raji

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728149#comment-14728149 ] Edward Ribeiro commented on KAFKA-2338: --- Updated reviewboard h

[jira] [Updated] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2338: -- Attachment: KAFKA-2338_2015-09-02_19:27:17.patch > Warn users if they change max.message.by

Re: Review Request 36578: Patch for KAFKA-2338

f1405a5b2961bc826caa22507db8ba39ce1cf4d3 core/src/main/scala/kafka/server/AbstractFetcherThread.scala dca975ca1bf3e560b9d9817e7f2a511ef4296e70 Diff: https://reviews.apache.org/r/36578/diff/ Testing --- Thanks, Edward Ribeiro

[jira] [Commented] (KAFKA-2499) kafka-producer-perf-test should use something more realistic than empty byte arrays

[ https://issues.apache.org/jira/browse/KAFKA-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726134#comment-14726134 ] Edward Ribeiro commented on KAFKA-2499: --- okay, thanks! > kafka-producer-pe

[jira] [Commented] (KAFKA-2499) kafka-producer-perf-test should use something more realistic than empty byte arrays

[ https://issues.apache.org/jira/browse/KAFKA-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726069#comment-14726069 ] Edward Ribeiro commented on KAFKA-2499: --- Hi [~benstopford], I have a tidy bi

[jira] [Commented] (KAFKA-2498) need build steps/instruction while building apache kafka from source github branch 0.8.2

[ https://issues.apache.org/jira/browse/KAFKA-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725882#comment-14725882 ] Edward Ribeiro commented on KAFKA-2498: --- Hi [~gundun], I am afraid you lost me

[jira] [Comment Edited] (KAFKA-2473) Not able to find release version with patch jira-1591

[ https://issues.apache.org/jira/browse/KAFKA-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712009#comment-14712009 ] Edward Ribeiro edited comment on KAFKA-2473 at 8/25/15 9:3

[jira] [Comment Edited] (KAFKA-2473) Not able to find release version with patch jira-1591

[ https://issues.apache.org/jira/browse/KAFKA-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712009#comment-14712009 ] Edward Ribeiro edited comment on KAFKA-2473 at 8/25/15 9:3

[jira] [Commented] (KAFKA-2473) Not able to find release version with patch jira-1591

[ https://issues.apache.org/jira/browse/KAFKA-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712009#comment-14712009 ] Edward Ribeiro commented on KAFKA-2473: --- Hi Amar, please, post this kin

[jira] [Updated] (KAFKA-1811) Ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-1811: -- Summary: Ensuring registered broker host:port is unique (was: ensuring registered broker

[jira] [Comment Edited] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709794#comment-14709794 ] Edward Ribeiro edited comment on KAFKA-1811 at 8/24/15 6:4

[jira] [Issue Comment Deleted] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-1811: -- Comment: was deleted (was: A tentative (git) patch cut for addressing this issue.) > ensur

[jira] [Commented] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709794#comment-14709794 ] Edward Ribeiro commented on KAFKA-1811: --- Hi [~gwenshap] and [~nehanarkhede], I

[jira] [Updated] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-1811: -- Attachment: (was: KAFKA-1811-2.patch) > ensuring registered broker host:port is uni

[jira] [Commented] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709767#comment-14709767 ] Edward Ribeiro commented on KAFKA-1811: --- Created reviewboard h

[jira] [Updated] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-1811: -- Attachment: KAFKA-1811.patch > ensuring registered broker host:port is uni

[jira] [Updated] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-1811: -- Status: Patch Available (was: Open) > ensuring registered broker host:port is uni

Review Request 37723: Patch for KAFKA-1811

/37723/diff/ Testing --- Thanks, Edward Ribeiro

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709707#comment-14709707 ] Edward Ribeiro commented on KAFKA-2338: --- Hi, [~gwenshap], thanks for the kind w

[jira] [Updated] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2338: -- Attachment: KAFKA-2338_2015-08-24_14:32:38.patch > Warn users if they change max.message.by

[jira] [Updated] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2338: -- Status: Patch Available (was: In Progress) > Warn users if they change max.message.bytes t

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709685#comment-14709685 ] Edward Ribeiro commented on KAFKA-2338: --- Updated reviewboard h

Re: Review Request 36578: Patch for KAFKA-2338

f1405a5b2961bc826caa22507db8ba39ce1cf4d3 core/src/main/scala/kafka/server/AbstractFetcherThread.scala f84306143c43049e3aa44e42beaffe7eb2783163 Diff: https://reviews.apache.org/r/36578/diff/ Testing --- Thanks, Edward Ribeiro

[jira] [Updated] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-1811: -- Attachment: KAFKA-1811-2.patch A tentative (git) patch cut for addressing this issue

[jira] [Work started] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-1811 started by Edward Ribeiro. - > ensuring registered broker host:port is uni

[jira] [Work stopped] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-1811 stopped by Edward Ribeiro. - > ensuring registered broker host:port is uni

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705911#comment-14705911 ] Edward Ribeiro commented on KAFKA-873: -- Sorry, I didn't follow here. Gua

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705909#comment-14705909 ] Edward Ribeiro commented on KAFKA-873: -- Sorry, I didn't follow here. Gua

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705442#comment-14705442 ] Edward Ribeiro commented on KAFKA-873: -- [~granthenke], [~fpj], [~ijuma] Please, c

Re: [DISCUSSION] Kafka 0.8.2.2 release?

I sort of follow Daniel Nelson on this issue: cut a 0.8.2.2 but not include much thing besides Snappy fixes. I mean, include a couple of additional critical bug fixes, if really urgent, and that's it. On Tue, Aug 18, 2015 at 3:25 PM, Daniel Nelson wrote: > I am strongly in favor of cutting a 0.8

Re: NEW: API Stability annotations!

Very cool! Congrats! :) My only comment is that, as Gwen pointed out in the first email, it is a set of API compatibility annotations, but the name is InterfaceStability. Wouldn't ApiStability be a better name? InterfaceStability looks a bit restrictive, imho. https://github.com/apache/kafka/pu

[jira] [Commented] (KAFKA-2418) Typo on official KAFKA documentation

[ https://issues.apache.org/jira/browse/KAFKA-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693984#comment-14693984 ] Edward Ribeiro commented on KAFKA-2418: --- Hi folks, if you have any free time c

Re: Kafka Indentation

+1 about rewriting to Java (in a year or more). +1 about upping Scala use in the meanwhile +1 about using Gradle instead of Maven or SBT. Eddie On Wed, Aug 12, 2015 at 5:26 AM, Ismael Juma wrote: > On Wed, Aug 12, 2015 at 1:29 AM, Gwen Shapira wrote: > > > +1 on not breaking git blame > > > >

Re: KAFKA-2364 migrate docs from SVN to git

nd migrating? Or are we looking for a > > > volunteer? > > > > > > On Tue, Aug 11, 2015 at 5:46 PM, Ashish Singh > > wrote: > > > > > >> +1 on same repo. > > >> > > >> On Tue, Aug 11, 2015 at 12:21 PM, Edw

Re: KAFKA-2364 migrate docs from SVN to git

+1. As soon as possible, please. :) On Sat, Aug 8, 2015 at 4:05 PM, Neha Narkhede wrote: > +1 on the same repo for code and website. It helps to keep both in sync. > > On Thu, Aug 6, 2015 at 1:52 PM, Grant Henke wrote: > > > +1 for the same repo. The closer docs can be to code the more accurate

Re: Typo on documentation

g jiras. This saves some overhead for such > patches. > > > > > > Guozhang > > > > > > On Mon, Aug 10, 2015 at 2:53 PM, Edward Ribeiro < > > edward.ribe...@gmail.com> > > > wrote: > > > > > > > Okay. > > > > > >

Re: Review Request 34492: Patch for KAFKA-2210

> On Julho 21, 2015, 1:30 a.m., Edward Ribeiro wrote: > > core/src/main/scala/kafka/security/auth/Acl.scala, line 71 > > <https://reviews.apache.org/r/34492/diff/8/?file=1017296#file1017296line71> > > > > Disclaimer: I am not claiming that you should ch

Re: Review Request 36858: Patch for KAFKA-2120

/RecordBatch.java (line 135) <https://reviews.apache.org/r/36858/#comment149464> When we code a method that may or may not execute a given operation, it's usually a good practice to name it ``maybeExpire``. There's a couple of examples of "maybe*" in Kafka code base

Re: Review Request 36858: Patch for KAFKA-2120

r.java (line 236) <https://reviews.apache.org/r/36858/#comment149461> Again, we could wrap it in ``Collections.unmodifiableList``? (ps: I am asking, not stating). - Edward Ribeiro On July 29, 2015, 10:58 p.m., Mayuresh Gharat wrote: > > ---

[jira] [Updated] (KAFKA-2418) Typo on official KAFKA documentation

[ https://issues.apache.org/jira/browse/KAFKA-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2418: -- Status: Patch Available (was: Open) > Typo on official KAFKA documentat

[jira] [Updated] (KAFKA-2418) Typo on official KAFKA documentation

[ https://issues.apache.org/jira/browse/KAFKA-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2418: -- Affects Version/s: 0.8.0 0.8.1 0.8.2.0 > Typo

[jira] [Updated] (KAFKA-2418) Typo on official KAFKA documentation

[ https://issues.apache.org/jira/browse/KAFKA-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2418: -- Attachment: KAFKA-2418.patch Adding a patch to web site documentation. > Typo on offic

[jira] [Created] (KAFKA-2418) Typo on official KAFKA documentation

Edward Ribeiro created KAFKA-2418: - Summary: Typo on official KAFKA documentation Key: KAFKA-2418 URL: https://issues.apache.org/jira/browse/KAFKA-2418 Project: Kafka Issue Type: Bug

Re: Typo on documentation

Okay. On Mon, Aug 10, 2015 at 5:21 PM, Gwen Shapira wrote: > yeppers. JIRA and patch? > > On Mon, Aug 10, 2015 at 12:36 PM, Edward Ribeiro > > wrote: > > > I have just seen the typo below at > > http://kafka.apache.org/documentation.html . It's supposed

Typo on documentation

I have just seen the typo below at http://kafka.apache.org/documentation.html . It's supposed to be JMX instead of JMZ, right? []'s Eddie

[jira] [Assigned] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro reassigned KAFKA-1811: - Assignee: Edward Ribeiro > ensuring registered broker host:port is uni

Re: Review Request 28096: Patch for KAFKA-313

/admin/ConsumerGroupCommand.scala (line 345) <https://reviews.apache.org/r/28096/#comment149145> nit: you could rename this as ``elapsedTime`` and make it ``System.currentTimeMillis() - startTime`` as it's only used at line L#346. So, L#346 becomes ``val sleepTime = loopInterval - elap

Re: Kafka KIP discussion tomorrow

​The tech lead at my former company did A LOT of research and experimentation with various online meetings services/softwares (join.me, G hangouts, goto, etc). Unfortunately, the most *usable* are goto meetings and Google Hangouts. Even so, many people have problem with one of the two. :( During t

Re: Review Request 33049: Patch for KAFKA-2084

ws.apache.org/r/33049/#comment148486> separate ``for`` and ``(`` with a space. core/src/test/scala/unit/kafka/server/ThrottledRequestExpirationTest.scala (line 83) <https://reviews.apache.org/r/33049/#comment148485> separate ``for`` and ``(`` wit

Re: Review Request 33125: Add comment to timing fix

(line 58) <https://reviews.apache.org/r/33125/#comment148391> Wow, 1 millisecond?! Does it make a difference? Just curious. :) - Edward Ribeiro On April 13, 2015, 7:15 p.m., Rajini Sivaram wrote: > > --- > This is a

Re: Review Request 33620: Patch for KAFKA-1690

/java/org/apache/kafka/common/network/PlainTextTransportLayer.java (line 38) <https://reviews.apache.org/r/33620/#comment148377> It's a good practice to make both ''key'' and ''socketChannel'' as final fiel

Re: Review Request 36871: Patch for KAFKA-2381

> On July 28, 2015, 8:07 p.m., Edward Ribeiro wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java, > > line 87 > > <https://reviews.apache.org/r/36871/diff/5/?file=1023563#file1023563line87> > > > > So

Re: Review Request 36871: Patch for KAFKA-2381

> On July 28, 2015, 8:07 p.m., Edward Ribeiro wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java, > > line 87 > > <https://reviews.apache.org/r/36871/diff/5/?file=1023563#file1023563line87> > > > > So

Re: Review Request 36871: Patch for KAFKA-2381

pListSet''? IMHO, making a defensive copy here is nice for this particular case, but it still leave room for concurrent exceptions in the future. Just a musing though. I am fine with leaving as it-is now. :) - Edward Ribeiro O

[jira] [Commented] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639095#comment-14639095 ] Edward Ribeiro commented on KAFKA-2355: --- Oh, thanks [~gwenshap]! Sorry for

[jira] [Commented] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639011#comment-14639011 ] Edward Ribeiro commented on KAFKA-2355: --- Hi [~ijuma], no problem, mate. If it l

[jira] [Commented] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638036#comment-14638036 ] Edward Ribeiro commented on KAFKA-2355: --- Updated reviewboard h

[jira] [Updated] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2355: -- Attachment: KAFKA-2355_2015-07-22_22:23:13.patch > Add an unit test to validate the deletion

Re: Review Request 36670: Patch for KAFKA-2355

fa8ce259a2832ab86f9dda8c1d409b2c42d43ae9 Diff: https://reviews.apache.org/r/36670/diff/ Testing --- Thanks, Edward Ribeiro

Re: Review Request 36681: Patch for KAFKA-2275

/src/test/scala/integration/kafka/api/ConsumerTest.scala (line 198) <https://reviews.apache.org/r/36681/#comment146930> nit: really *really* really cosmetic stuff, but ``topicPartsMap`` makes more sense, no? :) - Edward Ribeiro On July 22, 2015, 11:09 p.m

[jira] [Commented] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637996#comment-14637996 ] Edward Ribeiro commented on KAFKA-2355: --- Hi [~ijuma] and [~granthenke], I

[jira] [Updated] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2355: -- Attachment: KAFKA-2355_2015-07-22_21:37:51.patch > Add an unit test to validate the deletion

[jira] [Commented] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637984#comment-14637984 ] Edward Ribeiro commented on KAFKA-2355: --- Updated reviewboard h

Re: Review Request 36670: Patch for KAFKA-2355

fa8ce259a2832ab86f9dda8c1d409b2c42d43ae9 Diff: https://reviews.apache.org/r/36670/diff/ Testing --- Thanks, Edward Ribeiro

Re: Review Request 36670: Patch for KAFKA-2355

ve it after the catch. - Edward Ribeiro On July 22, 2015, 1:46 a.m., Edward Ribeiro wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

[jira] [Updated] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2355: -- Issue Type: Test (was: Sub-task) Parent: (was: KAFKA-2345) > Add an unit test

[jira] [Updated] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2355: -- Affects Version/s: 0.8.2.1 Status: Patch Available (was: Open) > Add an u

[jira] [Commented] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636119#comment-14636119 ] Edward Ribeiro commented on KAFKA-2355: --- Hi [~singhashish] and [~gwenshap]. I

  1   2   >