Re: [ANNOUNCE] New committer: Grant Henke

2017-01-13 Thread Jeff Holoman
Well done Grant! Congrats! On Thu, Jan 12, 2017 at 1:13 PM, Joel Koshy wrote: > Hey Grant - congrats! > > On Thu, Jan 12, 2017 at 10:00 AM, Neha Narkhede wrote: > > > Congratulations, Grant. Well deserved! > > > > On Thu, Jan 12, 2017 at 7:51 AM Grant

[jira] [Updated] (KAFKA-2757) Consolidate BrokerEndPoint and EndPoint

2016-01-06 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-2757: Assignee: (was: Jeff Holoman) > Consolidate BrokerEndPoint and EndPo

Re: [ANNOUNCE] New Kafka Committer Ewen Cheslack-Postava

2015-12-08 Thread Jeff Holoman
reviewed > > > > > > numerous patches to Kafka. His most significant contribution is > Kafka > > > > > > Connect which was released few days ago as part of 0.9. > > > > > > > > > > > > Please join me on welcoming and congratulating Ewen. > > > > > > > > > > > > Ewen, we look forward to your continued contributions to the > Kafka > > > > > > community! > > > > > > > > > > > > -- > > > > > > Thanks, > > > > > > Neha > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Liquan Pei > > > > > Department of Physics > > > > > University of Massachusetts Amherst > > > > > > > > > > > > > > > > > > > > > -- > > > > -- Guozhang > > > > > > > > > > > > > -- > > Ashish h > -- Jeff Holoman Systems Engineer

Re: New and updated producers and consumers

2015-11-05 Thread Jeff Holoman
; > > > > -- > > ----- > > "There are only 10 types of people in the world: Those who understand > > binary, and those who don't" > > > > > > -- > - > "There are only 10 types of people in the world: Those who understand > binary, and those who don't" > -- Jeff Holoman Systems Engineer

Re: New and updated producers and consumers

2015-11-05 Thread Jeff Holoman
0.9. > > Thanks, > Cliff > > On Thu, Nov 5, 2015 at 11:18 AM, Jeff Holoman <jholo...@cloudera.com> > wrote: > > > Prabhjot, > > > > The answer changes slightly for the Producer and Consumer and depends on > > your timeline and comfort with u

[jira] [Created] (KAFKA-2735) BrokerEndPoint should support non-lowercase hostnames

2015-11-03 Thread Jeff Holoman (JIRA)
Jeff Holoman created KAFKA-2735: --- Summary: BrokerEndPoint should support non-lowercase hostnames Key: KAFKA-2735 URL: https://issues.apache.org/jira/browse/KAFKA-2735 Project: Kafka Issue Type

[jira] [Updated] (KAFKA-2735) BrokerEndPoint should support uppercase hostnames

2015-11-03 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-2735: Summary: BrokerEndPoint should support uppercase hostnames (was: BrokerEndPoint should support non

[jira] [Commented] (KAFKA-2549) Checkstyle reporting failure in trunk due to unused imports in Selector.java

2015-09-14 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14744425#comment-14744425 ] Jeff Holoman commented on KAFKA-2549: - Yeah sorry about that, I inadvertently cmd-z'd the import

[jira] [Updated] (KAFKA-2504) Stop logging WARN when client disconnects

2015-09-13 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-2504: Status: Patch Available (was: Open) > Stop logging WARN when client disconne

[jira] [Assigned] (KAFKA-2504) Stop logging WARN when client disconnects

2015-09-12 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman reassigned KAFKA-2504: --- Assignee: Jeff Holoman > Stop logging WARN when client disconne

[jira] [Commented] (KAFKA-1929) Convert core kafka module to use the errors in org.apache.kafka.common.errors

2015-09-04 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730833#comment-14730833 ] Jeff Holoman commented on KAFKA-1929: - Jason, I'm not working on this at this time. It was previously

Re: [DISCUSSION] Kafka 0.8.2.2 release?

2015-08-16 Thread Jeff Holoman
Software Engineer | Cloudera gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke -- Jeff Holoman Systems Engineer

[jira] [Updated] (KAFKA-1929) Convert core kafka module to use the errors in org.apache.kafka.common.errors

2015-08-10 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1929: Assignee: Grant Henke (was: Jeff Holoman) Convert core kafka module to use the errors

[jira] [Updated] (KAFKA-2064) Replace ConsumerMetadataRequest and Response with org.apache.kafka.common.requests objects

2015-07-04 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-2064: Assignee: (was: Jeff Holoman) Replace ConsumerMetadataRequest and Response

Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-04-22 Thread Jeff Holoman
system I can think of. -- Jeff Holoman Systems Engineer

[jira] [Updated] (KAFKA-1810) Add IP Filtering / Whitelists-Blacklists

2015-04-21 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1810: Resolution: Won't Fix Status: Resolved (was: Patch Available) Add IP Filtering

Re: Review Request 31590: Patch for KAFKA-1990

2015-04-19 Thread Jeff Holoman
rather than unit/kafka/log ? Thanks, Jeff Holoman

[jira] [Updated] (KAFKA-1990) Add unlimited time-based log retention

2015-04-19 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1990: Attachment: KAFKA-1990_2015-04-19_13:41:23.patch Add unlimited time-based log retention

[jira] [Commented] (KAFKA-1990) Add unlimited time-based log retention

2015-04-19 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14502017#comment-14502017 ] Jeff Holoman commented on KAFKA-1990: - Updated reviewboard https://reviews.apache.org

[jira] [Updated] (KAFKA-1990) Add unlimited time-based log retention

2015-04-19 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1990: Status: Patch Available (was: In Progress) Add unlimited time-based log retention

[jira] [Assigned] (KAFKA-2064) Replace ConsumerMetadataRequest and Response with org.apache.kafka.common.requests objects

2015-04-01 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman reassigned KAFKA-2064: --- Assignee: Jeff Holoman Replace ConsumerMetadataRequest and Response

[jira] [Commented] (KAFKA-1929) Convert core kafka module to use the errors in org.apache.kafka.common.errors

2015-04-01 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391298#comment-14391298 ] Jeff Holoman commented on KAFKA-1929: - [~jkreps] Did you have a chance to review

Re: [VOTE] KIP-7 Security - IP Filtering

2015-03-20 Thread Jeff Holoman
On 3/20/15, 10:28 AM, Jeff Holoman jholo...@cloudera.com wrote: Hey Jun, The intent was for the same functionality to be utilized when 1688 is done, as mentioned in the KIP: The broader security initiative http://kafka-1682/ will add more robust controls for these types

Re: [VOTE] KIP-7 Security - IP Filtering

2015-03-20 Thread Jeff Holoman
for authorization and be included there? Thanks, Jun On Wed, Mar 18, 2015 at 6:26 PM, Jeff Holoman jholo...@cloudera.com wrote: One other thought. Does the timing of the implementation (or lack thereof) affect the proposal? It seems like the question you are asking is an implementation detail

Re: [VOTE] KIP-7 Security - IP Filtering

2015-03-17 Thread Jeff Holoman
bump On Tue, Mar 3, 2015 at 8:12 PM, Jeff Holoman jholo...@cloudera.com wrote: Guozhang, The way the patch is implemented, the check is done in the acceptor thread accept() method of the Socket Server, just before connectionQuotas. Thanks Jeff On Tue, Mar 3, 2015 at 7:59 PM, Guozhang

[jira] [Commented] (KAFKA-1810) Add IP Filtering / Whitelists-Blacklists

2015-03-14 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362217#comment-14362217 ] Jeff Holoman commented on KAFKA-1810: - Updated reviewboard https://reviews.apache.org

Re: Review Request 29714: Patch for KAFKA-1810

2015-03-14 Thread Jeff Holoman
to this functionality, one to handle configuration errors, and one to handle blocking the request. Currently the level is set to INFO. Does it make sense to move this to WARN ? Thanks, Jeff Holoman

[jira] [Updated] (KAFKA-1810) Add IP Filtering / Whitelists-Blacklists

2015-03-14 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1810: Attachment: KAFKA-1810_2015-03-15_01:13:12.patch Add IP Filtering / Whitelists-Blacklists

Re: Review Request 29714: Patch for KAFKA-1810

2015-03-14 Thread Jeff Holoman
+-+Security+-+IP+Filtering Thanks, Jeff Holoman

Re: Review Request 29714: Patch for KAFKA-1810

2015-03-14 Thread Jeff Holoman
://reviews.apache.org/r/29714/#comment124033 Need to delete - Jeff Holoman On March 15, 2015, 5:13 a.m., Jeff Holoman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29714

[jira] [Commented] (KAFKA-1990) Add unlimited time-based log retention

2015-03-09 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14354325#comment-14354325 ] Jeff Holoman commented on KAFKA-1990: - Updated reviewboard https://reviews.apache.org

Re: Review Request 31590: Patch for KAFKA-1990

2015-03-09 Thread Jeff Holoman
rather than unit/kafka/log ? Thanks, Jeff Holoman

Re: Review Request 31590: Patch for KAFKA-1990

2015-03-09 Thread Jeff Holoman
core/src/test/scala/unit/kafka/admin/AdminTest.scala ee0b21e6a94ad79c11dd08f6e5adf98c333e2ec9 core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala 7f47e6f9a74314ed9e9f19d0c97931f3f2e49259 Diff: https://reviews.apache.org/r/31590/diff/ Testing --- Thanks, Jeff Holoman

[VOTE] KIP-7 Security - IP Filtering

2015-03-03 Thread Jeff Holoman
Details in the wiki. https://cwiki.apache.org/confluence/display/KAFKA/KIP-7+-+Security+-+IP+Filtering -- Jeff Holoman Systems Engineer

Re: [VOTE] KIP-2 - Refactor brokers to allow listening on multiple ports and IPs

2015-03-03 Thread Jeff Holoman
are in the wiki: https://cwiki.apache.org/confluence/display/KAFKA/KIP-2+-+Refactor+brokers+to+allow+listening+on+multiple+ports+and+IPs -- Jeff Holoman Systems Engineer

Re: [VOTE] KIP-7 Security - IP Filtering

2015-03-03 Thread Jeff Holoman
:44 PM, Jeff Holoman jholo...@cloudera.com wrote: Details in the wiki. https://cwiki.apache.org/confluence/display/KAFKA/KIP-7+-+Security+-+IP+F iltering -- Jeff Holoman Systems Engineer -- -- Guozhang -- Jeff Holoman Systems Engineer

Re: [KIP-DISCUSSION] KIP-7 Security - IP Filtering

2015-03-03 Thread Jeff Holoman
://www.twitter.com/allthingshadoop / On Wed, Jan 21, 2015 at 8:47 PM, Jeff Holoman jholo...@cloudera.com wrote: Posted a KIP for IP Filtering: https://cwiki.apache.org/confluence/display/KAFKA/KIP-7+-+Security+-+IP+Filtering Relevant JIRA

[jira] [Assigned] (KAFKA-1990) Add unlimited time-based log retention

2015-03-01 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman reassigned KAFKA-1990: --- Assignee: Jeff Holoman Add unlimited time-based log retention

Re: Review Request 31591: Patch for KAFKA-1992

2015-03-01 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31591/#review74699 --- Looks good to me. - Jeff Holoman On March 1, 2015, 7:58 a.m

[jira] [Updated] (KAFKA-1929) Convert core kafka module to use the errors in org.apache.kafka.common.errors

2015-02-25 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1929: Attachment: KAFKA-1929.patch Convert core kafka module to use the errors

[jira] [Updated] (KAFKA-1929) Convert core kafka module to use the errors in org.apache.kafka.common.errors

2015-02-25 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1929: Status: Patch Available (was: Open) Convert core kafka module to use the errors

Review Request 31460: Patch for KAFKA-1929

2015-02-25 Thread Jeff Holoman
c2dd8eb69da8c0982a0dd20231c6f8bd58eb623e Diff: https://reviews.apache.org/r/31460/diff/ Testing --- Thanks, Jeff Holoman

[jira] [Commented] (KAFKA-1929) Convert core kafka module to use the errors in org.apache.kafka.common.errors

2015-02-25 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337828#comment-14337828 ] Jeff Holoman commented on KAFKA-1929: - Created reviewboard https://reviews.apache.org

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations

2015-02-24 Thread Jeff Holoman
/ -- -- Guozhang -- Jeff Holoman Systems Engineer

[jira] [Commented] (KAFKA-1929) Convert core kafka module to use the errors in org.apache.kafka.common.errors

2015-02-19 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327974#comment-14327974 ] Jeff Holoman commented on KAFKA-1929: - Here's the list of duplicated errors

[jira] [Assigned] (KAFKA-1929) Convert core kafka module to use the errors in org.apache.kafka.common.errors

2015-02-08 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman reassigned KAFKA-1929: --- Assignee: Jeff Holoman Convert core kafka module to use the errors

Re: [DISCUSS] ConfigDec Broker Changes on Trunk

2015-02-06 Thread Jeff Holoman
Data Open Source Security LLC http://www.stealth.ly Twitter: @allthingshadoop http://www.twitter.com/allthingshadoop / -- Jeff Holoman Systems Engineer

Re: Review Request 30126: Patch for KAFKA-1845

2015-02-03 Thread Jeff Holoman
://reviews.apache.org/r/30126/#comment116129 Is this is the right way to do this rather than having these in Validators? - Jeff Holoman On Jan. 21, 2015, 5:49 p.m., Andrii Biletskyi wrote: --- This is an automatically generated e-mail

Re: Review Request 30403: Patch for KAFKA-1906

2015-02-01 Thread Jeff Holoman
. -Jaikiran On Thursday 29 January 2015 08:00 PM, Jeff Holoman wrote: Maybe I'm in the minority here, but I actually don't think there should be a default for this param and you should be required to explicitly set this. On Thu, Jan 29, 2015 at 5:43 AM, Jay Kreps boredandr...@gmail.com wrote

Re: Review Request 28769: Patch for KAFKA-1809

2015-01-29 Thread Jeff Holoman
On Jan. 23, 2015, 1:57 a.m., Jun Rao wrote: core/src/main/scala/kafka/server/KafkaConfig.scala, lines 182-183 https://reviews.apache.org/r/28769/diff/12/?file=820431#file820431line182 Since this is also used for communication btw the controller and the brokers, perhaps it's

Re: 0.9 security features and release schedule

2015-01-25 Thread Jeff Holoman
that implement security features? thanks, Justin -- Jeff Holoman Systems Engineer

[jira] [Updated] (KAFKA-1810) Add IP Filtering / Whitelists-Blacklists

2015-01-25 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1810: Component/s: security Add IP Filtering / Whitelists-Blacklists

[jira] [Commented] (KAFKA-1782) Junit3 Misusage

2015-01-21 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286491#comment-14286491 ] Jeff Holoman commented on KAFKA-1782: - Thank you for the feedback [~guozhang]. I

[KIP-DISCUSSION] KIP-7 Security - IP Filtering

2015-01-21 Thread Jeff Holoman
Posted a KIP for IP Filtering: https://cwiki.apache.org/confluence/display/KAFKA/KIP-7+-+Security+-+IP+Filtering Relevant JIRA: https://issues.apache.org/jira/browse/KAFKA-1810 Appreciate any feedback. Thanks Jeff

[jira] [Commented] (KAFKA-1810) Add IP Filtering / Whitelists-Blacklists

2015-01-21 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286741#comment-14286741 ] Jeff Holoman commented on KAFKA-1810: - The current plan is to rework the configuration

Re: Review Request 29714: Patch for KAFKA-1810

2015-01-16 Thread Jeff Holoman
--- On Jan. 16, 2015, 12:48 a.m., Jeff Holoman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29714/ --- (Updated Jan. 16

[jira] [Updated] (KAFKA-1810) Add IP Filtering / Whitelists-Blacklists

2015-01-15 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1810: Attachment: KAFKA-1810_2015-01-15_19:47:14.patch Add IP Filtering / Whitelists-Blacklists

Re: Review Request 29714: Patch for KAFKA-1810

2015-01-15 Thread Jeff Holoman
realted to this functionality, one to handle configuration errors, and one to handle blocking the request. Currently the level is set to INFO. Does it make sense to move this to WARN ? Thanks, Jeff Holoman

[jira] [Commented] (KAFKA-1810) Add IP Filtering / Whitelists-Blacklists

2015-01-15 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279609#comment-14279609 ] Jeff Holoman commented on KAFKA-1810: - Updated reviewboard https://reviews.apache.org

Re: Review Request 29714: Patch for KAFKA-1810

2015-01-09 Thread Jeff Holoman
://reviews.apache.org/r/29714/#comment111609 This needs to be addressed as I backed out the previous fix for 1512 core/src/main/scala/kafka/server/KafkaServer.scala https://reviews.apache.org/r/29714/#comment111610 Also needs to be fixed to include previous fix for 1512 - Jeff Holoman

Review Request 29714: Patch for KAFKA-1810

2015-01-08 Thread Jeff Holoman
--- Thanks, Jeff Holoman

[jira] [Updated] (KAFKA-1810) Add IP Filtering / Whitelists-Blacklists

2015-01-08 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1810: Attachment: KAFKA-1810.patch Add IP Filtering / Whitelists-Blacklists

[jira] [Updated] (KAFKA-1810) Add IP Filtering / Whitelists-Blacklists

2015-01-08 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1810: Status: Patch Available (was: Open) Add IP Filtering / Whitelists-Blacklists

[jira] [Commented] (KAFKA-1810) Add IP Filtering / Whitelists-Blacklists

2015-01-08 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269567#comment-14269567 ] Jeff Holoman commented on KAFKA-1810: - Created reviewboard https://reviews.apache.org

[jira] [Commented] (KAFKA-1810) Add IP Filtering / Whitelists-Blacklists

2015-01-08 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269579#comment-14269579 ] Jeff Holoman commented on KAFKA-1810: - This patch is a first pass at implementing IP

Re: Review Request 29714: Patch for KAFKA-1810

2015-01-08 Thread Jeff Holoman
configuration errors, and one to handle blocking the request. Currently the level is set to INFO. Does it make sense to move this to WARN ? Thanks, Jeff Holoman

Re: Review Request 29301: Patch for KAFKA-1694

2015-01-06 Thread Jeff Holoman
/AlterTopicCommand.java https://reviews.apache.org/r/29301/#comment110502 minor nit: grammar. The topic to be created, altered, or described - Jeff Holoman On Dec. 24, 2014, 7:22 p.m., Andrii Biletskyi wrote: --- This is an automatically generated e

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

2015-01-05 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1512: Attachment: KAFKA-1512-082.patch Patch against 0.8.2 Limit the maximum number of connections per

[jira] [Commented] (KAFKA-1782) Junit3 Misusage

2014-12-27 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259533#comment-14259533 ] Jeff Holoman commented on KAFKA-1782: - I did a check through the tests looking

[jira] [Comment Edited] (KAFKA-1782) Junit3 Misusage

2014-12-27 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259533#comment-14259533 ] Jeff Holoman edited comment on KAFKA-1782 at 12/28/14 12:26 AM

[jira] [Commented] (KAFKA-1782) Junit3 Misusage

2014-12-25 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258803#comment-14258803 ] Jeff Holoman commented on KAFKA-1782: - Given the timing, is it best to move the fix

Re: Review Request 29029: Patch for KAFKA-1512

2014-12-23 Thread Jeff Holoman
--- Thanks, Jeff Holoman

[jira] [Commented] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-23 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257846#comment-14257846 ] Jeff Holoman commented on KAFKA-1512: - Updated reviewboard https://reviews.apache.org

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-23 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1512: Attachment: KAFKA-1512_2014-12-23_21:24:28.patch Limit the maximum number of connections per ip

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-23 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1512: Attachment: (was: KAFKA-1512.patch) Limit the maximum number of connections per ip address

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-23 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1512: Attachment: (was: KAFKA-1512_2014-12-14_21:16:55.patch) Limit the maximum number

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-23 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1512: Attachment: (was: KAFKA-1512_2014-12-14_21:30:27.patch) Limit the maximum number

Re: Review Request 29029: Patch for KAFKA-1512

2014-12-23 Thread Jeff Holoman
/SocketServerTest.scala 5f4d85254c384dcc27a5a84f0836ea225d3a901a Diff: https://reviews.apache.org/r/29029/diff/ Testing --- Thanks, Jeff Holoman

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-23 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1512: Attachment: KAFKA-1512_2014-12-23_21:47:23.patch Limit the maximum number of connections per ip

[jira] [Commented] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-23 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257864#comment-14257864 ] Jeff Holoman commented on KAFKA-1512: - Updated reviewboard https://reviews.apache.org

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-23 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1512: Attachment: (was: KAFKA-1512_2014-12-23_21:24:28.patch) Limit the maximum number

[jira] [Commented] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-23 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257869#comment-14257869 ] Jeff Holoman commented on KAFKA-1512: - I modified the two tests related to max

Re: Review Request 29029: Patch for KAFKA-1512

2014-12-15 Thread Jeff Holoman
. - Jeff --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29029/#review65114 --- On Dec. 15, 2014, 2:30 a.m., Jeff Holoman wrote

[jira] [Comment Edited] (KAFKA-1810) Add IP Filtering / Whitelists-Blacklists

2014-12-14 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14240484#comment-14240484 ] Jeff Holoman edited comment on KAFKA-1810 at 12/14/14 3:08 PM

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-14 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1512: Attachment: KAFKA-1512.patch Limit the maximum number of connections per ip address

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-14 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1512: Status: Patch Available (was: Reopened) Limit the maximum number of connections per ip address

Review Request 29029: KAFKA-1512 wire in Override configuration

2014-12-14 Thread Jeff Holoman
1bf7d10cef23a77e71eb16bf6d0e68bc4ebe core/src/test/scala/unit/kafka/network/SocketServerTest.scala 5f4d85254c384dcc27a5a84f0836ea225d3a901a Diff: https://reviews.apache.org/r/29029/diff/ Testing --- Thanks, Jeff Holoman

[jira] [Commented] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-14 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246003#comment-14246003 ] Jeff Holoman commented on KAFKA-1512: - Created reviewboard https://reviews.apache.org

Re: Review Request 29029: Patch for KAFKA-1512

2014-12-14 Thread Jeff Holoman
--- Thanks, Jeff Holoman

[jira] [Commented] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-14 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246237#comment-14246237 ] Jeff Holoman commented on KAFKA-1512: - Updated reviewboard https://reviews.apache.org

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-14 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1512: Attachment: KAFKA-1512_2014-12-14_21:16:55.patch Limit the maximum number of connections per ip

Re: Review Request 29029: Patch for KAFKA-1512

2014-12-14 Thread Jeff Holoman
/KafkaServer.scala 1bf7d10cef23a77e71eb16bf6d0e68bc4ebe core/src/test/scala/unit/kafka/network/SocketServerTest.scala 5f4d85254c384dcc27a5a84f0836ea225d3a901a Diff: https://reviews.apache.org/r/29029/diff/ Testing --- Thanks, Jeff Holoman

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-14 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1512: Attachment: KAFKA-1512_2014-12-14_21:21:37.patch Limit the maximum number of connections per ip

[jira] [Commented] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-14 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246242#comment-14246242 ] Jeff Holoman commented on KAFKA-1512: - Updated reviewboard https://reviews.apache.org

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-14 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1512: Attachment: KAFKA-1512_2014-12-14_21:30:27.patch Limit the maximum number of connections per ip

[jira] [Commented] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-14 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246250#comment-14246250 ] Jeff Holoman commented on KAFKA-1512: - Updated reviewboard https://reviews.apache.org

[jira] [Assigned] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-12 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman reassigned KAFKA-1512: --- Assignee: Jeff Holoman Limit the maximum number of connections per ip address

[jira] [Commented] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-12 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14244729#comment-14244729 ] Jeff Holoman commented on KAFKA-1512: - [~jkreps] I can fix this if you're ok

[jira] [Commented] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-12-11 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243430#comment-14243430 ] Jeff Holoman commented on KAFKA-1512: - [~jkreps], I noticed that the overrides

Re: Review Request 28859: Patch for KAFKA-1812

2014-12-10 Thread Jeff Holoman
/UtilsTest.scala 0d0f0e2fba367180eeb718a259e8d680a73c3a73 Diff: https://reviews.apache.org/r/28859/diff/ Testing --- Thanks, Jeff Holoman

  1   2   >