Yes.
Thanks,
Mayuresh
On Tue, Jul 21, 2015 at 12:27 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Did you setup your jira.ini?
On Tue, Jul 21, 2015 at 11:52 AM, Mayuresh Gharat
gharatmayures...@gmail.com wrote:
Hi,
I had to clean up existing kafka repo on my linux box
Not sure if you can do that with High level consumer.
Thanks,
Mayuresh
On Tue, Jul 21, 2015 at 10:53 AM, Pranay Agarwal agarwalpran...@gmail.com
wrote:
Any ideas?
On Mon, Jul 20, 2015 at 2:34 PM, Pranay Agarwal agarwalpran...@gmail.com
wrote:
Hi all,
Is there any way I can force
On July 21, 2015, 8:18 p.m., Mayuresh Gharat wrote:
T
Yes. Got it, I thought that we should be catching all exceptions and exit. But
doing the above will catch the exception and exit when its shutting down and
thats the only thing that this ticket considers.
- Mayuresh
: https://reviews.apache.org/r/36652/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-2351:
---
Attachment: KAFKA-2351_2015-07-21_14:58:13.patch
Brokers are having a problem shutting down
[
https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635885#comment-14635885
]
Mayuresh Gharat commented on KAFKA-2351:
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-2351:
---
Status: Patch Available (was: Open)
Brokers are having a problem shutting down correctly
[
https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-2351:
---
Attachment: KAFKA-2351.patch
Brokers are having a problem shutting down correctly
---
Thanks,
Mayuresh Gharat
Resolved this.
Thanks,
Mayuresh
On Tue, Jul 21, 2015 at 12:59 PM, Mayuresh Gharat
gharatmayures...@gmail.com wrote:
Yes.
Thanks,
Mayuresh
On Tue, Jul 21, 2015 at 12:27 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Did you setup your jira.ini?
On Tue, Jul 21, 2015
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36652/#review92470
---
On July 21, 2015, 8:11 p.m., Mayuresh Gharat wrote
[
https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635734#comment-14635734
]
Mayuresh Gharat commented on KAFKA-2351:
Created reviewboard https
Thanks Jun.
Thanks,
Mayuresh
On Mon, Jul 20, 2015 at 10:03 AM, Jun Rao j...@confluent.io wrote:
Added.
Thanks,
Jun
On Mon, Jul 20, 2015 at 9:48 AM, Mayuresh Gharat
gharatmayures...@gmail.com
wrote:
My username is : mgharat
On Mon, Jul 20, 2015 at 9:46 AM, Mayuresh Gharat
Hi,
I wanted to edit a KIP page and would like to get permission for that.
Currently I don't have edit authorization. It does not show me an option to
edit.
Can one of the committers grant me permission? Thanks.
--
-Regards,
Mayuresh R. Gharat
(862) 250-7125
My username is : mgharat
On Mon, Jul 20, 2015 at 9:46 AM, Mayuresh Gharat gharatmayures...@gmail.com
wrote:
Hi,
I wanted to edit a KIP page and would like to get permission for that.
Currently I don't have edit authorization. It does not show me an option to
edit.
Can one
Mayuresh Gharat created KAFKA-2351:
--
Summary: Brokers are having a problem shutting down correctly
Key: KAFKA-2351
URL: https://issues.apache.org/jira/browse/KAFKA-2351
Project: Kafka
Issue
If we have 2 producers producing to a partition, they can be out of order,
then how does one producer know what offset to expect as it does not
interact with other producer?
Can you give an example flow that explains how it works with single
producer and with multiple producers?
Thanks,
[
https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14629988#comment-14629988
]
Mayuresh Gharat commented on KAFKA-1835:
I had a concern here, what happens
[
https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627263#comment-14627263
]
Mayuresh Gharat commented on KAFKA-1835:
Either way user will have to block
[
https://issues.apache.org/jira/browse/KAFKA-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624933#comment-14624933
]
Mayuresh Gharat commented on KAFKA-1788:
Hi [~parth.brahmbhatt], this is been
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36345/#review91324
---
Ship it!
Ship It!
- Mayuresh Gharat
On July 9, 2015, 9:05 a.m
[
https://issues.apache.org/jira/browse/KAFKA-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593812#comment-14593812
]
Mayuresh Gharat edited comment on KAFKA-2012 at 6/19/15 7:30 PM
[
https://issues.apache.org/jira/browse/KAFKA-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14580837#comment-14580837
]
Mayuresh Gharat commented on KAFKA-2253:
Thanks [~guozhang] for this patch. I
[
https://issues.apache.org/jira/browse/KAFKA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14575390#comment-14575390
]
Mayuresh Gharat commented on KAFKA-2160:
We hit a deadlock while running brokers
Mayuresh Gharat created KAFKA-2253:
--
Summary: Deadlock in delayed operation purgatory
Key: KAFKA-2253
URL: https://issues.apache.org/jira/browse/KAFKA-2253
Project: Kafka
Issue Type: Bug
+1 (non-binding). Thanks Jiangjie.
Thanks,
Mayuresh
On Tue, Jun 2, 2015 at 4:49 PM, Ewen Cheslack-Postava e...@confluent.io
wrote:
+1 non-binding. Thanks for all the work on this Jiangjie!
Aditya -- see discussion of partitionsFor() API, which needs to also use
one of those timeouts, and
TopicCreateRequest should be issued or not on UnknownTopicException. If
this is disabled and the topic doesn't exist, send will fail and the user
is expected to create the topic manually.
Thanks,
Jun
On Thu, May 21, 2015 at 5:27 PM, Mayuresh Gharat
gharatmayures...@gmail.com
wrote:
Hi
to something reasonable but maybe you
can override it if you want?
Thoughts?
-Jay
On Tue, May 19, 2015 at 11:34 AM, Mayuresh Gharat
gharatmayures...@gmail.com wrote:
So what I understand is that, we would have 3 time outs :
1) replication timeout
2) request timeout
3
) Qin
On 5/12/15, 2:59 PM, Mayuresh Gharat gharatmayures...@gmail.com
wrote:
+1 Becket. That would give enough time for clients to move. We should
make
this change very clear.
Thanks,
Mayuresh
On Tue, May 12, 2015 at 1:45 PM, Jiangjie Qin j...@linkedin.com.invalid
wrote
On Tue, May 19, 2015 at 11:34 AM, Mayuresh Gharat
gharatmayures...@gmail.com wrote:
So what I understand is that, we would have 3 time outs :
1) replication timeout
2) request timeout
3) metadata timeout (existing)
The request timeout has to be greater than the replication timeout
refresh will find the new
broker and we will not try to reconnect to the broker anymore.
Comments are welcome!
Thanks.
Jiangjie (Becket) Qin
On 5/12/15, 2:59 PM, Mayuresh Gharat gharatmayures...@gmail.com
wrote:
+1 Becket. That would give enough time for clients to move. We
, hopefully metadata refresh will find the new
broker and we will not try to reconnect to the broker anymore.
Comments are welcome!
Thanks.
Jiangjie (Becket) Qin
On 5/12/15, 2:59 PM, Mayuresh Gharat gharatmayures...@gmail.com wrote:
+1 Becket. That would give enough time for clients to move
[
https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14540270#comment-14540270
]
Mayuresh Gharat commented on KAFKA-1554:
This sounds interesting. We may try
+1 Becket. That would give enough time for clients to move. We should make
this change very clear.
Thanks,
Mayuresh
On Tue, May 12, 2015 at 1:45 PM, Jiangjie Qin j...@linkedin.com.invalid
wrote:
Hey Ewen,
Very good summary about the compatibility. What you proposed makes sense.
So
Just a quick question, can we handle REQUEST TIMEOUT as disconnections and
do a fresh MetaDataRequest and retry instead of failing the request?
Thanks,
Mayuresh
On Mon, May 4, 2015 at 10:32 AM, Jiangjie Qin j...@linkedin.com.invalid
wrote:
I incorporated Ewen and Guozhang’s comments in the
Agreed we also need to change in the code of Sender.java to indicate that
it resembles REPLICATION_TIMEOUT and not the request Timeout.
Thanks,
Mayuresh
On Thu, Apr 16, 2015 at 1:08 PM, Jiangjie Qin j...@linkedin.com.invalid
wrote:
Hi Guozhang,
By implicit timeout for close() and flush(), I
I suppose adding this timeout will help. In cases were the broker is not
completely down but stops responding to the produce request, tools like
Mirror Makers will hang since they are waiting for responses. Adding this
timeout enables it to fail the current request and retry with fresh
metadata.
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat reassigned KAFKA-2120:
--
Assignee: Mayuresh Gharat
Add a request timeout to NetworkClient
You can take a look at this :
https://issues.apache.org/jira/browse/KAFKA-1848
Thanks,
Mayuresh
On Sun, Mar 29, 2015 at 4:45 PM, Jiangjie Qin (JIRA) j...@apache.org
wrote:
[
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32440/#review77787
---
Ship it!
- Mayuresh Gharat
On March 25, 2015, 6:29 p.m., Grant
/KafkaProducer.java
https://reviews.apache.org/r/32440/#comment125718
Since its a Producer level config, is this change needed. We can keep it as
an instance variable. Also since the compression type does not change, the
private final makes it more clear. What do you think?
- Mayuresh Gharat
On March 24, 2015, 5 p.m., Mayuresh Gharat wrote:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java,
line 134
https://reviews.apache.org/r/32440/diff/1/?file=904417#file904417line134
Since its a Producer level config, is this change needed. We can keep
[
https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1554:
---
Status: Patch Available (was: Open)
Corrupt index found on clean startup
[
https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1554:
---
Attachment: KAFKA-1554.patch
Corrupt index found on clean startup
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377009#comment-14377009
]
Mayuresh Gharat commented on KAFKA-1554:
Created reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370426#comment-14370426
]
Mayuresh Gharat commented on KAFKA-1778:
I did not get :
c) Broker x
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32199/#review77060
---
LGTM
- Mayuresh Gharat
On March 18, 2015, 11:12 a.m., Adrian
[
https://issues.apache.org/jira/browse/KAFKA-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1860:
---
Status: Patch Available (was: Open)
File system errors are not detected unless Kafka tries
[
https://issues.apache.org/jira/browse/KAFKA-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366069#comment-14366069
]
Mayuresh Gharat commented on KAFKA-1860:
Created reviewboard https
/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366088#comment-14366088
]
Mayuresh Gharat commented on KAFKA-1860:
We need to reproduce and test the fix
I think the way reassignment works is asynchronous. Changes are made to
zookeeper but those changes get reflected only when controller watcher
fires for the respective zookeeper path. Is your watcher still alive?
Thanks,
Mayuresh
On Tue, Mar 17, 2015 at 1:29 PM, Allen Wang
[
https://issues.apache.org/jira/browse/KAFKA-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1860:
---
Comment: was deleted
(was: We need to reproduce and test the fix on our kafka server mp
...@netflix.com.invalid
wrote:
Yes, the watcher is still alive. The log in the controller indicates that
it observed the changes.
On Tue, Mar 17, 2015 at 2:05 PM, Mayuresh Gharat
gharatmayures...@gmail.com
wrote:
I think the way reassignment works is asynchronous. Changes are made to
zookeeper
[
https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14361309#comment-14361309
]
Mayuresh Gharat commented on KAFKA-1554:
I can take a shot at this one.
Corrupt
[
https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14361306#comment-14361306
]
Mayuresh Gharat edited comment on KAFKA-1554 at 3/13/15 11:26 PM
[
https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat reassigned KAFKA-1554:
--
Assignee: Mayuresh Gharat
Corrupt index found on clean startup
Mayuresh Gharat created KAFKA-2014:
--
Summary: Chaos Monkey / Failure Inducer for Kafka
Key: KAFKA-2014
URL: https://issues.apache.org/jira/browse/KAFKA-2014
Project: Kafka
Issue Type: Task
[
https://issues.apache.org/jira/browse/KAFKA-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14347645#comment-14347645
]
Mayuresh Gharat commented on KAFKA-1998:
I suppose what we need to do is top
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31306/#review74992
---
Ship it!
Ship It!
- Mayuresh Gharat
On Feb. 26, 2015, 6:54 p.m
://reviews.apache.org/r/31306/#comment121866
This will mean that if there are unkeyed messages we will neglect them and
not throw an exception right?
So we are aloowing unkeyed messages to go through comapction.
- Mayuresh Gharat
On Feb. 26, 2015, 6:54 p.m., Joel Koshy wrote
[
https://issues.apache.org/jira/browse/KAFKA-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat reassigned KAFKA-1998:
--
Assignee: Mayuresh Gharat
Partitions Missing From MetadataResponse
[
https://issues.apache.org/jira/browse/KAFKA-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333536#comment-14333536
]
Mayuresh Gharat commented on KAFKA-1796:
[~nehanarkhede] Sure. Actually I went
://reviews.apache.org/r/31306/#comment120016
We may also need to check this right:
sourceCodec != NoCompressionCodec
- Mayuresh Gharat
On Feb. 23, 2015, 2:43 p.m., Joel Koshy wrote:
---
This is an automatically generated e-mail
/#comment118893
Are you assuming that first argument will be some key?
core/src/main/scala/kafka/tools/ContinuousValidationTest.java
https://reviews.apache.org/r/30809/#comment118907
what do you mean by rebuild state later?
- Mayuresh Gharat
On Feb. 9, 2015, 11:53 p.m., Abhishek Nigam
[
https://issues.apache.org/jira/browse/KAFKA-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat reassigned KAFKA-1796:
--
Assignee: Mayuresh Gharat
Sanity check partition command line tools
[
https://issues.apache.org/jira/browse/KAFKA-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319346#comment-14319346
]
Mayuresh Gharat edited comment on KAFKA-1796 at 2/13/15 1:07 AM
[
https://issues.apache.org/jira/browse/KAFKA-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319346#comment-14319346
]
Mayuresh Gharat commented on KAFKA-1796:
[~nehanarkhede], I went over KAFKA-1678
[
https://issues.apache.org/jira/browse/KAFKA-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat reassigned KAFKA-1860:
--
Assignee: Mayuresh Gharat (was: Guozhang Wang)
File system errors are not detected
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14276282#comment-14276282
]
Mayuresh Gharat commented on KAFKA-1013:
Updated reviewboard https
41f334d48897b3027ed54c58bbf4811487d3b191
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala
4a3a5b264a021e55c39f4d7424ce04ee591503ef
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1013:
---
Attachment: KAFKA-1013_2015-01-13_16:43:03.patch
Modify existing tools as per the changes
[
https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14275714#comment-14275714
]
Mayuresh Gharat commented on KAFKA-1476:
Was just thinking if this can be exposed
://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1013:
---
Attachment: KAFKA-1013_2015-01-13_13:56:39.patch
Modify existing tools as per the changes
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1013:
---
Description:
Modify existing tools as per the changes in KAFKA-1000. AFAIK, the tools below
[
https://issues.apache.org/jira/browse/KAFKA-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat resolved KAFKA-1785.
Resolution: Duplicate
Consumer offset checker should show the offset manager and offsets
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14276025#comment-14276025
]
Mayuresh Gharat commented on KAFKA-1013:
Updated reviewboard https
/OffsetCommitTest.scala
8c5364fa97da1be09973c176d1baeb339455d319
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14265225#comment-14265225
]
Mayuresh Gharat commented on KAFKA-1013:
Yes. I suppose the code will require
[
https://issues.apache.org/jira/browse/KAFKA-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14265465#comment-14265465
]
Mayuresh Gharat commented on KAFKA-1785:
Talked to Joel about it last time. Joel
[
https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14260506#comment-14260506
]
Mayuresh Gharat commented on KAFKA-1784:
I suppose we don't require this ticket
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1013:
---
Attachment: KAFKA-1013_2014-12-27_16:15:54.patch
Modify existing tools as per the changes
8c5364fa97da1be09973c176d1baeb339455d319
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259530#comment-14259530
]
Mayuresh Gharat commented on KAFKA-1013:
Updated reviewboard https
/OffsetCommitTest.scala
8c5364fa97da1be09973c176d1baeb339455d319
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259531#comment-14259531
]
Mayuresh Gharat commented on KAFKA-1013:
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1013:
---
Attachment: KAFKA-1013_2014-12-27_16:20:57.patch
Modify existing tools as per the changes
/TestOffsetManager.scala
41f334d48897b3027ed54c58bbf4811487d3b191
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala
8c5364fa97da1be09973c176d1baeb339455d319
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
/25944/#review65997
---
On Dec. 24, 2014, 12:41 a.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944
/ImportOffsets.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1013:
---
Attachment: KAFKA-1013_2014-12-21_14:42:49.patch
Modify existing tools as per the changes
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255286#comment-14255286
]
Mayuresh Gharat commented on KAFKA-1013:
Updated reviewboard https
/TestOffsetManager.scala
41f334d48897b3027ed54c58bbf4811487d3b191
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala
8c5364fa97da1be09973c176d1baeb339455d319
Diff: https://reviews.apache.org/r/26291/diff/
Testing
---
Thanks,
Mayuresh Gharat
, your admin tool can just utilize the existing
APIst to expose commit/fetch through the tool. This class may be
unnecessary.
Mayuresh Gharat wrote:
I can pull out the code and use client utils as of now and once we get
the other patch with refactored code we can use this. Does
/TestOffsetManager.scala
41f334d48897b3027ed54c58bbf4811487d3b191
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala
8c5364fa97da1be09973c176d1baeb339455d319
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
, your admin tool can just utilize the existing
APIst to expose commit/fetch through the tool. This class may be
unnecessary.
Mayuresh Gharat wrote:
I can pull out the code and use client utils as of now and once we get
the other patch with refactored code we can use this. Does
/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION
Diff: https://reviews.apache.org/r/28793/diff/
Testing
---
Thanks,
Mayuresh Gharat
/r/28793/#review64477
---
On Dec. 7, 2014, 7:43 p.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28793
401 - 500 of 593 matches
Mail list logo
