[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-07-16 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709904#comment-13709904 ] Scott Carey commented on KAFKA-717: --- {quote}As it stands now folks are already running

[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-07-16 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709915#comment-13709915 ] Scott Carey commented on KAFKA-717: --- {quote}that would be easiest for us would be

[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-07-16 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710343#comment-13710343 ] Scott Carey commented on KAFKA-717: --- The latter plan looks good to me.

[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-07-15 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708973#comment-13708973 ] Scott Carey commented on KAFKA-717: --- {quote} looking at the simple patch not sure

[jira] [Updated] (KAFKA-717) scala 2.10 build support

2013-06-14 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated KAFKA-717: -- Attachment: 0004-Fix-cross-compile-of-tests-update-to-2.10.2-and-set-.patch

[jira] [Commented] (KAFKA-133) Publish kafka jar to a public maven repository

2013-04-29 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13645053#comment-13645053 ] Scott Carey commented on KAFKA-133: --- The build is using SBT, whic is using Ivy behind the

[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-04-23 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13639349#comment-13639349 ] Scott Carey commented on KAFKA-717: --- The patch was meant to apply to the 0.8 branch. The

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

2013-04-23 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13639553#comment-13639553 ] Scott Carey commented on KAFKA-873: --- The way the in-memory ZK is used needs to change

[jira] [Commented] (KAFKA-865) Mavenize and separate the client.

2013-04-18 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13635478#comment-13635478 ] Scott Carey commented on KAFKA-865: --- I'm a big fan of Maven (It has some big flaws, but

[jira] [Commented] (KAFKA-156) Messages should not be dropped when brokers are unavailable

2013-04-14 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631474#comment-13631474 ] Scott Carey commented on KAFKA-156: --- Jay -- I agree, the duplication issue does not

[jira] [Commented] (KAFKA-843) Re-add the release-zip sbt target

2013-04-12 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630562#comment-13630562 ] Scott Carey commented on KAFKA-843: --- Another suggestion: What if buildNumber was only

[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-12 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630579#comment-13630579 ] Scott Carey commented on KAFKA-854: --- 1. It is probably easier to review by looking at the

[jira] [Commented] (KAFKA-843) Re-add the release-zip sbt target

2013-04-11 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629221#comment-13629221 ] Scott Carey commented on KAFKA-843: --- This seems to require that there be a buildNumber,

[jira] [Commented] (KAFKA-843) Re-add the release-zip sbt target

2013-04-11 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629400#comment-13629400 ] Scott Carey commented on KAFKA-843: --- The final release artifact version will be version =

[jira] [Updated] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-09 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated KAFKA-854: -- Attachment: KAFKA-854.patch Cleans up dependencies and SBT build in general (~350 lines fewer than

[jira] [Updated] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-09 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated KAFKA-854: -- Attachment: KAFKA-854.patch Rebased to 0.8 branch, 6dbf9212ae4dc6ed7f91fc99135b8a3b35ab5edb Big

[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-08 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13625652#comment-13625652 ] Scott Carey commented on KAFKA-854: --- {quote} While you're at it you could also upgrade

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-08 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13626135#comment-13626135 ] Scott Carey commented on KAFKA-826: --- Can a committer look at this? This would be great

[jira] [Updated] (KAFKA-717) scala 2.10 build support

2013-04-07 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated KAFKA-717: -- Attachment: KAFKA-717-complex.patch KAFKA-717-simple.patch The patches here implement

[jira] [Created] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-05 Thread Scott Carey (JIRA)
Scott Carey created KAFKA-854: - Summary: Upgrade dependencies for 0.8 Key: KAFKA-854 URL: https://issues.apache.org/jira/browse/KAFKA-854 Project: Kafka Issue Type: Improvement Affects

[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-04-05 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624220#comment-13624220 ] Scott Carey commented on KAFKA-717: --- To support all versions concurrently, we need a

[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-05 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624250#comment-13624250 ] Scott Carey commented on KAFKA-854: --- Also, upgrading log4j means that all of the ugly

[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-05 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624255#comment-13624255 ] Scott Carey commented on KAFKA-854: --- Why are dependencies repeated?

[jira] [Comment Edited] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-05 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624255#comment-13624255 ] Scott Carey edited comment on KAFKA-854 at 4/6/13 1:06 AM: --- Why

[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-05 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624264#comment-13624264 ] Scott Carey commented on KAFKA-854: --- Ick, worse, some dependencies are listed three times

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-04 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13622650#comment-13622650 ] Scott Carey commented on KAFKA-826: --- Sounds good to me. Make Kafka 0.8

[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-04-04 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13623232#comment-13623232 ] Scott Carey commented on KAFKA-717: --- The patch is already attached to this ticket, it is

[jira] [Comment Edited] (KAFKA-717) scala 2.10 build support

2013-04-04 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13623232#comment-13623232 ] Scott Carey edited comment on KAFKA-717 at 4/5/13 1:19 AM: --- The

[jira] [Commented] (KAFKA-264) Change the consumer side load balancing and distributed co-ordination to use a consumer co-ordinator

2013-04-03 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621242#comment-13621242 ] Scott Carey commented on KAFKA-264: --- Is this still going into 0.8? Is it already in

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-03 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621416#comment-13621416 ] Scott Carey commented on KAFKA-826: --- My main complaint prior to this was two-fold: *

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-03 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621426#comment-13621426 ] Scott Carey commented on KAFKA-826: --- Given the volume of work that has been done on

[jira] [Commented] (KAFKA-156) Messages should not be dropped when brokers are unavailable

2013-04-03 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621433#comment-13621433 ] Scott Carey commented on KAFKA-156: --- I am positive that the producer wire protocol has to

[jira] [Commented] (KAFKA-156) Messages should not be dropped when brokers are unavailable

2013-04-03 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621665#comment-13621665 ] Scott Carey commented on KAFKA-156: --- To support lossless transmission, the producer

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-03-29 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617539#comment-13617539 ] Scott Carey commented on KAFKA-826: --- The only real trouble with 3.0.x is if: * it

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-03-25 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13613192#comment-13613192 ] Scott Carey commented on KAFKA-826: --- Thank you! We will be able to test and validate

[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-03-04 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13592862#comment-13592862 ] Scott Carey commented on KAFKA-717: --- It appears that the changes are back-compatible with

[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-03-04 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13592900#comment-13592900 ] Scott Carey commented on KAFKA-717: --- I take that back, scala.annotation.StaticAnnotation

[jira] [Commented] (KAFKA-374) Move to java CRC32 implementation

2012-12-12 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13530654#comment-13530654 ] Scott Carey commented on KAFKA-374: --- Awesome. I was just profiling some Kafka 0.7.1