Re: [VOTE] KIP-1082: Require Client-Generated IDs over the ConsumerGroupHeartbeat RPC

Hello everyone, The vote is now closed, and the KIP has been accepted with 4 binding +1s from Chia-Ping, Chris, David, and Lianet, as well as 3 non-binding +1 from Kirk, TaiJuWu, and Andrew. Thank you all for your participation! Sincerely, TengYao TengYao Chi 於 2024年10月3日 週四 下午7:41寫道： >

[jira] [Reopened] (KAFKA-15369) Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

[ https://issues.apache.org/jira/browse/KAFKA-15369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reopened KAFKA-15369: - > Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add > Cont

Re: [VOTE] KIP-1082: Require Client-Generated IDs over the ConsumerGroupHeartbeat RPC

iven that the RPC is already in version 1. > > With that I'm +1 (binding) > > Thanks! > Lianet > > On Thu, Oct 3, 2024 at 5:01 AM David Jacot > wrote: > > > +1 (binding) > > > > Thanks for the KIP! > > > > Best, > > David > &g

Re: [VOTE] KIP-1082: Require Client-Generated IDs over the ConsumerGroupHeartbeat RPC

e. > > > > > > Best, > > > Chia-Ping > > > > > > Kirk True 於 2024年9月16日 週一 下午11:36寫道： > > > > > > > Hi TengYao, > > > > > > > > +1 (non-binding) > > > > > > > > Thanks for a

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

Hello everyone, It seems we have reached a consensus on how this KIP will proceed. I have updated the content accordingly. Please take a look, and if there are no further questions, I will initiate a vote. Best regards, TengYao Chia-Ping Tsai 於 2024年10月2日 週三 上午7:06寫道： > hi Matthias > > Thanks

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

24年10月1日 週二 下午2:41寫道： > +1 from me on the fluent API using the `with` prefix too. > > Thanks, > Andrew > > ____________ > From: TengYao Chi > Sent: 01 October 2024 05:23 > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-1092: Extend Con

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

;>>> sub-class > >>>>> which would have the getters if needed. So I think we should have > >>>>> > >>>>> I value the static factory methods for their convenience, allowing > >>> users > >>>> to > >>&

Re: [VOTE] KIP-1090 Flaky Test Management

+1 (non-binding) Thank you, David Best, TengYao 吳岱儒 於 2024年9月30日 週一，下午6:01寫道： > +1 (non-binding) > Thanks David, I do love this flaky tag. > > TJ >

[jira] [Resolved] (KAFKA-17560) testCurrentLag flaky if enabled for new consumer

[ https://issues.apache.org/jira/browse/KAFKA-17560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi resolved KAFKA-17560. - Resolution: Fixed > testCurrentLag flaky if enabled for new consu

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

oven pattern is to have a few static > > "entry" methods, with return the object itself to allow chaining with > > non-static methods. > > > > > > > > I am not sure, why KIP-812 did not follow this pattern... I think it got > > it wrong and we should not repeat

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

uot;default" and "user-defined" > behaviors. > > Therefore, I prefer to leave the timeout empty as the default value, > allowing the consumer to handle it in a way that reflects default behavior. > Best, > Chia-Ping > > > > TengYao Chi 於 2024年9月29日 週日 下午

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

Or should we > > allow users to pass in an "empty" CloseOptions to leave both the timeout > > and leaveGroup behavior to the default? > > > > > > > > On Sat, Sep 28, 2024 at 9:58 AM Chia-Ping Tsai > wrote: > > > > > hi TengYao > >

[jira] [Created] (KAFKA-17651) Implement `describeDelegationToken`, `describeUserScramCredentials` and `unregisterBroker`

TengYao Chi created KAFKA-17651: --- Summary: Implement `describeDelegationToken`, `describeUserScramCredentials` and `unregisterBroker` Key: KAFKA-17651 URL: https://issues.apache.org/jira/browse/KAFKA-17651

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

Hi Sophie Thanks for feedback. I have updated the Public Interface part accordingly. Please take a look. Best, TengYao TengYao Chi 於 2024年9月28日 週六 下午1:26寫道： > Hi Matthias, > > Thanks for the explanation, particularly regarding the important > considerations for both the plain

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

Hi Matthias, Thanks for the explanation, particularly regarding the important considerations for both the plain consumer and Kafka Streams use cases. In this case, I think it would be better to stick with my initial proposal. We should give plain consumers the ability to determine whether to send

Re: Please subscribe me to kafka

Hi Prince, I'm not sure which group you're referring to. If you're looking to subscribe to the mailing list, please send an email to *dev-subscr...@kafka.apache.org * If that's not what you're looking for, please check out the Contact page on the Apache Kafka web

Re: [DISCUSS] KIP-1082: Enable ID Generation for Clients over the ConsumerGroupHeartbeat RPC

e group. > > > > > > > > > > I failed to find the code of implementing "The member is also > removed > > > > from > > > > > the group.". I will appreciate it if someone can share the code > link > > to > > > > m

[DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

Hello everyone, I would like to start a discussion thread on KIP-1092 , which proposes extending Consumer#close with an option to leave the consumer group or not. Please take a look and let me know what you think, and I would appreciate any suggestion

Re: [DISCUSS] KIP-1082: Enable ID Generation for Clients over the ConsumerGroupHeartbeat RPC

smatch occurs within a session: If the server detects a > > mismatch between the provided member ID and the expected member ID for an > > ongoing session, it should return a UNKNOWN_MEMBER_ID error. > > > > How could we detect a mismatch between the provided and the expected

Re: [DISCUSS] KIP-1082: Enable ID Generation for Clients over the ConsumerGroupHeartbeat RPC

ts a > mismatch between the provided member ID and the expected member ID for an > ongoing session, it should return a UNKNOWN_MEMBER_ID error. > > How could we detect a mismatch between the provided and the expected member > id? My understanding is that we can only know whethe

Re: [DISCUSS] KIP-1090 Flaky Tests 👻

rantined.txt? This > > would help us prioritize which tests to resolve first. > > > > Additionally, I would prefer to add a flaky (JUnit) tag to the source > code > > so we can focus on these tests during development. > > > > Thanks, > > TaiJuWu > &g

Re: [DISCUSS] KIP-1090 Flaky Tests 👻

Hi David, Thanks for this great KIP. I really appreciate the goal of this KIP, which aims to stabilize the build and improve our confidence in CI results. It addresses a real issue where we've become accustomed to seeing failed results from CI, and this is definitely not good for the Kafka commun

Re: [VOTE] KIP-1079: Deprecate `delete-config` of TopicCommand

Hello Federico I'm sorry that I missed your email. The ticket used to track future removal has been filed. (KAFKA-17556 <https://issues.apache.org/jira/browse/KAFKA-17556>) Please take a look and sorry for the inconvenience. Sincerely, TengYao TengYao Chi 於 2024年9月18日 週三 下午12:30寫

Re: [VOTE] KIP-1079: Deprecate `delete-config` of TopicCommand

+1 (binding) from me > > Justine > > On Mon, Sep 16, 2024 at 7:36 PM TengYao Chi wrote: > > > Hi Kirk > > Thanks for pointing out. I have updated the description of KAFKA-17087. > > > > Sincerely, > > TengYao > > > > Kirk True 於 2024年9月16日 週一

Re: [VOTE] KIP-1079: Deprecate `delete-config` of TopicCommand

M, Lianet M. wrote: > > > > Thanks for the update! Looks good to me now. > > > > +1 (binding) > > > > Cheers, > > > > Lianet > > > > On Mon, Sep 16, 2024 at 9:31 AM TengYao Chi wrote: > > > >> Hi Lianet, > >> &g

[jira] [Resolved] (KAFKA-17324) Set config group.protocol to classic in Streams

[ https://issues.apache.org/jira/browse/KAFKA-17324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi resolved KAFKA-17324. - Resolution: Fixed > Set config group.protocol to classic in Stre

[VOTE] KIP-1082: Require Client-Generated IDs over the ConsumerGroupHeartbeat RPC

Hi everyone, Based on our discussion regarding KIP-1082 , I believe this KIP is now ready for a vote. Sincerely, TengYao

Re: [VOTE] KIP-1079: Deprecate `delete-config` of TopicCommand

ot;Compatibility, Deprecation, and Migration Plan" section)? > > Thanks! > > Lianet > > On Mon, Sep 16, 2024 at 1:01 AM TengYao Chi wrote: > > > Hello everyone, > > I hope this message finds you well. > > As the vote has been pending for two wee

[jira] [Created] (KAFKA-17556) Delete `delete-config` of TopicCommand

TengYao Chi created KAFKA-17556: --- Summary: Delete `delete-config` of TopicCommand Key: KAFKA-17556 URL: https://issues.apache.org/jira/browse/KAFKA-17556 Project: Kafka Issue Type: Improvement

Re: [VOTE] KIP-1079: Deprecate `delete-config` of TopicCommand

> > > On 27 Aug 2024, at 10:31, Federico Valeri wrote: > > > > +1 non binding > > > > Should we also create a Jira to track future removal? > > > > On Tue, Aug 27, 2024 at 11:02 AM Chia-Ping Tsai > wrote: > >> > >> +1 (binding) >

[jira] [Resolved] (KAFKA-16027) Refactor MetadataTest#testUpdatePartitionLeadership

[ https://issues.apache.org/jira/browse/KAFKA-16027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi resolved KAFKA-16027. - Assignee: TengYao Chi (was: Alexander Aghili) Resolution: Resolved > Refac

Re: [DISCUSS] KIP-1082: Enable ID Generation for Clients over the ConsumerGroupHeartbeat RPC

Hello everyone, Since this KIP has been fully discussed, I will initiate a vote for it next Monday. Thank you and have a nice weekend. Best regards, TengYao TengYao Chi 於 2024年9月5日 週四 下午2:19寫道： > Hello everyone, > > KT2: It looks like everyone who has expressed an opinion sup

[jira] [Created] (KAFKA-17466) Revisit failAndRemoveExpiredCommitRequests method

TengYao Chi created KAFKA-17466: --- Summary: Revisit failAndRemoveExpiredCommitRequests method Key: KAFKA-17466 URL: https://issues.apache.org/jira/browse/KAFKA-17466 Project: Kafka Issue Type

Re: [DISCUSS] KIP-1082: Enable ID Generation for Clients over the ConsumerGroupHeartbeat RPC

t;The client should reuse the > same UUID as the member ID for all heartbeats and rejoin attempts to > maintain continuity within the group.” Could we change the first part of > that to “The Consumer instance should…” We do have lifetimes that extend > past the lifetime of a cl

Re: [DISCUSS] KIP-1082: Enable ID Generation for Clients over the ConsumerGroupHeartbeat RPC

I would expect > > that > > > the UUID is associated to a consumer instance (generated for the > consumer > > > the first time it needs to send a HB if it doesn't have the UUID yet. > > From > > > there on, every time it needs to send a "first HB&q

Re: [VOTE] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

Hello everyone, The vote is now closed, and the KIP has been accepted with 4 binding +1s from Chia-Ping, Matthias, Bill, and Lucas, as well as 1 non-binding +1 from 黃竣陽. Thank you all for your participation! Sincerely, TengYao Lucas Brutschy 於 2024年8月26日 週一 下午3:37寫道： > +1 (binding) > > On Thu

Re: [DISCUSS] KIP-1082: Enable ID Generation for Clients over the ConsumerGroupHeartbeat RPC

it's not part of it (ex. consumer unsubscribe + > subscribe, fenced, stale). Is this the intention or are you considering the > lifetime differently? We should clarify it in the KIP. > > Thanks! > > Lianet > > On Tue, Aug 27, 2024 at 2:27 AM TengYao Chi wrote: >

Re: [ANNOUNCE] New committer: Lianet Magrans

Congratulations, Lianet! This recognition is well deserved. Philip Nee 於 2024年8月29日 週四 上午1:09寫道： > congrats! > > On Wed, Aug 28, 2024 at 10:08 AM xijiu <422766...@qq.com.invalid> wrote: > > > Congratulations Lianet! > > > > > > > > > > ---Original--- > > From: "Kirk True" > Date: Thu, Aug 29, 20

Re: [DISCUSS] KIP-1082: Enable ID Generation for Clients over the ConsumerGroupHeartbeat RPC

TengYao Chi 於 2024年8月23日 週五 下午2:43寫道： > Hi Andrew, > Thank you for your previous feedback and insights. > Your contributions have added valuable perspectives to the discussions. > And we also benefit from the comparison of different solutions. > I’m also looking forward to seeing an ini

[VOTE] KIP-1079: Deprecate `delete-config` of TopicCommand

Hi everyone, The discussion of KIP-1079 has been silent for a long time, I believe this KIP is now ready for a vote. Since

Re: [DISCUSS] KIP-1079: Deprecate `delete-config` of TopicCommand

Hello folks, I believe this KIP is finalized and ready for a vote. If there are no further discussions, I will proceed with filing a vote soon. Best regards, TengYao TengYao Chi 於 2024年8月5日 週一 下午10:57寫道： > Hello folks, > I think we have reached a consensus, and we can now see if there a

Re: [DISCUSS] KIP-1082: Enable ID Generation for Clients over the ConsumerGroupHeartbeat RPC

specific encoding which > is used is what org.apache.kafka.utils.Uuid uses. > > Thanks, > Andrew > > > On 14 Aug 2024, at 17:00, TengYao Chi wrote: > > > > Hello Apoorv, > > Thank you for your feedback. > > Regarding the questions you raised, unfortunatel

[VOTE] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

Hi everyone, Based on our discussion regarding KIP-1078 , I believe this KIP is now ready for a vote. Sincerely, TengYao

Re: [DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

s > > On 8/6/24 7:54 PM, TengYao Chi wrote: > > Hi Matthias, > > Thank you for pointing that out. I will keep it in mind. > > Do I need to update the content of the KIP, or can we leave it as is? > > > > Best regards, > > TengYao > > > > Matthias

Re: [DISCUSS] KIP-1081: Graduation Steps for Features

evelopment on this feature continued and it was > declared to enter level 2 right in time for being in Kafka 3.9. > > Let me know what you think. > > Best, > > On Mon, Aug 19, 2024 at 8:51 AM TengYao Chi wrote: > > > Hello Josep, > > I think this KIP is a g

Re: [VOTE] KIP-1077: Deprecate `ForeachProcessor` and move to internal package

Hi Bruno, Thanks for the clarification and for pointing that out! Sorry for the mix-up—I'll make sure to get it right next time. Appreciate the reminder! That said, I'll correct it here: I’m +1. Best, TengYao Bruno Cadonna 於 2024年8月19日 週一 下午8:16寫道： > Hi TengYao Chi a

Re: [VOTE] KIP-1077: Deprecate `ForeachProcessor` and move to internal package

Thanks for the KIP and nice insight. +1 (binding) Best regards. TengYao Bruno Cadonna 於 2024年8月19日 週一 下午7:40寫道： > Hi, > > Thanks for the KIP! > > +1 (binding) > > Best, > Bruno > > On 8/19/24 11:39 AM, Lucas Brutschy wrote: > > Thanks for the KIP and the cleanup! > > > > +1 (binding). > > > >

Re: [DISCUSS] KIP-1081: Graduation Steps for Features

Hello Josep, I think this KIP is a great addition to the community that we now have a crystal-clear definition for the state of a feature. In the current proposal, I think Level 1 is defined as the stage where a feature is "incomplete and unusable", while Level 2 represents a feature that is "usab

Re: [DISCUSS] GitHub CI

Hello David, I think this proposal is awesome. Personally, I find the UI of Jenkins not very friendly for newcomers. When I first contributed to Kafka and wanted to see the result of my PR build, it took me some time to understand each part of Jenkins. So, for me, the modern and user-friendly UI o

Re: [DISCUSS] KIP-1082: Enable ID Generation for Clients over the ConsumerGroupHeartbeat RPC

, which is something we want to avoid. KIP-848 aims to simplify the existing protocol, and while the lobby approach is a good one, I believe it is not the right fit for this particular situation. Best regards, TengYao TengYao Chi 於 2024年8月14日 週三 下午11:45寫道： > Hi David, > > I really apprec

Re: [DISCUSS] KIP-1082: Enable ID Generation for Clients over the ConsumerGroupHeartbeat RPC

p member in the lobby is in the group, but it does not have any > > > > assignments. A member of a consumer group can have no assigned > > > > partitions (such as 5 CG members subscribed to a topic with 4 > > > partitions), > > > > so it’s a situation that consumer g

Re: [DISCUSS] KIP-1082: Enable ID Generation for Clients over the ConsumerGroupHeartbeat RPC

nts until the client sends the next heartbeat, thus confirming it > has received the member ID. This would not be a protocol change at all, > just > a change to the GC to keep a new member in the lobby until it’s comfirmed > it knows its member ID. > > > Thanks, > Andrew >

Re: [DISCUSS] KIP-1082: Enable ID Generation for Clients over the ConsumerGroupHeartbeat RPC

he version number explicitly in the KIP > > 3) how new client code handle the old HB? Does it always generate member > ID on client-side even though that is not restricted? > > Best, > Chia-Ping > > On 2024/08/13 06:20:42 TengYao Chi wrote: > > Hello everyon

[DISCUSS] KIP-1082: Enable ID Generation for Clients over the ConsumerGroupHeartbeat RPC

Hello everyone, I would like to start a discussion thread on KIP-1082, which proposes enabling id generation for clients over the ConsumerGroupHeartbeat RPC. Here is the KIP Link: KIP-1082

Re: [DISCUSS] KIP-1080: Fix the typo: `maxlifeTimeMs` in CreateDelegationTokenOptions

Hi Could you please remove the placeholder from the KIP template ? Best, TengYao TengYao Chi 於 2024年8月12日 週一 下午9:47寫道： > Hi > Thanks for this KIP, LGTM. > > Best Regards, > TengYao > > ChengHan Hsu 於 2024年8月12日 週一 下午9:42寫道： > >> Hi, >> Thanks for the

Re: [DISCUSS] KIP-1080: Fix the typo: `maxlifeTimeMs` in CreateDelegationTokenOptions

Hi Thanks for this KIP, LGTM. Best Regards, TengYao ChengHan Hsu 於 2024年8月12日 週一 下午9:42寫道： > Hi, > Thanks for the KIP, it looks good to me! > > Best, > Johnny > > On Mon, 12 Aug 2024 at 9:29 PM, 黃竣陽 wrote: > > > Hello everyone, > > > > I would like to start a discussion about KIP-1080 > > < >

Re: [DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

changes. > > > -Matthias > > On 8/4/24 5:50 PM, 黃竣陽 wrote: > > I just trace these code, I think this proposal is clear enough. > > > >> Kuan Po Tseng 於 2024年8月5日 凌晨12:45 寫道： > >> > >> Thank you ! LGTM ! > >> > >> Best reg

Re: [DISCUSS] KIP-1079: Deprecate `delete-config` of TopicCommand

ither way, it’s a very small point and > it can > certainly remain until its final removal in AK 5.0. > > Thanks, > Andrew > > > On 5 Aug 2024, at 14:29, TengYao Chi wrote: > > > > Hi Andrew, Chia-Ping > > > > Thanks for the suggestions. > >

Re: [DISCUSS] KIP-1079: Deprecate `delete-config` of TopicCommand

Hi Andrew, Chia-Ping Thanks for the suggestions. Personally, I also want to remove this in 4.0 since it is not a significant function. But as Chia-Ping mentioned, we seem to have a ‘1-year rule’ (or convention) for removing code, so I intend to follow the convention rather than being too aggressiv

Re: [DISCUSS] KIP-1079: Deprecate `delete-config` of TopicCommand

lete the config is 5.0 rather > than 4.0 > > Best, > Chia-Ping > > > TengYao Chi 於 2024年8月5日 週一 下午12:32寫道： > > > Hello everyone, > > I would like to start a discussion about KIP-1079 > > < > > > https://cwiki.apache.org/confluence/display/KAFKA

[DISCUSS] KIP-1079: Deprecate `delete-config` of TopicCommand

Hello everyone, I would like to start a discussion about KIP-1079 . We plan to deprecate the `*delete-config*` command in *TopicCommand*, as it is a no-op. Please take a look, and if you hav

Re: [DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

： > Thank you for the nice KIP ! > > About deprecating Joined#gracePeriod, did you mean we should move the > Joined#gracePeriod to JoinedInternal class as I didn't see the > corresponding method in JoinedInternal you mentioned. > > Best regards, > > Kuan-Po Tseng > &

[DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

Hello everyone, I would like to start a discussion about KIP-1078 . We plan to deprecate the four public APIs in *org.apache.kafka.streams.kstream.Joined* that already have internal

Re: KIP-1077: Deprecate `ForeachProcessor` and move to internal package

Cool, I have read the code at trunk, this class is only used in KStream. I think this proposal is fair enough. Chia-Ping Tsai 於 2024年8月4日 週日 下午3:45寫道： > Thanks Kuan-Po for writing KIP-1077. LGTM > > Kuan Po Tseng 於 2024年8月4日 週日 下午2:34寫道： > > > Hello everyone, > > > > In KIP-1077 (https://cwiki.

[jira] [Created] (KAFKA-17128) Make node.id immutable after removing Zookeeper

TengYao Chi created KAFKA-17128: --- Summary: Make node.id immutable after removing Zookeeper Key: KAFKA-17128 URL: https://issues.apache.org/jira/browse/KAFKA-17128 Project: Kafka Issue Type