[GitHub] kafka pull request #2903: MINOR: Fix needless GC + Result time unit in JMH

GitHub user original-brownbear reopened a pull request: https://github.com/apache/kafka/pull/2903 MINOR: Fix needless GC + Result time unit in JMH Fixes two issues with the JMH benchmark example: * Trivial: The output should be in `ops/ms` for readability reasons (it's

[GitHub] kafka pull request #2889: KAFKA-4928: Add integration test for DumpLogSegmen...

Github user original-brownbear closed the pull request at: https://github.com/apache/kafka/pull/2889 ---

[GitHub] kafka pull request #2903: MINOR: Fix needless GC + Result time unit in JMH

Github user original-brownbear closed the pull request at: https://github.com/apache/kafka/pull/2903 ---

[GitHub] kafka pull request #2901: KAFKA-5018: LogCleaner tests to verify behaviour o...

Github user original-brownbear closed the pull request at: https://github.com/apache/kafka/pull/2901 ---

[GitHub] kafka pull request #2921: KAFKA-5124: autocommit reset earliest fixes race c...

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2921 KAFKA-5124: autocommit reset earliest fixes race condition Fixes `org.apache.kafka.streams.integration.utils.IntegrationTestUtils#readKeyValues` potentially starting to `poll

[GitHub] kafka pull request #2920: Minor: IntegrationTestUtils were not handling prod...

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2920 Minor: IntegrationTestUtils were not handling producer and consumer in a resource-safe manner Producer and Consumer `close` calls were not handled via `try-with-resources` You can

[GitHub] kafka pull request #2903: MINOR: Fix needless GC + Result time unit in JMH

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2903 MINOR: Fix needless GC + Result time unit in JMH Fixes two issues with the JMH benchmark example: * Trivial: The output should be in `ops/ms` for readability reasons (it's

[GitHub] kafka pull request #2901: KAFKA-5018: LogCleaner tests to verify behaviour o...

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2901 KAFKA-5018: LogCleaner tests to verify behaviour of message format v2 For https://issues.apache.org/jira/browse/KAFKA-5018: * Added test for `baseOffset` behaviour after

[GitHub] kafka pull request #2775: MINOR: Reduce Fork Count in ITs

Github user original-brownbear closed the pull request at: https://github.com/apache/kafka/pull/2775 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] kafka pull request #2889: KAFKA-4928: Add integration test for DumpLogSegmen...

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2889 KAFKA-4928: Add integration test for DumpLogSegments Adding tests for `kafka.tools.DumpLogSegments` You can merge this pull request into a Git repository by running: $ git pull

[GitHub] kafka pull request #2786: MINOR: Removed dead field

Github user original-brownbear closed the pull request at: https://github.com/apache/kafka/pull/2786 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] kafka pull request #2801: MINOR: Fix multiple org.apache.kafka.streams.Kafka...

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2801 MINOR: Fix multiple org.apache.kafka.streams.KafkaStreams.StreamStateListener being instantiated There should only be a single `org.apache.kafka.streams.KafkaStreams.StreamStateListener

[GitHub] kafka pull request #2791: MINOR: Fix Deadlock in StreamThread

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2791 MINOR: Fix Deadlock in StreamThread I think this may be the (or on of them) reason we see Jenkins jobs time out at times. At least I can reproduce this to cause tests to time out

[GitHub] kafka pull request #2786: MINOR: Removed dead field

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2786 MINOR: Removed dead field Really trivial but can't hurt to clean this up I think. Just saw this when trying out the findbugs task randomly :) You can merge this pull request

[GitHub] kafka pull request #2775: MINOR: Reduce Fork Count in ITs

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2775 MINOR: Reduce Fork Count in ITs While looking into instabilities like https://issues.apache.org/jira/browse/KAFKA-4692 I noticed that we are running one JVM fork per core in the ITs

[GitHub] kafka pull request #2761: KAFKA-4692: Make testNo thread safe

Github user original-brownbear closed the pull request at: https://github.com/apache/kafka/pull/2761 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] kafka pull request #2761: KAFKA-4692: Make testNo thread safe

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2761 KAFKA-4692: Make testNo thread safe https://issues.apache.org/jira/browse/KAFKA-4692 should be resolved by this. The problem here (or at least one problem, causing trouble

[GitHub] kafka pull request #2573: MINOR: Cleanup org.apache.kafka.streams.kstream.in...

Github user original-brownbear closed the pull request at: https://github.com/apache/kafka/pull/2573 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] kafka pull request #2722: KAFKA-4878: Improved Invalid Connect Config Error ...

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2722 KAFKA-4878: Improved Invalid Connect Config Error Message Addresses for https://issues.apache.org/jira/browse/KAFKA-4878 * Adjusted the error message to explicitly state errors

[GitHub] kafka pull request #2699: KAFKA-4569: Make KafkaConsumer Trigger Wakeup befo...

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2699 KAFKA-4569: Make KafkaConsumer Trigger Wakeup before Updating Offsets An attempt at resolving https://issues.apache.org/jira/browse/KAFKA-4569 using the @hachikuji suggestions from

[GitHub] kafka pull request #2680: KAFKA-4859: Raised Timeout

Github user original-brownbear closed the pull request at: https://github.com/apache/kafka/pull/2680 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] kafka pull request #2680: KAFKA-4859: Raised Timeout

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2680 KAFKA-4859: Raised Timeout This fixes https://issues.apache.org/jira/browse/KAFKA-4859 for me over hundreds of iterations while I could easily reproduce it with less than ~30-40

[GitHub] kafka pull request #2639: KAFKA-3155: Avoid Long Overflow by Setting Linger ...

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2639 KAFKA-3155: Avoid Long Overflow by Setting Linger to 1h instead of LONG_MAX This deals with https://issues.apache.org/jira/browse/KAFKA-3155 This is a really trivial one

[GitHub] kafka pull request #2632: KAFKA-3182: Fix Transient Test Failure (kafka.netw...

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2632 KAFKA-3182: Fix Transient Test Failure (kafka.network.SocketServerTest.testSocketsCloseOnShutdown) Fixes https://issues.apache.org/jira/browse/KAFKA-3182 by: * Turning off Nagle

[GitHub] kafka pull request #2570: KAFKA-4196: Improved Test Stability

Github user original-brownbear closed the pull request at: https://github.com/apache/kafka/pull/2570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] kafka pull request #2582: MINOR: Fixed Non-Final Close Method + its Duplicat...

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2582 MINOR: Fixed Non-Final Close Method + its Duplication Trivial but in my opinion it's well worth it making the `close` method `final` here and also deleting that duplication (especially

[GitHub] kafka pull request #2574: MINOR: Fixed 3 inner classes without instance refe...

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2574 MINOR: Fixed 3 inner classes without instance reference to be static * Turned 3 inner classes that weren't static but could be into `static` ones. * Turned one `public` inner class

[GitHub] kafka pull request #2573: MINOR: Cleanup org.apache.kafka.streams.kstream.in...

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2573 MINOR: Cleanup org.apache.kafka.streams.kstream.internals.AbstractKTableKTableJoinValueGetterSupplier#storeNames (performance and clarity) Just a trivial fix improving the performance

[GitHub] kafka pull request #2571: HOTFIX: ClassCastException in Request logging

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2571 HOTFIX: ClassCastException in Request logging Comming from [here](https://github.com/apache/kafka/pull/2570#issuecomment-280859637) Fixed ClassCastException resulting from

[GitHub] kafka pull request #2570: KAFKA-4196: Improved Test Stability by Disabling Z...

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2570 KAFKA-4196: Improved Test Stability by Disabling ZK Fsync and Fixed KafkaAPI Error Response This addresses https://issues.apache.org/jira/browse/KAFKA-4196 What I found

[GitHub] kafka pull request #2568: Kafka 4198: Fix Race Condition in KafkaServer Shut...

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2568 Kafka 4198: Fix Race Condition in KafkaServer Shutdown Fixes the initially reported issue in https://issues.apache.org/jira/browse/KAFKA-4198. The relevant part in fixing

[GitHub] kafka pull request #2552: KAFKA-4765: Fixed Intentionally Broken Hosts Resol...

GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2552 KAFKA-4765: Fixed Intentionally Broken Hosts Resolving to 127.0.53.53 Fixes https://issues.apache.org/jira/browse/KAFKA-4765 by simply using artificially broken hosts