Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

2024-06-21 Thread Kaushik Raina
Thanks Matthias for feedback - We have updates KIP and grouped exceptions https://cwiki.apache.org/confluence/display/KAFKA/KIP-1050%3A+Consistent+error+handling+for+Transactions#KIP1050:ConsistenterrorhandlingforTransactions-ExceptionTable - Regarding compatibility, all changes in KIP are

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

2024-06-10 Thread Matthias J. Sax
Thanks for this KIP. Great to see it. I would assume it will make KIP-691 unnecessary? I don't think I fully understand the proposal yet. It's clear, that you propose to add new sub-classed to group existing exceptions. But it's not clear to me, which of the existing exceptions (which

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

2024-06-07 Thread Kaushik Raina
Thank you Andrew for feedback 1. We are suggesting to only update subclasses of o.a.k.common.errors.ApiException, which are used in transactions. All such subclasses are mentioned in Exception table

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

2024-06-06 Thread Andrew Schofield
Hi Kaushik, Thanks for the KIP. This is definitely an area that needs clearing up so it’s good to see it. A few initial questions. 1. If I understand correctly, you are proposing to change the superclass of all subclasses of o.a.k.common.errors.ApiException which can be thrown by the producer

[DISCUSS] KIP-1050: Consistent error handling for Transactions

2024-06-06 Thread Kaushik Raina
Hi everyone, I would like to start a discussion thread for KIP-1050: Consistent error handling for Transactions https://cwiki.apache.org/confluence/display/KAFKA/KIP-1050%3A+Consistent+error+handling+for+Transactions Thanks Kaushik Raina