Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2018-04-07 Thread Ted Yu
Can you start another thread with [VOTE] in the subject ? Original message From: 东方甲乙 <254479...@qq.com> Date: 4/7/18 6:10 AM (GMT-08:00) To: dev <dev@kafka.apache.org> Subject: Re: [DISCUSS] KIP-148: Add a  connect timeout for client Hi all, Do you have furt

Re?? [DISCUSS] KIP-148: Add a connect timeout for client

2018-04-07 Thread ????????
?: "dev"<dev@kafka.apache.org>; ????: Re?? [DISCUSS] KIP-148: Add a connect timeout for client Hi Colin, I think the exponential backoff should still apply, thanks for the explanation. thanks, David -- -- ??: "Colin McCabe&

Re?? [DISCUSS] KIP-148: Add a connect timeout for client

2017-06-16 Thread ????????
kafka.apache.org>; ????: Re: ??Re?? [DISCUSS] KIP-148: Add a connect timeout for client Just a note: KIP-144 added exponential backoff for broker reconnect attempts, configured via reconnect.backoff.max.ms. cheers, Colin On Sat, Jun 10

Re: 回复:Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-06-12 Thread Colin McCabe
17年6月4日(星期天) 晚上6:05 > 收件人: "dev"<dev@kafka.apache.org>; > > 主题: Re: [DISCUSS] KIP-148: Add a connect timeout for client > > > > >I guess one obvious question is, how does this interact with retries? > >Does it result in a failure getting delivered to

??????Re?? [DISCUSS] KIP-148: Add a connect timeout for client

2017-06-10 Thread ????????
-- -- ??: "";<254479...@qq.com>; : 2017??6??4??(??) 6:05 ??: "dev"<dev@kafka.apache.org>; ????: Re?? [DISCUSS] KIP-148: Add a connect timeout for client >I guess one obvious

Re?? [DISCUSS] KIP-148: Add a connect timeout for client

2017-06-04 Thread ????????
lin McCabe";<cmcc...@apache.org>; : 2017??5??31??(??) 2:44 ??: "dev"<dev@kafka.apache.org>; : Re: [DISCUSS] KIP-148: Add a connect timeout for client On Mon, May 29, 2017, at 15:46, Guozhang Wang wrote: > On Wed, May 24, 2017 at 9:59 AM, Colin M

Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-30 Thread Colin McCabe
> > > > > > > > > > > > > > > > > > > > > Is there a reason why you wouldn't want to use > > > > request.timeout.ms > > > > > > > as > > > > > > > > > the > > > > > > > > > > > tim

RE?? [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-29 Thread ????????
???: "dev@kafka.apache.org"<dev@kafka.apache.org>; ????: Re: [DISCUSS] KIP-148: Add a connect timeout for client On Wed, May 24, 2017 at 9:59 AM, Colin McCabe <cmcc...@apache.org> wrote: > On Tue, May 23, 2017, at 19:07, Guozhang Wang wrote: > > I think usi

Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-29 Thread Guozhang Wang
> > Ismael > > > > > > > > > > > > > > > > On Mon, May 22, 2017 at 4:15 PM, Rajini Sivaram < > > > > > > rajinisiva...@gmail.com > > > > > > > > > > > > >

Re?? Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-29 Thread ????????
-- -- ??: "Rajini Sivaram";<rajinisiva...@gmail.com>; : 2017??5??23??(??) 11:57 ??: ""<254479...@qq.com>; : "dev"<dev@kafka.apache.org>; ????: Re: Re: Re: [DISCUSS] KIP-148: Add a c

RE?? [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-28 Thread ????????
-- -- ??: "Guozhang Wang";<wangg...@gmail.com>; : 2017??5??24??(??) 10:07 ??: "dev@kafka.apache.org"<dev@kafka.apache.org>; ????: Re: [DISCUSS] KIP-148: Add a connect timeout for client I think using a single config to cover end-to-end latency w

Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-24 Thread Colin McCabe
gt; > > > > > > > Hi David, > > > > > > > > > > > > > > > > Sorry, what I meant was: Can you reuse the existing > > configuration > > > > > > option > > > > > >

Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-23 Thread Guozhang Wang
timeout,ms , instead of adding a new config and add the > > > > > behaviour > > > > > > > that you have proposed in the KIP for the connection phase > using this > > > > > > > timeout? I think the timeout for connection is useful. I am > not sure > >

Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-23 Thread Colin McCabe
ducer.sender even the selector.poll can > > > > timeout, > > > > > > but > > > > > > > > the next time is also not close the previous connecting and try > > > > > another > > > > > > > > good node. > > >

Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-23 Thread Colin McCabe
On Mon, May 22, 2017 at 11:06 AM, 东方甲乙 <254479...@qq.com> wrote: > > > > > > > > > > > Hi Rajini. > > > > > > > > > > > > When kafka node' machine is shutdown or network is closed, the > > > > connecting > > &g

Re: Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-23 Thread Rajini Sivaram
cases. > > Thanks, > David > > -- 原始邮件 -- > *发件人:* "Rajini Sivaram" <rajinisiva...@gmail.com>; > *发送时间:* 2017年5月23日(星期二) 19:27 > *收件人:* "dev" <dev@kafka.apache.org>; > *主题:* Re: Re: [DISCUSS] KIP-148: Add a connec

Re:Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-23 Thread 东方甲乙
, David -- 原始邮件 -- 发件人: "Rajini Sivaram" <rajinisiva...@gmail.com>; 发送时间: 2017年5月23日(星期二) 19:27 收件人: "dev" <dev@kafka.apache.org>; 主题: Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client Guozhang, At the moment

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-23 Thread Rajini Sivaram
connecting > > > > > phase could not use the request.timeout.ms, because the client > > haven't > > > > > send a req yet. And no response for the nio, the selector will > not > > > > close > > > > > the connect, so it will not choos

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Simon Souter
the > > connecting > > > > phase could not use the request.timeout.ms, because the client > haven't > > > > send a req yet. And no response for the nio, the selector will not > > > close > > > > the connect, so it will not choose other good n

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Guozhang Wang
> > > > > > > Hi Rajini. > > > > > > > > > > When kafka node' machine is shutdown or network is closed, the > > > connecting > > > > > phase could not use the request.timeout.ms, because the client > > haven't > > > > > send

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Ismael Juma
uest.timeout.ms, because the client > haven't > > > > send a req yet. And no response for the nio, the selector will not > > > close > > > > the connect, so it will not choose other good node to get the > metadata. > > > > > > > >

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Rajini Sivaram
he connect, so it will not choose other good node to get the metadata. > > > > > > > > > Thanks > > > David > > > > > > -- 原始邮件 -- > > > *发件人:* "Rajini Sivaram" <rajinisiva...@gmail.c

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Ismael Juma
> > > > Thanks > > David > > > > -- 原始邮件 -- > > *发件人:* "Rajini Sivaram" <rajinisiva...@gmail.com>; > > *发送时间:* 2017年5月22日(星期一) 20:17 > > *收件人:* "dev" <dev@kafka.apache.org>; > > *主题:* Re: [DIS

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Rajini Sivaram
ot; <rajinisiva...@gmail.com>; > *发送时间:* 2017年5月22日(星期一) 20:17 > *收件人:* "dev" <dev@kafka.apache.org>; > *主题:* Re: [DISCUSS] KIP-148: Add a connect timeout for client > > > Hi David, > > Is there a reason why you wouldn't want to use request.timeo

Re:Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread 东方甲乙
the metadata. Thanks David -- 原始邮件 -- 发件人: "Rajini Sivaram" <rajinisiva...@gmail.com>; 发送时间: 2017年5月22日(星期一) 20:17 收件人: "dev" <dev@kafka.apache.org>; 主题: Re: [DISCUSS] KIP-148: Add a connect timeout for client Hi David, Is ther

Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Rajini Sivaram
> node, > > it will be disconnected in 5 seconds, so the default value of > > connections.max.idle.ms is setting to a larger time. We should have two > > parameters to control the connecting phrase behavior and the connected > > phrase behavior, do you think so

RE?? [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-21 Thread ????????
t;Guozhang Wang";<wangg...@gmail.com>; : 2017??5??16??(??) 1:51 ??: "dev@kafka.apache.org"<dev@kafka.apache.org>; ????: Re: [DISCUSS] KIP-148: Add a connect timeout for client Hi David, I may be a bit confused before, just clarifying a

Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-15 Thread Guozhang Wang
should have two > parameters to control the connecting phrase behavior and the connected > phrase behavior, do you think so? > > > Thanks, > > > David > > > > > -- 原始邮件 -- > 发件人: "Guozhang Wang";<wangg...@gmail.com>; > 发送

RE: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-14 Thread ????????
nks, David -- -- ??: "Guozhang Wang";<wangg...@gmail.com>; : 2017??5??6??(??) 7:52 ??: "dev@kafka.apache.org"<dev@kafka.apache.org>; : Re: [DISCUSS] KIP-148: Add a connect timeout for client

Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-05 Thread Guozhang Wang
Hello David, Thanks for the KIP. For the described issue, I'm wondering if it can be resolved by tuning the CONNECTIONS_MAX_IDLE_MS_CONFIG ( connections.max.idle.ms) on the client side? Default is 9 minutes. Guozhang On Tue, May 2, 2017 at 8:22 AM, 东方甲乙 <254479...@qq.com> wrote: > Hi all, > >

[DISCUSS] KIP-148: Add a connect timeout for client

2017-05-02 Thread ????????
Hi all, Currently in our test environment, we found that after one of the broker node crash (reboot or os crash), the client may still be connecting to the crash node to send metadata request or other request, and it needs several minutes to be aware that the connection is timeout then try