Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

I started voting thread for this KIP. Thanks, Jason and Colin. From: Colin McCabe Date: 2018-05-10 2:53 GMT+09:00 Subject: Re: [DISCUSS] KIP-278: Add version option to Kafka's commands To: dev@kafka.apache.org +1. Thanks, Sasaki. Colin On Wed, May 9, 2018, at 09:15, Jason Gustafson

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

ent proposal prints on the older > >>>> version. > >>>> > >>>> On Tue, May 1, 2018 at 7:47 PM, Colin McCabe > >>>> wrote: > >>>> > >>>> Thanks, Sasaki. > >>>>> > >>>>> Col

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

nts which should be considered. > > If you have any better ideas, could you please tell us? > > > Many thanks, > Sasaki > > From: Manikumar >> Date: 2018-05-03 4:11 GMT+09:00 >> >> Subject: Re: [DISCUSS] KIP-278: Add version option to Kafka's commands >

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

ut I think it is better to create new KIP because this function has some points which should be considered. If you have any better ideas, could you please tell us? Many thanks, Sasaki From: Manikumar Date: 2018-05-03 4:11 GMT+09:00 Subject: Re: [DISCUSS] KIP-278: Add version option to Kafka&

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

we cat get the result such > > > below: > > > > > > > >$ bin/kafka-topics.sh --version > > > >(snip) > > > >2.0.0-SNAPSHOT (Commit:f3876cd9617faf7e) > > > > > > > > > > > > I have also updated to accept d

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

emporary, because I seem that it's useful> > > >>> before KIP-14 accepted. > > > >>> > > > >>> > > > >>> > Can you give a little more detail about what would be > > > >>> > di

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

mit:f3876cd9617faf7e) > > > > > > I have also updated to accept double-dash for this option (-- > > version) only.> > > > > Many thanks, > > Sasaki > > > > > From: Jason Gustafson > > > Date: 2018-04-25 9:42 GMT+09:00 > &

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

more detail about what would be > >>> > displayed when> >>> the version command was used? > >>> > >>> As Ismael said, the version string is got from > >>> AppInfoParser#getVersion.> >>> > >>> In my Pull Request, w

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

also updated to accept double-dash for this option (--version) only. Many thanks, Sasaki From: Jason Gustafson Date: 2018-04-25 9:42 GMT+09:00 Subject: Re: [DISCUSS] KIP-278: Add version option to Kafka's commands To: dev +1 on adding the git commit id to the output. We often enco

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

t;$ bin/kafka-topics.sh --version > >(snip) > >Kafka 1.2.0-SNAPSHOT > > Hi Sasaki, > > Thanks for the info. Can you add this to the KIP? > > Also, I really think we should include the git hash. > > best, > Colin > > > > > > >

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

>Kafka 1.2.0-SNAPSHOT Hi Sasaki, Thanks for the info. Can you add this to the KIP? Also, I really think we should include the git hash. best, Colin > > > Many thanks, > Sasaki > > > > From: Ismael Juma > > Date: 2018-04-24 3:44 GMT+09:00 > > Subject

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

ull Request, we can get the result such as below:: $ bin/kafka-topics.sh --version (snip) Kafka 1.2.0-SNAPSHOT Many thanks, Sasaki From: Ismael Juma Date: 2018-04-24 3:44 GMT+09:00 Subject: Re: [DISCUSS] KIP-278: Add version option to Kafka's commands To: dev FYI, the injection

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

FYI, the injection via the build process that is mentioned here already happens. See AppInfoParser. Ismael On Mon, Apr 23, 2018 at 9:39 AM, Colin McCabe wrote: > Hi Sasaki, > > Thanks for the KIP. I think a version flag is a good idea. > > Can you give a little more detail about what would be

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

Hi Sasaki, Thanks for the KIP. I think a version flag is a good idea. Can you give a little more detail about what would be displayed when the version command was used? We clearly want the version number, but we probably also want to know if this is an official release, or a random SNAPSHOT f

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

Hey Sasaki, Yeah, I don't feel too strongly about only supporting --version. I agree it may help discoverability given the current approach. On the other hand, if we refactored all of the tools so that we could use a common set of base options, it might be a little annoying to have to continue sup

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

Hi Jason Thank you for helpful comments. I updated wiki based on your advice. I thought this option was relatively common and making maintenance easy was also important. However, as you said, it is not good that version option won't be shown up in help description. I thought accepting both si

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

@Ted Yeah, you're right. Sorry about the confusion. Since we're here, I think this KIP is a nice improvement. It's definitely nice to have an easy way to check the version. That said, do we really need to support both `-version` and `--version`? The latter is consistent with our current tools. Al

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

Jason: Maybe your reply was intended for another KIP ? KIP-278 is about adding version option, not timeout. Cheers On Wed, Apr 4, 2018 at 9:36 AM, Jason Gustafson wrote: > Hi Sasaki, > > Thanks for the KIP. I think the timeout controls the maximum allowed time > that the consumer will block fo

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

Hi Sasaki, Thanks for the KIP. I think the timeout controls the maximum allowed time that the consumer will block for the next record. Maybe the meaning would be clearer with the more concise name `--timeout`? That also fits with the old consumer which overrides the `consumer.timeout.ms` property.

[DISCUSS] KIP-278: Add version option to Kafka's commands

Hello everyone, I would like to start a discussion for KIP 278. Cloud you please give comments and advice ? JIRA ticket and Pull Request are bellow: