RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-12-05 Thread Pellerin, Clement
. -Original Message- From: Pellerin, Clement Sent: Wednesday, November 28, 2018 11:49 AM To: dev@kafka.apache.org Subject: RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory If no one objects, I'll rewrite the KIP like this and resubmit for discussion: Ideal interface, ignor

RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-11-28 Thread Pellerin, Clement
nyway. -Original Message- From: Pellerin, Clement Sent: Wednesday, November 21, 2018 10:42 AM To: dev@kafka.apache.org Subject: RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory This turned out to be trickier than I thought and I don't have a firm solution yet. Since SslFactory w

RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-11-21 Thread Pellerin, Clement
rface instead. Thoughts? -Original Message- From: Rajini Sivaram [mailto:rajinisiva...@gmail.com] Sent: Tuesday, October 23, 2018 7:54 AM To: dev Subject: Re: [DISCUSS] KIP-383 Pluggable interface for SSL Factory Thanks for the PR. A couple of comments: 1) For other public interfaces, w

RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-10-23 Thread Pellerin, Clement
t: Re: [DISCUSS] KIP-383 Pluggable interface for SSL Factory Thanks for the PR. A couple of comments: 1) For other public interfaces, we use parameters to configure instead of internal config names going into the same list of configs. Kafka has public config names and custom config names that

Re: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-10-23 Thread Rajini Sivaram
I need more feedback? > > -Original Message- > From: Harsha Chintalapani [mailto:ka...@harsha.io] > Sent: Monday, October 22, 2018 4:36 PM > To: dev@kafka.apache.org > Subject: RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory > > Thanks for the changes. KIP lo

RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-10-22 Thread Pellerin, Clement
October 19, 2018 6:51 PM > To: dev@kafka.apache.org; dev@kafka.apache.org > Subject: RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory > > SslFactory is not a public interface for others to use.  EchoServer is > internal testing. > We should make these a

RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-10-22 Thread Harsha Chintalapani
ber 19, 2018 6:51 PM > To: dev@kafka.apache.org; dev@kafka.apache.org > Subject: RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory > > SslFactory is not a public interface for others to use.  EchoServer is > internal testing. > We should make these as proposed in rejected alternatives t

RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-10-22 Thread Pellerin, Clement
on this new version. -Original Message- From: Harsha Chintalapani [mailto:ka...@harsha.io] Sent: Friday, October 19, 2018 6:51 PM To: dev@kafka.apache.org; dev@kafka.apache.org Subject: RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory SslFactory is not a public interface for

RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-10-19 Thread Harsha Chintalapani
es if the Kafka community thinks no Kafka > application calls SslFactory directly. I would like more opinions on this > though. > > > -Original Message- > From: Harsha Chintalapani [mailto:ka...@harsha.io] > Sent: Friday, October 19, 2018 5:55 PM > To: dev@kafka.apache.or

RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-10-19 Thread Pellerin, Clement
rectly. I would like more opinions on this though. -Original Message- From: Harsha Chintalapani [mailto:ka...@harsha.io] Sent: Friday, October 19, 2018 5:55 PM To: dev@kafka.apache.org Subject: RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory Hi,      Overall the KIP looks good t

RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-10-19 Thread Harsha Chintalapani
sage- > From: Pellerin, Clement > Sent: Wednesday, October 17, 2018 3:11 PM > To: dev@kafka.apache.org > Subject: [DISCUSS] KIP-383 Pluggable interface for SSL Factory > > I would like feedback on this proposal to make it possible to replace > SslFactory with a custom implem

RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-10-19 Thread Pellerin, Clement
, Clement Sent: Wednesday, October 17, 2018 3:11 PM To: dev@kafka.apache.org Subject: [DISCUSS] KIP-383 Pluggable interface for SSL Factory I would like feedback on this proposal to make it possible to replace SslFactory with a custom implementation. https://cwiki.apache.org/confluence/display

RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-10-18 Thread Pellerin, Clement
Original Message- From: Harsha [mailto:ka...@harsha.io] Sent: Thursday, October 18, 2018 10:58 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-383 Pluggable interface for SSL Factory Hi, Thanks for the KIP. Curious to understand why the ChannelBuilder interface doesn't so

Re: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-10-18 Thread Harsha
Hi, Thanks for the KIP. Curious to understand why the ChannelBuilder interface doesn't solve the stated reasons in Motiviation section. Thanks, Harsha On Wed, Oct 17, 2018, at 12:10 PM, Pellerin, Clement wrote: > I would like feedback on this proposal to make it possible to replace > Ssl

[DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-10-17 Thread Pellerin, Clement
I would like feedback on this proposal to make it possible to replace SslFactory with a custom implementation. https://cwiki.apache.org/confluence/display/KAFKA/KIP-383%3A++Pluggable+interface+for+SSL+Factory