Thanks for the comments @Vahid,
Yes i agree we can always introduce the new option, but what i was think is, as
this is a ad-hoc tool and whoever is using the new version of the tool always
will have the info to correct the usage, and also this will keep the tool
in-sync with the current
Hi Satish,
Thanks for the update. What you suggest in the KIP is ideal, the only issue
is the --execute option will not be backward compatible; so the same
command that used to work before, may no longer work if this suggestion is
implemented. One option for keeping backward compatibility would
Hi Vahid,
After re-thinking on this, i have following updates on the KIP, with aligning
to the other options on ReassignPartitionsCommand,
The --execute command by default take rack awareness into consideration, and if
the custom generated reassignment planner has conflicts along with the racks
Hi Viktor,
-1, @Vahid already provided the info.
-2, Moved the KIP to the parent path instead of KIP-36, thanks for finding out.
--sbellapu
On 2019/11/22 10:57:35, Viktor Somogyi-Vass wrote:
> Hi Satish,
>
> Couple of questions/suggestions:
> 1. You say that when you execute the planned
Here is the link for the [KIP-548]
https://cwiki.apache.org/confluence/display/KAFKA/KIP-548+Add+Option+to+enforce+rack-aware+custom+partition+reassignment+execution
On 2019/11/22 10:37:07, Stanislav Kozlovski wrote:
> Hello Satish,
>
> Could you provide a link to the KIP? I am unable to find
Thanks Satish for drafting the KIP. Looks good overall. I would suggest
emphasizing on the default option for --disable-rack-aware option when used
with --execute option.
Also, it would be great to also emphasize that the new format for
--disable-rack-aware (which now takes a true/false value)
Hi Satish,
Couple of questions/suggestions:
1. You say that when you execute the planned reassignment then it would
throw an error if the generated reassignment doesn't comply with the
rack-aware requirement. Opposed to this: why don't you have the --generate
option to generate a rack-aware
Hello Satish,
Could you provide a link to the KIP? I am unable to find it in the KIP
parent page
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
Thanks,
Stanislav
On Fri, Nov 22, 2019 at 8:21 AM Satish Bellapu
wrote:
> Hi All,
>
> This [KIP-548] is basically
