Re: [DISCUSS] KIP-815: Replace KafkaConsumer with AdminClient in GetOffsetShell

2022-01-29 Thread deng ziming
Hi everyone, I will start a voting progress soon if no body has more concerns. > On Jan 25, 2022, at 1:04 PM, deng ziming wrote: > > Thank you Luke, I already changed the file name. > >> On Jan 20, 2022, at 10:08 AM, Luke Chen wrote: >> >> Hi Ziming, >> >> Thanks for the update! It looks goo

Re: [DISCUSS] KIP-815: Replace KafkaConsumer with AdminClient in GetOffsetShell

2022-01-24 Thread deng ziming
Thank you Luke, I already changed the file name. > On Jan 20, 2022, at 10:08 AM, Luke Chen wrote: > > Hi Ziming, > > Thanks for the update! It looks good now. > > Only 1 minor comment: > The file name in example can change to `kafka_admin_client.properties`, > which should be much clear. > >

Re: [DISCUSS] KIP-815: Replace KafkaConsumer with AdminClient in GetOffsetShell

2022-01-19 Thread Luke Chen
Hi Ziming, Thanks for the update! It looks good now. Only 1 minor comment: The file name in example can change to `kafka_admin_client.properties`, which should be much clear. Otherwise LGTM! Thanks for the improvement! Thank you. Luke On Thu, Jan 20, 2022 at 10:03 AM deng ziming wrote: > Hi

[DISCUSS] KIP-815: Replace KafkaConsumer with AdminClient in GetOffsetShell

2022-01-19 Thread deng ziming
Hi everyone, I would like to restart a discussion for KIP-815 since the old KIP number conflict with another KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-815%3A+Replace+KafkaConsumer+with+AdminClient+in+GetOffsetShell