Re: [VOTE] KIP-458: Connector Client Config Override Policy

Hi all, I'd like to bring attention to a feature that was added as part of the KIP but never actually documented: the new "admin." prefix and how it's used by workers to compute the configuration for admin clients when using the DLQ for a connector. I've written up a more detailed description of

Re: [VOTE] KIP-458: Connector Client Config Override Policy

While implementing the KIP it became evident that for the validate call from the Connect Rest interface it was required to pass each config individually to the policy implementation to be able to determine which overrides are allowed. This happened since the interface relied on using

Re: [VOTE] KIP-458: Connector Client Config Override Policy

Thanks a lot, Colin. This KIP has now passed voting with 3 binding votes ( Randall, Rajini & Colin) and 1 non-binding vote (Chris). Thanks a lot, everyone for the feedback & discussion on this KIP. On Fri, May 10, 2019 at 9:12 AM Colin McCabe wrote: > +1 (binding). Thanks, Magesh. > > cheers,

Re: [VOTE] KIP-458: Connector Client Config Override Policy

+1 (binding). Thanks, Magesh. cheers, Colin On Thu, May 9, 2019, at 18:31, Randall Hauch wrote: > I'm still +1 and like the simplification. > > Randall > > On Thu, May 9, 2019 at 5:54 PM Magesh Nandakumar > wrote: > > > I have updated the KIP to remove the `Ignore` policy and also the > >

Re: [VOTE] KIP-458: Connector Client Config Override Policy

I'm still +1 and like the simplification. Randall On Thu, May 9, 2019 at 5:54 PM Magesh Nandakumar wrote: > I have updated the KIP to remove the `Ignore` policy and also the > useOverrides() > method in the interface. > Thanks a lot for your thoughts, Colin. I believe this certainly simplifies

Re: [VOTE] KIP-458: Connector Client Config Override Policy

I have updated the KIP to remove the `Ignore` policy and also the useOverrides() method in the interface. Thanks a lot for your thoughts, Colin. I believe this certainly simplifies the KIP. On Thu, May 9, 2019 at 3:44 PM Magesh Nandakumar wrote: > Unless anyone has objections, I'm going to

Re: [VOTE] KIP-458: Connector Client Config Override Policy

Unless anyone has objections, I'm going to update the KIP to remove the `Ignore` policy and make `None` as the default. I will also remove the ` default boolean useOverrides()` in the interface which was introduced for the purpose of backward compatibility. On Thu, May 9, 2019 at 3:27 PM Randall

Re: [VOTE] KIP-458: Connector Client Config Override Policy

I have also seen users include in connector configs the `producer.*` and `consumer.*` properties that should go into the worker configs. But those don't match, and the likelihood that someone is already using `producer.override.*` or `consumer.override.*` properties in their connector configs does

Re: [VOTE] KIP-458: Connector Client Config Override Policy

To add more details regarding the backward compatibility; I have generally seen users trying to set "producer.request.timeout.ms " in their connector config under the assumption that it will get used and would never come back to remove it. The initial

Re: [VOTE] KIP-458: Connector Client Config Override Policy

Colin, Thanks a lot for the feedback. As you said, the possibilities of someone having "producer.override.request.timeout.ms" in their connector config in AK 2.2 or lower is very slim. But the key thing is if in case, someone has it AK2.2 doesn't do anything with it and it silently ignores the

Re: [VOTE] KIP-458: Connector Client Config Override Policy

Hi Magesh, Thanks for the KIP, +1 (binding) Regards, Rajini On Thu, May 9, 2019 at 3:55 PM Randall Hauch wrote: > Nice work, Magesh. > > +1 (binding) > > Randall > > On Wed, May 8, 2019 at 7:22 PM Magesh Nandakumar > wrote: > > > Thanks a lot Chris. So far, the KIP has one non-binding vote

Re: [VOTE] KIP-458: Connector Client Config Override Policy

Nice work, Magesh. +1 (binding) Randall On Wed, May 8, 2019 at 7:22 PM Magesh Nandakumar wrote: > Thanks a lot Chris. So far, the KIP has one non-binding vote and I'm still > looking forward to the KIP to be voted by Friday's deadline. > > On Tue, May 7, 2019 at 10:00 AM Chris Egerton wrote:

Re: [VOTE] KIP-458: Connector Client Config Override Policy

Thanks a lot Chris. So far, the KIP has one non-binding vote and I'm still looking forward to the KIP to be voted by Friday's deadline. On Tue, May 7, 2019 at 10:00 AM Chris Egerton wrote: > Hi Magesh, > > This looks great! Very excited to see these changes finally coming to > Connect. > +1

[VOTE] KIP-458: Connector Client Config Override Policy

Hi All, I would like to start a vote on https://cwiki.apache.org/confluence/display/KAFKA/KIP-458%3A+Connector+Client+Config+Override+Policy The discussion thread can be found here . Thanks, Magesh

Re: [VOTE] KIP-458: Connector Client Config Override Policy

Hi Magesh, This looks great! Very excited to see these changes finally coming to Connect. +1 (non-binding) Cheers, Chris On Tue, May 7, 2019 at 9:51 AM Magesh Nandakumar wrote: > Hi All, > > I would like to start a vote on > >

[VOTE] KIP-458: Connector Client Config Override Policy

Hi All, I would like to start a vote on https://cwiki.apache.org/confluence/display/KAFKA/KIP-458%3A+Connector+Client+Config+Override+Policy The discussion thread can be found here . Thanks, Magesh On Tue, May 7, 2019 at 9:35 AM