During the development of KIP-630 we made some minor changes to the
KIP to better match the implementation details. Here is a summary of
the changes we made to the KIP:
1. Added control records at the begin and end of the snapshots. The
control records are versioned. The snapshot header record inc
Thanks everyone for the votes. KIP-630 has been accepted.
Binding: Guozhang, Jason and Jun
Non-binding: Ron and Lucas
On Fri, Oct 9, 2020 at 4:33 PM Jose Garcia Sancio wrote:
>
> Thanks for the votes Jun, Jason, Ron, Lucas and Guozhang.
>
> Thanks for the feedback Ron and Jun.
>
> Agree with you
Thanks for the votes Jun, Jason, Ron, Lucas and Guozhang.
Thanks for the feedback Ron and Jun.
Agree with your comments Ron. I have updated those configurations to
metadata.snapshot.min.changed_records.ratio and
metadata.snapshot.min.new_records.size. I thought of using "clenable"
to keep it cons
Hi, Jose,
Thanks for the KIP. +1. A couple of minor comments below.
1. The new configuration names suggested by Ron sound reasonable.
2. It seems that OFFSET_OUT_OF_RANGE in the wiki needs to be changed to
POSITION_OUT_OF_RANGE.
Jun
On Mon, Oct 5, 2020 at 9:46 AM Jason Gustafson wrote:
> +1 T
+1 Thanks for the KIP!
-Jason
On Mon, Oct 5, 2020 at 9:03 AM Ron Dagostino wrote:
> Thanks for the KIP, Jose. +1 (non-binding) from me.
>
> I do have one comment/confusion.
>
> Upon re-reading the latest version, I am confused about the name of
> the proposed "metadata.snapshot.min.records" co
Thanks for the KIP, Jose. +1 (non-binding) from me.
I do have one comment/confusion.
Upon re-reading the latest version, I am confused about the name of
the proposed "metadata.snapshot.min.records" config. Is this a size,
or is it a count? I think it is about a size but want to be sure. I
als
Thanks for the KIP! Non-binding +1
On Fri, Oct 2, 2020 at 3:30 PM Guozhang Wang wrote:
> Thanks Jose! +1 from me.
>
> On Fri, Oct 2, 2020 at 3:18 PM Jose Garcia Sancio
> wrote:
>
> > Hi all,
> >
> > I would like to start a vote on KIP-630.
> >
> > KIP: https://cwiki.apache.org/confluence/x/exV4
Thanks Jose! +1 from me.
On Fri, Oct 2, 2020 at 3:18 PM Jose Garcia Sancio
wrote:
> Hi all,
>
> I would like to start a vote on KIP-630.
>
> KIP: https://cwiki.apache.org/confluence/x/exV4CQ
> Discussion Thread:
>
> https://lists.apache.org/thread.html/r9468d1f276385695a2d6d48f6dfbdc504c445fc574
Hi all,
I would like to start a vote on KIP-630.
KIP: https://cwiki.apache.org/confluence/x/exV4CQ
Discussion Thread:
https://lists.apache.org/thread.html/r9468d1f276385695a2d6d48f6dfbdc504c445fc5745aaa606d138fed%40%3Cdev.kafka.apache.org%3E
Thank you
--
-Jose
