Re: [VOTE] KIP-738: Removal of Connect's internal converter properties

2021-06-09 Thread Chris Egerton
Hi all, The KIP passes with three binding +1s from Randall, Tom, and Konstantine, and one non-binding +1 from Ryanne. I'll have a PR out shortly. Thanks to all who participated! Cheers, Chris On Fri, Jun 4, 2021 at 9:28 PM Konstantine Karantasis wrote: > +1 (binding) but also with the note

Re: [VOTE] KIP-738: Removal of Connect's internal converter properties

2021-06-04 Thread Konstantine Karantasis
+1 (binding) but also with the note that we don't tend to require a KIP in order to remove configurations that have been deprecated in previous KIPs. A jira ticket with the right release as a target should suffice. In future KIPs adding a note that says that a feature is deprecated and may be

Re: [VOTE] KIP-738: Removal of Connect's internal converter properties

2021-06-03 Thread Tom Bentley
+1 (binding). Thanks Chris! On Wed, Jun 2, 2021 at 11:00 PM Randall Hauch wrote: > Thanks for putting this together, Chris. > > Technically, we don't need a new KIP to explicitly remove an API, config, > etc. that was previously deprecated under an earlier approved KIP. But > KIP-174 could

Re: [VOTE] KIP-738: Removal of Connect's internal converter properties

2021-06-02 Thread Randall Hauch
Thanks for putting this together, Chris. Technically, we don't need a new KIP to explicitly remove an API, config, etc. that was previously deprecated under an earlier approved KIP. But KIP-174 could have been a bit more explicit (note taken for future KIPs) that deprecation means "deprecation

Re: [VOTE] KIP-738: Removal of Connect's internal converter properties

2021-05-18 Thread Ryanne Dolan
+1 (non-binding) Thanks! Ryanne On Tue, May 18, 2021, 6:38 AM Chris Egerton wrote: > Hi all, > > I'd like to call for a vote on KIP-738: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-738%3A+Removal+of+Connect%27s+internal+converter+properties > > The discussion thread (which was

[VOTE] KIP-738: Removal of Connect's internal converter properties

2021-05-18 Thread Chris Egerton
Hi all, I'd like to call for a vote on KIP-738: https://cwiki.apache.org/confluence/display/KAFKA/KIP-738%3A+Removal+of+Connect%27s+internal+converter+properties The discussion thread (which was originally titled with "KIP-736") can be found here: