Thanks everyone for voting.
Voting passed with the following +1s:
- Luke Chen
- Guozhang Wang (binding)
- John Roesler (binding)
- Bruno Cadonna (binding)
I'll update the KIP status accordingly.
Best,
Patrick
On Thu, Dec 16, 2021 at 2:09 PM Bruno Cadonna wrote:
> Hi Partick,
>
> Thank you
Hi Partick,
Thank you for the KIP!
+1 (binding)
Best,
Bruno
On 16.12.21 07:22, Luke Chen wrote:
Hi Patrick, John,
Thanks for your explanation and update.
It looks better now.
+1 (non-binding) from me.
just one minor comment:
10. In the example section, we are still using the variable
Hi Patrick, John,
Thanks for your explanation and update.
It looks better now.
+1 (non-binding) from me.
just one minor comment:
10. In the example section, we are still using the variable names `lower`
and `upper` as before. We should update them, too. (follow the decision for
point 7 above)
Thanks Patrick, John.
I read through the updated KIP and it's much cleared on the scope now,
appreciate that! I'm +1 overall, modulo a few minor comments:
7. The parameter names of `WindowKeyQuery#withKeyAndWindowStartRange`, i.e.
`startTime` and `endTime` seem not updated; also for the
FYI, I filed this follow-on task to explore a more general
pattern for these queries:
https://issues.apache.org/jira/browse/KAFKA-13548
We can unblock the current scope for these queries but still
plan to revisit the API before the first release of IQv2.
Thanks!
-John
On Wed, 2021-12-15 at
Thanks for the update, Patrick!
Tl;dr: I'm +1 (binding)
I just reviewed the KIP again (I hope you don't mind, I
fixed a couple of missed renames in the text and examples).
One of the design of IQv2 is to make proposing and evolving
these queries much less onerous. Unlike adding new methods
to
Thanks everyone for the sharing comments and suggestions, this is
very helpful!
I have updated the KIP based on the suggestions, please let me know what
you think. Here are the main changes:
- Removed constructor in WindowRangeQuery (Guozhang)
- Clearly specified how each of the instantiation of
Hi John,
Please see my follow-up comments inlined below.
On Mon, Dec 13, 2021 at 2:26 PM John Roesler wrote:
> Hi Patrick, thanks for the KIP!
>
> I hope you, Guozhang, and Luke don't mind if I share some
> thoughts:
>
> 1. I think you just meant to remove that private constructor
> from the
Hi Patrick, thanks for the KIP!
I hope you, Guozhang, and Luke don't mind if I share some
thoughts:
1. I think you just meant to remove that private constructor
from the KIP, right?
2. I think WindowRangeQuery#withWindowRage(windowLower,
windowUpper) is the version that yields an iterator over
Hi Patrick,
Thanks for the KIP!
I have some comments, in addition to Guozhang's comments:
4. The parameter names `windowLower` and `windowUpper` are kind of
ambiguous to me. Could we come up a better name for it, like
`windowStartTime`, `windowEndTime`, or even we don't need the "window"
name,
Hi Patrick,
I made a pass on the KIP and have a few comments below:
1. The `WindowRangeQuery` has a private constructor while the
`WindowKeyQuery` has not, is that intentional?
2. The `WindowRangeQuery` seems not allowing to range over both window and
key, but only window with a fixed key, in
Hi everyone,
I would like to start the vote for KIP-806 that adds window and session
query support to query KV-stores using IQv2.
The KIP can be found here:
https://cwiki.apache.org/confluence/x/LJaqCw
Skipping the discussion phase as this KIP is following the same pattern as
the previously
12 matches
Mail list logo
