[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14395955#comment-14395955
]
Jay Kreps commented on KAFKA-1729:
--
[~jjkoshy] is this still waiting on an update from
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328493#comment-14328493
]
Joel Koshy commented on KAFKA-1729:
---
Need to also update the protocol guide wiki with
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326764#comment-14326764
]
Joel Koshy commented on KAFKA-1729:
---
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309817#comment-14309817
]
Joel Koshy commented on KAFKA-1729:
---
I will be making a few more edits after some
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303446#comment-14303446
]
Jun Rao commented on KAFKA-1729:
[~jjkoshy], for 0.8.2, we can probably just update the
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301864#comment-14301864
]
Joel Koshy commented on KAFKA-1729:
---
Yes I will commit it today.
Re: rolling back to ZK
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14302676#comment-14302676
]
Joel Koshy commented on KAFKA-1729:
---
I committed the patch to trunk - but then realized
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301736#comment-14301736
]
Jun Rao commented on KAFKA-1729:
Joel,
Thanks for the doc. Looks good. Just a few minor
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14298059#comment-14298059
]
Joel Koshy commented on KAFKA-1729:
---
Thanks Jun - will do. When you get a chance, take a
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294645#comment-14294645
]
Joel Koshy commented on KAFKA-1729:
---
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294647#comment-14294647
]
Joel Koshy commented on KAFKA-1729:
---
(Uploaded above patch since we will most likely
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289595#comment-14289595
]
Jun Rao commented on KAFKA-1729:
Do you mean that you need to make code changes in the
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14290011#comment-14290011
]
Joel Koshy commented on KAFKA-1729:
---
Ideally yes because it makes Java access unwieldy
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14290013#comment-14290013
]
Joel Koshy commented on KAFKA-1729:
---
So perhaps it is best to leave the code as is since
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14290132#comment-14290132
]
Jun Rao commented on KAFKA-1729:
[~jjkoshy], thanks for the update. Yes, I agree that we
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14287949#comment-14287949
]
Joel Koshy commented on KAFKA-1729:
---
Should be able to update the doc patch today.
add
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288933#comment-14288933
]
Joel Koshy commented on KAFKA-1729:
---
I was trying out the documentation I wrote on
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286651#comment-14286651
]
Jun Rao commented on KAFKA-1729:
[~jjkoshy], are you on track to complete the doc for the
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14209071#comment-14209071
]
Jun Rao commented on KAFKA-1729:
Thanks for the patch. A few comments.
1. We need to make
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199616#comment-14199616
]
Joel Koshy commented on KAFKA-1729:
---
Incorporated comments. I would actually like to get
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14197067#comment-14197067
]
Gwen Shapira commented on KAFKA-1729:
-
Since tracking consumer offsets in ZK is still
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14197243#comment-14197243
]
Joel Koshy commented on KAFKA-1729:
---
Thanks for reviewing.
Re: offsets in ZK
Yes we can
22 matches
Mail list logo
