[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295435#comment-14295435
]
Jun Rao commented on KAFKA-1902:
It seems that the ganglia reporter replaces anything
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295454#comment-14295454
]
Kyle Banker commented on KAFKA-1902:
This looks great, [~junrao]!
fix MetricName so
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295359#comment-14295359
]
Jason Rosenberg commented on KAFKA-1902:
For the record, at Square, we do use
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295526#comment-14295526
]
Jason Rosenberg commented on KAFKA-1902:
LGTM
fix MetricName so that Yammer
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295420#comment-14295420
]
Jun Rao commented on KAFKA-1902:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293919#comment-14293919
]
Jun Rao commented on KAFKA-1902:
Thanks for the explanation. A couple of things: (1) Since
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294289#comment-14294289
]
Jun Rao commented on KAFKA-1902:
In Kafka, topic/group/clientId can include only -, _ and
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294287#comment-14294287
]
Jason Rosenberg commented on KAFKA-1902:
Actually, a red flag here too, is why are
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294261#comment-14294261
]
Jason Rosenberg commented on KAFKA-1902:
[~jjkoshy] I did mean to just replace all
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294286#comment-14294286
]
Jun Rao commented on KAFKA-1902:
Is graphite the only reporter using scope? t seems that
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294239#comment-14294239
]
Joel Koshy commented on KAFKA-1902:
---
I meant mytopic$with$dot.myclientId$with$dot
fix
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294545#comment-14294545
]
Kyle Banker commented on KAFKA-1902:
[~junrao] Agree that the dot may not be common,
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294474#comment-14294474
]
Jun Rao commented on KAFKA-1902:
Making the replacing character configurable is actually
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294499#comment-14294499
]
Joel Koshy commented on KAFKA-1902:
---
Jun - to answer your earlier question. I took a
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294332#comment-14294332
]
Jason Rosenberg commented on KAFKA-1902:
+1
fix MetricName so that Yammer
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294733#comment-14294733
]
Otis Gospodnetic commented on KAFKA-1902:
-
bq. It's unfortunate it seems graphite
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293747#comment-14293747
]
Jun Rao commented on KAFKA-1902:
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293840#comment-14293840
]
Jason Rosenberg commented on KAFKA-1902:
In the yammer metric reporter (which is
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293854#comment-14293854
]
Kyle Banker commented on KAFKA-1902:
This definitely fixes the issue. I'm now seeing
19 matches
Mail list logo