[jira] [Commented] (KAFKA-3525) max.reserved.broker.id off-by-one error

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279324#comment-15279324 ] ASF GitHub Bot commented on KAFKA-3525: --- Github user asfgit closed the pull request

[jira] [Commented] (KAFKA-3525) max.reserved.broker.id off-by-one error

2016-05-05 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273215#comment-15273215 ] Flavio Junqueira commented on KAFKA-3525: - Got it, thank you both for the clarific

[jira] [Commented] (KAFKA-3525) max.reserved.broker.id off-by-one error

2016-05-05 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272696#comment-15272696 ] Sriharsha Chintalapani commented on KAFKA-3525: --- [~fpj] reservered.broker.ma

[jira] [Commented] (KAFKA-3525) max.reserved.broker.id off-by-one error

2016-05-05 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272275#comment-15272275 ] Manikumar Reddy commented on KAFKA-3525: 1. Assume reserved.broker.max.id =1000 2.

[jira] [Commented] (KAFKA-3525) max.reserved.broker.id off-by-one error

2016-05-05 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272234#comment-15272234 ] Flavio Junqueira commented on KAFKA-3525: - I'm a bit confused by what this issue i

[jira] [Commented] (KAFKA-3525) max.reserved.broker.id off-by-one error

2016-05-04 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271527#comment-15271527 ] Gwen Shapira commented on KAFKA-3525: - This will wait for the next release. The max re

[jira] [Commented] (KAFKA-3525) max.reserved.broker.id off-by-one error

2016-04-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242882#comment-15242882 ] ASF GitHub Bot commented on KAFKA-3525: --- GitHub user omkreddy opened a pull request:

[jira] [Commented] (KAFKA-3525) max.reserved.broker.id off-by-one error

2016-04-08 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233241#comment-15233241 ] Manikumar Reddy commented on KAFKA-3525: Yes, by looking this function alone it is

[jira] [Commented] (KAFKA-3525) max.reserved.broker.id off-by-one error

2016-04-08 Thread Alan Braithwaite (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232703#comment-15232703 ] Alan Braithwaite commented on KAFKA-3525: - Please correct me if I'm wrong, but thi

[jira] [Commented] (KAFKA-3525) max.reserved.broker.id off-by-one error

2016-04-08 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232671#comment-15232671 ] Manikumar Reddy commented on KAFKA-3525: Actually getBrokerSequenceId will never r