Re: [VOTE] KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-12-20 Thread Gantigmaa Selenge
Thank you Andrew! I have now submitted a PR (https://github.com/apache/kafka/pull/14995) for the implementation of this KIP. Regards, Tina On Tue, Dec 19, 2023 at 1:32 PM Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: > Thanks for the KIP. > > +1 (non-binding) > > Thanks, > Andrew

Re: [VOTE] KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-12-19 Thread Andrew Schofield
Thanks for the KIP. +1 (non-binding) Thanks, Andrew > On 14 Dec 2023, at 13:41, Mickael Maison wrote: > > +1 (binding) > Thanks for the KIP > > Mickael > > On Wed, Dec 13, 2023 at 4:01 PM Chris Egerton wrote: >> >> Hi Tina, >> >> Thanks for the KIP! +1 (binding) >> >> Cheers, >> >> Chris >> >>

Re: [VOTE] KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-12-19 Thread Gantigmaa Selenge
Thank you so much Edo! The KIP is accepted with 3 binding votes (Chris, Mickael, Edo). Thank you all. Regards, Tina On Tue, Dec 19, 2023 at 10:34 AM Edoardo Comar wrote: > +1 (binding) > Thanks for the KIP Tina! > > Edo > > On Tue, 19 Dec 2023 at 10:01, Gantigmaa Selenge > wrote: > > > > Than

Re: [VOTE] KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-12-19 Thread Edoardo Comar
+1 (binding) Thanks for the KIP Tina! Edo On Tue, 19 Dec 2023 at 10:01, Gantigmaa Selenge wrote: > > Thank you Chris and Mickael for the vote! > > KIP is missing just one more +1 (binding). > > Regards, > Tina > > On Thu, Dec 14, 2023 at 1:48 PM Mickael Maison > wrote: > > > +1 (binding) > > Th

Re: [VOTE] KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-12-19 Thread Gantigmaa Selenge
Thank you Chris and Mickael for the vote! KIP is missing just one more +1 (binding). Regards, Tina On Thu, Dec 14, 2023 at 1:48 PM Mickael Maison wrote: > +1 (binding) > Thanks for the KIP > > Mickael > > On Wed, Dec 13, 2023 at 4:01 PM Chris Egerton > wrote: > > > > Hi Tina, > > > > Thanks f

Re: [VOTE] KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-12-14 Thread Mickael Maison
+1 (binding) Thanks for the KIP Mickael On Wed, Dec 13, 2023 at 4:01 PM Chris Egerton wrote: > > Hi Tina, > > Thanks for the KIP! +1 (binding) > > Cheers, > > Chris > > On Wed, Dec 13, 2023 at 5:50 AM Gantigmaa Selenge > wrote: > > > Hi > > > > I'd like to call for a vote on KIP-993, which allo

Re: [VOTE] KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-12-13 Thread Chris Egerton
Hi Tina, Thanks for the KIP! +1 (binding) Cheers, Chris On Wed, Dec 13, 2023 at 5:50 AM Gantigmaa Selenge wrote: > Hi > > I'd like to call for a vote on KIP-993, which allows restricting files > accessed by File and Directory ConfigProviders when using Connect. > > The KIP: > > https://cwiki.

[VOTE] KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-12-13 Thread Gantigmaa Selenge
Hi I'd like to call for a vote on KIP-993, which allows restricting files accessed by File and Directory ConfigProviders when using Connect. The KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-993%3A+Allow+restricting+files+accessed+by+File+and+Directory+ConfigProviders The discussion

Re: KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-12-12 Thread Gantigmaa Selenge
Thanks Chris. I have added that as well. I think I can start the vote on this KIP if there are no further comments. Thanks. Regards, Tina On Tue, Dec 12, 2023 at 1:43 PM Chris Egerton wrote: > Thanks Tina! LGTM as long as we take care to document that recursive access > to directories will be

Re: KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-12-12 Thread Chris Egerton
Thanks Tina! LGTM as long as we take care to document that recursive access to directories will be granted when we release this feature. On Tue, Dec 12, 2023 at 8:16 AM Gantigmaa Selenge wrote: > Hi Chris, > > Thank you for the feedback. > > > 1. Addressed > > > 2. I have updated the type to be

Re: KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-12-12 Thread Gantigmaa Selenge
Hi Chris, Thank you for the feedback. 1. Addressed 2. I have updated the type to be List. The configure() function is more likely to process the value as String and convert to List using the comma separation but I think it makes sense to specify it as List, as that is the final type. 3. Yes

Re: KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-12-07 Thread Chris Egerton
Hi Tina, Thanks for the KIP! Looks good overall. A few minor thoughts: 1. We can remove the "This page is meant as a template for writing a KIP" section from the beginning. 2. The type of the allowed.paths property is string in the KIP, but the description mentions it'll contain multiple comma-s

Re: KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-12-07 Thread Gantigmaa Selenge
Thank you Mickael. I'm going to leave the discussion thread open for a couple more days and if there are no further comments, I would like to start the vote for this KIP. Thanks. Regards, Tina On Wed, Dec 6, 2023 at 10:06 AM Mickael Maison wrote: > Hi, > > I'm not aware of any other mechanisms

Re: KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-12-06 Thread Mickael Maison
Hi, I'm not aware of any other mechanisms to explore the filesystem. If you have ideas, please reach out to the security list. Thanks, Mickael On Tue, Dec 5, 2023 at 1:05 PM Gantigmaa Selenge wrote: > > Hi everyone, > > > Apologies for the very delayed response. Thank you both for the feedback.

Re: KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-12-05 Thread Gantigmaa Selenge
Hi everyone, Apologies for the very delayed response. Thank you both for the feedback. > For clarity it might make sense to mention this feature will be useful when using a ConfigProvider with Kafka Connect as providers are set in the runtime and can then be used by connectors. This feature h

Re: KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-11-08 Thread Greg Harris
Hey Tina, Thanks for the KIP! Unrestricted file system access over a REST API is an unfortunate anti-pattern, so I'm glad that you're trying to change it. I had a few questions, mostly from the Connect perspective. 1. In the past Connect removed the FileStream connectors in order to prevent a RES

Re: KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-11-07 Thread Mickael Maison
Hi Tina, Thanks for the KIP. For clarity it might make sense to mention this feature will be useful when using a ConfigProvider with Kafka Connect as providers are set in the runtime and can then be used by connectors. This feature has no use when using a ConfigProvider in server.properties or in

Re: KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-11-07 Thread Gantigmaa Selenge
Hi everyone, Please let me know if you have any comments on the KIP. I will leave it for a few more days. If there are still no comments, I will start the vote on it. Regards, Tina On Wed, Oct 25, 2023 at 8:31 AM Gantigmaa Selenge wrote: > Hi everyone, > > I would like to start a discussion o

KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-10-25 Thread Gantigmaa Selenge
Hi everyone, I would like to start a discussion on KIP-933 that proposes restricting files accessed by File and Directory ConfigProviders. https://cwiki.apache.org/confluence/display/KAFKA/KIP-993%3A+Allow+restricting+files+accessed+by+File+and+Directory+ConfigProviders Regards, Tina