Hey everyone,
I was wondering if it is possible to standardize indentation across clients
and core. As an example, all the java code uses 4 spaces and the scala code
2. As we increasingly share code between clients and core, I think
consistency would be super useful.
Thoughts?
Aditya
For my part I actually prefer it how it is. The scala code is a different
language, has different naming and capitalization conventions, etc. I
actually like that it has a different look and feel so I don't get
confused. In general, I think 4 spaces is standard for java and 2 spaces is
pretty stand
Hi Jay,
On Fri, Jul 24, 2015 at 2:00 AM, Jay Kreps wrote:
> - Wait for java 8 to become common so we don't have to translate to java 7
> ...
> Even ignoring those items I don't think we would dare take this on right
> now because there are so many other projects in flight but it might be
> worth
On Fri, Jul 24, 2015 at 2:00 AM, Jay Kreps wrote:
> I do agree that working with a mixture of scala and java is a pain in the
> butt. What about considering the more extreme idea of just moving the
> remaining server-side scala into java? I like Scala, but the tooling and
> compatibility story fo
Personally, I prefer the consistency and 2 spaces for indentation. Although
I'm in agreement with Jay about the ambition to eventually move the server
code to Java, I'd hate to make that a blocker for discussing a simple
change like standardizing on java/scala indentation :-)
On Fri, Jul 24, 2015
+1 for consistency.
On Fri, Jul 24, 2015 at 8:51 AM, Neha Narkhede wrote:
> Personally, I prefer the consistency and 2 spaces for indentation. Although
> I'm in agreement with Jay about the ambition to eventually move the server
> code to Java, I'd hate to make that a blocker for discussing a si
Ismael,
Makes sense. I think there is a good chance that it is just our ignorance
of scala tools. I really do like having compile time enforced formatting
and dependency checking as we have for java. But we really put no effort
into trying to improve the scala developer experience so it may be an
I'm with Neha on this one. I don't have a strong preference on 2 vs 4 but I
do think that consistency is more important. It makes writing code a bit
easier especially since patches are increasingly likely to touch both Java
and Scala code and it's nice to not think about formatting certain files
di
Bump. Anyone else have an opinion?
Neha/Jay - You've made your thoughts clear. Any thoughts on how/if we make
any changes?
Thanks,
Aditya
On Fri, Jul 24, 2015 at 10:32 AM, Aditya Auradkar
wrote:
> I'm with Neha on this one. I don't have a strong preference on 2 vs 4 but
> I do think that cons
Can the java code be indented without affecting the results of git blame?
If not, then I'd vote to leave it as it is.
(Also +1 on rewriting Kafka in Java)
-Jason
On Tue, Aug 11, 2015 at 5:15 PM, Aditya Auradkar <
aaurad...@linkedin.com.invalid> wrote:
> Bump. Anyone else have an opinion?
>
> Ne
+1 on consistency.
Thanks,
Mayuresh
On Tue, Aug 11, 2015 at 5:15 PM, Aditya Auradkar <
aaurad...@linkedin.com.invalid> wrote:
> Bump. Anyone else have an opinion?
>
> Neha/Jay - You've made your thoughts clear. Any thoughts on how/if we make
> any changes?
>
> Thanks,
> Aditya
>
>
> On Fri, Jul
missed it. +1 on rewriting Kafka in Java.
Thanks,
Mayuresh
On Tue, Aug 11, 2015 at 5:23 PM, Jason Gustafson wrote:
> Can the java code be indented without affecting the results of git blame?
> If not, then I'd vote to leave it as it is.
>
> (Also +1 on rewriting Kafka in Java)
>
> -Jason
>
> O
+1 on not breaking git blame
-1 on rewriting Kafka in Java
+1 on upping our Scala game (as Ismael pointed out)
On Tue, Aug 11, 2015 at 5:23 PM, Jason Gustafson wrote:
> Can the java code be indented without affecting the results of git blame?
> If not, then I'd vote to leave it as it is.
>
> (A
I am also a +1 on not breaking git blame. IDEs support language specific
settings in same project.
On Tue, Aug 11, 2015 at 5:29 PM, Gwen Shapira wrote:
> +1 on not breaking git blame
>
> -1 on rewriting Kafka in Java
> +1 on upping our Scala game (as Ismael pointed out)
>
> On Tue, Aug 11, 2015
+1 on not breaking blame
-1 on 4 spaces for scala
-1 on rewriting Kafka in Java
+1 on upping our Scala game
so I guess an accumulative of 0 for me ;)
On Tue, Aug 11, 2015 at 7:37 PM, Ashish Singh wrote:
> I am also a +1 on not breaking git blame. IDEs support language specific
> settings in s
Ha ha, love that this thread is simultaneously an argument over code
whitespace AND language choice. Getting agreement here will be like the
open source discussion equivalent of trying to simultaneously conquer both
France and Russia.
Anyone have preferences on text editors? I've always thought em
Jay is in the mood for the mother of all bikeshedding exercises. Let me add
the (in)famous build framework question to the mix. I think we should move
to Maven :-P
On Tue, Aug 11, 2015 at 9:31 PM, Jay Kreps wrote:
> Ha ha, love that this thread is simultaneously an argument over code
> whitespac
On Wed, Aug 12, 2015 at 1:23 AM, Jason Gustafson wrote:
> Can the java code be indented without affecting the results of git blame?
> If not, then I'd vote to leave it as it is.
>
Nope.
Ismael
On Wed, Aug 12, 2015 at 1:29 AM, Gwen Shapira wrote:
> +1 on not breaking git blame
>
> -1 on rewriting Kafka in Java
> +1 on upping our Scala game (as Ismael pointed out)
>
I filed a couple of JIRAs, and I'll look at introducing Scalastyle once
some of the bigger patches/PRs are merged.
https:
+1 about rewriting to Java (in a year or more).
+1 about upping Scala use in the meanwhile
+1 about using Gradle instead of Maven or SBT.
Eddie
On Wed, Aug 12, 2015 at 5:26 AM, Ismael Juma wrote:
> On Wed, Aug 12, 2015 at 1:29 AM, Gwen Shapira wrote:
>
> > +1 on not breaking git blame
> >
> >
20 matches
Mail list logo
