.
-Original Message-
From: Pellerin, Clement
Sent: Wednesday, November 28, 2018 11:49 AM
To: dev@kafka.apache.org
Subject: RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory
If no one objects, I'll rewrite the KIP like this and resubmit for discussion:
Ideal interface, ignor
nyway.
-Original Message-
From: Pellerin, Clement
Sent: Wednesday, November 21, 2018 10:42 AM
To: dev@kafka.apache.org
Subject: RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory
This turned out to be trickier than I thought and I don't have a firm solution
yet.
Since SslFactory w
rface instead.
Thoughts?
-Original Message-
From: Rajini Sivaram [mailto:rajinisiva...@gmail.com]
Sent: Tuesday, October 23, 2018 7:54 AM
To: dev
Subject: Re: [DISCUSS] KIP-383 Pluggable interface for SSL Factory
Thanks for the PR. A couple of comments:
1) For other public interfaces, w
t: Re: [DISCUSS] KIP-383 Pluggable interface for SSL Factory
Thanks for the PR. A couple of comments:
1) For other public interfaces, we use parameters to configure instead of
internal config names going into the same list of configs. Kafka has public
config names and custom config names that
I need more feedback?
>
> -Original Message-
> From: Harsha Chintalapani [mailto:ka...@harsha.io]
> Sent: Monday, October 22, 2018 4:36 PM
> To: dev@kafka.apache.org
> Subject: RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory
>
> Thanks for the changes. KIP lo
October 19, 2018 6:51 PM
> To: dev@kafka.apache.org; dev@kafka.apache.org
> Subject: RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory
>
> SslFactory is not a public interface for others to use. EchoServer is
> internal testing.
> We should make these a
ber 19, 2018 6:51 PM
> To: dev@kafka.apache.org; dev@kafka.apache.org
> Subject: RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory
>
> SslFactory is not a public interface for others to use. EchoServer is
> internal testing.
> We should make these as proposed in rejected alternatives t
on this new version.
-Original Message-
From: Harsha Chintalapani [mailto:ka...@harsha.io]
Sent: Friday, October 19, 2018 6:51 PM
To: dev@kafka.apache.org; dev@kafka.apache.org
Subject: RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory
SslFactory is not a public interface for
es if the Kafka community thinks no Kafka
> application calls SslFactory directly. I would like more opinions on this
> though.
>
>
> -Original Message-
> From: Harsha Chintalapani [mailto:ka...@harsha.io]
> Sent: Friday, October 19, 2018 5:55 PM
> To: dev@kafka.apache.or
rectly. I would like more opinions on this
though.
-Original Message-
From: Harsha Chintalapani [mailto:ka...@harsha.io]
Sent: Friday, October 19, 2018 5:55 PM
To: dev@kafka.apache.org
Subject: RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory
Hi,
Overall the KIP looks good t
Hi,
Overall the KIP looks good to me.
"Ideally, the interface should be called SslFactory and the built-in
implementation should be called DefaultSslFactory. This was rejected to improve
backwards compatibility for applications that call the SslFactory directly.”
Can you explain why callin
I have updated the KIP to use a default constructor in the pluggable SSL
Factory implementation.
I also changed the name of the config to ssl.sslfactory.class and fixed a typo
in the constant names.
I would like your feedback on this version of the KIP.
-Original Message-
From: Pellerin,
Original Message-
From: Harsha [mailto:ka...@harsha.io]
Sent: Thursday, October 18, 2018 10:58 AM
To: dev@kafka.apache.org
Subject: Re: [DISCUSS] KIP-383 Pluggable interface for SSL Factory
Hi,
Thanks for the KIP. Curious to understand why the ChannelBuilder
interface doesn't so
Hi,
Thanks for the KIP. Curious to understand why the ChannelBuilder
interface doesn't solve the stated reasons in Motiviation section.
Thanks,
Harsha
On Wed, Oct 17, 2018, at 12:10 PM, Pellerin, Clement wrote:
> I would like feedback on this proposal to make it possible to replace
> Ssl
14 matches
Mail list logo
