---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14638/
---
(Updated Oct. 16, 2013, 11:29 p.m.)
Review request for kafka.
Bugs:
On Oct. 15, 2013, 8:03 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/tools/GetOffsetShell.scala, line 63
https://reviews.apache.org/r/14638/diff/1/?file=364653#file364653line63
Can use CommandLineUtils.checkRequiredArgs
Fixed this. Thanks for pointing this out!
On Oct. 15,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14638/#review27028
---
Ship it!
Only one minor comment below.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14638/#review27039
---
core/src/main/scala/kafka/tools/GetOffsetShell.scala
On Oct. 15, 2013, 8:03 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/tools/GetOffsetShell.scala, line 71
https://reviews.apache.org/r/14638/diff/1/?file=364653#file364653line71
Nice use of clientId. We should do this in every tool. I would suggest
we also prepend this with
On Oct. 15, 2013, 4:33 p.m., Jun Rao wrote:
core/src/main/scala/kafka/tools/GetOffsetShell.scala, lines 41-42
https://reviews.apache.org/r/14638/diff/1/?file=364653#file364653line41
Should we name this option partitions?
Sure. Will make that change on check-in
- Neha
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14638/
---
Review request for kafka.
Bugs: KAFKA-1086
