Re: Review Request 23895: Patch for KAFKA-1419

2014-08-07 Thread Ivan Lyutov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated Aug. 7, 2014, 10:17 a.m.) Review request for kafka. Bugs:

Re: Review Request 23895: Patch for KAFKA-1419

2014-08-07 Thread Ivan Lyutov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated Aug. 7, 2014, 10:52 a.m.) Review request for kafka. Bugs:

Re: Review Request 23895: Patch for KAFKA-1419

2014-08-07 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/#review49920 --- Thanks for the patch. I think it's almost ready to go. A couple of

Re: Review Request 23895: Patch for KAFKA-1419

2014-08-05 Thread Ivan Lyutov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated Aug. 5, 2014, 12:52 p.m.) Review request for kafka. Bugs:

Re: Review Request 23895: Patch for KAFKA-1419

2014-08-05 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/#review49601 --- build.gradle https://reviews.apache.org/r/23895/#comment86832

Re: Review Request 23895: Patch for KAFKA-1419

2014-08-05 Thread Jun Rao
On Aug. 5, 2014, 2:24 p.m., Joe Stein wrote: gradle.properties, line 18 https://reviews.apache.org/r/23895/diff/5/?file=652031#file652031line18 I think this should be 2.9.2 but confirming with Jun that is what we are going to be recommending when 0.8.2 releases. Joe, I agree

Re: Review Request 23895: Patch for KAFKA-1419

2014-08-04 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/#review49454 --- build.gradle https://reviews.apache.org/r/23895/#comment86528

Re: Review Request 23895: Patch for KAFKA-1419

2014-08-04 Thread Ivan Lyutov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated Aug. 4, 2014, 2:43 p.m.) Review request for kafka. Bugs: KAFKA-1419

Re: Review Request 23895: Patch for KAFKA-1419

2014-08-04 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/#review49559 --- Look good overall. We need to change the default scala version in

Re: Review Request 23895: Patch for KAFKA-1419

2014-07-29 Thread Ivan Lyutov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated July 29, 2014, 3:13 p.m.) Review request for kafka. Bugs:

Re: Review Request 23895: Patch for KAFKA-1419

2014-07-28 Thread Ivan Lyutov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated July 28, 2014, 3:07 p.m.) Review request for kafka. Bugs:

Re: Review Request 23895: Patch for KAFKA-1419

2014-07-28 Thread Joe Crobak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/#review48877 --- Good stuff, I was able to get all binaries to build and pass tests

Re: Review Request 23895: Patch for KAFKA-1419

2014-07-28 Thread Joe Crobak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/#review48957 --- build.gradle https://reviews.apache.org/r/23895/#comment85795

Review Request 23895: Patch for KAFKA-1419

2014-07-24 Thread Ivan Lyutov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- Review request for kafka. Bugs: KAFKA-1419