Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review67997 --- core/src/main/scala/kafka/client/ClientUtils.scala

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Jan. 14, 2015, 12:43 a.m.) Review request for kafka, Guozhang Wang, jo

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Jan. 13, 2015, 9:56 p.m.) Review request for kafka, Guozhang Wang, joe

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Jan. 8, 2015, 2:35 a.m.) Review request for kafka, Guozhang Wang, joel

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Dec. 28, 2014, 12:21 a.m.) Review request for kafka and joel koshy.

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Dec. 28, 2014, 12:15 a.m.) Review request for kafka and joel koshy.

Re: Review Request 25944: Patch for KAFKA-1013

> On Dec. 24, 2014, 1:59 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/OffsetClient.scala, line 141 > > > > > > This really should not be part of the offset client's public API. > > fetchTopicMetadata is

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review65997 --- core/src/main/scala/kafka/client/ClientUtils.scala

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Dec. 24, 2014, 12:41 a.m.) Review request for kafka and joel koshy.

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Dec. 21, 2014, 11:06 p.m.) Review request for kafka and joel koshy.

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Dec. 21, 2014, 10:42 p.m.) Review request for kafka. Bugs: KAFKA-101

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Oct. 3, 2014, 5:43 a.m.) Review request for kafka. Bugs: KAFKA-1013

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Oct. 2, 2014, 4:05 a.m.) Review request for kafka. Bugs: KAFKA-1013

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Sept. 27, 2014, 1:52 a.m.) Review request for kafka. Bugs: KAFKA-101

Re: Review Request 25944: Patch for KAFKA-1013

> On Sept. 24, 2014, 5:13 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/OffsetClient.scala, line 133 > > > > > > Should we just use ClientUtils.fetchTopicMetadata? Made ClientUtils.fetchTopicMetadata use

Re: Review Request 25944: Patch for KAFKA-1013

> On Sept. 25, 2014, 10:43 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, line > > 374 > > > > > > Is there a difference between these two: > > > > Thread.

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review54609 --- core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala

Re: Review Request 25944: Patch for KAFKA-1013

> On Sept. 25, 2014, 12:54 a.m., Neha Narkhede wrote: > > Can you consolidate the import and export offsets tools into a single tool? > > We already have https://issues.apache.org/jira/browse/KAFKA-1476 filed to > > consolidate tools and it will be great to not create too many redundant > > to

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review54487 --- Can you consolidate the import and export offsets tools into a singl

Re: Review Request 25944: Patch for KAFKA-1013

> On Sept. 24, 2014, 5:13 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/OffsetClient.scala, line 1 > > > > > > I think kafka.client would be a better place for this than kafka.tools > > > > In fact

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review54329 --- core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review54288 --- config/consumer.properties

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Sept. 23, 2014, 5:48 p.m.) Review request for kafka. Bugs: KAFKA-101

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Sept. 23, 2014, 5:45 p.m.) Review request for kafka. Bugs: KAFKA-101

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review54286 --- config/consumer.properties

Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- Review request for kafka. Bugs: KAFKA-1013 https://issues.apache.org/jira/b