Re: Review Request 28121: Patch for KAFKA-1780

> On Nov. 25, 2014, 12:26 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/utils/IteratorTemplate.scala, line 46 > > > > > > The change is larger than I expected it to be. What is the reason we > > couldn't cha

Re: Review Request 28121: Patch for KAFKA-1780

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28121/#review62926 --- Ship it! - Neha Narkhede On Nov. 25, 2014, 1:24 a.m., Ewen Chesla

Re: Review Request 28121: Patch for KAFKA-1780

> On Nov. 25, 2014, 12:26 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/consumer/ConsumerIterator.scala, line 30 > > > > > > Since we're changing the behavior of ConsumerIterator, let's document > > it here.

Re: Review Request 28121: Patch for KAFKA-1780

> On Nov. 25, 2014, 12:26 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/consumer/ConsumerIterator.scala, line 30 > > > > > > Since we're changing the behavior of ConsumerIterator, let's document > > it here.

Re: Review Request 28121: Patch for KAFKA-1780

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28121/ --- (Updated Nov. 25, 2014, 1:24 a.m.) Review request for kafka. Bugs: KAFKA-1780

Re: Review Request 28121: Patch for KAFKA-1780

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28121/#review62909 --- core/src/main/scala/kafka/consumer/ConsumerIterator.scala

Review Request 28121: Patch for KAFKA-1780

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28121/ --- Review request for kafka. Bugs: KAFKA-1780 https://issues.apache.org/jira/b