Re: Review Request 28268: Fix KAFKA-1624

2014-11-24 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28268/ --- (Updated Nov. 24, 2014, 7:02 p.m.) Review request for kafka. Summary (updated

Re: Review Request 28268: Fix KAFKA-1624

2014-11-24 Thread Guozhang Wang
> On Nov. 22, 2014, 2:24 a.m., Joel Koshy wrote: > > Looks good, although the patch does not apply - can you rebase; check that > > it builds properly and then we can close this out. > > Guozhang Wang wrote: > This is a little wired.. both you and Gwen said it does not apply but > when I a