Review Request 28793: Patch for KAFKA-1784

2014-12-07 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28793/ --- Review request for kafka. Bugs: KAFKA-1784 https://issues.apache.org/jira/b

Re: Review Request 28793: Patch for KAFKA-1784

2014-12-07 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28793/ --- (Updated Dec. 7, 2014, 7:43 p.m.) Review request for kafka. Bugs: KAFKA-1784

Re: Review Request 28793: Patch for KAFKA-1784

2014-12-09 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28793/#review64477 --- Can you add unit tests for this? core/src/main/scala/kafka/tools/O

Re: Review Request 28793: Patch for KAFKA-1784

2014-12-09 Thread Mayuresh Gharat
> On Dec. 10, 2014, 12:37 a.m., Neha Narkhede wrote: > > Can you add unit tests for this? Sure. I will try and add unit tests for this. - Mayuresh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Re: Review Request 28793: Patch for KAFKA-1784

2014-12-09 Thread Mayuresh Gharat
> On Dec. 10, 2014, 12:37 a.m., Neha Narkhede wrote: > > Can you add unit tests for this? > > Mayuresh Gharat wrote: > Sure. I will try and add unit tests for this. This part of the code was tested by Clark here, when had encountered an issue where we had to fetch offsets from kafka. - M

Re: Review Request 28793: Patch for KAFKA-1784

2014-12-10 Thread Mayuresh Gharat
> On Dec. 10, 2014, 12:37 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/OffsetClient.scala, line 142 > > > > > > This and a lot of the rest of the code exists in ClientUtils. Until the > > refactoring

Re: Review Request 28793: Patch for KAFKA-1784

2014-12-11 Thread Mayuresh Gharat
> On Dec. 10, 2014, 12:37 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/OffsetClient.scala, line 142 > > > > > > This and a lot of the rest of the code exists in ClientUtils. Until the > > refactoring

Re: Review Request 28793: Patch for KAFKA-1784

2014-12-11 Thread Neha Narkhede
> On Dec. 10, 2014, 12:37 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/OffsetClient.scala, line 142 > > > > > > This and a lot of the rest of the code exists in ClientUtils. Until the > > refactoring

Re: Review Request 28793: Patch for KAFKA-1784

2014-12-21 Thread Mayuresh Gharat
> On Dec. 10, 2014, 12:37 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/OffsetClient.scala, line 142 > > > > > > This and a lot of the rest of the code exists in ClientUtils. Until the > > refactoring