Re: Review Request 31447: Patch for KAFKA-1881

2015-02-26 Thread Gwen Shapira
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: Ah, now I get what dedupe buffer refers to :) I never managed to reproduce the oom, but this looks like the right fix. Ewen Cheslack-Postava wrote: This happened consistently for me, which provided good motivation to figure out

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-26 Thread Ewen Cheslack-Postava
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: Ah, now I get what dedupe buffer refers to :) I never managed to reproduce the oom, but this looks like the right fix. Ewen Cheslack-Postava wrote: This happened consistently for me, which provided good motivation to figure out

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-26 Thread Gwen Shapira
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: Ah, now I get what dedupe buffer refers to :) I never managed to reproduce the oom, but this looks like the right fix. Ewen Cheslack-Postava wrote: This happened consistently for me, which provided good motivation to figure out

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-25 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31447/#review74200 --- Ship it! Ah, now I get what dedupe buffer refers to :) I never

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-25 Thread Ewen Cheslack-Postava
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: Ah, now I get what dedupe buffer refers to :) I never managed to reproduce the oom, but this looks like the right fix. This happened consistently for me, which provided good motivation to figure out how to fix it :) It looks like the

Review Request 31447: Patch for KAFKA-1881

2015-02-25 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31447/ --- Review request for kafka. Bugs: KAFKA-1881

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-25 Thread Ewen Cheslack-Postava
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: Ah, now I get what dedupe buffer refers to :) I never managed to reproduce the oom, but this looks like the right fix. Ewen Cheslack-Postava wrote: This happened consistently for me, which provided good motivation to figure out

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-25 Thread Gwen Shapira
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: Ah, now I get what dedupe buffer refers to :) I never managed to reproduce the oom, but this looks like the right fix. Ewen Cheslack-Postava wrote: This happened consistently for me, which provided good motivation to figure out

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-25 Thread Ewen Cheslack-Postava
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: Ah, now I get what dedupe buffer refers to :) I never managed to reproduce the oom, but this looks like the right fix. Ewen Cheslack-Postava wrote: This happened consistently for me, which provided good motivation to figure out

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-25 Thread Gwen Shapira
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: Ah, now I get what dedupe buffer refers to :) I never managed to reproduce the oom, but this looks like the right fix. Ewen Cheslack-Postava wrote: This happened consistently for me, which provided good motivation to figure out