Re: Review Request 33760: Patch for KAFKA-2121

2015-05-05 Thread Jun Rao
> On May 4, 2015, 5:31 p.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/common/serialization/Serializer.java, > > line 25 > > > > > > This and also the Deserializer should extend Configurable too r

Re: Review Request 33760: Patch for KAFKA-2121

2015-05-04 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33760/#review82399 --- clients/src/main/java/org/apache/kafka/common/serialization/Seriali

Re: Review Request 33760: Patch for KAFKA-2121

2015-05-01 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33760/#review82292 --- Ship it! Ship It! - Guozhang Wang On May 1, 2015, 10:42 p.m., St

Re: Review Request 33760: Patch for KAFKA-2121

2015-05-01 Thread Steven Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33760/ --- (Updated May 1, 2015, 10:42 p.m.) Review request for kafka. Bugs: KAFKA-2121

Re: Review Request 33760: Patch for KAFKA-2121

2015-05-01 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33760/#review82280 --- Pointed out two minor issues, but otherwise LGTM. clients/src/test

Review Request 33760: Patch for KAFKA-2121

2015-05-01 Thread Steven Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33760/ --- Review request for kafka. Bugs: KAFKA-2121 https://issues.apache.org/jira/b