Re: Review Request 34403: Patch for KAFKA-2198

2015-07-13 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34403/#review91579 --- Ship it! Ship It! - Gwen Shapira On July 13, 2015, 1:57 p.m.,

Re: Review Request 34403: Patch for KAFKA-2198

2015-07-13 Thread Manikumar Reddy O
On July 10, 2015, 4:46 p.m., Gwen Shapira wrote: core/src/main/scala/kafka/admin/TopicCommand.scala, lines 72-73 https://reviews.apache.org/r/34403/diff/4/?file=1008271#file1008271line72 This is a bit unclean. I think its more idiomatic when the catch block includes the

Re: Review Request 34403: Patch for KAFKA-2198

2015-07-12 Thread Gwen Shapira
On July 10, 2015, 4:46 p.m., Gwen Shapira wrote: core/src/main/scala/kafka/admin/TopicCommand.scala, lines 72-73 https://reviews.apache.org/r/34403/diff/4/?file=1008271#file1008271line72 This is a bit unclean. I think its more idiomatic when the catch block includes the

Re: Review Request 34403: Patch for KAFKA-2198

2015-07-10 Thread Manikumar Reddy O
On July 10, 2015, 4:46 p.m., Gwen Shapira wrote: core/src/main/scala/kafka/admin/TopicCommand.scala, lines 72-73 https://reviews.apache.org/r/34403/diff/4/?file=1008271#file1008271line72 This is a bit unclean. I think its more idiomatic when the catch block includes the

Re: Review Request 34403: Patch for KAFKA-2198

2015-07-10 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34403/ --- (Updated July 10, 2015, 4:34 p.m.) Review request for kafka. Bugs:

Re: Review Request 34403: Patch for KAFKA-2198

2015-07-10 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34403/#review91310 --- Thanks for the patch!

Review Request 34403: Patch for KAFKA-2198

2015-05-19 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34403/ --- Review request for kafka. Bugs: KAFKA-2198

Re: Review Request 34403: Patch for KAFKA-2198

2015-05-19 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34403/ --- (Updated May 19, 2015, 12:59 p.m.) Review request for kafka. Bugs:

Re: Review Request 34403: Patch for KAFKA-2198

2015-05-19 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34403/ --- (Updated May 19, 2015, 1:14 p.m.) Review request for kafka. Bugs: KAFKA-2198