Re: [Vote] KIP-321: Update TopologyDescription to better represent Source and Sink Nodes

KIP 321 has passed. Here is the vote break down: Binding: - Matthias J. Sax - Guozhang Wong - Ewen Cheslack-Postava Non-Binding: - Ted Yu - Bill Bejeck - Damian Guy Thanks to all those who voted and provided feedback! Best, Nishanth Pradeep On Thu, Aug 2, 2018 at 12:42 PM

Re: [Vote] KIP-321: Update TopologyDescription to better represent Source and Sink Nodes

t;> Hi Nishanth, > > >> > > >> I have one nit on the KIP. I think the topicNameExtractor method > should > > >> return Optional rather than null. > > >> Sorry I'm late here. > > >> > > >> Thanks, > > >> Damian &g

Re: [Vote] KIP-321: Update TopologyDescription to better represent Source and Sink Nodes

We need one more binding vote. Binding Votes: - Matthias J. Sax - Guozhang Wong Community Votes: - Bill Bejeck - Ted Yu Best, Nishanth Pradeep On Fri, Jul 27, 2018 at 10:02 AM Bill Bejeck wrote: > Thanks for the KIP! > > +1 > > -Bill > > On Thu, Jul 26, 201

[Vote] KIP-321: Update TopologyDescription to better represent Source and Sink Nodes

Hello, I'm calling a vote for KIP-321: https://cwiki.apache.org/confluence/display/KAFKA/KIP-321%3A+Update+TopologyDescription+to+better+represent+Source+and+Sink+Nodes Best, Nishanth Pradeep

Re: [Discuss] KIP-321: Add method to get TopicNameExtractor in TopologyDescription

topics() to the Deprecation plan. Thanks again for the feedback. Best, Nishanth Pradeep On Tue, Jul 24, 2018 at 11:21 AM Guozhang Wang wrote: > We should not remove it immediately in the up coming 2.1 release. Usually > we first mark an API as deprecated, and consider removing it only after it > has

Re: [Discuss] KIP-321: Add method to get TopicNameExtractor in TopologyDescription

Sounds good to me too. As far as deprecating goes -- should the topics() method removed completely or should it have a @deprecated annotation for removal in some future version? Best, Nishanth Pradeep On Sun, Jul 22, 2018 at 1:32 PM Matthias J. Sax wrote: > Works for me. > > On 7/2

Re: [Discuss] KIP-321: Add method to get TopicNameExtractor in TopologyDescription

I definitely agree with you on deprecating topics(). I also think changing the method names for consistency is reasonable, since there is no functionality change. Although, I can be convinced either way on this one. Best, Nishanth Pradeep On Fri, Jul 20, 2018 at 12:15 PM Matthias J. Sax wrote

Re: [Discuss] KIP-321: Add method to get TopicNameExtractor in TopologyDescription

Understood, Guozhang. Thanks for the help, everyone! I have updated the KIP. Let me know if you any other thoughts or suggestions. Best, Nishanth Pradeep On Thu, Jul 19, 2018 at 7:33 PM Guozhang Wang wrote: > I see. > > Well, I think if we add a new function like topicSet() it is le

Re: [Discuss] KIP-321: Add method to get TopicNameExtractor in TopologyDescription

pics()" as is. > > Guozhang > > On Thu, Jul 19, 2018 at 5:22 PM, Nishanth Pradeep > wrote: > > > Right, adding topicNames() instead of changing the return type of > topics() > > in order preserve backwards compatibility is a good idea. But is it not > > better

Re: [Discuss] KIP-321: Add method to get TopicNameExtractor in TopologyDescription

that perhaps changing the other API's might be unnecessary since it's only a name change. I have made the change to the KIP to only add, not change, preexisting APIs. But where do we stand on deprecating topics()? Best, Nishanth Pradeep On Thu, Jul 19, 2018 at 1:44 PM Guozhang Wang wrote

Re: [Discuss] KIP-321: Add method to get TopicNameExtractor in TopologyDescription

Added method in TopologyDescription#Source to return the Pattern used by the Source node. Pattern Source#topicPattern() 3. Changed return type of Sink#topicNameExtractor from Class to just TopicNameExtractor. TopicNameExtractor Sink#topicNameExtractor() Best, Nishanth Pradeep On Sun,

Re: [Discuss] KIP-321: Add method to get TopicNameExtractor in TopologyDescription

;>>>>>>>> > >>>>>>>>> Guozhang > >>>>>>>>> > >>>>>>>>> On Sun, Jun 24, 2018 at 5:01 PM, Matthias J. Sax < > >>>>>> matth...@confluent.io> > >>>>>

Re: [VOTE] KIP-321: Add method to get TopicNameExtractor in TopologyDescription

the discussion thread for more details. However, I believe this KIP is finished and the other changes might need to be part of another KIP. Best, Nishanth Pradeep On Tue, Jul 3, 2018 at 10:54 PM, Ted Yu wrote: > Hi, > I don't seem to find response to John's comment : > > http://searc

[VOTE] KIP-321: Add method to get TopicNameExtractor in TopologyDescription

description if he or she chooses. https://cwiki.apache.org/confluence/display/KAFKA/KIP-321%3A+Add+method+to+get+TopicNameExtractor+in+TopologyDescription Best, Nishanth Pradeep

[Discuss] KIP-321: Add method to get TopicNameExtractor in TopologyDescription

Hello Everyone, I have created a new KIP to discuss extending TopologyDescription. You can find it here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-321%3A+Add+method+to+get+TopicNameExtractor+in+TopologyDescription Please provide any feedback that you might have. Best, Nishanth

Wiki Access

Hello, Could you give me access so I can create a KIP. I have been tasked with an issue <https://issues.apache.org/jira/browse/KAFKA-6966> that needs a KIP. WIKI ID: nprad Let me know if you need more information. Thank You! Best, Nishanth Pradeep