Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

> >> >> >> previous data> >> >> >> and setting userA's > config > > > > with producer_byte_rate. Now in > > > > >>> >>> > > >> >> >> version 1> >> >> >> opposed to version 0 it will > > add > > > > an extra config and keeps > &

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

t; >>> >>> > > >> >> > way that users can write code to support both > broker > > > versions. > > > >>> >>> > > >> &

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

d default to false so that old > > code > > >>> >>> > > >> >> > continues to work.> >> >> > > > >>> >>> > > >> >> >> > > >>> >>> > > >> >> >

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

nts to delete a configuration key named "foo", they > can > >>> >>> > > >> >> > create a ConfigEntry with name = "foo", value = null.> > >> >> > > >>> >&

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

;> > > >> >> >> cases (if someone> >> >> >> builds their own tool based on >>> >>> > > >> >> >> the AdminClient), so users can >>> >>> > > >> >> >> add and> >&g

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

ient/AdminManager how they should >> >>> > > >> >> >> behave.> >> >> >> However since the AdminClient matches >> >&

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

Although one of> >> >> >> the goals is to put this new > ConfigCommand to the tools > >>> > > >> >> >> module, which> >> >> >> doesn't have the dependency on > the server code

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

t; >>> > > >> >> >> not need the extra flag but > >>> > > >> >> >> make the behavior> >> >> >> break. What do yo

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

gt; > >> >> >> course - and as> >> >> >> per the community's feedback it may >>> > > >> >> >> be the better option. >>> > > >> >> >> Although one of> >> >> >> the goals is to put this new >>> > >

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

ed code, and just move >> > > >> >> > towards having only a KIP-248-based tool. It's a breaking >> > > >> >> > change, but it's clear to users that it's oc

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

> Let me know what do you think about this and thank you for >> > >> >> >> your feedback.> >> >> >> >> > >> >> >> Cheers, >> > >> >> >> Viktor >> > >> >

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

>> your feedback.> >> >> >> > > > >> >> >> Cheers, > > > >> >> >> Viktor > > > >> >> >> > > > >> >> >> On Thu, Apr 26, 2018 at 7:06 PM, Colin McC

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

1) => [resources] > > >> >> >> > > validate_only> >> >> >> > > validate_only => BOOLEAN > > >> >> >> > >

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

t; STRING > >> >> >> > > config_value => STRING > >> >> >> > > config_operation => INT8 [NEW ADDITION] > >> >> >> > > > >> >> >> > > Request Semantics: > >> &g

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

;> > ./clients/src/main/java/org/apache/kafka/clients/admin/AlterConfigsOptions.java >> >> >> > , specifying whether we want to clear everything that hasn't been >> >> >> > specified, or not. This should default to true so that existing >> >> >

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

ems like > >> >> > something users would really want-- is it truly infeasible to do > >> >> > here? The > >> >> > Java code could call into the Scala code as necessary when the zk >

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

> >> > > that it wants to change, as opposed to the current atomic behaviour >> >> > > where >> >> > > all settings >> >> > > need to

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

2018-04-16 13:27 GMT+02:00 Viktor Somogyi <viktorsomo...@gmail.com>: > >> > > > >> > > > Hi Rajini, > >> > > > > >> > > > The current ConfigCommand would still be possible to use, therefore > >> > those > >> >

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

eeper.sh shell script for shortening the >> > > > kafka-run-class command. >> > > > What do you and others think? >> > > > >> > > > Thanks, >> > > > Viktor >> > > > >> > > > >> > > > >&g

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

remove the ability to configure using ZooKeeper. > > This > > > > > means we will no longer have the ability to start up a cluster with > > SCRAM > > > > > credentials since we first need to create SCRAM credentials before > > > > brokers &g

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

s for the AdminClient before we can create new > ones. > > > > For quotas as well, we will no longer be able to configure quotas > until > > > at > > > > least one broker has been started. Perhaps, we ought to retain the > > > ability > > > > to

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

> > ability > > > to configure using ZooKeeper for these initialization scenarios and > > support > > > only AdminClient for dynamic updates? > > > > > > What do others think? > > > > >

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

Regards, > > > > Rajini > > > > On Sun, Apr 15, 2018 at 10:28 AM, Ted Yu <yuzhih...@gmail.com> wrote: > > > > > +1 > > > ---- Original message ----From: zhenya Sun <toke...@126.com> > > > Date: 4/15/18 12:42 AM (GMT-0

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

: zhenya Sun <toke...@126.com> > > Date: 4/15/18 12:42 AM (GMT-08:00) To: dev <dev@kafka.apache.org> Cc: > > dev <dev@kafka.apache.org> Subject: Re: [VOTE] #2 KIP-248: Create New > > ConfigCommand That Uses The New AdminClient > > non-binding +1 > > > &g

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

T-08:00) To: dev <dev@kafka.apache.org> Cc: > dev <dev@kafka.apache.org> Subject: Re: [VOTE] #2 KIP-248: Create New > ConfigCommand That Uses The New AdminClient > non-binding +1 > > > > > > from my iphone！ > On 04/15/2018 15:41, Attila Sasvári wrote: > Th

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

+1 Original message From: zhenya Sun <toke...@126.com> Date: 4/15/18 12:42 AM (GMT-08:00) To: dev <dev@kafka.apache.org> Cc: dev <dev@kafka.apache.org> Subject: Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient non-binding +1

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

non-binding +1 from my iphone！ On 04/15/2018 15:41, Attila Sasvári wrote: Thanks for updating the KIP. +1 (non-binding) Viktor Somogyi ezt írta (időpont: 2018. ápr. 9., H 16:49): > Hi Magnus, > > Thanks for the heads up, added the endianness to the KIP. Here is

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

Thanks for updating the KIP. +1 (non-binding) Viktor Somogyi ezt írta (időpont: 2018. ápr. 9., H 16:49): > Hi Magnus, > > Thanks for the heads up, added the endianness to the KIP. Here is the > current text: > > "Double > A new type needs to be added to transfer quota

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

Hi Magnus, Thanks for the heads up, added the endianness to the KIP. Here is the current text: "Double A new type needs to be added to transfer quota values. Since the protocol classes in Kafka already uses ByteBuffers it is logical to use their functionality for serializing doubles. The

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

Hi Viktor, since serialization of floats isn't as straight forward as integers, please specify the exact serialization format of DOUBLE in the protocol docs (e.g., IEEE 754), including endianness (big-endian please). This will help the non-java client ecosystem. Thanks, Magnus 2018-04-09

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

Hi Attila, 1. It uses ByteBuffers, which in turn will use Double.doubleToLongBits to convert the double value to a long and that long will be written in the buffer. I'v updated the KIP with this. 2. Good idea, modified it. 3. During the discussion I remember we didn't really decide which one

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

Thanks for working on it Viktor. It looks good to me, but I have some questions: - I see a new type DOUBLE is used for quota_value , and it is not listed among the primitive types on the Kafka protocol guide. Can you add some more details? - I am not sure that using an environment (i.e.

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

+1 (binding) Thanks for the KIP, Viktor! On Tue, Apr 3, 2018 at 8:25 AM, Peter Toth wrote: > +1 (non binding) > > Thanks Viktor. > Please remove "Unknown" AlterOperation type from Wire Format Types section > as you did from the AdminClient APIs section. > > > On Wed, Mar

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

+1 (non binding) Thanks Viktor. Please remove "Unknown" AlterOperation type from Wire Format Types section as you did from the AdminClient APIs section. On Wed, Mar 21, 2018 at 5:41 PM, Viktor Somogyi wrote: > Hi Everyone, > > I've started a vote on KIP-248 >

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

+1 （non-binding） | | zhenya Sun 邮箱：toke...@126.com | 签名由 网易邮箱大师 定制 On 03/29/2018 19:40, Sandor Murakozi wrote: +1 (non-binding) Thanks for the KIP, Viktor On Wed, Mar 21, 2018 at 5:41 PM, Viktor Somogyi wrote: > Hi Everyone, > > I've started a vote on KIP-248 >

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

+1 (non-binding) Thanks for the KIP, Viktor On Wed, Mar 21, 2018 at 5:41 PM, Viktor Somogyi wrote: > Hi Everyone, > > I've started a vote on KIP-248 >

[VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

Hi Everyone, I've started a vote on KIP-248 a few weeks ago but at the time I got a couple more comments and